225897 2021-05-17 16:43:10 -0700 _WKWebAuthenticationPanelDelegate registration and assertion SPI throws an exception without an LAContext 2021-10-15 10:35:23 -0700 1 1 1 Unclassified WebKit WebKit Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 231814 1 garrett_davidson garrett_davidson darin ews-watchlist jiewen_tan repstein rmondello thorton webkit-bug-importer wenson_hsieh oldest_to_newest 1760949 0 garrett_davidson 2021-05-17 16:43:10 -0700 The fix for 225218 was incomplete. Now instead of dropping the request entirely, WebKit tries to proceed and attempts to stick the nil contexts in NSDictionaries, throwing exceptions. 1760951 1 webkit-bug-importer 2021-05-17 16:47:08 -0700 <rdar://problem/78128655> 1760958 2 428896 garrett_davidson 2021-05-17 17:08:38 -0700 Created attachment 428896 Patch 1761188 3 ews-feeder 2021-05-18 09:49:10 -0700 garrett_davidson@apple.com does not have committer permissions according to https://raw.githubusercontent.com/WebKit/WebKit/main/Tools/Scripts/webkitpy/common/config/contributors.json. Rejecting attachment 428896 from commit queue. 1761190 4 ews-feeder 2021-05-18 10:04:41 -0700 Committed r277658 (237863@main): <https://commits.webkit.org/237863@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 428896. 428896 2021-05-17 17:08:38 -0700 2021-05-18 10:04:42 -0700 Patch bug-225897-20210517170837.patch text/plain 4839 garrett_davidson U3VidmVyc2lvbiBSZXZpc2lvbjogMjc3NDM3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDNhNTcyZjg1Y2Y2YWY0NjVm NDdiMmVlMmRmZGQxZDU5YjlhMmYyOWIuLmY3ZTdjMjIzZDE1OWZmNmYyM2EyNmQ0YzRlNzllMzAw NmE1MWQ0MjEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjIgQEAKKzIwMjEtMDUtMTcgIEdhcnJldHQg RGF2aWRzb24gIDxnYXJyZXR0X2Rhdmlkc29uQGFwcGxlLmNvbT4KKworICAgICAgICBBZGQgbmls IGNoZWNrcyBmb3IgTEFDb250ZXh0cyBiZWZvcmUgaW5zZXJ0aW5nIHRoZW0gaW4gdGhlIGRpY3Rp b25hcmllcy4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTIyNTg5NworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IEluIDIyNTIxOCB3ZSBzdG9wcGVkIGRyb3BwaW5nIHJlcXVlc3RzIHRoYXQgZGlkbid0IGhhdmUg TEFDb250ZXh0cy4gSG93ZXZlciwgdGhhdCBsZXQgdXMKKyAgICAgICAgcHJvY2VlZCBvbmx5IHVu dGlsIHdlIHRyaWVkIHRvIHB1dCB0aGUgKG5pbCkgTEFDb250ZXh0IGluIGFuIE5TRGljdGlvbmFy eSB0byBtYWtlIGEgU2VjKgorICAgICAgICBjYWxsLCB3aGljaCB0aHJvd3MgYW4gZXhjZXB0aW9u LiBUaGlzIHBhdGNoIGFkZHMgcHJvcGVyIG5pbCBjaGVja2luZyBiZWZvcmUgaW5zZXJ0aW5nIHRo ZQorICAgICAgICBjb250ZXh0cyBpbnRvIHRoZSBkaWN0aW9uYXJpZXMuCisKKyAgICAgICAgTWFu dWFsbHkgdGVzdGVkIHJlZ2lzdHJhdGlvbiBhbmQgYXNzZXJ0aW9uIG9uIG1hY09TIHdpdGggYW5k IHdpdGhvdXQgTEFDb250ZXh0cy4KKworICAgICAgICAqIFVJUHJvY2Vzcy9XZWJBdXRoZW50aWNh dGlvbi9Db2NvYS9Mb2NhbEF1dGhlbnRpY2F0b3IubW06CisgICAgICAgIChXZWJLaXQ6OkxvY2Fs QXV0aGVudGljYXRvcjo6Y29udGludWVHZXRBc3NlcnRpb25BZnRlclVzZXJWZXJpZmljYXRpb24p OgorICAgICAgICAqIFVJUHJvY2Vzcy9XZWJBdXRoZW50aWNhdGlvbi9Db2NvYS9Mb2NhbENvbm5l Y3Rpb24ubW06CisgICAgICAgIChXZWJLaXQ6OkxvY2FsQ29ubmVjdGlvbjo6Y3JlYXRlQ3JlZGVu dGlhbFByaXZhdGVLZXkgY29uc3QpOgorCiAyMDIxLTA1LTEzICBEYXJpbiBBZGxlciAgPGRhcmlu QGFwcGxlLmNvbT4KIAogICAgICAgICBSZW1vdmUgU3RyaW5nQnVpbGRlcjo6YXBwZW5kTnVtYmVy CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9XZWJBdXRoZW50aWNhdGlvbi9D b2NvYS9Mb2NhbEF1dGhlbnRpY2F0b3IubW0gYi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9XZWJB dXRoZW50aWNhdGlvbi9Db2NvYS9Mb2NhbEF1dGhlbnRpY2F0b3IubW0KaW5kZXggNWVjNWFjNTc4 YTc5MTU2MTgwMDNjMDFhYmVhYjVmMzk5ODhlMWEyMS4uZTczZmFhYzk4MTVhNDlhNDQ0NDc0ZjM0 N2Q2MzFiNjRmNTE2ZTAwNSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvV2Vi QXV0aGVudGljYXRpb24vQ29jb2EvTG9jYWxBdXRoZW50aWNhdG9yLm1tCisrKyBiL1NvdXJjZS9X ZWJLaXQvVUlQcm9jZXNzL1dlYkF1dGhlbnRpY2F0aW9uL0NvY29hL0xvY2FsQXV0aGVudGljYXRv ci5tbQpAQCAtNjAyLDE5ICs2MDIsMjIgQEAgdm9pZCBMb2NhbEF1dGhlbnRpY2F0b3I6OmNvbnRp bnVlR2V0QXNzZXJ0aW9uQWZ0ZXJVc2VyVmVyaWZpY2F0aW9uKFJlZjxXZWJDb3JlOjoKICAgICBS ZXRhaW5QdHI8Q0ZEYXRhUmVmPiBzaWduYXR1cmU7CiAgICAgYXV0byBuc0NyZWRlbnRpYWxJZCA9 IHRvTlNEYXRhKHJlc3BvbnNlLT5yYXdJZCgpKTsKICAgICB7Ci0gICAgICAgIGF1dG8gcXVlcnkg PSBhZG9wdE5TKFtbTlNNdXRhYmxlRGljdGlvbmFyeSBhbGxvY10gaW5pdF0pOwotICAgICAgICBb cXVlcnkgc2V0RGljdGlvbmFyeTpAeworICAgICAgICBOU011dGFibGVEaWN0aW9uYXJ5ICpxdWVy eURpY3Rpb25hcnkgPSBbQHsKICAgICAgICAgICAgIChpZClrU2VjQ2xhc3M6IChpZClrU2VjQ2xh c3NLZXksCiAgICAgICAgICAgICAoaWQpa1NlY0F0dHJLZXlDbGFzczogKGlkKWtTZWNBdHRyS2V5 Q2xhc3NQcml2YXRlLAogICAgICAgICAgICAgKGlkKWtTZWNBdHRyQXBwbGljYXRpb25MYWJlbDog bnNDcmVkZW50aWFsSWQuZ2V0KCksCi0gICAgICAgICAgICAoaWQpa1NlY1VzZUF1dGhlbnRpY2F0 aW9uQ29udGV4dDogY29udGV4dCwKICAgICAgICAgICAgIChpZClrU2VjUmV0dXJuUmVmOiBAWUVT LAogI2lmIEhBVkUoREFUQV9QUk9URUNUSU9OX0tFWUNIQUlOKQogICAgICAgICAgICAgKGlkKWtT ZWNVc2VEYXRhUHJvdGVjdGlvbktleWNoYWluOiBAWUVTCiAjZWxzZQogICAgICAgICAgICAgKGlk KWtTZWNBdHRyTm9MZWdhY3k6IEBZRVMKICNlbmRpZgotICAgICAgICB9XTsKKyAgICAgICAgfSBt dXRhYmxlQ29weV07CisKKyAgICAgICAgaWYgKGNvbnRleHQpCisgICAgICAgICAgICBxdWVyeURp Y3Rpb25hcnlbKGlkKWtTZWNVc2VBdXRoZW50aWNhdGlvbkNvbnRleHRdID0gY29udGV4dDsKKwor ICAgICAgICBhdXRvIHF1ZXJ5ID0gYWRvcHROUyhxdWVyeURpY3Rpb25hcnkpOwogICAgICAgICB1 cGRhdGVRdWVyeUlmTmVjZXNzYXJ5KHF1ZXJ5LmdldCgpKTsKIAogICAgICAgICBDRlR5cGVSZWYg cHJpdmF0ZUtleVJlZiA9IG51bGxwdHI7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L1VJUHJv Y2Vzcy9XZWJBdXRoZW50aWNhdGlvbi9Db2NvYS9Mb2NhbENvbm5lY3Rpb24ubW0gYi9Tb3VyY2Uv V2ViS2l0L1VJUHJvY2Vzcy9XZWJBdXRoZW50aWNhdGlvbi9Db2NvYS9Mb2NhbENvbm5lY3Rpb24u bW0KaW5kZXggMzcwZjRlZTVjM2Y2MzRlMTM3OTc2NGRhZDFhYWE2NTY2NGVhZTU5Yi4uODM4NDc5 NmEzNzFjNTQ4N2E4NWM1YzY4NWQ5YjNkZWU3NTg1ZjM2MSAxMDA2NDQKLS0tIGEvU291cmNlL1dl YktpdC9VSVByb2Nlc3MvV2ViQXV0aGVudGljYXRpb24vQ29jb2EvTG9jYWxDb25uZWN0aW9uLm1t CisrKyBiL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL1dlYkF1dGhlbnRpY2F0aW9uL0NvY29hL0xv Y2FsQ29ubmVjdGlvbi5tbQpAQCAtMTU5LDE4ICsxNTksMjYgQEAgdm9pZCBMb2NhbENvbm5lY3Rp b246OnZlcmlmeVVzZXIoU2VjQWNjZXNzQ29udHJvbFJlZiBhY2Nlc3NDb250cm9sLCBMQUNvbnRl eHQgKmMKIAogUmV0YWluUHRyPFNlY0tleVJlZj4gTG9jYWxDb25uZWN0aW9uOjpjcmVhdGVDcmVk ZW50aWFsUHJpdmF0ZUtleShMQUNvbnRleHQgKmNvbnRleHQsIFNlY0FjY2Vzc0NvbnRyb2xSZWYg YWNjZXNzQ29udHJvbFJlZiwgY29uc3QgU3RyaW5nJiBzZWNBdHRyTGFiZWwsIE5TRGF0YSAqc2Vj QXR0ckFwcGxpY2F0aW9uVGFnKSBjb25zdAogeworICAgIE5TRGljdGlvbmFyeSAqcHJpdmF0ZUtl eUF0dHJpYnV0ZXMgPSBAeworICAgICAgICAoaWQpa1NlY0F0dHJBY2Nlc3NDb250cm9sOiAoaWQp YWNjZXNzQ29udHJvbFJlZiwKKyAgICAgICAgKGlkKWtTZWNBdHRySXNQZXJtYW5lbnQ6IEBZRVMs CisgICAgICAgIChpZClrU2VjQXR0ckFjY2Vzc0dyb3VwOiAoaWQpU3RyaW5nKExvY2FsQXV0aGVu dGljYXRpb3JBY2Nlc3NHcm91cCksCisgICAgICAgIChpZClrU2VjQXR0ckxhYmVsOiBzZWNBdHRy TGFiZWwsCisgICAgICAgIChpZClrU2VjQXR0ckFwcGxpY2F0aW9uVGFnOiBzZWNBdHRyQXBwbGlj YXRpb25UYWcsCisgICAgfTsKKworICAgIGlmIChjb250ZXh0KSB7CisgICAgICAgIHByaXZhdGVL ZXlBdHRyaWJ1dGVzID0gW3ByaXZhdGVLZXlBdHRyaWJ1dGVzIG11dGFibGVDb3B5XTsKKyAgICAg ICAgKChOU011dGFibGVEaWN0aW9uYXJ5ICopcHJpdmF0ZUtleUF0dHJpYnV0ZXMpWyhpZClrU2Vj VXNlQXV0aGVudGljYXRpb25Db250ZXh0XSA9IGNvbnRleHQ7CisgICAgfQorCiAgICAgTlNEaWN0 aW9uYXJ5ICphdHRyaWJ1dGVzID0gQHsKICAgICAgICAgKGlkKWtTZWNBdHRyVG9rZW5JRDogKGlk KWtTZWNBdHRyVG9rZW5JRFNlY3VyZUVuY2xhdmUsCiAgICAgICAgIChpZClrU2VjQXR0cktleVR5 cGU6IChpZClrU2VjQXR0cktleVR5cGVFQ1NFQ1ByaW1lUmFuZG9tLAogICAgICAgICAoaWQpa1Nl Y0F0dHJLZXlTaXplSW5CaXRzOiBAMjU2LAotICAgICAgICAoaWQpa1NlY1ByaXZhdGVLZXlBdHRy czogQHsKLSAgICAgICAgICAgIChpZClrU2VjVXNlQXV0aGVudGljYXRpb25Db250ZXh0OiBjb250 ZXh0LAotICAgICAgICAgICAgKGlkKWtTZWNBdHRyQWNjZXNzQ29udHJvbDogKGlkKWFjY2Vzc0Nv bnRyb2xSZWYsCi0gICAgICAgICAgICAoaWQpa1NlY0F0dHJJc1Blcm1hbmVudDogQFlFUywKLSAg ICAgICAgICAgIChpZClrU2VjQXR0ckFjY2Vzc0dyb3VwOiAoaWQpU3RyaW5nKExvY2FsQXV0aGVu dGljYXRpb3JBY2Nlc3NHcm91cCksCi0gICAgICAgICAgICAoaWQpa1NlY0F0dHJMYWJlbDogc2Vj QXR0ckxhYmVsLAotICAgICAgICAgICAgKGlkKWtTZWNBdHRyQXBwbGljYXRpb25UYWc6IHNlY0F0 dHJBcHBsaWNhdGlvblRhZywKLSAgICAgICAgfX07CisgICAgICAgIChpZClrU2VjUHJpdmF0ZUtl eUF0dHJzOiBwcml2YXRlS2V5QXR0cmlidXRlcywKKyAgICB9OworCiAgICAgTE9DQUxfQ09OTkVD VElPTl9BRERJVElPTlMKICAgICBDRkVycm9yUmVmIGVycm9yUmVmID0gbnVsbHB0cjsKICAgICBh dXRvIGNyZWRlbnRpYWxQcml2YXRlS2V5ID0gYWRvcHRDRihTZWNLZXlDcmVhdGVSYW5kb21LZXko KF9fYnJpZGdlIENGRGljdGlvbmFyeVJlZilhdHRyaWJ1dGVzLCAmZXJyb3JSZWYpKTsK