225892 2021-05-17 16:05:16 -0700 Remove SQLiteStatement::isColumnNull and its use 2021-05-17 20:40:19 -0700 1 1 1 Unclassified WebKit WebCore Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 sihui_liu sihui_liu alecflett beidson cdumez ews-watchlist jsbell webkit-bug-importer oldest_to_newest 1760925 0 sihui_liu 2021-05-17 16:05:16 -0700 ... 1760926 1 428884 sihui_liu 2021-05-17 16:11:59 -0700 Created attachment 428884 Patch 1760938 2 428884 cdumez 2021-05-17 16:23:41 -0700 Comment on attachment 428884 Patch r=me if the bots are happy. 1761020 3 ews-feeder 2021-05-17 20:39:31 -0700 Committed r277634 (237845@main): <https://commits.webkit.org/237845@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 428884. 1761021 4 webkit-bug-importer 2021-05-17 20:40:19 -0700 <rdar://problem/78136524> 428884 2021-05-17 16:11:59 -0700 2021-05-17 20:39:32 -0700 Patch bug-225892-20210517161158.patch text/plain 3979 sihui_liu U3VidmVyc2lvbiBSZXZpc2lvbjogMjc3NTk0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNWU3ZWRlMTFiNTViNTNm YWQ1NGNkNjliMDI5N2Y4YzQ3OTc0ZjljOC4uNWYzYWQ5NWM2MTNiMDI5M2U2ZGI3MTkxMDI0OGVm ZDM0NmYyNzU3ZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDIxLTA1LTE3ICBTaWh1 aSBMaXUgIDxzaWh1aV9saXVAYXBwbGUuY29tPgorCisgICAgICAgIFJlbW92ZSBTUUxpdGVTdGF0 ZW1lbnQ6OmlzQ29sdW1uTnVsbCBhbmQgaXRzIHVzZQorICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjI1ODkyCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgU1FMaXRlU3RhdGVtZW50Ojppc0NvbHVtbk51bGwgaXMg b25seSB1c2VkIGluIFNRTGl0ZUlEQkJhY2tpbmdTdG9yZSBhbmQgaXQgaXMgYWN0dWFsbHkgbm90 IG5lZWRlZCwgYmVjYXVzZSAKKyAgICAgICAgU1FMaXRlSURCQmFja2luZ1N0b3JlIGNhbiB1c2Ug Z2V0Q29sdW1uVGV4dCB0byBldmFsdWF0ZSB0aGUgc3RhdGVtZW50IGFuZCBnZXQgdGhlIHJlc3Vs dC4gU28gdGhlIGNoZWNrIGlzCisgICAgICAgIHJlZHVuZGFudC4KKworICAgICAgICAqIE1vZHVs ZXMvaW5kZXhlZGRiL3NlcnZlci9TUUxpdGVJREJCYWNraW5nU3RvcmUuY3BwOgorICAgICAgICAo V2ViQ29yZTo6SURCU2VydmVyOjpTUUxpdGVJREJCYWNraW5nU3RvcmU6OmV4dHJhY3RFeGlzdGlu Z0RhdGFiYXNlSW5mbyk6CisgICAgICAgICogcGxhdGZvcm0vc3FsL1NRTGl0ZVN0YXRlbWVudC5j cHA6CisgICAgICAgIChXZWJDb3JlOjpTUUxpdGVTdGF0ZW1lbnQ6OmlzQ29sdW1uTnVsbCk6IERl bGV0ZWQuCisgICAgICAgICogcGxhdGZvcm0vc3FsL1NRTGl0ZVN0YXRlbWVudC5oOgorCiAyMDIx LTA1LTE3ICBBbGV4IENocmlzdGVuc2VuICA8YWNocmlzdGVuc2VuQHdlYmtpdC5vcmc+CiAKICAg ICAgICAgTnVsbCBjaGVjayBtX3Jlc291cmNlIGluIFN1YnJlc291cmNlTG9hZGVyOjpkaWRSZWNl aXZlUmVzcG9uc2UKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvaW5kZXhlZGRi L3NlcnZlci9TUUxpdGVJREJCYWNraW5nU3RvcmUuY3BwIGIvU291cmNlL1dlYkNvcmUvTW9kdWxl cy9pbmRleGVkZGIvc2VydmVyL1NRTGl0ZUlEQkJhY2tpbmdTdG9yZS5jcHAKaW5kZXggOWFhYTBm ZDUzZGVjZDFhZDZmODU1MDA2ZGM3M2E1NzU0Zjc3MjNmOS4uNzc4YzBmMzZmZjkxY2JiZmFjNmEy Yzc0NGFhYjUwMjcxMGI1ZjM2ZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvTW9kdWxlcy9p bmRleGVkZGIvc2VydmVyL1NRTGl0ZUlEQkJhY2tpbmdTdG9yZS5jcHAKKysrIGIvU291cmNlL1dl YkNvcmUvTW9kdWxlcy9pbmRleGVkZGIvc2VydmVyL1NRTGl0ZUlEQkJhY2tpbmdTdG9yZS5jcHAK QEAgLTk5MCw4ICs5OTAsNiBAQCBzdGQ6OnVuaXF1ZV9wdHI8SURCRGF0YWJhc2VJbmZvPiBTUUxp dGVJREJCYWNraW5nU3RvcmU6OmV4dHJhY3RFeGlzdGluZ0RhdGFiYXNlSQogICAgIFN0cmluZyBk YXRhYmFzZU5hbWU7CiAgICAgewogICAgICAgICBhdXRvIHNxbCA9IG1fc3FsaXRlREItPnByZXBh cmVTdGF0ZW1lbnQoIlNFTEVDVCB2YWx1ZSBGUk9NIElEQkRhdGFiYXNlSW5mbyBXSEVSRSBrZXkg PSAnRGF0YWJhc2VOYW1lJzsiX3MpOwotICAgICAgICBpZiAoc3FsLT5pc0NvbHVtbk51bGwoMCkp Ci0gICAgICAgICAgICByZXR1cm4gbnVsbHB0cjsKICAgICAgICAgZGF0YWJhc2VOYW1lID0gc3Fs LT5nZXRDb2x1bW5UZXh0KDApOwogICAgICAgICBpZiAoZGF0YWJhc2VOYW1lICE9IG1faWRlbnRp Zmllci5kYXRhYmFzZU5hbWUoKSkgewogICAgICAgICAgICAgTE9HX0VSUk9SKCJEYXRhYmFzZSBu YW1lIGluIHRoZSBpbmZvIGRhdGFiYXNlICgnJXMnKSBkb2VzIG5vdCBtYXRjaCB0aGUgZXhwZWN0 ZWQgbmFtZSAoJyVzJykiLCBkYXRhYmFzZU5hbWUudXRmOCgpLmRhdGEoKSwgbV9pZGVudGlmaWVy LmRhdGFiYXNlTmFtZSgpLnV0ZjgoKS5kYXRhKCkpOwpAQCAtMTAwMSw4ICs5OTksNiBAQCBzdGQ6 OnVuaXF1ZV9wdHI8SURCRGF0YWJhc2VJbmZvPiBTUUxpdGVJREJCYWNraW5nU3RvcmU6OmV4dHJh Y3RFeGlzdGluZ0RhdGFiYXNlSQogICAgIHVpbnQ2NF90IGRhdGFiYXNlVmVyc2lvbjsKICAgICB7 CiAgICAgICAgIGF1dG8gc3FsID0gbV9zcWxpdGVEQi0+cHJlcGFyZVN0YXRlbWVudCgiU0VMRUNU IHZhbHVlIEZST00gSURCRGF0YWJhc2VJbmZvIFdIRVJFIGtleSA9ICdEYXRhYmFzZVZlcnNpb24n OyJfcyk7Ci0gICAgICAgIGlmIChzcWwtPmlzQ29sdW1uTnVsbCgwKSkKLSAgICAgICAgICAgIHJl dHVybiBudWxscHRyOwogICAgICAgICBTdHJpbmcgc3RyaW5nVmVyc2lvbiA9IHNxbC0+Z2V0Q29s dW1uVGV4dCgwKTsKICAgICAgICAgYXV0byBwYXJzZWRWZXJzaW9uID0gcGFyc2VJbnRlZ2VyPHVp bnQ2NF90PihzdHJpbmdWZXJzaW9uKTsKICAgICAgICAgaWYgKCFwYXJzZWRWZXJzaW9uKSB7CmRp ZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9zcWwvU1FMaXRlU3RhdGVtZW50LmNw cCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL3NxbC9TUUxpdGVTdGF0ZW1lbnQuY3BwCmluZGV4 IDQ4ZjlhZWUyZDcxZDkxZmI0NTcwMjIyZDRlNWIwNzg4YTBiZTE1ZGYuLjcyM2Y2YmM2YmYxNWQ0 MjlmNmYxNjAzYjIxZmI2Y2VjODhkNmJhZjIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3Bs YXRmb3JtL3NxbC9TUUxpdGVTdGF0ZW1lbnQuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRm b3JtL3NxbC9TUUxpdGVTdGF0ZW1lbnQuY3BwCkBAIC0xODUsMTcgKzE4NSw2IEBAIGludCBTUUxp dGVTdGF0ZW1lbnQ6OmNvbHVtbkNvdW50KCkKICAgICByZXR1cm4gc3FsaXRlM19kYXRhX2NvdW50 KG1fc3RhdGVtZW50KTsKIH0KIAotYm9vbCBTUUxpdGVTdGF0ZW1lbnQ6OmlzQ29sdW1uTnVsbChp bnQgY29sKQotewotICAgIEFTU0VSVChjb2wgPj0gMCk7Ci0gICAgaWYgKCFoYXNTdGFydGVkU3Rl cHBpbmcoKSAmJiBzdGVwKCkgIT0gU1FMSVRFX1JPVykKLSAgICAgICAgcmV0dXJuIGZhbHNlOwot ICAgIGlmIChjb2x1bW5Db3VudCgpIDw9IGNvbCkKLSAgICAgICAgcmV0dXJuIGZhbHNlOwotCi0g ICAgcmV0dXJuIHNxbGl0ZTNfY29sdW1uX3R5cGUobV9zdGF0ZW1lbnQsIGNvbCkgPT0gU1FMSVRF X05VTEw7Ci19Ci0KIGJvb2wgU1FMaXRlU3RhdGVtZW50Ojppc0NvbHVtbkRlY2xhcmVkQXNCbG9i KGludCBjb2wpCiB7CiAgICAgQVNTRVJUKGNvbCA+PSAwKTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9X ZWJDb3JlL3BsYXRmb3JtL3NxbC9TUUxpdGVTdGF0ZW1lbnQuaCBiL1NvdXJjZS9XZWJDb3JlL3Bs YXRmb3JtL3NxbC9TUUxpdGVTdGF0ZW1lbnQuaAppbmRleCA2MzUxMmJiNmViNDlhNmVlMTllNzFm MWM2N2IxZmU4ZjI5ZjY1YzhkLi42OGMyNTYyOGQ5YzMwN2NhZjM1YzJiNDliNmY0MzI4Y2FiN2Zj ZDExIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9zcWwvU1FMaXRlU3RhdGVt ZW50LmgKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vc3FsL1NRTGl0ZVN0YXRlbWVudC5o CkBAIC02NSw3ICs2NSw2IEBAIHB1YmxpYzoKICAgICAvLyByZXR1cm5lZCBpbiB0aGUgbGFzdCBz dGVwKCkKICAgICBpbnQgY29sdW1uQ291bnQoKTsKICAgICAKLSAgICBXRUJDT1JFX0VYUE9SVCBi b29sIGlzQ29sdW1uTnVsbChpbnQgY29sKTsKICAgICBXRUJDT1JFX0VYUE9SVCBib29sIGlzQ29s dW1uRGVjbGFyZWRBc0Jsb2IoaW50IGNvbCk7CiAgICAgU3RyaW5nIGdldENvbHVtbk5hbWUoaW50 IGNvbCk7CiAgICAgU1FMVmFsdWUgZ2V0Q29sdW1uVmFsdWUoaW50IGNvbCk7Cg==