225885 2021-05-17 14:04:47 -0700 Drop unnecessary SQLiteDatabase::updateLastChangesCount() 2021-05-17 17:12:26 -0700 1 1 1 Unclassified WebKit WebCore Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=46070 InRadar P2 Normal --- 1 cdumez cdumez achristensen beidson darin ggaren sam sihui_liu webkit-bug-importer oldest_to_newest 1760877 0 cdumez 2021-05-17 14:04:47 -0700 Drop unnecessary SQLiteDatabase::updateLastChangesCount(). 1760880 1 428868 cdumez 2021-05-17 14:10:52 -0700 Created attachment 428868 Patch 1760940 2 428868 achristensen 2021-05-17 16:25:16 -0700 Comment on attachment 428868 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=428868&action=review > Source/WebCore/ChangeLog:10 > + + sqlite3_total_changes() in https://commits.webkit.org/r130891 to address an issue in WebSQL I wonder how this "Christophe Dumez" feels about us undoing his hard work. 1760942 3 cdumez 2021-05-17 16:26:15 -0700 (In reply to Alex Christensen from comment #2) > Comment on attachment 428868 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=428868&action=review > > > Source/WebCore/ChangeLog:10 > > + + sqlite3_total_changes() in https://commits.webkit.org/r130891 to address an issue in WebSQL > > I wonder how this "Christophe Dumez" feels about us undoing his hard work. muhahah, I was so surprised when I saw I did this. It was so long ago. 1760963 4 ews-feeder 2021-05-17 17:11:47 -0700 Committed r277618 (237833@main): <https://commits.webkit.org/237833@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 428868. 1760964 5 webkit-bug-importer 2021-05-17 17:12:26 -0700 <rdar://problem/78129682> 428868 2021-05-17 14:10:52 -0700 2021-05-17 17:11:48 -0700 Patch bug-225885-20210517141051.patch text/plain 6369 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjc3NjAxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMmYwMmVjZjYzYWJkMmJj NzgwOTVkZTQ5MDQ5MDVkOWI4MGQwYjk0OC4uYjAwNzMyMjg2ZmViODE0ZjllNThhYTBlNDMyMGI5 MWM1MTk3OTZhNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDMwIEBACisyMDIxLTA1LTE3ICBDaHJp cyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CisKKyAgICAgICAgRHJvcCB1bm5lY2Vzc2FyeSBT UUxpdGVEYXRhYmFzZTo6dXBkYXRlTGFzdENoYW5nZXNDb3VudCgpCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMjU4ODUKKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBEcm9wIHVubmVjZXNzYXJ5IFNRTGl0ZURh dGFiYXNlOjp1cGRhdGVMYXN0Q2hhbmdlc0NvdW50KCkgYW5kIGhhdmUgU1FMaXRlRGF0YWJhc2U6 Omxhc3RDaGFuZ2VzKCkKKyAgICAgICAgcmVseSBvbiBzcWxpdGUzX2NoYW5nZXMoKSBpbnN0ZWFk IG9mIHNxbGl0ZTNfdG90YWxfY2hhbmdlcygpLiBXZSBzdGFydGVkIHVzaW5nIHVwZGF0ZUxhc3RD aGFuZ2VzQ291bnQoKQorICAgICAgICArIHNxbGl0ZTNfdG90YWxfY2hhbmdlcygpIGluIGh0dHBz Oi8vY29tbWl0cy53ZWJraXQub3JnL3IxMzA4OTEgdG8gYWRkcmVzcyBhbiBpc3N1ZSBpbiBXZWJT UUwKKyAgICAgICAgU1FMUmVzdWx0U2V0LnJvd3NBZmZlY3RlZCB3b3VsZCBub3QgYmUgMCBmb3Ig U0VMRUNUIHN0YXRlbWVudC4gVGhpcyBwYXRjaCByZXZlcnRzIHIxMzA4OTEgYW5kIGluc3RlYWQK KyAgICAgICAgc2V0cyBTUUxSZXN1bHRTZXQucm93c0FmZmVjdGVkIHdoZW4gdGhlIHN0YXRlbWVu dCBpcyBub3QgYSByZWFkLW9ubHkgc3RhdGVtZW50LgorCisgICAgICAgIFRoaXMgaXMgY292ZXJl ZCBieSBzdG9yYWdlL3dlYnNxbC9leGVjdXRlLXNxbC1yb3dzQWZmZWN0ZWQuaHRtbCB3aGljaCBp cyBzdGlsbCBwYXNzaW5nIGFmdGVyCisgICAgICAgIHRoaXMgY2hhbmdlLgorCisgICAgICAgICog TW9kdWxlcy93ZWJkYXRhYmFzZS9TUUxTdGF0ZW1lbnQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6 U1FMU3RhdGVtZW50OjpleGVjdXRlKToKKyAgICAgICAgKiBwbGF0Zm9ybS9zcWwvU1FMaXRlRGF0 YWJhc2UuY3BwOgorICAgICAgICAoV2ViQ29yZTo6U1FMaXRlRGF0YWJhc2U6Omxhc3RDaGFuZ2Vz KToKKyAgICAgICAgKFdlYkNvcmU6OlNRTGl0ZURhdGFiYXNlOjp1cGRhdGVMYXN0Q2hhbmdlc0Nv dW50KTogRGVsZXRlZC4KKyAgICAgICAgKiBwbGF0Zm9ybS9zcWwvU1FMaXRlRGF0YWJhc2UuaDoK KyAgICAgICAgKiBwbGF0Zm9ybS9zcWwvU1FMaXRlU3RhdGVtZW50LmNwcDoKKyAgICAgICAgKFdl YkNvcmU6OlNRTGl0ZVN0YXRlbWVudDo6c3RlcCk6CisgICAgICAgIChXZWJDb3JlOjpTUUxpdGVT dGF0ZW1lbnQ6OmlzUmVhZE9ubHkpOgorICAgICAgICAqIHBsYXRmb3JtL3NxbC9TUUxpdGVTdGF0 ZW1lbnQuaDoKKwogMjAyMS0wNS0xNyAgQ2hyaXMgRHVtZXogIDxjZHVtZXpAYXBwbGUuY29tPgog CiAgICAgICAgIEF2b2lkIG1vcmUgU3RyaW5nIGNyZWF0aW9ucyB3aGVuIHByZXBhcmluZyBTUUxp dGUgc3RhdGVtZW50cwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvTW9kdWxlcy93ZWJkYXRh YmFzZS9TUUxTdGF0ZW1lbnQuY3BwIGIvU291cmNlL1dlYkNvcmUvTW9kdWxlcy93ZWJkYXRhYmFz ZS9TUUxTdGF0ZW1lbnQuY3BwCmluZGV4IDE0Nzk4ZDk3NTRkMmI4Zjk2M2FmMDFiNTYzNmIwOGZk MjdhMzU1ZGYuLjBjNzZmY2EwODk0OWM3ZWU1NThhNmIxOGY0OWUzMjE5Mzk0NzlhYWQgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvd2ViZGF0YWJhc2UvU1FMU3RhdGVtZW50LmNw cAorKysgYi9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL3dlYmRhdGFiYXNlL1NRTFN0YXRlbWVudC5j cHAKQEAgLTE4NywxMCArMTg3LDEwIEBAIGJvb2wgU1FMU3RhdGVtZW50OjpleGVjdXRlKERhdGFi YXNlJiBkYikKICAgICAgICAgcmV0dXJuIGZhbHNlOwogICAgIH0KIAotICAgIC8vIEZJWE1FOiBJ ZiB0aGUgc3BlYyBhbGxvd3MgdHJpZ2dlcnMsIGFuZCB3ZSB3YW50IHRvIGJlICJhY2N1cmF0ZSIg aW4gYSBkaWZmZXJlbnQgd2F5LCB3ZSdkIHVzZQotICAgIC8vIHNxbGl0ZTNfdG90YWxfY2hhbmdl cygpIGhlcmUgaW5zdGVhZCBvZiBzcWxpdGUzX2NoYW5nZWQsIGJlY2F1c2UgdGhhdCBpbmNsdWRl cyByb3dzIG1vZGlmaWVkIGZyb20gd2l0aGluIGEgdHJpZ2dlcgotICAgIC8vIEZvciBub3csIHRo aXMgc2VlbXMgc3VmZmljaWVudAotICAgIHJlc3VsdFNldC0+c2V0Um93c0FmZmVjdGVkKGRhdGFi YXNlLmxhc3RDaGFuZ2VzKCkpOworICAgIC8vIHJvd3NBZmZlY3RlZCBzaG91bGQgYmUgMCBmb3Ig cmVhZCBvbmx5IHN0YXRlbWVudHMgKGUuZy4gU0VMRUNUIHN0YXRlbWVudCkuIEhvd2V2ZXIsIFNR TGl0ZURhdGFiYXNlOjpsYXN0Q2hhbmdlcygpIHJldHVybnMKKyAgICAvLyB0aGUgbnVtYmVyIG9m IGNoYW5nZXMgbWFkZSBieSB0aGUgbW9zdCByZWNlbnQgSU5TRVJULCBVUERBVEUgb3IgREVMRVRF IHN0YXRlbWVudC4KKyAgICBpZiAoIXN0YXRlbWVudC0+aXNSZWFkT25seSgpKQorICAgICAgICBy ZXN1bHRTZXQtPnNldFJvd3NBZmZlY3RlZChkYXRhYmFzZS5sYXN0Q2hhbmdlcygpKTsKIAogICAg IG1fcmVzdWx0U2V0ID0gV1RGTW92ZShyZXN1bHRTZXQpOwogICAgIHJldHVybiB0cnVlOwpkaWZm IC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vc3FsL1NRTGl0ZURhdGFiYXNlLmNwcCBi L1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL3NxbC9TUUxpdGVEYXRhYmFzZS5jcHAKaW5kZXggMjAy NmZhMjMxMWE3ZTFhYzcwZmU3NjNjOTgyMzQ4YTY4NjZkMzUxNS4uZDQ1ODc1ODAwZTVmNDI0OGEx ZDZjNzA1ZTllZThlZjA5ZDdlN2M4MyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZv cm0vc3FsL1NRTGl0ZURhdGFiYXNlLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9z cWwvU1FMaXRlRGF0YWJhc2UuY3BwCkBAIC00NDUsMjAgKzQ0NSwxMiBAQCBpbnQ2NF90IFNRTGl0 ZURhdGFiYXNlOjpsYXN0SW5zZXJ0Um93SUQoKQogICAgIHJldHVybiBzcWxpdGUzX2xhc3RfaW5z ZXJ0X3Jvd2lkKG1fZGIpOwogfQogCi12b2lkIFNRTGl0ZURhdGFiYXNlOjp1cGRhdGVMYXN0Q2hh bmdlc0NvdW50KCkKLXsKLSAgICBpZiAoIW1fZGIpCi0gICAgICAgIHJldHVybjsKLQotICAgIG1f bGFzdENoYW5nZXNDb3VudCA9IHNxbGl0ZTNfdG90YWxfY2hhbmdlcyhtX2RiKTsKLX0KLQogaW50 IFNRTGl0ZURhdGFiYXNlOjpsYXN0Q2hhbmdlcygpCiB7CiAgICAgaWYgKCFtX2RiKQogICAgICAg ICByZXR1cm4gMDsKIAotICAgIHJldHVybiBzcWxpdGUzX3RvdGFsX2NoYW5nZXMobV9kYikgLSBt X2xhc3RDaGFuZ2VzQ291bnQ7CisgICAgcmV0dXJuIHNxbGl0ZTNfY2hhbmdlcyhtX2RiKTsKIH0K IAogaW50IFNRTGl0ZURhdGFiYXNlOjpsYXN0RXJyb3IoKQpkaWZmIC0tZ2l0IGEvU291cmNlL1dl YkNvcmUvcGxhdGZvcm0vc3FsL1NRTGl0ZURhdGFiYXNlLmggYi9Tb3VyY2UvV2ViQ29yZS9wbGF0 Zm9ybS9zcWwvU1FMaXRlRGF0YWJhc2UuaAppbmRleCAwOWY1OTFlMWFlNDQ1NWU3ZWQ5M2Q1MGQ5 NTg3Y2U1OTQ0YzRiZTAwLi40MmYyMGZkZWY3MWQ0YmIxY2M1NjNhNDU1MDRkYmEyYmNkNDBhNDQ3 IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9zcWwvU1FMaXRlRGF0YWJhc2Uu aAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9zcWwvU1FMaXRlRGF0YWJhc2UuaApAQCAt NjAsOCArNjAsNiBAQCBwdWJsaWM6CiAgICAgYm9vbCBpc09wZW4oKSBjb25zdCB7IHJldHVybiBt X2RiOyB9CiAgICAgV0VCQ09SRV9FWFBPUlQgdm9pZCBjbG9zZSgpOwogCi0gICAgV0VCQ09SRV9F WFBPUlQgdm9pZCB1cGRhdGVMYXN0Q2hhbmdlc0NvdW50KCk7Ci0KICAgICBXRUJDT1JFX0VYUE9S VCBib29sIGV4ZWN1dGVDb21tYW5kU2xvdyhjb25zdCBTdHJpbmcmKTsKICAgICBXRUJDT1JFX0VY UE9SVCBib29sIGV4ZWN1dGVDb21tYW5kKEFTQ0lJTGl0ZXJhbCk7CiAgICAgCkBAIC04MSw2ICs3 OSw4IEBAIHB1YmxpYzoKICAgICBXRUJDT1JFX0VYUE9SVCB2b2lkIGludGVycnVwdCgpOwogCiAg ICAgaW50NjRfdCBsYXN0SW5zZXJ0Um93SUQoKTsKKworICAgIC8vIFRoaXMgZnVuY3Rpb24gcmV0 dXJucyB0aGUgbnVtYmVyIG9mIHJvd3MgbW9kaWZpZWQsIGluc2VydGVkIG9yIGRlbGV0ZWQgYnkg dGhlIG1vc3QgcmVjZW50bHkgY29tcGxldGVkIElOU0VSVCwgVVBEQVRFIG9yIERFTEVURSBzdGF0 ZW1lbnQuCiAgICAgV0VCQ09SRV9FWFBPUlQgaW50IGxhc3RDaGFuZ2VzKCk7CiAKICAgICB2b2lk IHNldEJ1c3lUaW1lb3V0KGludCBtcyk7CkBAIC0xODUsOCArMTg1LDYgQEAgcHJpdmF0ZToKIAog ICAgIGludCBtX29wZW5FcnJvciB7IFNRTElURV9FUlJPUiB9OwogICAgIENTdHJpbmcgbV9vcGVu RXJyb3JNZXNzYWdlOwotCi0gICAgaW50IG1fbGFzdENoYW5nZXNDb3VudCB7IDAgfTsKIH07CiAK IH0gLy8gbmFtZXNwYWNlIFdlYkNvcmUKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRm b3JtL3NxbC9TUUxpdGVTdGF0ZW1lbnQuY3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vc3Fs L1NRTGl0ZVN0YXRlbWVudC5jcHAKaW5kZXggNDhmOWFlZTJkNzFkOTFmYjQ1NzAyMjJkNGU1YjA3 ODhhMGJlMTVkZi4uMDIwY2U1NzhjYjFlZjExZmY1MDMzMDNmNWJkZGUyODRmOTVhNGU1YiAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vc3FsL1NRTGl0ZVN0YXRlbWVudC5jcHAK KysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vc3FsL1NRTGl0ZVN0YXRlbWVudC5jcHAKQEAg LTYzLDEwICs2Myw2IEBAIGludCBTUUxpdGVTdGF0ZW1lbnQ6OnN0ZXAoKQogewogICAgIExvY2tI b2xkZXIgZGF0YWJhc2VMb2NrKG1fZGF0YWJhc2UuZGF0YWJhc2VNdXRleCgpKTsKIAotICAgIC8v IFRoZSBkYXRhYmFzZSBuZWVkcyB0byB1cGRhdGUgaXRzIGxhc3QgY2hhbmdlcyBjb3VudCBiZWZv cmUgZWFjaCBzdGF0ZW1lbnQKLSAgICAvLyBpbiBvcmRlciB0byBjb21wdXRlIHByb3Blcmx5IHRo ZSBsYXN0Q2hhbmdlcygpIHJldHVybiB2YWx1ZS4KLSAgICBtX2RhdGFiYXNlLnVwZGF0ZUxhc3RD aGFuZ2VzQ291bnQoKTsKLQogICAgIGludCBlcnJvciA9IHNxbGl0ZTNfc3RlcChtX3N0YXRlbWVu dCk7CiAgICAgaWYgKGVycm9yICE9IFNRTElURV9ET05FICYmIGVycm9yICE9IFNRTElURV9ST1cp CiAgICAgICAgIExPRyhTUUxEYXRhYmFzZSwgInNxbGl0ZTNfc3RlcCBmYWlsZWQgKCVpKVxuRXJy b3IgLSAlcyIsIGVycm9yLCBzcWxpdGUzX2Vycm1zZyhtX2RhdGFiYXNlLnNxbGl0ZTNIYW5kbGUo KSkpOwpAQCAtNDMxLDQgKzQyNyw5IEBAIGJvb2wgU1FMaXRlU3RhdGVtZW50OjpoYXNTdGFydGVk U3RlcHBpbmcoKQogICAgIHJldHVybiBzcWxpdGUzX3N0bXRfYnVzeShtX3N0YXRlbWVudCk7CiB9 CiAKK2Jvb2wgU1FMaXRlU3RhdGVtZW50Ojppc1JlYWRPbmx5KCkKK3sKKyAgICByZXR1cm4gc3Fs aXRlM19zdG10X3JlYWRvbmx5KG1fc3RhdGVtZW50KTsKK30KKwogfSAvLyBuYW1lc3BhY2UgV2Vi Q29yZQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vc3FsL1NRTGl0ZVN0YXRl bWVudC5oIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vc3FsL1NRTGl0ZVN0YXRlbWVudC5oCmlu ZGV4IDYzNTEyYmI2ZWI0OWE2ZWUxOWU3MWYxYzY3YjFmZThmMjlmNjVjOGQuLjEyMGNlMTY4YTZh MmJlZGY0NzYyNjEzOTQxYjEzODAxODUwMTg4Y2IgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3Jl L3BsYXRmb3JtL3NxbC9TUUxpdGVTdGF0ZW1lbnQuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0 Zm9ybS9zcWwvU1FMaXRlU3RhdGVtZW50LmgKQEAgLTY0LDYgKzY0LDggQEAgcHVibGljOgogICAg IC8vIFJldHVybnMgLTEgb24gbGFzdC1zdGVwIGZhaWxpbmcuICBPdGhlcndpc2UsIHJldHVybnMg bnVtYmVyIG9mIHJvd3MKICAgICAvLyByZXR1cm5lZCBpbiB0aGUgbGFzdCBzdGVwKCkKICAgICBp bnQgY29sdW1uQ291bnQoKTsKKworICAgIGJvb2wgaXNSZWFkT25seSgpOwogICAgIAogICAgIFdF QkNPUkVfRVhQT1JUIGJvb2wgaXNDb2x1bW5OdWxsKGludCBjb2wpOwogICAgIFdFQkNPUkVfRVhQ T1JUIGJvb2wgaXNDb2x1bW5EZWNsYXJlZEFzQmxvYihpbnQgY29sKTsK