225879 2021-05-17 10:48:49 -0700 Null check m_resource in SubresourceLoader::didReceiveResponse 2021-05-17 13:27:26 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 achristensen achristensen cdumez ews-watchlist ggaren japhet webkit-bug-importer oldest_to_newest 1760803 0 achristensen 2021-05-17 10:48:49 -0700 Null check m_resource in SubresourceLoader::didReceiveResponse 1760806 1 428845 achristensen 2021-05-17 11:02:12 -0700 Created attachment 428845 Patch 1760807 2 achristensen 2021-05-17 11:02:15 -0700 <rdar://problem/78084804> 1760820 3 achristensen 2021-05-17 11:44:30 -0700 r277594 1760825 4 ggaren 2021-05-17 11:59:24 -0700 Let's do a debug ASSERT and a RELEASE_LOG_FAULT for the null resource condition, since we do not believe it is valid, and continuing might sometimes end in mysterious loading bugs. 1760830 5 achristensen 2021-05-17 12:17:37 -0700 Reopening to attach new patch. 1760831 6 428854 achristensen 2021-05-17 12:17:38 -0700 Created attachment 428854 Patch 1760853 7 achristensen 2021-05-17 13:27:26 -0700 r277603 428845 2021-05-17 11:02:12 -0700 2021-05-17 12:17:35 -0700 Patch bug-225879-20210517110211.patch text/plain 3792 achristensen U3VidmVyc2lvbiBSZXZpc2lvbjogMjc3NTUzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMDM3YjVkOTkyNTY4Yzhk Y2I0ZDk2ZjU1NjBlMzNkZjFkYTY2YzU1Zi4uMjk3ODA0YzBlN2VmZmYwZDVlMjNkZjU5OTg1ZjNi NjVmZjdhYmM1ZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDIxLTA1LTE3ICBBbGV4 IENocmlzdGVuc2VuICA8YWNocmlzdGVuc2VuQHdlYmtpdC5vcmc+CisKKyAgICAgICAgTnVsbCBj aGVjayBtX3Jlc291cmNlIGluIFN1YnJlc291cmNlTG9hZGVyOjpkaWRSZWNlaXZlUmVzcG9uc2UK KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIyNTg3OQor ICAgICAgICA8cmRhcjovLzc4MDg0ODA0PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgICogbG9hZGVyL1N1YnJlc291cmNlTG9hZGVyLmNwcDoKKyAgICAg ICAgKFdlYkNvcmU6OlN1YnJlc291cmNlTG9hZGVyOjpkaWRSZWNlaXZlUmVzcG9uc2UpOgorCiAy MDIxLTA1LTE1ICBDaHJpcyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CiAKICAgICAgICAgQ2xl YW4gdXAgQmFzZUF1ZGlvQ29udGV4dCBub3cgdGhhdCBsZWdhY3kvcHJlZml4ZWQgV2ViQXVkaW8g aXMgZ29uZQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvbG9hZGVyL1N1YnJlc291cmNlTG9h ZGVyLmNwcCBiL1NvdXJjZS9XZWJDb3JlL2xvYWRlci9TdWJyZXNvdXJjZUxvYWRlci5jcHAKaW5k ZXggMDBjOWQ4NzAzMzc3OTA1Njg3ZmE2ZDAzNDU1MTY0MDI3NjVkMjQyNi4uODA2MzlmOTFjNjQ5 NjdmNGIyODBlNDdiYTM4ODQ5OWVjMzY3ZmM3NSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUv bG9hZGVyL1N1YnJlc291cmNlTG9hZGVyLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9sb2FkZXIv U3VicmVzb3VyY2VMb2FkZXIuY3BwCkBAIC00MDksNyArNDA5LDcgQEAgdm9pZCBTdWJyZXNvdXJj ZUxvYWRlcjo6ZGlkUmVjZWl2ZVJlc3BvbnNlKGNvbnN0IFJlc291cmNlUmVzcG9uc2UmIHJlc3Bv bnNlLCBDb20KICAgICBpZiAoc2hvdWxkSW5jbHVkZUNlcnRpZmljYXRlSW5mbygpKQogICAgICAg ICByZXNwb25zZS5pbmNsdWRlQ2VydGlmaWNhdGVJbmZvKCk7CiAKLSAgICBpZiAobV9yZXNvdXJj ZS0+cmVzb3VyY2VUb1JldmFsaWRhdGUoKSkgeworICAgIGlmIChtX3Jlc291cmNlICYmIG1fcmVz b3VyY2UtPnJlc291cmNlVG9SZXZhbGlkYXRlKCkpIHsKICAgICAgICAgaWYgKHJlc3BvbnNlLmh0 dHBTdGF0dXNDb2RlKCkgPT0gMzA0KSB7CiAgICAgICAgICAgICAvLyAzMDQgTm90IG1vZGlmaWVk IC8gVXNlIGxvY2FsIGNvcHkKICAgICAgICAgICAgIC8vIEV4aXN0aW5nIHJlc291cmNlIGlzIG9r LCBqdXN0IHVzZSBpdCB1cGRhdGluZyB0aGUgZXhwaXJhdGlvbiB0aW1lLgpAQCAtNDQ4LDE0ICs0 NDgsMTYgQEAgdm9pZCBTdWJyZXNvdXJjZUxvYWRlcjo6ZGlkUmVjZWl2ZVJlc3BvbnNlKGNvbnN0 IFJlc291cmNlUmVzcG9uc2UmIHJlc3BvbnNlLCBDb20KICAgICAgICAgICAgIFJlc291cmNlUmVz cG9uc2Ugb3BhcXVlUmVkaXJlY3RlZFJlc3BvbnNlID0gcmVzcG9uc2U7CiAgICAgICAgICAgICBv cGFxdWVSZWRpcmVjdGVkUmVzcG9uc2Uuc2V0VHlwZShSZXNvdXJjZVJlc3BvbnNlOjpUeXBlOjpP cGFxdWVyZWRpcmVjdCk7CiAgICAgICAgICAgICBvcGFxdWVSZWRpcmVjdGVkUmVzcG9uc2Uuc2V0 VGFpbnRpbmcoUmVzb3VyY2VSZXNwb25zZTo6VGFpbnRpbmc6Ok9wYXF1ZXJlZGlyZWN0KTsKLSAg ICAgICAgICAgIG1fcmVzb3VyY2UtPnJlc3BvbnNlUmVjZWl2ZWQob3BhcXVlUmVkaXJlY3RlZFJl c3BvbnNlKTsKKyAgICAgICAgICAgIGlmIChtX3Jlc291cmNlKQorICAgICAgICAgICAgICAgIG1f cmVzb3VyY2UtPnJlc3BvbnNlUmVjZWl2ZWQob3BhcXVlUmVkaXJlY3RlZFJlc3BvbnNlKTsKICAg ICAgICAgICAgIGlmICghcmVhY2hlZFRlcm1pbmFsU3RhdGUoKSkKICAgICAgICAgICAgICAgICBS ZXNvdXJjZUxvYWRlcjo6ZGlkUmVjZWl2ZVJlc3BvbnNlKG9wYXF1ZVJlZGlyZWN0ZWRSZXNwb25z ZSwgW2NvbXBsZXRpb25IYW5kbGVyQ2FsbGVyID0gV1RGTW92ZShjb21wbGV0aW9uSGFuZGxlckNh bGxlcildIHsgfSk7CiAgICAgICAgICAgICByZXR1cm47CiAgICAgICAgIH0KICAgICB9CiAKLSAg ICBtX3Jlc291cmNlLT5yZXNwb25zZVJlY2VpdmVkKHJlc3BvbnNlKTsKKyAgICBpZiAobV9yZXNv dXJjZSkKKyAgICAgICAgbV9yZXNvdXJjZS0+cmVzcG9uc2VSZWNlaXZlZChyZXNwb25zZSk7CiAg ICAgaWYgKHJlYWNoZWRUZXJtaW5hbFN0YXRlKCkpCiAgICAgICAgIHJldHVybjsKIApAQCAtNDY4 LDcgKzQ3MCw3IEBAIHZvaWQgU3VicmVzb3VyY2VMb2FkZXI6OmRpZFJlY2VpdmVSZXNwb25zZShj b25zdCBSZXNvdXJjZVJlc3BvbnNlJiByZXNwb25zZSwgQ29tCiAKICAgICAgICAgLy8gRklYTUU6 IE1haW4gcmVzb3VyY2VzIGhhdmUgYSBkaWZmZXJlbnQgc2V0IG9mIHJ1bGVzIGZvciBtdWx0aXBh cnQgdGhhbiBpbWFnZXMgZG8uCiAgICAgICAgIC8vIEhvcGVmdWxseSB3ZSBjYW4gbWVyZ2UgdGhv c2UgMiBwYXRocy4KLSAgICAgICAgaWYgKGlzUmVzcG9uc2VNdWx0aXBhcnQgJiYgbV9yZXNvdXJj ZS0+dHlwZSgpICE9IENhY2hlZFJlc291cmNlOjpUeXBlOjpNYWluUmVzb3VyY2UpIHsKKyAgICAg ICAgaWYgKGlzUmVzcG9uc2VNdWx0aXBhcnQgJiYgbV9yZXNvdXJjZSAmJiBtX3Jlc291cmNlLT50 eXBlKCkgIT0gQ2FjaGVkUmVzb3VyY2U6OlR5cGU6Ok1haW5SZXNvdXJjZSkgewogICAgICAgICAg ICAgbV9sb2FkaW5nTXVsdGlwYXJ0Q29udGVudCA9IHRydWU7CiAKICAgICAgICAgICAgIC8vIFdl IGRvbid0IGNvdW50IG11bHRpUGFydHMgaW4gYSBDYWNoZWRSZXNvdXJjZUxvYWRlcidzIHJlcXVl c3QgY291bnQKQEAgLTQ4Myw3ICs0ODUsOCBAQCB2b2lkIFN1YnJlc291cmNlTG9hZGVyOjpkaWRS ZWNlaXZlUmVzcG9uc2UoY29uc3QgUmVzb3VyY2VSZXNwb25zZSYgcmVzcG9uc2UsIENvbQogICAg ICAgICBhdXRvKiBidWZmZXIgPSByZXNvdXJjZURhdGEoKTsKICAgICAgICAgaWYgKG1fbG9hZGlu Z011bHRpcGFydENvbnRlbnQgJiYgYnVmZmVyICYmIGJ1ZmZlci0+c2l6ZSgpKSB7CiAgICAgICAg ICAgICAvLyBUaGUgcmVzb3VyY2UgZGF0YSB3aWxsIGNoYW5nZSBhcyB0aGUgbmV4dCBwYXJ0IGlz IGxvYWRlZCwgc28gd2UgbmVlZCB0byBtYWtlIGEgY29weS4KLSAgICAgICAgICAgIG1fcmVzb3Vy Y2UtPmZpbmlzaExvYWRpbmcoYnVmZmVyLT5jb3B5KCkucHRyKCksIHsgfSk7CisgICAgICAgICAg ICBpZiAobV9yZXNvdXJjZSkKKyAgICAgICAgICAgICAgICBtX3Jlc291cmNlLT5maW5pc2hMb2Fk aW5nKGJ1ZmZlci0+Y29weSgpLnB0cigpLCB7IH0pOwogICAgICAgICAgICAgY2xlYXJSZXNvdXJj ZURhdGEoKTsKICAgICAgICAgICAgIC8vIFNpbmNlIGEgc3VicmVzb3VyY2UgbG9hZGVyIGRvZXMg bm90IGxvYWQgbXVsdGlwYXJ0IHNlY3Rpb25zIHByb2dyZXNzaXZlbHksIGRhdGEgd2FzIGRlbGl2 ZXJlZCB0byB0aGUgbG9hZGVyIGFsbCBhdCBvbmNlLgogICAgICAgICAgICAgLy8gQWZ0ZXIgdGhl IGZpcnN0IG11bHRpcGFydCBzZWN0aW9uIGlzIGNvbXBsZXRlLCBzaWduYWwgdG8gZGVsZWdhdGVz IHRoYXQgdGhpcyBsb2FkIGlzICJmaW5pc2hlZCIK 428854 2021-05-17 12:17:38 -0700 2021-05-17 12:24:54 -0700 Patch bug-225879-20210517121737.patch text/plain 1900 achristensen U3VidmVyc2lvbiBSZXZpc2lvbjogMjc3NTk0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNWU3ZWRlMTFiNTViNTNm YWQ1NGNkNjliMDI5N2Y4YzQ3OTc0ZjljOC4uNTg0ZDY0NTU5ZDFjZTExNjRkNmNkNWM2NTMyYTg3 ZDNmNjVhNmNmZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDIxLTA1LTE3ICBBbGV4 IENocmlzdGVuc2VuICA8YWNocmlzdGVuc2VuQHdlYmtpdC5vcmc+CisKKyAgICAgICAgTnVsbCBj aGVjayBtX3Jlc291cmNlIGluIFN1YnJlc291cmNlTG9hZGVyOjpkaWRSZWNlaXZlUmVzcG9uc2UK KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIyNTg3OQor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEFkZCBBU1NF UlRfTk9UX1JFQUNIRUQgYW5kIFJFTEVBU0VfTE9HX0ZBVUxUIGlmIG1fcmVzb3VyY2UgaXMgbnVs bC4KKyAgICAgICAgVGhpcyB3aWxsIGhlbHAgdXMgbm90aWNlIHRoaXMgaW52YWxpZCBzdGF0ZSBp biBkZWJ1ZyBidWlsZHMgYW5kIGRpYWdub3NlIHN0cmFuZ2UgbG9hZGluZyBmYWlsdXJlcyBpbiBz aW11bGF0ZWQgY3Jhc2ggbG9ncy4KKyAgICAgICAgT24gZnVydGhlciBpbnZlc3RpZ2F0aW9uLCB0 aGUgY3Jhc2ggZml4ZWQgaW4gcjI3NzU5NCB3YXMgbGlrZWx5IGFscmVhZHkgZml4ZWQgYnkgc29t ZXRoaW5nIGVsc2UsIGJ1dCB0aGF0IG1hZGUgaXQgbW9yZSByb2J1c3QuCisKKyAgICAgICAgKiBs b2FkZXIvU3VicmVzb3VyY2VMb2FkZXIuY3BwOgorICAgICAgICAoV2ViQ29yZTo6U3VicmVzb3Vy Y2VMb2FkZXI6OmRpZFJlY2VpdmVSZXNwb25zZSk6CisKIDIwMjEtMDUtMTcgIEFsZXggQ2hyaXN0 ZW5zZW4gIDxhY2hyaXN0ZW5zZW5Ad2Via2l0Lm9yZz4KIAogICAgICAgICBOdWxsIGNoZWNrIG1f cmVzb3VyY2UgaW4gU3VicmVzb3VyY2VMb2FkZXI6OmRpZFJlY2VpdmVSZXNwb25zZQpkaWZmIC0t Z2l0IGEvU291cmNlL1dlYkNvcmUvbG9hZGVyL1N1YnJlc291cmNlTG9hZGVyLmNwcCBiL1NvdXJj ZS9XZWJDb3JlL2xvYWRlci9TdWJyZXNvdXJjZUxvYWRlci5jcHAKaW5kZXggODA2MzlmOTFjNjQ5 NjdmNGIyODBlNDdiYTM4ODQ5OWVjMzY3ZmM3NS4uMDZhNTk1OWJjZDExZjA2NGMwYTczZTA3NGIw YmRmY2NmMzc1YTA1MiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvbG9hZGVyL1N1YnJlc291 cmNlTG9hZGVyLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9sb2FkZXIvU3VicmVzb3VyY2VMb2Fk ZXIuY3BwCkBAIC00MDksNiArNDA5LDExIEBAIHZvaWQgU3VicmVzb3VyY2VMb2FkZXI6OmRpZFJl Y2VpdmVSZXNwb25zZShjb25zdCBSZXNvdXJjZVJlc3BvbnNlJiByZXNwb25zZSwgQ29tCiAgICAg aWYgKHNob3VsZEluY2x1ZGVDZXJ0aWZpY2F0ZUluZm8oKSkKICAgICAgICAgcmVzcG9uc2UuaW5j bHVkZUNlcnRpZmljYXRlSW5mbygpOwogCisgICAgaWYgKCFtX3Jlc291cmNlKSB7CisgICAgICAg IEFTU0VSVF9OT1RfUkVBQ0hFRCgpOworICAgICAgICBSRUxFQVNFX0xPR19GQVVMVChMb2FkaW5n LCAiUmVzb3VyY2Ugd2FzIHVuZXhwZWN0ZWRseSBudWxsIGluIFN1YnJlc291cmNlTG9hZGVyOjpk aWRSZWNlaXZlUmVzcG9uc2UiKTsKKyAgICB9CisKICAgICBpZiAobV9yZXNvdXJjZSAmJiBtX3Jl c291cmNlLT5yZXNvdXJjZVRvUmV2YWxpZGF0ZSgpKSB7CiAgICAgICAgIGlmIChyZXNwb25zZS5o dHRwU3RhdHVzQ29kZSgpID09IDMwNCkgewogICAgICAgICAgICAgLy8gMzA0IE5vdCBtb2RpZmll ZCAvIFVzZSBsb2NhbCBjb3B5Cg==