<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>225876</bug_id>
          
          <creation_ts>2021-05-17 09:27:37 -0700</creation_ts>
          <short_desc>UserGestureToken::processingUserGestureForMedia is use for non-media things</short_desc>
          <delta_ts>2021-05-24 09:28:15 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>WebCore Misc.</component>
          <version>Other</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>NEW</bug_status>
          <resolution></resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Sam Weinig">sam</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>eric.carlson</cc>
    
    <cc>jer.noble</cc>
    
    <cc>webkit-bug-importer</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1760778</commentid>
    <comment_count>0</comment_count>
    <who name="Sam Weinig">sam</who>
    <bug_when>2021-05-17 09:27:37 -0700</bug_when>
    <thetext>The function UserGestureToken::processingUserGestureForMedia is use for non-media things such as the WebAuthenticatorCoordinator.

It really should be renamed to indicate what it does, since the current name is quite unclear.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1760782</commentid>
    <comment_count>1</comment_count>
    <who name="Sam Weinig">sam</who>
    <bug_when>2021-05-17 09:31:05 -0700</bug_when>
    <thetext>(or rather, we should either rename it or stop using it for non-media related things).</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1760786</commentid>
    <comment_count>2</comment_count>
    <who name="Sam Weinig">sam</who>
    <bug_when>2021-05-17 09:33:31 -0700</bug_when>
    <thetext>It looks like the differences between processingUserGesture() and processingUserGestureForMedia() are:

- processingUserGestureForMedia() works for any scope type, processingUserGesture() only works for All (not MediaOnly)
- processingUserGestureForMedia() works for state == ProcessingUserGesture or m_state == ProcessingPotentialUserGesture, processingUserGesture() only works for state == ProcessingUserGesture.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1760787</commentid>
    <comment_count>3</comment_count>
    <who name="Sam Weinig">sam</who>
    <bug_when>2021-05-17 09:38:34 -0700</bug_when>
    <thetext>It took a while to find, but ProcessingPotentialUserGesture is set when a touch event is a potential tap and we are in TouchStart.

GestureScope::MediaOnly is used when propagating a user gesture on from a fetch or XHR.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1763159</commentid>
    <comment_count>4</comment_count>
    <who name="Radar WebKit Bug Importer">webkit-bug-importer</who>
    <bug_when>2021-05-24 09:28:15 -0700</bug_when>
    <thetext>&lt;rdar://problem/78403759&gt;</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>