22585 2008-12-01 19:02:02 -0800 Compilation failure in PluginPackageWin.cpp on MinGW/Win 2008-12-02 08:04:12 -0800 1 1 1 Unclassified WebKit Plug-ins 528+ (Nightly build) PC Windows XP RESOLVED FIXED P2 Normal --- 0 laszlo.gombos webkit-unassigned hausmann laszlo.gombos oldest_to_newest 100939 0 laszlo.gombos 2008-12-01 19:02:02 -0800 ..\..\..\webkit\WebCore\plugins\win\PluginPackageWin.cpp: In member function `bool WebCore::PluginPackage::fetchInfo()': ..\..\..\webkit\WebCore\plugins\win\PluginPackageWin.cpp:165: error: invalid conversion from `const UChar*' to `WCHAR*' ..\..\..\webkit\WebCore\plugins\win\PluginPackageWin.cpp:165: error: initializing argument 1 of `DWORD GetFileVersionI nfoSizeW(WCHAR*, DWORD*)' ..\..\..\webkit\WebCore\plugins\win\PluginPackageWin.cpp:171: error: invalid conversion from `const UChar*' to `WCHAR*' ..\..\..\webkit\WebCore\plugins\win\PluginPackageWin.cpp:171: error: initializing argument 1 of `BOOL GetFileVersionIn foW(WCHAR*, DWORD, DWORD, void*)' mingw32-make[2]: *** [tmp/PluginPackageWin.o] Error 1 100940 1 25652 laszlo.gombos 2008-12-01 19:04:10 -0800 Created attachment 25652 Fix Cast away const. 101004 2 25652 vestbo 2008-12-02 08:03:55 -0800 Comment on attachment 25652 Fix Thanks! Landed in r38903 25652 2008-12-01 19:04:10 -0800 2008-12-02 08:03:55 -0800 Fix patch_22585.txt text/plain 1650 laszlo.gombos SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiAzODg3OSkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTMgQEAKKzIwMDgtMTItMDEgIExhc3psbyBHb21ib3MgIDxsYXN6bG8uMS5nb21i b3NAbm9raWEuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMjU4NQorICAg ICAgICBNaW5HVyBjb21waWxhdGlvbiBmaXggZm9yIFBsdWdpblBhY2thZ2VXaW4uY3BwCisKKyAg ICAgICAgKiBwbHVnaW5zL3dpbi9QbHVnaW5QYWNrYWdlV2luLmNwcDoKKyAgICAgICAgKFdlYkNv cmU6OlBsdWdpblBhY2thZ2U6OmZldGNoSW5mbyk6CisKIDIwMDgtMTItMDEgIEp1bGllbiBDaGFm ZnJhaXggIDxqY2hhZmZyYWl4QHdlYmtpdC5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgQW50 dGkgS29pdmlzdG8uCkluZGV4OiBXZWJDb3JlL3BsdWdpbnMvd2luL1BsdWdpblBhY2thZ2VXaW4u Y3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvcGx1Z2lucy93aW4vUGx1Z2luUGFja2FnZVdpbi5j cHAJKHJldmlzaW9uIDM4ODIxKQorKysgV2ViQ29yZS9wbHVnaW5zL3dpbi9QbHVnaW5QYWNrYWdl V2luLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMTYyLDEzICsxNjIsMTMgQEAgdm9pZCBQbHVnaW5Q YWNrYWdlOjpkZXRlcm1pbmVRdWlya3MoY29ucwogYm9vbCBQbHVnaW5QYWNrYWdlOjpmZXRjaElu Zm8oKQogewogICAgIERXT1JEIHZlcnNpb25JbmZvU2l6ZSwgemVyb0hhbmRsZTsKLSAgICB2ZXJz aW9uSW5mb1NpemUgPSBHZXRGaWxlVmVyc2lvbkluZm9TaXplVyhtX3BhdGguY2hhcmFjdGVyc1dp dGhOdWxsVGVybWluYXRpb24oKSwgJnplcm9IYW5kbGUpOyAKKyAgICB2ZXJzaW9uSW5mb1NpemUg PSBHZXRGaWxlVmVyc2lvbkluZm9TaXplVyhjb25zdF9jYXN0PFVDaGFyKj4obV9wYXRoLmNoYXJh Y3RlcnNXaXRoTnVsbFRlcm1pbmF0aW9uKCkpLCAmemVyb0hhbmRsZSk7IAogICAgIGlmICh2ZXJz aW9uSW5mb1NpemUgPT0gMCkKICAgICAgICAgcmV0dXJuIGZhbHNlOwogCiAgICAgT3duQXJyYXlQ dHI8Y2hhcj4gdmVyc2lvbkluZm9EYXRhKG5ldyBjaGFyW3ZlcnNpb25JbmZvU2l6ZV0pOwogCi0g ICAgaWYgKCFHZXRGaWxlVmVyc2lvbkluZm9XKG1fcGF0aC5jaGFyYWN0ZXJzV2l0aE51bGxUZXJt aW5hdGlvbigpLCAwLCB2ZXJzaW9uSW5mb1NpemUsIHZlcnNpb25JbmZvRGF0YS5nZXQoKSkpCisg ICAgaWYgKCFHZXRGaWxlVmVyc2lvbkluZm9XKGNvbnN0X2Nhc3Q8VUNoYXIqPihtX3BhdGguY2hh cmFjdGVyc1dpdGhOdWxsVGVybWluYXRpb24oKSksIDAsIHZlcnNpb25JbmZvU2l6ZSwgdmVyc2lv bkluZm9EYXRhLmdldCgpKSkKICAgICAgICAgcmV0dXJuIGZhbHNlOwogCiAgICAgbV9uYW1lID0g Z2V0VmVyc2lvbkluZm8odmVyc2lvbkluZm9EYXRhLmdldCgpLCAiUHJvZHVjdE5hbWUiKTsK