225833 2021-05-14 16:06:21 -0700 [run-webkit-tests] Handle missing simulator state plist 2021-05-14 21:58:26 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 jbedard jbedard aakash_jain ews-watchlist glenn webkit-bug-importer oldest_to_newest 1760276 0 jbedard 2021-05-14 16:06:21 -0700 Our code should handle the case where no simulator state plist is found on disk. 1760277 1 webkit-bug-importer 2021-05-14 16:06:37 -0700 <rdar://problem/78036930> 1760280 2 428677 jbedard 2021-05-14 16:09:22 -0700 Created attachment 428677 Patch 1760287 3 428677 aakash_jain 2021-05-14 16:19:55 -0700 Comment on attachment 428677 Patch rs=me 1760290 4 428681 jbedard 2021-05-14 16:22:38 -0700 Created attachment 428681 Patch 1760295 5 428684 jbedard 2021-05-14 16:42:19 -0700 Created attachment 428684 Patch 1760375 6 ews-feeder 2021-05-14 21:58:26 -0700 Committed r277531 (237759@main): <https://commits.webkit.org/237759@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 428684. 428677 2021-05-14 16:09:22 -0700 2021-05-14 16:22:36 -0700 Patch bug-225833-20210514160921.patch text/plain 1596 jbedard SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDI3NzUxMykKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE0IEBACisyMDIxLTA1LTE0ICBKb25hdGhhbiBCZWRhcmQgIDxqYmVkYXJkQGFwcGxlLmNv bT4KKworICAgICAgICBbcnVuLXdlYmtpdC10ZXN0c10gSGFuZGxlIG1pc3Npbmcgc2ltdWxhdG9y IHN0YXRlIHBsaXN0CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0yMjU4MzMKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzc4MDM2OTMwPgorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogU2NyaXB0cy93ZWJraXRw eS94Y29kZS9zaW11bGF0ZWRfZGV2aWNlLnB5OgorICAgICAgICAoU2ltdWxhdGVkRGV2aWNlLnN0 YXRlKTogSWYgbm8gZGV2aWNlIHBsaXN0IGlzIGZvdW5kLCBhc3N1bWUgdGhlIGRldmljZSBpcyBz aHV0IGRvd24uCisKIDIwMjEtMDUtMTQgIEplYW4tWXZlcyBBdmVuYXJkICA8anlhQGFwcGxlLmNv bT4KIAogICAgICAgICBUZXN0V2ViS2l0QVBJLkZ1bGxzY3JlZW4uV0tWaWV3RGVsZWdhdGUgaXMg dGltaW5nIG91dApJbmRleDogVG9vbHMvU2NyaXB0cy93ZWJraXRweS94Y29kZS9zaW11bGF0ZWRf ZGV2aWNlLnB5Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT0KLS0tIFRvb2xzL1NjcmlwdHMvd2Via2l0cHkveGNvZGUvc2lt dWxhdGVkX2RldmljZS5weQkocmV2aXNpb24gMjc3NTAzKQorKysgVG9vbHMvU2NyaXB0cy93ZWJr aXRweS94Y29kZS9zaW11bGF0ZWRfZGV2aWNlLnB5CSh3b3JraW5nIGNvcHkpCkBAIC01NjEsNyAr NTYxLDExIEBAIGNsYXNzIFNpbXVsYXRlZERldmljZShvYmplY3QpOgogICAgICAgICAgICAgcmV0 dXJuIHNlbGYuX3N0YXRlCiAKICAgICAgICAgZGV2aWNlX3BsaXN0ID0gc2VsZi5maWxlc3lzdGVt LmV4cGFuZHVzZXIoc2VsZi5maWxlc3lzdGVtLmpvaW4oU2ltdWxhdGVkRGV2aWNlTWFuYWdlci5z aW11bGF0b3JfZGV2aWNlX3BhdGgsIHNlbGYudWRpZCwgJ2RldmljZS5wbGlzdCcpKQotICAgICAg ICBzZWxmLl9zdGF0ZSA9IGludChyZWFkUGxpc3Qoc2VsZi5maWxlc3lzdGVtLm9wZW5fYmluYXJ5 X2ZpbGVfZm9yX3JlYWRpbmcoZGV2aWNlX3BsaXN0KSlbJ3N0YXRlJ10pCisgICAgICAgIHRyeToK KyAgICAgICAgICAgIHNlbGYuX3N0YXRlID0gaW50KHJlYWRQbGlzdChzZWxmLmZpbGVzeXN0ZW0u b3Blbl9iaW5hcnlfZmlsZV9mb3JfcmVhZGluZyhkZXZpY2VfcGxpc3QpKVsnc3RhdGUnXSkKKyAg ICAgICAgZXhjZXB0IElPRXJyb3I6CisgICAgICAgICAgICBzZWxmLl9zdGF0ZSA9IFNpbXVsYXRl ZERldmljZS5EZXZpY2VTdGF0ZS5TSFVUVElOR19ET1dOCisKICAgICAgICAgc2VsZi5fbGFzdF91 cGRhdGVkX3N0YXRlID0gdGltZS50aW1lKCkKICAgICAgICAgcmV0dXJuIHNlbGYuX3N0YXRlCiAK 428681 2021-05-14 16:22:38 -0700 2021-05-14 16:42:17 -0700 Patch bug-225833-20210514162238.patch text/plain 2702 jbedard SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDI3NzUxNSkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE1IEBACisyMDIxLTA1LTE0ICBKb25hdGhhbiBCZWRhcmQgIDxqYmVkYXJkQGFwcGxlLmNv bT4KKworICAgICAgICBbcnVuLXdlYmtpdC10ZXN0c10gSGFuZGxlIG1pc3Npbmcgc2ltdWxhdG9y IHN0YXRlIHBsaXN0CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0yMjU4MzMKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzc4MDM2OTMwPgorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogU2NyaXB0cy93ZWJraXRw eS94Y29kZS9zaW11bGF0ZWRfZGV2aWNlLnB5OgorICAgICAgICAoU2ltdWxhdGVkRGV2aWNlLnN0 YXRlKTogSWYgbm8gZGV2aWNlIHBsaXN0IGlzIGZvdW5kLCBhc3N1bWUgdGhlIGRldmljZSBpcyBz aHV0IGRvd24uCisgICAgICAgICogU2NyaXB0cy93ZWJraXRweS94Y29kZS9zaW11bGF0ZWRfZGV2 aWNlX3VuaXR0ZXN0LnB5OgorCiAyMDIxLTA1LTE0ICBDaHJpcyBEdW1leiAgPGNkdW1lekBhcHBs ZS5jb20+CiAKICAgICAgICAgRHJvcCAiZ2V0IiBwcmVmaXggZnJvbSBXVEY6OkZpbGVTeXN0ZW0n cyBnZXRGaWxlTW9kaWZpY2F0aW9uVGltZSgpIC8gZ2V0RmlsZUNyZWF0aW9uVGltZSgpCkluZGV4 OiBUb29scy9TY3JpcHRzL3dlYmtpdHB5L3hjb2RlL3NpbXVsYXRlZF9kZXZpY2UucHkKPT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PQotLS0gVG9vbHMvU2NyaXB0cy93ZWJraXRweS94Y29kZS9zaW11bGF0ZWRfZGV2aWNlLnB5 CShyZXZpc2lvbiAyNzc1MDMpCisrKyBUb29scy9TY3JpcHRzL3dlYmtpdHB5L3hjb2RlL3NpbXVs YXRlZF9kZXZpY2UucHkJKHdvcmtpbmcgY29weSkKQEAgLTU2MSw3ICs1NjEsMTEgQEAgY2xhc3Mg U2ltdWxhdGVkRGV2aWNlKG9iamVjdCk6CiAgICAgICAgICAgICByZXR1cm4gc2VsZi5fc3RhdGUK IAogICAgICAgICBkZXZpY2VfcGxpc3QgPSBzZWxmLmZpbGVzeXN0ZW0uZXhwYW5kdXNlcihzZWxm LmZpbGVzeXN0ZW0uam9pbihTaW11bGF0ZWREZXZpY2VNYW5hZ2VyLnNpbXVsYXRvcl9kZXZpY2Vf cGF0aCwgc2VsZi51ZGlkLCAnZGV2aWNlLnBsaXN0JykpCi0gICAgICAgIHNlbGYuX3N0YXRlID0g aW50KHJlYWRQbGlzdChzZWxmLmZpbGVzeXN0ZW0ub3Blbl9iaW5hcnlfZmlsZV9mb3JfcmVhZGlu ZyhkZXZpY2VfcGxpc3QpKVsnc3RhdGUnXSkKKyAgICAgICAgdHJ5OgorICAgICAgICAgICAgc2Vs Zi5fc3RhdGUgPSBpbnQocmVhZFBsaXN0KHNlbGYuZmlsZXN5c3RlbS5vcGVuX2JpbmFyeV9maWxl X2Zvcl9yZWFkaW5nKGRldmljZV9wbGlzdCkpWydzdGF0ZSddKQorICAgICAgICBleGNlcHQgSU9F cnJvcjoKKyAgICAgICAgICAgIHNlbGYuX3N0YXRlID0gU2ltdWxhdGVkRGV2aWNlLkRldmljZVN0 YXRlLlNIVVRUSU5HX0RPV04KKwogICAgICAgICBzZWxmLl9sYXN0X3VwZGF0ZWRfc3RhdGUgPSB0 aW1lLnRpbWUoKQogICAgICAgICByZXR1cm4gc2VsZi5fc3RhdGUKIApJbmRleDogVG9vbHMvU2Ny aXB0cy93ZWJraXRweS94Y29kZS9zaW11bGF0ZWRfZGV2aWNlX3VuaXR0ZXN0LnB5Cj09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT0KLS0tIFRvb2xzL1NjcmlwdHMvd2Via2l0cHkveGNvZGUvc2ltdWxhdGVkX2RldmljZV91bml0 dGVzdC5weQkocmV2aXNpb24gMjc3NTAzKQorKysgVG9vbHMvU2NyaXB0cy93ZWJraXRweS94Y29k ZS9zaW11bGF0ZWRfZGV2aWNlX3VuaXR0ZXN0LnB5CSh3b3JraW5nIGNvcHkpCkBAIC02NzgsMyAr Njc4LDEyIEBAIGNsYXNzIFNpbXVsYXRlZERldmljZVRlc3QodW5pdHRlc3QuVGVzdEMKICAgICAg ICAgU2ltdWxhdGVkRGV2aWNlVGVzdC5jaGFuZ2Vfc3RhdGVfdG8oU2ltdWxhdGVkRGV2aWNlTWFu YWdlci5JTklUSUFMSVpFRF9ERVZJQ0VTWzBdLCBTaW11bGF0ZWREZXZpY2UuRGV2aWNlU3RhdGUu U0hVVF9ET1dOKQogICAgICAgICBTaW11bGF0ZWREZXZpY2VNYW5hZ2VyLnRlYXJfZG93bihob3N0 KQogICAgICAgICBzZWxmLmFzc2VydElzTm9uZShTaW11bGF0ZWREZXZpY2VNYW5hZ2VyLklOSVRJ QUxJWkVEX0RFVklDRVMpCisKKyAgICBkZWYgdGVzdF9ub19zdGF0ZV9maWxlcyhzZWxmKToKKyAg ICAgICAgU2ltdWxhdGVkRGV2aWNlVGVzdC5yZXNldF9zaW11bGF0ZWRfZGV2aWNlX21hbmFnZXIo KQorICAgICAgICBob3N0ID0gU2ltdWxhdGVkRGV2aWNlVGVzdC5tb2NrX2hvc3RfZm9yX3NpbWN0 bCgpCisgICAgICAgIGhvc3QuZmlsZXN5c3RlbSA9IE1vY2tGaWxlU3lzdGVtKCkKKyAgICAgICAg ZGV2aWNlcyA9IFNpbXVsYXRlZERldmljZU1hbmFnZXIuYXZhaWxhYmxlX2RldmljZXMoaG9zdCkK KworICAgICAgICBmb3IgZGV2aWNlIGluIGRldmljZXM6CisgICAgICAgICAgICBzZWxmLmFzc2Vy dEVxdWFscyhTaW11bGF0ZWREZXZpY2UuRGV2aWNlU3RhdGUuU0hVVF9ET1dOLCBkZXZpY2Uuc3Rh dGUoZm9yY2VfdXBkYXRlPVRydWUpKQo= 428684 2021-05-14 16:42:19 -0700 2021-05-14 21:58:26 -0700 Patch bug-225833-20210514164218.patch text/plain 2705 jbedard SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDI3NzUxNykKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE1IEBACisyMDIxLTA1LTE0ICBKb25hdGhhbiBCZWRhcmQgIDxqYmVkYXJkQGFwcGxlLmNv bT4KKworICAgICAgICBbcnVuLXdlYmtpdC10ZXN0c10gSGFuZGxlIG1pc3Npbmcgc2ltdWxhdG9y IHN0YXRlIHBsaXN0CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0yMjU4MzMKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzc4MDM2OTMwPgorCisgICAgICAg IFJ1YmJlci1zdGFtcGVkIGJ5IEFha2FzaCBKYWluLgorCisgICAgICAgICogU2NyaXB0cy93ZWJr aXRweS94Y29kZS9zaW11bGF0ZWRfZGV2aWNlLnB5OgorICAgICAgICAoU2ltdWxhdGVkRGV2aWNl LnN0YXRlKTogSWYgbm8gZGV2aWNlIHBsaXN0IGlzIGZvdW5kLCBhc3N1bWUgdGhlIGRldmljZSBp cyBzaHV0IGRvd24uCisgICAgICAgICogU2NyaXB0cy93ZWJraXRweS94Y29kZS9zaW11bGF0ZWRf ZGV2aWNlX3VuaXR0ZXN0LnB5OgorCiAyMDIxLTA1LTE0ICBDaHJpcyBEdW1leiAgPGNkdW1lekBh cHBsZS5jb20+CiAKICAgICAgICAgRHJvcCAiZ2V0IiBwcmVmaXggZnJvbSBXVEY6OkZpbGVTeXN0 ZW0ncyBnZXRGaWxlTW9kaWZpY2F0aW9uVGltZSgpIC8gZ2V0RmlsZUNyZWF0aW9uVGltZSgpCklu ZGV4OiBUb29scy9TY3JpcHRzL3dlYmtpdHB5L3hjb2RlL3NpbXVsYXRlZF9kZXZpY2UucHkKPT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PQotLS0gVG9vbHMvU2NyaXB0cy93ZWJraXRweS94Y29kZS9zaW11bGF0ZWRfZGV2aWNl LnB5CShyZXZpc2lvbiAyNzc1MTcpCisrKyBUb29scy9TY3JpcHRzL3dlYmtpdHB5L3hjb2RlL3Np bXVsYXRlZF9kZXZpY2UucHkJKHdvcmtpbmcgY29weSkKQEAgLTU2MSw3ICs1NjEsMTEgQEAgY2xh c3MgU2ltdWxhdGVkRGV2aWNlKG9iamVjdCk6CiAgICAgICAgICAgICByZXR1cm4gc2VsZi5fc3Rh dGUKIAogICAgICAgICBkZXZpY2VfcGxpc3QgPSBzZWxmLmZpbGVzeXN0ZW0uZXhwYW5kdXNlcihz ZWxmLmZpbGVzeXN0ZW0uam9pbihTaW11bGF0ZWREZXZpY2VNYW5hZ2VyLnNpbXVsYXRvcl9kZXZp Y2VfcGF0aCwgc2VsZi51ZGlkLCAnZGV2aWNlLnBsaXN0JykpCi0gICAgICAgIHNlbGYuX3N0YXRl ID0gaW50KHJlYWRQbGlzdChzZWxmLmZpbGVzeXN0ZW0ub3Blbl9iaW5hcnlfZmlsZV9mb3JfcmVh ZGluZyhkZXZpY2VfcGxpc3QpKVsnc3RhdGUnXSkKKyAgICAgICAgdHJ5OgorICAgICAgICAgICAg c2VsZi5fc3RhdGUgPSBpbnQocmVhZFBsaXN0KHNlbGYuZmlsZXN5c3RlbS5vcGVuX2JpbmFyeV9m aWxlX2Zvcl9yZWFkaW5nKGRldmljZV9wbGlzdCkpWydzdGF0ZSddKQorICAgICAgICBleGNlcHQg SU9FcnJvcjoKKyAgICAgICAgICAgIHNlbGYuX3N0YXRlID0gU2ltdWxhdGVkRGV2aWNlLkRldmlj ZVN0YXRlLlNIVVRUSU5HX0RPV04KKwogICAgICAgICBzZWxmLl9sYXN0X3VwZGF0ZWRfc3RhdGUg PSB0aW1lLnRpbWUoKQogICAgICAgICByZXR1cm4gc2VsZi5fc3RhdGUKIApJbmRleDogVG9vbHMv U2NyaXB0cy93ZWJraXRweS94Y29kZS9zaW11bGF0ZWRfZGV2aWNlX3VuaXR0ZXN0LnB5Cj09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT0KLS0tIFRvb2xzL1NjcmlwdHMvd2Via2l0cHkveGNvZGUvc2ltdWxhdGVkX2RldmljZV91 bml0dGVzdC5weQkocmV2aXNpb24gMjc3NTE3KQorKysgVG9vbHMvU2NyaXB0cy93ZWJraXRweS94 Y29kZS9zaW11bGF0ZWRfZGV2aWNlX3VuaXR0ZXN0LnB5CSh3b3JraW5nIGNvcHkpCkBAIC02Nzgs MyArNjc4LDEyIEBAIGNsYXNzIFNpbXVsYXRlZERldmljZVRlc3QodW5pdHRlc3QuVGVzdEMKICAg ICAgICAgU2ltdWxhdGVkRGV2aWNlVGVzdC5jaGFuZ2Vfc3RhdGVfdG8oU2ltdWxhdGVkRGV2aWNl TWFuYWdlci5JTklUSUFMSVpFRF9ERVZJQ0VTWzBdLCBTaW11bGF0ZWREZXZpY2UuRGV2aWNlU3Rh dGUuU0hVVF9ET1dOKQogICAgICAgICBTaW11bGF0ZWREZXZpY2VNYW5hZ2VyLnRlYXJfZG93biho b3N0KQogICAgICAgICBzZWxmLmFzc2VydElzTm9uZShTaW11bGF0ZWREZXZpY2VNYW5hZ2VyLklO SVRJQUxJWkVEX0RFVklDRVMpCisKKyAgICBkZWYgdGVzdF9ub19zdGF0ZV9maWxlcyhzZWxmKToK KyAgICAgICAgU2ltdWxhdGVkRGV2aWNlVGVzdC5yZXNldF9zaW11bGF0ZWRfZGV2aWNlX21hbmFn ZXIoKQorICAgICAgICBob3N0ID0gU2ltdWxhdGVkRGV2aWNlVGVzdC5tb2NrX2hvc3RfZm9yX3Np bWN0bCgpCisgICAgICAgIGhvc3QuZmlsZXN5c3RlbSA9IE1vY2tGaWxlU3lzdGVtKCkKKyAgICAg ICAgZGV2aWNlcyA9IFNpbXVsYXRlZERldmljZU1hbmFnZXIuYXZhaWxhYmxlX2RldmljZXMoaG9z dCkKKworICAgICAgICBmb3IgZGV2aWNlIGluIGRldmljZXM6CisgICAgICAgICAgICBzZWxmLmFz c2VydEVxdWFscyhTaW11bGF0ZWREZXZpY2UuRGV2aWNlU3RhdGUuU0hVVF9ET1dOLCBkZXZpY2Uu c3RhdGUoZm9yY2VfdXBkYXRlPVRydWUpKQo=