225824 2021-05-14 14:34:25 -0700 DFGVarargsForwardingPhase shouldn't consult Flush 2021-05-16 00:31:17 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 saam saam ews-watchlist fpizlo ggaren keith_miller mark.lam msaboff tzagallo webkit-bug-importer ysuzuki oldest_to_newest 1760211 0 saam 2021-05-14 14:34:25 -0700 ... 1760223 1 428664 saam 2021-05-14 14:48:27 -0700 Created attachment 428664 patch 1760225 2 428664 ysuzuki 2021-05-14 14:51:21 -0700 Comment on attachment 428664 patch View in context: https://bugs.webkit.org/attachment.cgi?id=428664&action=review r=me too > Source/JavaScriptCore/ChangeLog:23 > + This is a 0.5% Speedometer progression. Can we have some microbenchmarks that ensures this is working? 1760244 3 428670 saam 2021-05-14 15:14:31 -0700 Created attachment 428670 patch for landing 1760576 4 ews-feeder 2021-05-16 00:30:47 -0700 Committed r277565 (237793@main): <https://commits.webkit.org/237793@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 428670. 1760577 5 webkit-bug-importer 2021-05-16 00:31:17 -0700 <rdar://problem/78071191> 428664 2021-05-14 14:48:27 -0700 2021-05-14 15:14:31 -0700 patch b-backup.diff text/plain 2115 saam SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMjc3NTA1KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDI5IEBA CisyMDIxLTA1LTE0ICBTYWFtIEJhcmF0aSAgPHNiYXJhdGlAYXBwbGUuY29tPgorCisgICAgICAg IERGR1ZhcmFyZ3NGb3J3YXJkaW5nUGhhc2Ugc2hvdWxkbid0IGNvbnN1bHQgRmx1c2gKKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIyNTgyNAorCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEluIHRoZSBWYXJhcmdz IEZvcndhcmRpbmcgUGhhc2UsIHdlIHdlcmUgdHJlYXRpbmcgRmx1c2ggYXMgaWYgaXQKKyAgICAg ICAgd2VyZSBhbnkgb3RoZXIgZm9ybSBvZiBub2RlIHRoYXQgaW50ZXJmZXJlcyB3aXRoIGFuIGFy Z3VtZW50CisgICAgICAgIHZpYSBjbG9iYmVyaW5nIGEgc3RhY2sgbG9jYXRpb24uCisgICAgICAg IAorICAgICAgICBUaGlzIGlzbid0IGhvdyBGbHVzaCB3b3JrcyB0aG91Z2guIEl0IGRvZXNuJ3Qg aGF2ZSBleGVjdXRpb24KKyAgICAgICAgc2VtYW50aWNzIGF0IHRoZSBub2RlJ3MgZ3JhcGggbG9j YXRpb24uIEluc3RlYWQsIEZsdXNoIG1lYW5zIHRoYXQKKyAgICAgICAgYW55IHZhcmlhYmxlIGl0 J3MgbGlua2VkIHRvIGluIENQUyBzaG91bGQgYmUgZmx1c2hlZCB0byB0aGUgc3RhY2sKKyAgICAg ICAgYmV0d2VlbiBpdCBhbmQgdGhlIEZsdXNoLgorICAgICAgICAKKyAgICAgICAgVGhlIHNlbWFu dGljcyBvZiBhcmd1bWVudHMgaXMgdGhhdCB0aGV5J3JlIGFscmVhZHkgZmx1c2hlZCB0byB0aGUK KyAgICAgICAgc3RhY2ssIGFuZCB0aGV5J3ZlIGFsd2F5cyBiZWVuLiBTZWVpbmcgYSBGbHVzaCBu b2RlIGRvZXNuJ3QgcHJldmVudAorICAgICAgICBhcmd1bWVudHMgZWxpbWluYXRpb24sIHdlIGFs cmVhZHkga25vdyB0aGUgYXJndW1lbnRzIGFyZSBvbiB0aGUgc3RhY2ssCisgICAgICAgIGFuZCBh bGwgd2UncmUgc2VhcmNoaW5nIGZvciBpcyBpZiB0aGVyZSBpcyBhbiBpbnRlcmZlcmVuY2Ugb3Bl cmF0aW9uCisgICAgICAgIHRoYXQgc2F5cyBpdCdsbCBjbG9iYmVyIHRoYXQgc3RhY2sgc2xvdC4g Rmx1c2ggaXNuJ3QgYW4gaW50ZXJmZXJlbmNlIG9wZXJhdGlvbi4KKyAgICAgICAgCisgICAgICAg IFRoaXMgaXMgYSAwLjUlIFNwZWVkb21ldGVyIHByb2dyZXNzaW9uLgorCisgICAgICAgICogZGZn L0RGR1ZhcmFyZ3NGb3J3YXJkaW5nUGhhc2UuY3BwOgorCiAyMDIxLTA1LTE0ICBNYXJrIExhbSAg PG1hcmsubGFtQGFwcGxlLmNvbT4KIAogICAgICAgICBJbXBsZW1lbnQgQmFzZWxpbmUgSklUIHBy b3BlcnR5IGFjY2VzcyBzbG93IHBhdGhzIHVzaW5nIEpJVCB0aHVua3MuCkluZGV4OiBTb3VyY2Uv SmF2YVNjcmlwdENvcmUvZGZnL0RGR1ZhcmFyZ3NGb3J3YXJkaW5nUGhhc2UuY3BwCj09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHVmFyYXJnc0ZvcndhcmRpbmdQaGFz ZS5jcHAJKHJldmlzaW9uIDI3NzQ0MCkKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZH VmFyYXJnc0ZvcndhcmRpbmdQaGFzZS5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTI4Myw3ICsyODMs NiBAQCBwcml2YXRlOgogICAgICAgICAgICAgICAgIGJyZWFrOwogICAgICAgICAgICAgICAgIAog ICAgICAgICAgICAgY2FzZSBTZXRMb2NhbDoKLSAgICAgICAgICAgIGNhc2UgRmx1c2g6CiAgICAg ICAgICAgICAgICAgaWYgKGFyZ3VtZW50c0ludm9sdmVTdGFja1Nsb3QoY2FuZGlkYXRlLCBub2Rl LT5vcGVyYW5kKCkpKSB7CiAgICAgICAgICAgICAgICAgICAgIGlmICh2ZXJib3NlKQogICAgICAg ICAgICAgICAgICAgICAgICAgZGF0YUxvZygiICAgIEludGVyZmVyZW5jZSBhdCAiLCBub2RlLCAi XG4iKTsK 428670 2021-05-14 15:14:31 -0700 2021-05-16 00:30:48 -0700 patch for landing b-backup.diff text/plain 3466 saam SW5kZXg6IEpTVGVzdHMvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIEpTVGVzdHMvQ2hhbmdlTG9n CShyZXZpc2lvbiAyNzc1MDcpCisrKyBKU1Rlc3RzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpA QCAtMSwzICsxLDEyIEBACisyMDIxLTA1LTE0ICBTYWFtIEJhcmF0aSAgPHNiYXJhdGlAYXBwbGUu Y29tPgorCisgICAgICAgIERGR1ZhcmFyZ3NGb3J3YXJkaW5nUGhhc2Ugc2hvdWxkbid0IGNvbnN1 bHQgRmx1c2gKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTIyNTgyNAorCisgICAgICAgIFJldmlld2VkIGJ5IEZpbGlwIFBpemxvIGFuZCBZdXN1a2UgU3V6 dWtpLgorCisgICAgICAgICogbWljcm9iZW5jaG1hcmtzL3RhaWwtY2FsbC1mb3J3YXJkLWFyZ3Vt ZW50cy1hcmd1bWVudHMtZWxpbWluYXRpb24uanM6IEFkZGVkLgorCiAyMDIxLTA1LTA3ICBSb3Nz IEtpcnNsaW5nICA8cm9zcy5raXJzbGluZ0Bzb255LmNvbT4KIAogICAgICAgICBbSlNDXSBFcnJv ciNjYXVzZSBtdXN0IHJlY29nbml6ZSBleHBsaWNpdCB1bmRlZmluZWQKSW5kZXg6IEpTVGVzdHMv bWljcm9iZW5jaG1hcmtzL3RhaWwtY2FsbC1mb3J3YXJkLWFyZ3VtZW50cy1hcmd1bWVudHMtZWxp bWluYXRpb24uanMKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PQotLS0gSlNUZXN0cy9taWNyb2JlbmNobWFya3MvdGFpbC1j YWxsLWZvcndhcmQtYXJndW1lbnRzLWFyZ3VtZW50cy1lbGltaW5hdGlvbi5qcwkobm9uZXhpc3Rl bnQpCisrKyBKU1Rlc3RzL21pY3JvYmVuY2htYXJrcy90YWlsLWNhbGwtZm9yd2FyZC1hcmd1bWVu dHMtYXJndW1lbnRzLWVsaW1pbmF0aW9uLmpzCSh3b3JraW5nIGNvcHkpCkBAIC0wLDAgKzEsMjAg QEAKKyJ1c2Ugc3RyaWN0IjsKKworZnVuY3Rpb24gYXNzZXJ0KGIpIHsKKyAgICBpZiAoIWIpCisg ICAgICAgIHRocm93IG5ldyBFcnJvcjsKK30KKworZnVuY3Rpb24gYXNzZXJ0V3JhcHBlcihhLCBi LCBjKSB7CisgICAgcmV0dXJuIGFzc2VydC5hcHBseShudWxsLCBhcmd1bWVudHMpOworfQorbm9J bmxpbmUoYXNzZXJ0V3JhcHBlcik7Citub0ZUTChhc3NlcnRXcmFwcGVyKTsKKworbGV0IHN0YXJ0 ID0gRGF0ZS5ub3coKTsKK2ZvciAobGV0IGkgPSAwOyBpIDwgMTAwMDAwMDsgKytpKSB7CisgICAg YXNzZXJ0V3JhcHBlcih0cnVlLCB0cnVlLCB0cnVlKTsKK30KKworaWYgKGZhbHNlKQorICAgIHBy aW50KERhdGUubm93KCkgLSBzdGFydCk7CkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvQ2hh bmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cJKHJl dmlzaW9uIDI3NzUwNSkKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cJKHdvcmtp bmcgY29weSkKQEAgLTEsMyArMSwyOSBAQAorMjAyMS0wNS0xNCAgU2FhbSBCYXJhdGkgIDxzYmFy YXRpQGFwcGxlLmNvbT4KKworICAgICAgICBERkdWYXJhcmdzRm9yd2FyZGluZ1BoYXNlIHNob3Vs ZG4ndCBjb25zdWx0IEZsdXNoCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD0yMjU4MjQKKworICAgICAgICBSZXZpZXdlZCBieSBGaWxpcCBQaXpsbyBhbmQg WXVzdWtlIFN1enVraS4KKworICAgICAgICBJbiB0aGUgVmFyYXJncyBGb3J3YXJkaW5nIFBoYXNl LCB3ZSB3ZXJlIHRyZWF0aW5nIEZsdXNoIGFzIGlmIGl0CisgICAgICAgIHdlcmUgYW55IG90aGVy IGZvcm0gb2Ygbm9kZSB0aGF0IGludGVyZmVyZXMgd2l0aCBhbiBhcmd1bWVudAorICAgICAgICB2 aWEgY2xvYmJlcmluZyBhIHN0YWNrIGxvY2F0aW9uLgorICAgICAgICAKKyAgICAgICAgVGhpcyBp c24ndCBob3cgRmx1c2ggd29ya3MgdGhvdWdoLiBJdCBkb2Vzbid0IGhhdmUgZXhlY3V0aW9uCisg ICAgICAgIHNlbWFudGljcyBhdCB0aGUgbm9kZSdzIGdyYXBoIGxvY2F0aW9uLiBJbnN0ZWFkLCBG bHVzaCBtZWFucyB0aGF0CisgICAgICAgIGFueSB2YXJpYWJsZSBpdCdzIGxpbmtlZCB0byBpbiBD UFMgc2hvdWxkIGJlIGZsdXNoZWQgdG8gdGhlIHN0YWNrCisgICAgICAgIGJldHdlZW4gaXQgYW5k IHRoZSBGbHVzaC4KKyAgICAgICAgCisgICAgICAgIFRoZSBzZW1hbnRpY3Mgb2YgYXJndW1lbnRz IGlzIHRoYXQgdGhleSdyZSBhbHJlYWR5IGZsdXNoZWQgdG8gdGhlCisgICAgICAgIHN0YWNrLCBh bmQgdGhleSd2ZSBhbHdheXMgYmVlbi4gU2VlaW5nIGEgRmx1c2ggbm9kZSBkb2Vzbid0IHByZXZl bnQKKyAgICAgICAgYXJndW1lbnRzIGVsaW1pbmF0aW9uLCB3ZSBhbHJlYWR5IGtub3cgdGhlIGFy Z3VtZW50cyBhcmUgb24gdGhlIHN0YWNrLAorICAgICAgICBhbmQgYWxsIHdlJ3JlIHNlYXJjaGlu ZyBmb3IgaXMgaWYgdGhlcmUgaXMgYW4gaW50ZXJmZXJlbmNlIG9wZXJhdGlvbgorICAgICAgICB0 aGF0IHNheXMgaXQnbGwgY2xvYmJlciB0aGF0IHN0YWNrIHNsb3QuIEZsdXNoIGlzbid0IGFuIGlu dGVyZmVyZW5jZSBvcGVyYXRpb24uCisgICAgICAgIAorICAgICAgICBUaGlzIGlzIGEgMC41JSBT cGVlZG9tZXRlciBwcm9ncmVzc2lvbi4KKworICAgICAgICAqIGRmZy9ERkdWYXJhcmdzRm9yd2Fy ZGluZ1BoYXNlLmNwcDoKKwogMjAyMS0wNS0xNCAgTWFyayBMYW0gIDxtYXJrLmxhbUBhcHBsZS5j b20+CiAKICAgICAgICAgSW1wbGVtZW50IEJhc2VsaW5lIEpJVCBwcm9wZXJ0eSBhY2Nlc3Mgc2xv dyBwYXRocyB1c2luZyBKSVQgdGh1bmtzLgpJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL2Rm Zy9ERkdWYXJhcmdzRm9yd2FyZGluZ1BoYXNlLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2 YVNjcmlwdENvcmUvZGZnL0RGR1ZhcmFyZ3NGb3J3YXJkaW5nUGhhc2UuY3BwCShyZXZpc2lvbiAy Nzc0NDApCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvZGZnL0RGR1ZhcmFyZ3NGb3J3YXJkaW5n UGhhc2UuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0yODMsNyArMjgzLDYgQEAgcHJpdmF0ZToKICAg ICAgICAgICAgICAgICBicmVhazsKICAgICAgICAgICAgICAgICAKICAgICAgICAgICAgIGNhc2Ug U2V0TG9jYWw6Ci0gICAgICAgICAgICBjYXNlIEZsdXNoOgogICAgICAgICAgICAgICAgIGlmIChh cmd1bWVudHNJbnZvbHZlU3RhY2tTbG90KGNhbmRpZGF0ZSwgbm9kZS0+b3BlcmFuZCgpKSkgewog ICAgICAgICAgICAgICAgICAgICBpZiAodmVyYm9zZSkKICAgICAgICAgICAgICAgICAgICAgICAg IGRhdGFMb2coIiAgICBJbnRlcmZlcmVuY2UgYXQgIiwgbm9kZSwgIlxuIik7Cg==