225815 2021-05-14 10:42:16 -0700 Web Inspector: `_WKInspector` leaks `WebInspectorUIProxy` 2021-05-14 16:34:55 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 223899 1 pangle pangle hi inspector-bugzilla-changes thorton webkit-bug-importer oldest_to_newest 1760134 0 pangle 2021-05-14 10:42:16 -0700 <rdar://77178283> 1760138 1 428640 pangle 2021-05-14 10:48:28 -0700 Created attachment 428640 Patch v1.0 1760166 2 428640 hi 2021-05-14 12:17:19 -0700 Comment on attachment 428640 Patch v1.0 View in context: https://bugs.webkit.org/attachment.cgi?id=428640&action=review > Source/WebKit/UIProcess/API/Cocoa/_WKInspector.mm:217 > + _inspector->~WebInspectorUIProxy(); `WebInspectorUIPRoxy` is also held by `WebPageProxy`. Is this safe and/or the right thing to do? I'd suggest talking with some folks familiar with WebKit's API to see if this is the correct approach. 1760177 3 428640 pangle 2021-05-14 13:12:45 -0700 Comment on attachment 428640 Patch v1.0 View in context: https://bugs.webkit.org/attachment.cgi?id=428640&action=review >> Source/WebKit/UIProcess/API/Cocoa/_WKInspector.mm:217 >> + _inspector->~WebInspectorUIProxy(); > > `WebInspectorUIPRoxy` is also held by `WebPageProxy`. Is this safe and/or the right thing to do? I'd suggest talking with some folks familiar with WebKit's API to see if this is the correct approach. This is consistent with other API objects, like is the case in `_WKGeolocationPosition` and `_WKFrameHandle` which have a API::ObjectStorage wrapped object, and explicitly call the destructor during dealloc. Also re: WebPageProxy, I see where WebPageProxy creates a new WebInspectorUIProxy, but I don't see anywhere that specific proxy makes it to _WKInspector? 1760293 4 ews-feeder 2021-05-14 16:34:53 -0700 Committed r277518 (237747@main): <https://commits.webkit.org/237747@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 428640. 428640 2021-05-14 10:48:28 -0700 2021-05-14 16:34:54 -0700 Patch v1.0 bug-225815-20210514104827.patch text/plain 1314 pangle U3VidmVyc2lvbiBSZXZpc2lvbjogMjc3NDQ0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGM4MTBkNTYyZmI5MDk3MDkw NTQxOWFiYTI4MjgxN2NhZTFlYzdmZTYuLjA0YzQzMjU0OWZlNzdjNjgwZjAzMDYwMDY2ZmE5ODU2 YWQwNThjYTUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMjEtMDUtMTQgIFBhdHJpY2sg QW5nbGUgIDxwYW5nbGVAYXBwbGUuY29tPgorCisgICAgICAgIFdlYiBJbnNwZWN0b3I6IGBfV0tJ bnNwZWN0b3JgIGxlYWtzIGBXZWJJbnNwZWN0b3JVSVByb3h5YAorICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjI1ODE1CisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQWRkIGEgbWlzc2luZyBjYWxsIGluIGBfV0tJ bnNwZWN0b3JgJ3MgZGVzdHJ1Y3RvciB0byBkZXN0cnVjdCB0aGUgYFdlYkluc3BlY3RvclVJUHJv eHlgIGluIEFQSSBvYmplY3Qgc3RvcmFnZS4KKworICAgICAgICAqIFVJUHJvY2Vzcy9BUEkvQ29j b2EvX1dLSW5zcGVjdG9yLm1tOgorICAgICAgICAoLVtfV0tJbnNwZWN0b3IgZGVhbGxvY10pOgor CiAyMDIxLTA1LTEzICBTYW0gV2VpbmlnICA8d2VpbmlnQGFwcGxlLmNvbT4KIAogICAgICAgICBD R0Rpc3BsYXlMaXN0IGRlYnVnIGNvbmZpZ3VyYXRpb24gZmFpbHMgdG8gYnVpbGQKZGlmZiAtLWdp dCBhL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0FQSS9Db2NvYS9fV0tJbnNwZWN0b3IubW0gYi9T b3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9BUEkvQ29jb2EvX1dLSW5zcGVjdG9yLm1tCmluZGV4IGEz NTNjZTgxM2JhYzg5YTcwYzcwOTEzYzU2MDc4NDE5MDNiZWFjY2IuLmQ2OTVmMWZmZmMzOGFkMTg5 NTRkZjc1NDcyYWIzZjQ3OWQ2YTY0M2IgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvVUlQcm9j ZXNzL0FQSS9Db2NvYS9fV0tJbnNwZWN0b3IubW0KKysrIGIvU291cmNlL1dlYktpdC9VSVByb2Nl c3MvQVBJL0NvY29hL19XS0luc3BlY3Rvci5tbQpAQCAtMjEzLDYgKzIxMyw4IEBAIHByaXZhdGU6 CiB7CiAgICAgaWYgKFdlYkNvcmVPYmpDU2NoZWR1bGVEZWFsbG9jYXRlT25NYWluUnVuTG9vcChf V0tJbnNwZWN0b3IuY2xhc3MsIHNlbGYpKQogICAgICAgICByZXR1cm47CisgICAgCisgICAgX2lu c3BlY3Rvci0+fldlYkluc3BlY3RvclVJUHJveHkoKTsKIAogICAgIFtzdXBlciBkZWFsbG9jXTsK IH0K