<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>225811</bug_id>
          
          <creation_ts>2021-05-14 10:01:54 -0700</creation_ts>
          <short_desc>Rename FileSystem::getVolumeFreeSpace() to FileSystem::volumeFreeSpace()</short_desc>
          <delta_ts>2021-05-14 16:09:19 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Web Template Framework</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Chris Dumez">cdumez</reporter>
          <assigned_to name="Chris Dumez">cdumez</assigned_to>
          <cc>achristensen</cc>
    
    <cc>benjamin</cc>
    
    <cc>cgarcia</cc>
    
    <cc>cmarcelo</cc>
    
    <cc>darin</cc>
    
    <cc>ews-watchlist</cc>
    
    <cc>ggaren</cc>
    
    <cc>sam</cc>
    
    <cc>webkit-bug-importer</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1760120</commentid>
    <comment_count>0</comment_count>
    <who name="Chris Dumez">cdumez</who>
    <bug_when>2021-05-14 10:01:54 -0700</bug_when>
    <thetext>Rename FileSystem::getVolumeFreeSpace() to FileSystem::volumeFreeSpace() and have it return an Optional&lt;uint64_t&gt; instead of using an out-parameter.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1760121</commentid>
    <comment_count>1</comment_count>
      <attachid>428632</attachid>
    <who name="Chris Dumez">cdumez</who>
    <bug_when>2021-05-14 10:04:43 -0700</bug_when>
    <thetext>Created attachment 428632
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1760127</commentid>
    <comment_count>2</comment_count>
      <attachid>428635</attachid>
    <who name="Chris Dumez">cdumez</who>
    <bug_when>2021-05-14 10:21:08 -0700</bug_when>
    <thetext>Created attachment 428635
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1760278</commentid>
    <comment_count>3</comment_count>
    <who name="EWS">ews-feeder</who>
    <bug_when>2021-05-14 16:08:11 -0700</bug_when>
    <thetext>Committed r277514 (237744@main): &lt;https://commits.webkit.org/237744@main&gt;

All reviewed patches have been landed. Closing bug and clearing flags on attachment 428635.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1760279</commentid>
    <comment_count>4</comment_count>
    <who name="Radar WebKit Bug Importer">webkit-bug-importer</who>
    <bug_when>2021-05-14 16:09:19 -0700</bug_when>
    <thetext>&lt;rdar://problem/78037054&gt;</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>428632</attachid>
            <date>2021-05-14 10:04:43 -0700</date>
            <delta_ts>2021-05-14 10:29:46 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-225811-20210514100442.patch</filename>
            <type>text/plain</type>
            <size>6299</size>
            <attacher name="Chris Dumez">cdumez</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjc3NDkyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n
ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IDk2YjAzYzE0MTA2NTIzNjM5ZjMxMDFh
NTkzNTE3NzU3ZjYzZGY0NmMuLmQ2ZjQ2ODNlMmI1NzlmMGIxMTg1ZTBjNjUyYWE2MDQ5Y2Q5ODk2
NTEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh
bmdlTG9nCkBAIC0xLDMgKzEsMTggQEAKKzIwMjEtMDUtMTQgIENocmlzIER1bWV6ICA8Y2R1bWV6
QGFwcGxlLmNvbT4KKworICAgICAgICBSZW5hbWUgRmlsZVN5c3RlbTo6Z2V0Vm9sdW1lRnJlZVNw
YWNlKCkgdG8gRmlsZVN5c3RlbTo6dm9sdW1lRnJlZVNwYWNlKCkKKyAgICAgICAgaHR0cHM6Ly9i
dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIyNTgxMQorCisgICAgICAgIFJldmlld2Vk
IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFJlbmFtZSBGaWxlU3lzdGVtOjpnZXRWb2x1
bWVGcmVlU3BhY2UoKSB0byBGaWxlU3lzdGVtOjp2b2x1bWVGcmVlU3BhY2UoKSBnaXZlbiB0aGF0
IHdlCisgICAgICAgIGF2b2lkIHRoZSAiZ2V0IiBwcmVmaXggaW4gV2ViS2l0LiBBbHNvIG1vZGVy
bml6ZSB0aGUgZnVuY3Rpb24gYnkgcmV0dXJuaW5nIGFuCisgICAgICAgIE9wdGlvbmFsPHVpbnQ2
NF90PiBpbnN0ZWFkIG9mIHVzaW5nIGFuIG91dC1wYXJhbWV0ZXIuCisKKyAgICAgICAgKiB3dGYv
RmlsZVN5c3RlbS5jcHA6CisgICAgICAgIChXVEY6OkZpbGVTeXN0ZW1JbXBsOjp2b2x1bWVGcmVl
U3BhY2UpOgorICAgICAgICAqIHd0Zi9GaWxlU3lzdGVtLmg6CisKIDIwMjEtMDUtMTQgIENocmlz
IER1bWV6ICA8Y2R1bWV6QGFwcGxlLmNvbT4KIAogICAgICAgICBSZW5hbWUgRmlsZVN5c3RlbTo6
Z2V0RmlsZVNpemUoKSB0byBGaWxlU3lzdGVtOjpmaWxlU2l6ZSgpCmRpZmYgLS1naXQgYS9Tb3Vy
Y2UvV2ViS2l0L0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDZlZGRi
MDM5NGRlOWRjOTc0NzQzYTliOGM2MmNhODQ5MDlkYTkzMGMuLjhlMTRiODg3MWM2MmY1OWRmYThj
Y2IxZGZjMzYyYjhhZTNlZGQ5YjEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9n
CisrKyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMjEtMDUt
MTQgIENocmlzIER1bWV6ICA8Y2R1bWV6QGFwcGxlLmNvbT4KKworICAgICAgICBSZW5hbWUgRmls
ZVN5c3RlbTo6Z2V0Vm9sdW1lRnJlZVNwYWNlKCkgdG8gRmlsZVN5c3RlbTo6dm9sdW1lRnJlZVNw
YWNlKCkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIy
NTgxMQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFVw
ZGF0ZSBjb2RlIGJhc2UgZHVlIHRvIEFQSSBjaGFuZ2UuCisKKyAgICAgICAgKiBOZXR3b3JrUHJv
Y2Vzcy9jYWNoZS9OZXR3b3JrQ2FjaGUuY3BwOgorICAgICAgICAoV2ViS2l0OjpOZXR3b3JrQ2Fj
aGU6OmNvbXB1dGVDYXBhY2l0eSk6CisKIDIwMjEtMDUtMTQgIENocmlzIER1bWV6ICA8Y2R1bWV6
QGFwcGxlLmNvbT4KIAogICAgICAgICBSZW5hbWUgRmlsZVN5c3RlbTo6Z2V0RmlsZVNpemUoKSB0
byBGaWxlU3lzdGVtOjpmaWxlU2l6ZSgpCmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL3d0Zi9GaWxl
U3lzdGVtLmNwcCBiL1NvdXJjZS9XVEYvd3RmL0ZpbGVTeXN0ZW0uY3BwCmluZGV4IDdjYzBjNDFj
YTlkNDBkN2YzZjExM2QyOTA5MzNmNmI4MTUyNTc1YjUuLjQ2Zjk0MjU2NDVhZWJlNjI0YTQxNzRi
Y2Y3NDU0YmI2MzE0OTY1NzQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvd3RmL0ZpbGVTeXN0ZW0u
Y3BwCisrKyBiL1NvdXJjZS9XVEYvd3RmL0ZpbGVTeXN0ZW0uY3BwCkBAIC02MjUsMTQgKzYyNSwx
MyBAQCBib29sIG1ha2VBbGxEaXJlY3Rvcmllcyhjb25zdCBTdHJpbmcmIHBhdGgpCiAgICAgcmV0
dXJuICFlYzsKIH0KIAotYm9vbCBnZXRWb2x1bWVGcmVlU3BhY2UoY29uc3QgU3RyaW5nJiBwYXRo
LCB1aW50NjRfdCYgZnJlZVNwYWNlKQorT3B0aW9uYWw8dWludDY0X3Q+IHZvbHVtZUZyZWVTcGFj
ZShjb25zdCBTdHJpbmcmIHBhdGgpCiB7CiAgICAgc3RkOjplcnJvcl9jb2RlIGVjOwogICAgIGF1
dG8gc3BhY2VJbmZvID0gc3RkOjpmaWxlc3lzdGVtOjpzcGFjZSh0b1N0ZEZpbGVTeXN0ZW1QYXRo
KHBhdGgpLCBlYyk7CiAgICAgaWYgKGVjKQotICAgICAgICByZXR1cm4gZmFsc2U7Ci0gICAgZnJl
ZVNwYWNlID0gc3BhY2VJbmZvLmF2YWlsYWJsZTsKLSAgICByZXR1cm4gdHJ1ZTsKKyAgICAgICAg
cmV0dXJuIFdURjo6bnVsbG9wdDsKKyAgICByZXR1cm4gc3BhY2VJbmZvLmF2YWlsYWJsZTsKIH0K
IAogYm9vbCBjcmVhdGVTeW1ib2xpY0xpbmsoY29uc3QgU3RyaW5nJiB0YXJnZXRQYXRoLCBjb25z
dCBTdHJpbmcmIHN5bWJvbGljTGlua1BhdGgpCmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL3d0Zi9G
aWxlU3lzdGVtLmggYi9Tb3VyY2UvV1RGL3d0Zi9GaWxlU3lzdGVtLmgKaW5kZXggNGY3ZGY0NTdl
M2JkZDNkNGQ3ZmY3YmI5YTM5ODc4YTZlOWJhY2I0OC4uMTYzZGJhOTQxMjc5Yjc0MjQ3MzJmZWJm
YzdlM2Y1M2I1YmEwNDM2MiAxMDA2NDQKLS0tIGEvU291cmNlL1dURi93dGYvRmlsZVN5c3RlbS5o
CisrKyBiL1NvdXJjZS9XVEYvd3RmL0ZpbGVTeXN0ZW0uaApAQCAtMTI2LDcgKzEyNiw3IEBAIFdU
Rl9FWFBPUlRfUFJJVkFURSBib29sIG1ha2VBbGxEaXJlY3Rvcmllcyhjb25zdCBTdHJpbmcmIHBh
dGgpOwogV1RGX0VYUE9SVF9QUklWQVRFIFN0cmluZyBob21lRGlyZWN0b3J5UGF0aCgpOwogV1RG
X0VYUE9SVF9QUklWQVRFIFN0cmluZyBwYXRoRmlsZU5hbWUoY29uc3QgU3RyaW5nJik7CiBXVEZf
RVhQT1JUX1BSSVZBVEUgU3RyaW5nIHBhcmVudFBhdGgoY29uc3QgU3RyaW5nJik7Ci1XVEZfRVhQ
T1JUX1BSSVZBVEUgYm9vbCBnZXRWb2x1bWVGcmVlU3BhY2UoY29uc3QgU3RyaW5nJiwgdWludDY0
X3QmKTsKK1dURl9FWFBPUlRfUFJJVkFURSBPcHRpb25hbDx1aW50NjRfdD4gdm9sdW1lRnJlZVNw
YWNlKGNvbnN0IFN0cmluZyYpOwogV1RGX0VYUE9SVF9QUklWQVRFIE9wdGlvbmFsPGludDMyX3Q+
IGdldEZpbGVEZXZpY2VJZChjb25zdCBDU3RyaW5nJik7CiBXVEZfRVhQT1JUX1BSSVZBVEUgYm9v
bCBjcmVhdGVTeW1ib2xpY0xpbmsoY29uc3QgU3RyaW5nJiB0YXJnZXRQYXRoLCBjb25zdCBTdHJp
bmcmIHN5bWJvbGljTGlua1BhdGgpOwogV1RGX0VYUE9SVF9QUklWQVRFIFN0cmluZyBjcmVhdGVU
ZW1wb3JhcnlaaXBBcmNoaXZlKGNvbnN0IFN0cmluZyYgZGlyZWN0b3J5KTsKZGlmZiAtLWdpdCBh
L1NvdXJjZS9XZWJLaXQvTmV0d29ya1Byb2Nlc3MvY2FjaGUvTmV0d29ya0NhY2hlLmNwcCBiL1Nv
dXJjZS9XZWJLaXQvTmV0d29ya1Byb2Nlc3MvY2FjaGUvTmV0d29ya0NhY2hlLmNwcAppbmRleCA2
NGNkNGJjZDE2MTY3YzZlMmJlODllMmRiYzU5NzIyZWM1YTNmNmNiLi42ZGMzMjhlZjM3N2M0NWNl
MTAyYWZmMTVlODA2MWRhNzdkYjA2OWFmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L05ldHdv
cmtQcm9jZXNzL2NhY2hlL05ldHdvcmtDYWNoZS5jcHAKKysrIGIvU291cmNlL1dlYktpdC9OZXR3
b3JrUHJvY2Vzcy9jYWNoZS9OZXR3b3JrQ2FjaGUuY3BwCkBAIC02NiwxMiArNjYsMTEgQEAgc3Rh
dGljIHNpemVfdCBjb21wdXRlQ2FwYWNpdHkoQ2FjaGVNb2RlbCBjYWNoZU1vZGVsLCBjb25zdCBT
dHJpbmcmIGNhY2hlUGF0aCkKIHsKICAgICB1bnNpZ25lZCB1cmxDYWNoZU1lbW9yeUNhcGFjaXR5
ID0gMDsKICAgICB1aW50NjRfdCB1cmxDYWNoZURpc2tDYXBhY2l0eSA9IDA7Ci0gICAgdWludDY0
X3QgZGlza0ZyZWVTaXplID0gMDsKLSAgICBpZiAoRmlsZVN5c3RlbTo6Z2V0Vm9sdW1lRnJlZVNw
YWNlKGNhY2hlUGF0aCwgZGlza0ZyZWVTaXplKSkgeworICAgIGlmIChhdXRvIGRpc2tGcmVlU2l6
ZSA9IEZpbGVTeXN0ZW06OnZvbHVtZUZyZWVTcGFjZShjYWNoZVBhdGgpKSB7CiAgICAgICAgIC8v
IEFzIGEgZnVkZ2UgZmFjdG9yLCB1c2UgMTAwMCBpbnN0ZWFkIG9mIDEwMjQsIGluIGNhc2UgdGhl
IHJlcG9ydGVkIGJ5dGUKICAgICAgICAgLy8gY291bnQgZG9lc24ndCBhbGlnbiBleGFjdGx5IHRv
IGEgbWVnYWJ5dGUgYm91bmRhcnkuCi0gICAgICAgIGRpc2tGcmVlU2l6ZSAvPSBLQiAqIDEwMDA7
Ci0gICAgICAgIGNhbGN1bGF0ZVVSTENhY2hlU2l6ZXMoY2FjaGVNb2RlbCwgZGlza0ZyZWVTaXpl
LCB1cmxDYWNoZU1lbW9yeUNhcGFjaXR5LCB1cmxDYWNoZURpc2tDYXBhY2l0eSk7CisgICAgICAg
ICpkaXNrRnJlZVNpemUgLz0gS0IgKiAxMDAwOworICAgICAgICBjYWxjdWxhdGVVUkxDYWNoZVNp
emVzKGNhY2hlTW9kZWwsICpkaXNrRnJlZVNpemUsIHVybENhY2hlTWVtb3J5Q2FwYWNpdHksIHVy
bENhY2hlRGlza0NhcGFjaXR5KTsKICAgICB9CiAgICAgcmV0dXJuIHVybENhY2hlRGlza0NhcGFj
aXR5OwogfQpkaWZmIC0tZ2l0IGEvVG9vbHMvQ2hhbmdlTG9nIGIvVG9vbHMvQ2hhbmdlTG9nCmlu
ZGV4IGNhNzc3ZWVkOTY3ZTc2ZWFmYWY3OGQ2NmEzNzk1YWM4ZWE1OTA4M2QuLmE3ZWFlYjEyYmIx
ZjYyYjFjMWEwMjk3MzY0OTIxZDg3MWQyZGVkN2IgMTAwNjQ0Ci0tLSBhL1Rvb2xzL0NoYW5nZUxv
ZworKysgYi9Ub29scy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNSBAQAorMjAyMS0wNS0xNCAgQ2hy
aXMgRHVtZXogIDxjZHVtZXpAYXBwbGUuY29tPgorCisgICAgICAgIFJlbmFtZSBGaWxlU3lzdGVt
OjpnZXRWb2x1bWVGcmVlU3BhY2UoKSB0byBGaWxlU3lzdGVtOjp2b2x1bWVGcmVlU3BhY2UoKQor
ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjI1ODExCisK
KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVXBkYXRlIGNv
ZGUgYmFzZSBkdWUgdG8gQVBJIGNoYW5nZS4KKworICAgICAgICAqIFRlc3RXZWJLaXRBUEkvVGVz
dHMvV1RGL0ZpbGVTeXN0ZW0uY3BwOgorICAgICAgICAoVGVzdFdlYktpdEFQSTo6VEVTVF9GKToK
KwogMjAyMS0wNS0xNCAgQ2hyaXMgRHVtZXogIDxjZHVtZXpAYXBwbGUuY29tPgogCiAgICAgICAg
IFJlbmFtZSBGaWxlU3lzdGVtOjpnZXRGaWxlU2l6ZSgpIHRvIEZpbGVTeXN0ZW06OmZpbGVTaXpl
KCkKZGlmZiAtLWdpdCBhL1Rvb2xzL1Rlc3RXZWJLaXRBUEkvVGVzdHMvV1RGL0ZpbGVTeXN0ZW0u
Y3BwIGIvVG9vbHMvVGVzdFdlYktpdEFQSS9UZXN0cy9XVEYvRmlsZVN5c3RlbS5jcHAKaW5kZXgg
NTU0MjZkOGVhOWJhMDJkODFmYTA0Yjg3YzU4MmFlMjM4MWZhZGU5OS4uYmRhOTcxMzlhNjUwYmI4
Y2M3ODcxNzY1ZjQ3NGYyMWJiNTkxZGMyYSAxMDA2NDQKLS0tIGEvVG9vbHMvVGVzdFdlYktpdEFQ
SS9UZXN0cy9XVEYvRmlsZVN5c3RlbS5jcHAKKysrIGIvVG9vbHMvVGVzdFdlYktpdEFQSS9UZXN0
cy9XVEYvRmlsZVN5c3RlbS5jcHAKQEAgLTU0MywxNCArNTQzLDE0IEBAIFRFU1RfRihGaWxlU3lz
dGVtVGVzdCwgbWFrZUFsbERpcmVjdG9yaWVzKQogICAgIEVYUEVDVF9GQUxTRShGaWxlU3lzdGVt
OjpmaWxlRXhpc3RzKHN1YkZvbGRlclBhdGgpKTsKIH0KIAotVEVTVF9GKEZpbGVTeXN0ZW1UZXN0
LCBnZXRWb2x1bWVGcmVlU3BhY2UpCitURVNUX0YoRmlsZVN5c3RlbVRlc3QsIHZvbHVtZUZyZWVT
cGFjZSkKIHsKLSAgICB1aW50NjRfdCBmcmVlU3BhY2UgPSAwOwotICAgIEVYUEVDVF9UUlVFKEZp
bGVTeXN0ZW06OmdldFZvbHVtZUZyZWVTcGFjZSh0ZW1wRmlsZVBhdGgoKSwgZnJlZVNwYWNlKSk7
Ci0gICAgRVhQRUNUX0dUKGZyZWVTcGFjZSwgMFUpOworICAgIHVpbnQ2NF90IGZyZWVTcGFjZSA9
IEZpbGVTeXN0ZW06OnZvbHVtZUZyZWVTcGFjZSh0ZW1wRmlsZVBhdGgoKSk7CisgICAgQVNTRVJU
X1RSVUUoZnJlZVNwYWNlKTsKKyAgICBFWFBFQ1RfR1QoKmZyZWVTcGFjZSwgMFUpOwogCiAgICAg
U3RyaW5nIGZpbGVUaGF0RG9lc05vdEV4aXN0ID0gRmlsZVN5c3RlbTo6cGF0aEJ5QXBwZW5kaW5n
Q29tcG9uZW50KHRlbXBFbXB0eUZvbGRlclBhdGgoKSwgImRvZXMtbm90LWV4aXN0Il9zKTsKLSAg
ICBFWFBFQ1RfRkFMU0UoRmlsZVN5c3RlbTo6Z2V0Vm9sdW1lRnJlZVNwYWNlKGZpbGVUaGF0RG9l
c05vdEV4aXN0LCBmcmVlU3BhY2UpKTsKKyAgICBFWFBFQ1RfRkFMU0UoRmlsZVN5c3RlbTo6dm9s
dW1lRnJlZVNwYWNlKGZpbGVUaGF0RG9lc05vdEV4aXN0KSk7CiB9CiAKIFRFU1RfRihGaWxlU3lz
dGVtVGVzdCwgY3JlYXRlU3ltYm9saWNMaW5rKQo=
</data>
<flag name="commit-queue"
          id="449604"
          type_id="3"
          status="-"
          setter="ews-feeder"
    />
          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>428635</attachid>
            <date>2021-05-14 10:21:08 -0700</date>
            <delta_ts>2021-05-14 16:08:12 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-225811-20210514102107.patch</filename>
            <type>text/plain</type>
            <size>6295</size>
            <attacher name="Chris Dumez">cdumez</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjc3NDkyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n
ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IDk2YjAzYzE0MTA2NTIzNjM5ZjMxMDFh
NTkzNTE3NzU3ZjYzZGY0NmMuLmQ2ZjQ2ODNlMmI1NzlmMGIxMTg1ZTBjNjUyYWE2MDQ5Y2Q5ODk2
NTEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh
bmdlTG9nCkBAIC0xLDMgKzEsMTggQEAKKzIwMjEtMDUtMTQgIENocmlzIER1bWV6ICA8Y2R1bWV6
QGFwcGxlLmNvbT4KKworICAgICAgICBSZW5hbWUgRmlsZVN5c3RlbTo6Z2V0Vm9sdW1lRnJlZVNw
YWNlKCkgdG8gRmlsZVN5c3RlbTo6dm9sdW1lRnJlZVNwYWNlKCkKKyAgICAgICAgaHR0cHM6Ly9i
dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIyNTgxMQorCisgICAgICAgIFJldmlld2Vk
IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFJlbmFtZSBGaWxlU3lzdGVtOjpnZXRWb2x1
bWVGcmVlU3BhY2UoKSB0byBGaWxlU3lzdGVtOjp2b2x1bWVGcmVlU3BhY2UoKSBnaXZlbiB0aGF0
IHdlCisgICAgICAgIGF2b2lkIHRoZSAiZ2V0IiBwcmVmaXggaW4gV2ViS2l0LiBBbHNvIG1vZGVy
bml6ZSB0aGUgZnVuY3Rpb24gYnkgcmV0dXJuaW5nIGFuCisgICAgICAgIE9wdGlvbmFsPHVpbnQ2
NF90PiBpbnN0ZWFkIG9mIHVzaW5nIGFuIG91dC1wYXJhbWV0ZXIuCisKKyAgICAgICAgKiB3dGYv
RmlsZVN5c3RlbS5jcHA6CisgICAgICAgIChXVEY6OkZpbGVTeXN0ZW1JbXBsOjp2b2x1bWVGcmVl
U3BhY2UpOgorICAgICAgICAqIHd0Zi9GaWxlU3lzdGVtLmg6CisKIDIwMjEtMDUtMTQgIENocmlz
IER1bWV6ICA8Y2R1bWV6QGFwcGxlLmNvbT4KIAogICAgICAgICBSZW5hbWUgRmlsZVN5c3RlbTo6
Z2V0RmlsZVNpemUoKSB0byBGaWxlU3lzdGVtOjpmaWxlU2l6ZSgpCmRpZmYgLS1naXQgYS9Tb3Vy
Y2UvV2ViS2l0L0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDZlZGRi
MDM5NGRlOWRjOTc0NzQzYTliOGM2MmNhODQ5MDlkYTkzMGMuLjhlMTRiODg3MWM2MmY1OWRmYThj
Y2IxZGZjMzYyYjhhZTNlZGQ5YjEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9n
CisrKyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMjEtMDUt
MTQgIENocmlzIER1bWV6ICA8Y2R1bWV6QGFwcGxlLmNvbT4KKworICAgICAgICBSZW5hbWUgRmls
ZVN5c3RlbTo6Z2V0Vm9sdW1lRnJlZVNwYWNlKCkgdG8gRmlsZVN5c3RlbTo6dm9sdW1lRnJlZVNw
YWNlKCkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIy
NTgxMQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFVw
ZGF0ZSBjb2RlIGJhc2UgZHVlIHRvIEFQSSBjaGFuZ2UuCisKKyAgICAgICAgKiBOZXR3b3JrUHJv
Y2Vzcy9jYWNoZS9OZXR3b3JrQ2FjaGUuY3BwOgorICAgICAgICAoV2ViS2l0OjpOZXR3b3JrQ2Fj
aGU6OmNvbXB1dGVDYXBhY2l0eSk6CisKIDIwMjEtMDUtMTQgIENocmlzIER1bWV6ICA8Y2R1bWV6
QGFwcGxlLmNvbT4KIAogICAgICAgICBSZW5hbWUgRmlsZVN5c3RlbTo6Z2V0RmlsZVNpemUoKSB0
byBGaWxlU3lzdGVtOjpmaWxlU2l6ZSgpCmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL3d0Zi9GaWxl
U3lzdGVtLmNwcCBiL1NvdXJjZS9XVEYvd3RmL0ZpbGVTeXN0ZW0uY3BwCmluZGV4IDdjYzBjNDFj
YTlkNDBkN2YzZjExM2QyOTA5MzNmNmI4MTUyNTc1YjUuLjQ2Zjk0MjU2NDVhZWJlNjI0YTQxNzRi
Y2Y3NDU0YmI2MzE0OTY1NzQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvd3RmL0ZpbGVTeXN0ZW0u
Y3BwCisrKyBiL1NvdXJjZS9XVEYvd3RmL0ZpbGVTeXN0ZW0uY3BwCkBAIC02MjUsMTQgKzYyNSwx
MyBAQCBib29sIG1ha2VBbGxEaXJlY3Rvcmllcyhjb25zdCBTdHJpbmcmIHBhdGgpCiAgICAgcmV0
dXJuICFlYzsKIH0KIAotYm9vbCBnZXRWb2x1bWVGcmVlU3BhY2UoY29uc3QgU3RyaW5nJiBwYXRo
LCB1aW50NjRfdCYgZnJlZVNwYWNlKQorT3B0aW9uYWw8dWludDY0X3Q+IHZvbHVtZUZyZWVTcGFj
ZShjb25zdCBTdHJpbmcmIHBhdGgpCiB7CiAgICAgc3RkOjplcnJvcl9jb2RlIGVjOwogICAgIGF1
dG8gc3BhY2VJbmZvID0gc3RkOjpmaWxlc3lzdGVtOjpzcGFjZSh0b1N0ZEZpbGVTeXN0ZW1QYXRo
KHBhdGgpLCBlYyk7CiAgICAgaWYgKGVjKQotICAgICAgICByZXR1cm4gZmFsc2U7Ci0gICAgZnJl
ZVNwYWNlID0gc3BhY2VJbmZvLmF2YWlsYWJsZTsKLSAgICByZXR1cm4gdHJ1ZTsKKyAgICAgICAg
cmV0dXJuIFdURjo6bnVsbG9wdDsKKyAgICByZXR1cm4gc3BhY2VJbmZvLmF2YWlsYWJsZTsKIH0K
IAogYm9vbCBjcmVhdGVTeW1ib2xpY0xpbmsoY29uc3QgU3RyaW5nJiB0YXJnZXRQYXRoLCBjb25z
dCBTdHJpbmcmIHN5bWJvbGljTGlua1BhdGgpCmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL3d0Zi9G
aWxlU3lzdGVtLmggYi9Tb3VyY2UvV1RGL3d0Zi9GaWxlU3lzdGVtLmgKaW5kZXggNGY3ZGY0NTdl
M2JkZDNkNGQ3ZmY3YmI5YTM5ODc4YTZlOWJhY2I0OC4uMTYzZGJhOTQxMjc5Yjc0MjQ3MzJmZWJm
YzdlM2Y1M2I1YmEwNDM2MiAxMDA2NDQKLS0tIGEvU291cmNlL1dURi93dGYvRmlsZVN5c3RlbS5o
CisrKyBiL1NvdXJjZS9XVEYvd3RmL0ZpbGVTeXN0ZW0uaApAQCAtMTI2LDcgKzEyNiw3IEBAIFdU
Rl9FWFBPUlRfUFJJVkFURSBib29sIG1ha2VBbGxEaXJlY3Rvcmllcyhjb25zdCBTdHJpbmcmIHBh
dGgpOwogV1RGX0VYUE9SVF9QUklWQVRFIFN0cmluZyBob21lRGlyZWN0b3J5UGF0aCgpOwogV1RG
X0VYUE9SVF9QUklWQVRFIFN0cmluZyBwYXRoRmlsZU5hbWUoY29uc3QgU3RyaW5nJik7CiBXVEZf
RVhQT1JUX1BSSVZBVEUgU3RyaW5nIHBhcmVudFBhdGgoY29uc3QgU3RyaW5nJik7Ci1XVEZfRVhQ
T1JUX1BSSVZBVEUgYm9vbCBnZXRWb2x1bWVGcmVlU3BhY2UoY29uc3QgU3RyaW5nJiwgdWludDY0
X3QmKTsKK1dURl9FWFBPUlRfUFJJVkFURSBPcHRpb25hbDx1aW50NjRfdD4gdm9sdW1lRnJlZVNw
YWNlKGNvbnN0IFN0cmluZyYpOwogV1RGX0VYUE9SVF9QUklWQVRFIE9wdGlvbmFsPGludDMyX3Q+
IGdldEZpbGVEZXZpY2VJZChjb25zdCBDU3RyaW5nJik7CiBXVEZfRVhQT1JUX1BSSVZBVEUgYm9v
bCBjcmVhdGVTeW1ib2xpY0xpbmsoY29uc3QgU3RyaW5nJiB0YXJnZXRQYXRoLCBjb25zdCBTdHJp
bmcmIHN5bWJvbGljTGlua1BhdGgpOwogV1RGX0VYUE9SVF9QUklWQVRFIFN0cmluZyBjcmVhdGVU
ZW1wb3JhcnlaaXBBcmNoaXZlKGNvbnN0IFN0cmluZyYgZGlyZWN0b3J5KTsKZGlmZiAtLWdpdCBh
L1NvdXJjZS9XZWJLaXQvTmV0d29ya1Byb2Nlc3MvY2FjaGUvTmV0d29ya0NhY2hlLmNwcCBiL1Nv
dXJjZS9XZWJLaXQvTmV0d29ya1Byb2Nlc3MvY2FjaGUvTmV0d29ya0NhY2hlLmNwcAppbmRleCA2
NGNkNGJjZDE2MTY3YzZlMmJlODllMmRiYzU5NzIyZWM1YTNmNmNiLi42ZGMzMjhlZjM3N2M0NWNl
MTAyYWZmMTVlODA2MWRhNzdkYjA2OWFmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L05ldHdv
cmtQcm9jZXNzL2NhY2hlL05ldHdvcmtDYWNoZS5jcHAKKysrIGIvU291cmNlL1dlYktpdC9OZXR3
b3JrUHJvY2Vzcy9jYWNoZS9OZXR3b3JrQ2FjaGUuY3BwCkBAIC02NiwxMiArNjYsMTEgQEAgc3Rh
dGljIHNpemVfdCBjb21wdXRlQ2FwYWNpdHkoQ2FjaGVNb2RlbCBjYWNoZU1vZGVsLCBjb25zdCBT
dHJpbmcmIGNhY2hlUGF0aCkKIHsKICAgICB1bnNpZ25lZCB1cmxDYWNoZU1lbW9yeUNhcGFjaXR5
ID0gMDsKICAgICB1aW50NjRfdCB1cmxDYWNoZURpc2tDYXBhY2l0eSA9IDA7Ci0gICAgdWludDY0
X3QgZGlza0ZyZWVTaXplID0gMDsKLSAgICBpZiAoRmlsZVN5c3RlbTo6Z2V0Vm9sdW1lRnJlZVNw
YWNlKGNhY2hlUGF0aCwgZGlza0ZyZWVTaXplKSkgeworICAgIGlmIChhdXRvIGRpc2tGcmVlU2l6
ZSA9IEZpbGVTeXN0ZW06OnZvbHVtZUZyZWVTcGFjZShjYWNoZVBhdGgpKSB7CiAgICAgICAgIC8v
IEFzIGEgZnVkZ2UgZmFjdG9yLCB1c2UgMTAwMCBpbnN0ZWFkIG9mIDEwMjQsIGluIGNhc2UgdGhl
IHJlcG9ydGVkIGJ5dGUKICAgICAgICAgLy8gY291bnQgZG9lc24ndCBhbGlnbiBleGFjdGx5IHRv
IGEgbWVnYWJ5dGUgYm91bmRhcnkuCi0gICAgICAgIGRpc2tGcmVlU2l6ZSAvPSBLQiAqIDEwMDA7
Ci0gICAgICAgIGNhbGN1bGF0ZVVSTENhY2hlU2l6ZXMoY2FjaGVNb2RlbCwgZGlza0ZyZWVTaXpl
LCB1cmxDYWNoZU1lbW9yeUNhcGFjaXR5LCB1cmxDYWNoZURpc2tDYXBhY2l0eSk7CisgICAgICAg
ICpkaXNrRnJlZVNpemUgLz0gS0IgKiAxMDAwOworICAgICAgICBjYWxjdWxhdGVVUkxDYWNoZVNp
emVzKGNhY2hlTW9kZWwsICpkaXNrRnJlZVNpemUsIHVybENhY2hlTWVtb3J5Q2FwYWNpdHksIHVy
bENhY2hlRGlza0NhcGFjaXR5KTsKICAgICB9CiAgICAgcmV0dXJuIHVybENhY2hlRGlza0NhcGFj
aXR5OwogfQpkaWZmIC0tZ2l0IGEvVG9vbHMvQ2hhbmdlTG9nIGIvVG9vbHMvQ2hhbmdlTG9nCmlu
ZGV4IGNhNzc3ZWVkOTY3ZTc2ZWFmYWY3OGQ2NmEzNzk1YWM4ZWE1OTA4M2QuLmE3ZWFlYjEyYmIx
ZjYyYjFjMWEwMjk3MzY0OTIxZDg3MWQyZGVkN2IgMTAwNjQ0Ci0tLSBhL1Rvb2xzL0NoYW5nZUxv
ZworKysgYi9Ub29scy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNSBAQAorMjAyMS0wNS0xNCAgQ2hy
aXMgRHVtZXogIDxjZHVtZXpAYXBwbGUuY29tPgorCisgICAgICAgIFJlbmFtZSBGaWxlU3lzdGVt
OjpnZXRWb2x1bWVGcmVlU3BhY2UoKSB0byBGaWxlU3lzdGVtOjp2b2x1bWVGcmVlU3BhY2UoKQor
ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjI1ODExCisK
KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVXBkYXRlIGNv
ZGUgYmFzZSBkdWUgdG8gQVBJIGNoYW5nZS4KKworICAgICAgICAqIFRlc3RXZWJLaXRBUEkvVGVz
dHMvV1RGL0ZpbGVTeXN0ZW0uY3BwOgorICAgICAgICAoVGVzdFdlYktpdEFQSTo6VEVTVF9GKToK
KwogMjAyMS0wNS0xNCAgQ2hyaXMgRHVtZXogIDxjZHVtZXpAYXBwbGUuY29tPgogCiAgICAgICAg
IFJlbmFtZSBGaWxlU3lzdGVtOjpnZXRGaWxlU2l6ZSgpIHRvIEZpbGVTeXN0ZW06OmZpbGVTaXpl
KCkKZGlmZiAtLWdpdCBhL1Rvb2xzL1Rlc3RXZWJLaXRBUEkvVGVzdHMvV1RGL0ZpbGVTeXN0ZW0u
Y3BwIGIvVG9vbHMvVGVzdFdlYktpdEFQSS9UZXN0cy9XVEYvRmlsZVN5c3RlbS5jcHAKaW5kZXgg
NTU0MjZkOGVhOWJhMDJkODFmYTA0Yjg3YzU4MmFlMjM4MWZhZGU5OS4uNjY5Zjc2OTliNTIyZDUw
MjViNjhmMmUxN2Y0YzI0ZmRjYjJhZTI5ZCAxMDA2NDQKLS0tIGEvVG9vbHMvVGVzdFdlYktpdEFQ
SS9UZXN0cy9XVEYvRmlsZVN5c3RlbS5jcHAKKysrIGIvVG9vbHMvVGVzdFdlYktpdEFQSS9UZXN0
cy9XVEYvRmlsZVN5c3RlbS5jcHAKQEAgLTU0MywxNCArNTQzLDE0IEBAIFRFU1RfRihGaWxlU3lz
dGVtVGVzdCwgbWFrZUFsbERpcmVjdG9yaWVzKQogICAgIEVYUEVDVF9GQUxTRShGaWxlU3lzdGVt
OjpmaWxlRXhpc3RzKHN1YkZvbGRlclBhdGgpKTsKIH0KIAotVEVTVF9GKEZpbGVTeXN0ZW1UZXN0
LCBnZXRWb2x1bWVGcmVlU3BhY2UpCitURVNUX0YoRmlsZVN5c3RlbVRlc3QsIHZvbHVtZUZyZWVT
cGFjZSkKIHsKLSAgICB1aW50NjRfdCBmcmVlU3BhY2UgPSAwOwotICAgIEVYUEVDVF9UUlVFKEZp
bGVTeXN0ZW06OmdldFZvbHVtZUZyZWVTcGFjZSh0ZW1wRmlsZVBhdGgoKSwgZnJlZVNwYWNlKSk7
Ci0gICAgRVhQRUNUX0dUKGZyZWVTcGFjZSwgMFUpOworICAgIGF1dG8gZnJlZVNwYWNlID0gRmls
ZVN5c3RlbTo6dm9sdW1lRnJlZVNwYWNlKHRlbXBGaWxlUGF0aCgpKTsKKyAgICBBU1NFUlRfVFJV
RShmcmVlU3BhY2UpOworICAgIEVYUEVDVF9HVCgqZnJlZVNwYWNlLCAwVSk7CiAKICAgICBTdHJp
bmcgZmlsZVRoYXREb2VzTm90RXhpc3QgPSBGaWxlU3lzdGVtOjpwYXRoQnlBcHBlbmRpbmdDb21w
b25lbnQodGVtcEVtcHR5Rm9sZGVyUGF0aCgpLCAiZG9lcy1ub3QtZXhpc3QiX3MpOwotICAgIEVY
UEVDVF9GQUxTRShGaWxlU3lzdGVtOjpnZXRWb2x1bWVGcmVlU3BhY2UoZmlsZVRoYXREb2VzTm90
RXhpc3QsIGZyZWVTcGFjZSkpOworICAgIEVYUEVDVF9GQUxTRShGaWxlU3lzdGVtOjp2b2x1bWVG
cmVlU3BhY2UoZmlsZVRoYXREb2VzTm90RXhpc3QpKTsKIH0KIAogVEVTVF9GKEZpbGVTeXN0ZW1U
ZXN0LCBjcmVhdGVTeW1ib2xpY0xpbmspCg==
</data>

          </attachment>
      

    </bug>

</bugzilla>