225789 2021-05-13 16:48:15 -0700 report-non-inclusive-language should skip symlinks 2021-05-17 10:01:35 -0700 1 1 1 Unclassified WebKit Tools / Tests Other Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 213092 1 aakash_jain aakash_jain aakash_jain ap bdakin darin ryanhaddad webkit-bug-importer oldest_to_newest 1759900 0 aakash_jain 2021-05-13 16:48:15 -0700 report-non-inclusive-language should skip symlinks. Currently the script fails with an error if there is a symlink pointing to a non-existing file. Traceback (most recent call last): File "OpenSource/Tools/Scripts/report-non-inclusive-language", line 70, in <module> handle = open(os.path.join(subroot, file), "r") IOError: [Errno 2] No such file or directory: 'testdir/symlink-pointing-to-non-existing-file' 1759908 1 aakash_jain 2021-05-13 16:56:23 -0700 Also most likely the linked file would be checked directly by the script while iterating the directory structure and would result in it being counted twice. 1759909 2 428578 aakash_jain 2021-05-13 16:57:56 -0700 Created attachment 428578 Patch 1759953 3 428578 darin 2021-05-13 18:27:07 -0700 Comment on attachment 428578 Patch How did you discover the need for this? Who’s using this on directories with symlinks in them? 1759956 4 aakash_jain 2021-05-13 18:31:33 -0700 > How did you discover the need for this? I discovered this while running this script on an "Internal" repository. 1759959 5 webkit-bug-importer 2021-05-13 18:34:54 -0700 <rdar://problem/77998004> 1759969 6 ews-feeder 2021-05-13 19:06:14 -0700 Committed r277476 (237711@main): <https://commits.webkit.org/237711@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 428578. 428578 2021-05-13 16:57:56 -0700 2021-05-14 04:08:29 -0700 Patch bug-225789-20210513195755.patch text/plain 1426 aakash_jain SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDI3NzQ2NykKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE0IEBACisyMDIxLTA1LTEzICBBYWthc2ggSmFpbiAgPGFha2FzaF9qYWluQGFwcGxlLmNv bT4KKworICAgICAgICByZXBvcnQtbm9uLWluY2x1c2l2ZS1sYW5ndWFnZSBzaG91bGQgc2tpcCBz eW1saW5rcworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MjI1Nzg5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg KiBTY3JpcHRzL3JlcG9ydC1ub24taW5jbHVzaXZlLWxhbmd1YWdlOiBTa2lwIHN5bWxpbmtzIHNp bmNlIG1vc3QgbGlrZWx5IHRoZSBsaW5rZWQgZmlsZSB3b3VsZCBiZSBjaGVja2VkIAorICAgICAg ICBkaXJlY3RseSBieSB0aGUgc2NyaXB0IHdoaWxlIGl0ZXJhdGluZyB0aGUgZGlyZWN0b3J5IHN0 cnVjdHVyZSBhbmQgd291bGQgcmVzdWx0IGluIGl0IGJlaW5nIGNvdW50ZWQgdHdpY2UuCisgICAg ICAgIEFsc28gdGhlIHNjcmlwdCBmYWlscyB3aXRoIGFuIGVycm9yIGlmIHRoZXJlIGlzIGEgc3lt bGluayBwb2ludGluZyB0byBhIG5vbi1leGlzdGluZyBmaWxlLgorCiAyMDIxLTA1LTEzICBBYWth c2ggSmFpbiAgPGFha2FzaF9qYWluQGFwcGxlLmNvbT4KIAogICAgICAgICBbZXdzXSBTdHlsZSBm aXhlcyBpbiBzdGVwcy5weQpJbmRleDogVG9vbHMvU2NyaXB0cy9yZXBvcnQtbm9uLWluY2x1c2l2 ZS1sYW5ndWFnZQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9TY3JpcHRzL3JlcG9ydC1ub24taW5jbHVz aXZlLWxhbmd1YWdlCShyZXZpc2lvbiAyNzc0NjcpCisrKyBUb29scy9TY3JpcHRzL3JlcG9ydC1u b24taW5jbHVzaXZlLWxhbmd1YWdlCSh3b3JraW5nIGNvcHkpCkBAIC02Nyw2ICs2Nyw4IEBAIGZv ciBzdWJyb290LCBkaXJlY3RvcmllcywgZmlsZXMgaW4gb3Mud2EKICAgICAgICAgICAgIGNvbnRp bnVlCiAgICAgICAgIGlmIGZpbGUgaW4gSUdOT1JFX0ZJTEVfTkFNRVM6CiAgICAgICAgICAgICBj b250aW51ZQorICAgICAgICBpZiBvcy5wYXRoLmlzbGluayhvcy5wYXRoLmpvaW4oc3Vicm9vdCwg ZmlsZSkpOgorICAgICAgICAgICAgY29udGludWUKICAgICAgICAgaGFuZGxlID0gb3Blbihvcy5w YXRoLmpvaW4oc3Vicm9vdCwgZmlsZSksICJyIikKICAgICAgICAgZm9yIGxpbmUgaW4gaGFuZGxl LnJlYWRsaW5lcygpOgogICAgICAgICAgICAgZm9yIHRlcm0gaW4gbm9uSW5jbHVzaXZlVGVybXM6 Cg==