225787 2021-05-13 16:23:53 -0700 m_calleeSaveRegisters should not be a pointer to a pointer 2021-05-13 19:04:15 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 ggaren ggaren ews-watchlist keith_miller mark.lam msaboff nham saam tzagallo webkit-bug-importer ysuzuki oldest_to_newest 1759883 0 ggaren 2021-05-13 16:23:53 -0700 m_calleeSaveRegisters should not be a pointer to a pointer 1759888 1 428573 ggaren 2021-05-13 16:27:35 -0700 Created attachment 428573 Patch 1759890 2 428573 keith_miller 2021-05-13 16:31:00 -0700 Comment on attachment 428573 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=428573&action=review r=me with nits. > Source/JavaScriptCore/bytecode/CodeBlock.h:287 > + bool m_hasCalleeSaveRegisters { false }; Can't we just add an operator bool to RegisterAtOffsetList which is true when the FixedVector has a pointer? 1759895 3 ggaren 2021-05-13 16:41:43 -0700 > > Source/JavaScriptCore/bytecode/CodeBlock.h:287 > > + bool m_hasCalleeSaveRegisters { false }; > > Can't we just add an operator bool to RegisterAtOffsetList which is true > when the FixedVector has a pointer? If we did that, we wouldn't be able to distinguish "not initialized" from "initialized with 0 size". I'm not sure if that matters or not. 1759896 4 ggaren 2021-05-13 16:42:10 -0700 ....so I took the conservative approach and maintained support for "initialized with 0 size". 1759954 5 428573 ggaren 2021-05-13 18:27:31 -0700 Comment on attachment 428573 Patch CQ+ 1759964 6 keith_miller 2021-05-13 18:55:21 -0700 (In reply to Geoffrey Garen from comment #4) > ....so I took the conservative approach and maintained support for > "initialized with 0 size". Ah yes, all those platforms with 0 calleeSavedRegisters we support 🙃 1759967 7 ews-feeder 2021-05-13 19:03:51 -0700 Committed r277475 (237710@main): <https://commits.webkit.org/237710@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 428573. 1759968 8 webkit-bug-importer 2021-05-13 19:04:15 -0700 <rdar://problem/77998921> 428573 2021-05-13 16:27:35 -0700 2021-05-13 19:03:52 -0700 Patch bug-225787-20210513162734.patch text/plain 5720 ggaren SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMjc3NDYzKQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDMxIEBA CisyMDIxLTA1LTEzICBHZW9mZnJleSBHYXJlbiAgPGdnYXJlbkBhcHBsZS5jb20+CisKKyAgICAg ICAgbV9jYWxsZWVTYXZlUmVnaXN0ZXJzIHNob3VsZCBub3QgYmUgYSBwb2ludGVyIHRvIGEgcG9p bnRlcgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjI1 Nzg3CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQmVu IGZvdW5kIHRoaXMgdGhyb3VnaCBtZW1vcnkgc3RyZXNzIHRlc3RpbmcuCisKKyAgICAgICAgUmVn aXN0ZXJBdE9mZnNldExpc3QgaXMgZWZmZWN0aXZlbHkganVzdCBhIHBvaW50ZXIuIHVuaXF1ZV9w dHI8UmVnaXN0ZXJBdE9mZnNldExpc3Q+CisgICAgICAgIGlzIGEgcG9pbnRlciB0byBhIHBvaW50 ZXIuIFJlZ2lzdGVyQXRPZmZzZXRMaXN0IGlzIGxvbmctbGl2ZWQsIHNvIGl0CisgICAgICAgIGNy ZWF0ZXMgaGVhcCBwYWdlIGZyYWdtZW50YXRpb24uCisKKyAgICAgICAgV29ydGggM01CIG9uIEJl bidzIHRlc3QuCisKKyAgICAgICAgKiBieXRlY29kZS9Db2RlQmxvY2suY3BwOgorICAgICAgICAo SlNDOjpDb2RlQmxvY2s6OnNldENhbGxlZVNhdmVSZWdpc3RlcnMpOgorICAgICAgICAoSlNDOjpD b2RlQmxvY2s6OmNhbGxlZVNhdmVSZWdpc3RlcnMgY29uc3QpOiBVc2UgYSBmZW5jZSBiZWZvcmUg c2V0dGluZworICAgICAgICBtX2hhc0NhbGxlZVNhdmVSZWdpc3RlcnMgdG8gZW5zdXJlIHRoYXQg YWxsIHdyaXRlcyBoYXZlIGNvbXBsZXRlZCBiZWZvcmUKKyAgICAgICAgdGhlIHN0cnVjdCBiZWNv bWVzIHZpc2libGUuCisKKyAgICAgICAgKiBieXRlY29kZS9Db2RlQmxvY2suaDogVXNlIFJlZ2lz dGVyQXRPZmZzZXRMaXN0IGRpcmVjdGx5IGluc3RlYWQgb2YgCisgICAgICAgIHVuaXF1ZV9wdHI8 UmVnaXN0ZXJBdE9mZnNldExpc3Q+IHRvIGF2b2lkIGEgbG9uZy1saXZlZCBsb25lbHkgOCBieXRl CisgICAgICAgIGFsbG9jYXRpb24uCisKKyAgICAgICAgKiBmdGwvRlRMQ29tcGlsZS5jcHA6Cisg ICAgICAgIChKU0M6OkZUTDo6Y29tcGlsZSk6IFVwZGF0ZWQgZm9yIHR5cGUgY2hhbmdlLgorCiAy MDIxLTA1LTEzICBDaHJpcyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CiAKICAgICAgICAgUmVu YW1lIEZpbGVTeXN0ZW06OmRpcmVjdG9yeU5hbWUoKSB0byBGaWxlU3lzdGVtOjpwYXJlbnRQYXRo KCkKSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9ieXRlY29kZS9Db2RlQmxvY2suY3BwCj09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9ieXRlY29kZS9Db2RlQmxvY2suY3Bw CShyZXZpc2lvbiAyNzczODMpCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvYnl0ZWNvZGUvQ29k ZUJsb2NrLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMTc5MCwxNiArMTc5MCwyNCBAQCB1bnNpZ25l ZCBDb2RlQmxvY2s6OnJhcmVDYXNlUHJvZmlsZUNvdW50CiAgICAgcmV0dXJuIDA7CiB9CiAKLXZv aWQgQ29kZUJsb2NrOjpzZXRDYWxsZWVTYXZlUmVnaXN0ZXJzKFJlZ2lzdGVyU2V0IGNhbGxlZVNh dmVSZWdpc3RlcnMpCit2b2lkIENvZGVCbG9jazo6c2V0Q2FsbGVlU2F2ZVJlZ2lzdGVycyhSZWdp c3RlclNldCByZWdpc3RlclNldCkKIHsKKyAgICBhdXRvIGNhbGxlZVNhdmVSZWdpc3RlcnMgPSBS ZWdpc3RlckF0T2Zmc2V0TGlzdChyZWdpc3RlclNldCk7CisKICAgICBDb25jdXJyZW50SlNMb2Nr ZXIgbG9ja2VyKG1fbG9jayk7Ci0gICAgZW5zdXJlSklURGF0YShsb2NrZXIpLm1fY2FsbGVlU2F2 ZVJlZ2lzdGVycyA9IG1ha2VVbmlxdWU8UmVnaXN0ZXJBdE9mZnNldExpc3Q+KGNhbGxlZVNhdmVS ZWdpc3RlcnMpOworICAgIGF1dG8mIGppdERhdGEgPSBlbnN1cmVKSVREYXRhKGxvY2tlcik7Cisg ICAgaml0RGF0YS5tX2NhbGxlZVNhdmVSZWdpc3RlcnMgPSBXVEZNb3ZlKGNhbGxlZVNhdmVSZWdp c3RlcnMpOworICAgIFdURjo6c3RvcmVTdG9yZUZlbmNlKCk7CisgICAgaml0RGF0YS5tX2hhc0Nh bGxlZVNhdmVSZWdpc3RlcnMgPSB0cnVlOwogfQogCi12b2lkIENvZGVCbG9jazo6c2V0Q2FsbGVl U2F2ZVJlZ2lzdGVycyhzdGQ6OnVuaXF1ZV9wdHI8UmVnaXN0ZXJBdE9mZnNldExpc3Q+IHJlZ2lz dGVyQXRPZmZzZXRMaXN0KQordm9pZCBDb2RlQmxvY2s6OnNldENhbGxlZVNhdmVSZWdpc3RlcnMo UmVnaXN0ZXJBdE9mZnNldExpc3QmJiByZWdpc3RlckF0T2Zmc2V0TGlzdCkKIHsKICAgICBDb25j dXJyZW50SlNMb2NrZXIgbG9ja2VyKG1fbG9jayk7Ci0gICAgZW5zdXJlSklURGF0YShsb2NrZXIp Lm1fY2FsbGVlU2F2ZVJlZ2lzdGVycyA9IFdURk1vdmUocmVnaXN0ZXJBdE9mZnNldExpc3QpOwor ICAgIGF1dG8mIGppdERhdGEgPSBlbnN1cmVKSVREYXRhKGxvY2tlcik7CisgICAgaml0RGF0YS5t X2NhbGxlZVNhdmVSZWdpc3RlcnMgPSBXVEZNb3ZlKHJlZ2lzdGVyQXRPZmZzZXRMaXN0KTsKKyAg ICBXVEY6OnN0b3JlU3RvcmVGZW5jZSgpOworICAgIGppdERhdGEubV9oYXNDYWxsZWVTYXZlUmVn aXN0ZXJzID0gdHJ1ZTsKIH0KIAogdm9pZCBDb2RlQmxvY2s6OnJlc2V0SklURGF0YSgpCkBAIC0y NDkyLDggKzI1MDAsOCBAQCBjb25zdCBSZWdpc3RlckF0T2Zmc2V0TGlzdCogQ29kZUJsb2NrOjpj CiB7CiAjaWYgRU5BQkxFKEpJVCkKICAgICBpZiAoYXV0byogaml0RGF0YSA9IG1faml0RGF0YS5n ZXQoKSkgewotICAgICAgICBpZiAoY29uc3QgUmVnaXN0ZXJBdE9mZnNldExpc3QqIHJlZ2lzdGVy cyA9IGppdERhdGEtPm1fY2FsbGVlU2F2ZVJlZ2lzdGVycy5nZXQoKSkKLSAgICAgICAgICAgIHJl dHVybiByZWdpc3RlcnM7CisgICAgICAgIGlmIChqaXREYXRhLT5tX2hhc0NhbGxlZVNhdmVSZWdp c3RlcnMpCisgICAgICAgICAgICByZXR1cm4gJmppdERhdGEtPm1fY2FsbGVlU2F2ZVJlZ2lzdGVy czsKICAgICB9CiAjZW5kaWYKICAgICByZXR1cm4gJlJlZ2lzdGVyQXRPZmZzZXRMaXN0OjpsbGlu dEJhc2VsaW5lQ2FsbGVlU2F2ZVJlZ2lzdGVycygpOwpJbmRleDogU291cmNlL0phdmFTY3JpcHRD b3JlL2J5dGVjb2RlL0NvZGVCbG9jay5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0 Q29yZS9ieXRlY29kZS9Db2RlQmxvY2suaAkocmV2aXNpb24gMjc3MzgzKQorKysgU291cmNlL0ph dmFTY3JpcHRDb3JlL2J5dGVjb2RlL0NvZGVCbG9jay5oCSh3b3JraW5nIGNvcHkpCkBAIC02NCw2 ICs2NCw3IEBACiAjaW5jbHVkZSAiUHJvZmlsZXJKZXR0aXNvblJlYXNvbi5oIgogI2luY2x1ZGUg IlByb2dyYW1FeGVjdXRhYmxlLmgiCiAjaW5jbHVkZSAiUHV0UHJvcGVydHlTbG90LmgiCisjaW5j bHVkZSAiUmVnaXN0ZXJBdE9mZnNldExpc3QuaCIKICNpbmNsdWRlICJWYWx1ZVByb2ZpbGUuaCIK ICNpbmNsdWRlICJWaXJ0dWFsUmVnaXN0ZXIuaCIKICNpbmNsdWRlICJXYXRjaHBvaW50LmgiCkBA IC0yODMsNyArMjg0LDggQEAgcHVibGljOgogICAgICAgICBGaXhlZFZlY3RvcjxTaW1wbGVKdW1w VGFibGU+IG1fc3dpdGNoSnVtcFRhYmxlczsKICAgICAgICAgRml4ZWRWZWN0b3I8U3RyaW5nSnVt cFRhYmxlPiBtX3N0cmluZ1N3aXRjaEp1bXBUYWJsZXM7CiAgICAgICAgIHN0ZDo6dW5pcXVlX3B0 cjxQQ1RvQ29kZU9yaWdpbk1hcD4gbV9wY1RvQ29kZU9yaWdpbk1hcDsKLSAgICAgICAgc3RkOjp1 bmlxdWVfcHRyPFJlZ2lzdGVyQXRPZmZzZXRMaXN0PiBtX2NhbGxlZVNhdmVSZWdpc3RlcnM7Cisg ICAgICAgIGJvb2wgbV9oYXNDYWxsZWVTYXZlUmVnaXN0ZXJzIHsgZmFsc2UgfTsKKyAgICAgICAg UmVnaXN0ZXJBdE9mZnNldExpc3QgbV9jYWxsZWVTYXZlUmVnaXN0ZXJzOwogICAgICAgICBKSVRD b2RlTWFwIG1faml0Q29kZU1hcDsKICAgICB9OwogCkBAIC0zNDMsNyArMzQ1LDcgQEAgcHVibGlj OgogICAgIE9wdGlvbmFsPENvZGVPcmlnaW4+IGZpbmRQQyh2b2lkKiBwYyk7CiAKICAgICB2b2lk IHNldENhbGxlZVNhdmVSZWdpc3RlcnMoUmVnaXN0ZXJTZXQpOwotICAgIHZvaWQgc2V0Q2FsbGVl U2F2ZVJlZ2lzdGVycyhzdGQ6OnVuaXF1ZV9wdHI8UmVnaXN0ZXJBdE9mZnNldExpc3Q+KTsKKyAg ICB2b2lkIHNldENhbGxlZVNhdmVSZWdpc3RlcnMoUmVnaXN0ZXJBdE9mZnNldExpc3QmJik7CiAK ICAgICB2b2lkIHNldFJhcmVDYXNlUHJvZmlsZXMoRml4ZWRWZWN0b3I8UmFyZUNhc2VQcm9maWxl PiYmKTsKICAgICBSYXJlQ2FzZVByb2ZpbGUqIHJhcmVDYXNlUHJvZmlsZUZvckJ5dGVjb2RlSW5k ZXgoY29uc3QgQ29uY3VycmVudEpTTG9ja2VyJiwgQnl0ZWNvZGVJbmRleCk7CkluZGV4OiBTb3Vy Y2UvSmF2YVNjcmlwdENvcmUvZnRsL0ZUTENvbXBpbGUuY3BwCj09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJj ZS9KYXZhU2NyaXB0Q29yZS9mdGwvRlRMQ29tcGlsZS5jcHAJKHJldmlzaW9uIDI3NzM4MykKKysr IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9mdGwvRlRMQ29tcGlsZS5jcHAJKHdvcmtpbmcgY29weSkK QEAgLTcxLDEwICs3MSw5IEBAIHZvaWQgY29tcGlsZShTdGF0ZSYgc3RhdGUsIFNhZmVwb2ludDo6 UmUKICAgICBpZiAoc3RhdGUuYWxsb2NhdGlvbkZhaWxlZCkKICAgICAgICAgcmV0dXJuOwogICAg IAotICAgIHN0ZDo6dW5pcXVlX3B0cjxSZWdpc3RlckF0T2Zmc2V0TGlzdD4gcmVnaXN0ZXJPZmZz ZXRzID0KLSAgICAgICAgbWFrZVVuaXF1ZTxSZWdpc3RlckF0T2Zmc2V0TGlzdD4oc3RhdGUucHJv Yy0+Y2FsbGVlU2F2ZVJlZ2lzdGVyQXRPZmZzZXRMaXN0KCkpOworICAgIFJlZ2lzdGVyQXRPZmZz ZXRMaXN0IHJlZ2lzdGVyT2Zmc2V0cyA9IHN0YXRlLnByb2MtPmNhbGxlZVNhdmVSZWdpc3RlckF0 T2Zmc2V0TGlzdCgpOwogICAgIGlmIChzaG91bGREdW1wRGlzYXNzZW1ibHkoKSkKLSAgICAgICAg ZGF0YUxvZyh0aWVyTmFtZSwgIlVud2luZCBpbmZvIGZvciAiLCBDb2RlQmxvY2tXaXRoSklUVHlw ZShjb2RlQmxvY2ssIEpJVFR5cGU6OkZUTEpJVCksICI6ICIsICpyZWdpc3Rlck9mZnNldHMsICJc biIpOworICAgICAgICBkYXRhTG9nKHRpZXJOYW1lLCAiVW53aW5kIGluZm8gZm9yICIsIENvZGVC bG9ja1dpdGhKSVRUeXBlKGNvZGVCbG9jaywgSklUVHlwZTo6RlRMSklUKSwgIjogIiwgcmVnaXN0 ZXJPZmZzZXRzLCAiXG4iKTsKICAgICBjb2RlQmxvY2stPnNldENhbGxlZVNhdmVSZWdpc3RlcnMo V1RGTW92ZShyZWdpc3Rlck9mZnNldHMpKTsKICAgICBBU1NFUlQoIShzdGF0ZS5wcm9jLT5mcmFt ZVNpemUoKSAlIHNpemVvZihFbmNvZGVkSlNWYWx1ZSkpKTsKICAgICBzdGF0ZS5qaXRDb2RlLT5j b21tb24uZnJhbWVSZWdpc3RlckNvdW50ID0gc3RhdGUucHJvYy0+ZnJhbWVTaXplKCkgLyBzaXpl b2YoRW5jb2RlZEpTVmFsdWUpOwo=