225782 2021-05-13 14:14:08 -0700 Work around WebCore failing to build due to NDEBUG getting undefined in release 2021-06-06 23:45:25 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 226709 1 thorton thorton ap commit-queue simon.fraser webkit-bug-importer oldest_to_newest 1759832 0 thorton 2021-05-13 14:14:08 -0700 Work around WebCore failing to build due to NDEBUG getting undefined in release 1759833 1 428560 thorton 2021-05-13 14:14:37 -0700 Created attachment 428560 Patch 1759834 2 thorton 2021-05-13 14:14:39 -0700 <rdar://problem/77982432> 1759835 3 428560 ap 2021-05-13 14:16:44 -0700 Comment on attachment 428560 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=428560&action=review > Source/WebCore/PAL/pal/spi/cg/CoreGraphicsSPI.h:52 > +#if defined(WK_NDEBUG) && !defined(NDEBUG) I'd undef WK_NDEBUG here, as leaking debug related defines from headers just doesn't feel good right now. 1759836 4 thorton 2021-05-13 14:27:35 -0700 Fair point :) 1759855 5 428568 thorton 2021-05-13 15:18:58 -0700 Created attachment 428568 Patch 1759887 6 ews-feeder 2021-05-13 16:27:28 -0700 Committed r277464 (237707@main): <https://commits.webkit.org/237707@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 428568. 1767316 7 commit-queue 2021-06-06 23:30:06 -0700 Re-opened since this is blocked by bug 226709 428560 2021-05-13 14:14:37 -0700 2021-05-13 15:18:56 -0700 Patch bug-225782-20210513141436.patch text/plain 1689 thorton U3VidmVyc2lvbiBSZXZpc2lvbjogMjc3MzQ0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9Q QUwvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkNvcmUvUEFML0NoYW5nZUxvZwppbmRleCBjZDIyYWVm ODQwYzc0ZjZhMjJiZjBmNTM5ODIzMzIxM2NiNDFhYzJmLi4yMTI1Yjg3OGY5YjVjYzNjM2E4ZWUx NTc2OTY5NjgxNjMyZmM1YzkyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9QQUwvQ2hhbmdl TG9nCisrKyBiL1NvdXJjZS9XZWJDb3JlL1BBTC9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNCBAQAor MjAyMS0wNS0xMyAgVGltIEhvcnRvbiAgPHRpbW90aHlfaG9ydG9uQGFwcGxlLmNvbT4KKworICAg ICAgICBXb3JrIGFyb3VuZCBXZWJDb3JlIGZhaWxpbmcgdG8gYnVpbGQgZHVlIHRvIE5ERUJVRyBn ZXR0aW5nIHVuZGVmaW5lZCBpbiByZWxlYXNlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD0yMjU3ODIKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzc3OTgy NDMyPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICog cGFsL3NwaS9jZy9Db3JlR3JhcGhpY3NTUEkuaDoKKyAgICAgICAgQXBwbHkgYSB0ZW1wb3Jhcnkg d29ya2Fyb3VuZCB0byBwcmVzZXJ2ZSBOREVCVUcgdGhyb3VnaCB0aGVzZSBpbmNsdWRlcy4KKwog MjAyMS0wNS0xMSAgQ29tbWl0IFF1ZXVlICA8Y29tbWl0LXF1ZXVlQHdlYmtpdC5vcmc+CiAKICAg ICAgICAgVW5yZXZpZXdlZCwgcmV2ZXJ0aW5nIHIyNzczMjIuCmRpZmYgLS1naXQgYS9Tb3VyY2Uv V2ViQ29yZS9QQUwvcGFsL3NwaS9jZy9Db3JlR3JhcGhpY3NTUEkuaCBiL1NvdXJjZS9XZWJDb3Jl L1BBTC9wYWwvc3BpL2NnL0NvcmVHcmFwaGljc1NQSS5oCmluZGV4IDA2ZDNjZWMwZGQ0YjI0NDMx M2I5MWIxNjg2MmVhZGZiZDVkOTQxOWMuLjdlNzgxYTE4NGQxMWFhYjAyYTI4NGE2OGEyYmE5NGRl ZjUxNmIwNDIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL1BBTC9wYWwvc3BpL2NnL0NvcmVH cmFwaGljc1NQSS5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL1BBTC9wYWwvc3BpL2NnL0NvcmVHcmFw aGljc1NQSS5oCkBAIC0zOCwxMiArMzgsMjEgQEAKIAogI2lmIFVTRShBUFBMRV9JTlRFUk5BTF9T REspCiAKKy8vIEZJWE1FICg3Nzk4MzM2MSk6IFJlbW92ZSB0aGlzIHdvcmthcm91bmQgd2hlbiA8 cmRhcjovL3Byb2JsZW0vNzc5NzcyMTY+IGlzIGZpeGVkLgorI2lmIGRlZmluZWQoTkRFQlVHKSAm JiBOREVCVUcKKyNkZWZpbmUgV0tfTkRFQlVHIDEKKyNlbmRpZgorCiAjaW5jbHVkZSA8Q29yZUdy YXBoaWNzL0NHQ29udGV4dERlbGVnYXRlUHJpdmF0ZS5oPgogI2luY2x1ZGUgPENvcmVHcmFwaGlj cy9DR0ZvbnRDYWNoZS5oPgogI2luY2x1ZGUgPENvcmVHcmFwaGljcy9DR1BhdGhQcml2YXRlLmg+ CiAjaW5jbHVkZSA8Q29yZUdyYXBoaWNzL0NvcmVHcmFwaGljc1ByaXZhdGUuaD4KICNpbmNsdWRl IDxDb3JlR3JhcGhpY3MvQ0dTdHlsZVByaXZhdGUuaD4KIAorI2lmIGRlZmluZWQoV0tfTkRFQlVH KSAmJiAhZGVmaW5lZChOREVCVUcpCisjZGVmaW5lIE5ERUJVRyAxCisjZW5kaWYKKwogI2lmIFBM QVRGT1JNKE1BQykKICNpbmNsdWRlIDxDb2xvclN5bmMvQ29sb3JTeW5jUHJpdi5oPgogI2luY2x1 ZGUgPENvcmVHcmFwaGljcy9DR0FjY2Vzc2liaWxpdHkuaD4K 428568 2021-05-13 15:18:58 -0700 2021-05-13 22:19:45 -0700 Patch bug-225782-20210513151857.patch text/plain 4194 thorton U3VidmVyc2lvbiBSZXZpc2lvbjogMjc3MzQ0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9Q QUwvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkNvcmUvUEFML0NoYW5nZUxvZwppbmRleCBjZDIyYWVm ODQwYzc0ZjZhMjJiZjBmNTM5ODIzMzIxM2NiNDFhYzJmLi42MjFiZGRiZDRlNGZkNTRjZGVjZjlk NmYyODA0NGFmYTRlYjg5NzM1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9QQUwvQ2hhbmdl TG9nCisrKyBiL1NvdXJjZS9XZWJDb3JlL1BBTC9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNiBAQAor MjAyMS0wNS0xMyAgVGltIEhvcnRvbiAgPHRpbW90aHlfaG9ydG9uQGFwcGxlLmNvbT4KKworICAg ICAgICBXb3JrIGFyb3VuZCBXZWJDb3JlIGZhaWxpbmcgdG8gYnVpbGQgZHVlIHRvIE5ERUJVRyBn ZXR0aW5nIHVuZGVmaW5lZCBpbiByZWxlYXNlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD0yMjU3ODIKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzc3OTgy NDMyPgorCisgICAgICAgIFJldmlld2VkIGJ5IFNpbW9uIEZyYXNlci4KKworICAgICAgICAqIHBh bC9zcGkvY2cvQ29yZUdyYXBoaWNzU1BJLmg6CisgICAgICAgICogcGFsL3NwaS9pb3MvR3JhcGhp Y3NTZXJ2aWNlc1NQSS5oOgorICAgICAgICBBcHBseSBhIHRlbXBvcmFyeSB3b3JrYXJvdW5kIHRv IHByZXNlcnZlIE5ERUJVRyB0aHJvdWdoIHRoZXNlIGluY2x1ZGVzLgorICAgICAgICBUaGVyZSBh cmUgYSBmZXcgd2F5cyB0byBnZXQgdG8gQ29yZUdyYXBoaWNzUHJpdmF0ZS5oLCBzbyB3ZSBmaXgg YWxsIG9mIHRoZW0uCisKIDIwMjEtMDUtMTEgIENvbW1pdCBRdWV1ZSAgPGNvbW1pdC1xdWV1ZUB3 ZWJraXQub3JnPgogCiAgICAgICAgIFVucmV2aWV3ZWQsIHJldmVydGluZyByMjc3MzIyLgpkaWZm IC0tZ2l0IGEvU291cmNlL1dlYktpdC9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0L0NoYW5nZUxv ZwppbmRleCAxNGNlYzdlZWVlOTVkM2FkMDM3ZTgxZDNjZTdkNzk0NDhkNTUxN2Y5Li43MTlhMzcz OWI5NTU2NDAwOTM2ZjU0ZmMyMDkzMDMyZjM3MmI4Nzc1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2Vi S2l0L0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViS2l0L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1 IEBACisyMDIxLTA1LTEzICBUaW0gSG9ydG9uICA8dGltb3RoeV9ob3J0b25AYXBwbGUuY29tPgor CisgICAgICAgIFdvcmsgYXJvdW5kIFdlYkNvcmUgZmFpbGluZyB0byBidWlsZCBkdWUgdG8gTkRF QlVHIGdldHRpbmcgdW5kZWZpbmVkIGluIHJlbGVhc2UKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIyNTc4MgorICAgICAgICA8cmRhcjovL3Byb2JsZW0v Nzc5ODI0MzI+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgU2ltb24gRnJhc2VyLgorCisgICAgICAg ICogUGxhdGZvcm0vc3BpL2lvcy9VSUtpdFNQSS5oOgorICAgICAgICBBcHBseSBhIHRlbXBvcmFy eSB3b3JrYXJvdW5kIHRvIHByZXNlcnZlIE5ERUJVRyB0aHJvdWdoIHRoZXNlIGluY2x1ZGVzLgor ICAgICAgICBUaGVyZSBhcmUgYSBmZXcgd2F5cyB0byBnZXQgdG8gQ29yZUdyYXBoaWNzUHJpdmF0 ZS5oLCBzbyB3ZSBmaXggYWxsIG9mIHRoZW0uCisKIDIwMjEtMDUtMTEgIEFsZXggQ2hyaXN0ZW5z ZW4gIDxhY2hyaXN0ZW5zZW5Ad2Via2l0Lm9yZz4KIAogICAgICAgICBSZW1vdmUgeHBjX2Nvbm5l Y3Rpb25fa2lsbApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvUEFML3BhbC9zcGkvY2cvQ29y ZUdyYXBoaWNzU1BJLmggYi9Tb3VyY2UvV2ViQ29yZS9QQUwvcGFsL3NwaS9jZy9Db3JlR3JhcGhp Y3NTUEkuaAppbmRleCAwNmQzY2VjMGRkNGIyNDQzMTNiOTFiMTY4NjJlYWRmYmQ1ZDk0MTljLi4x ZWZiODE5YWRhMDM0NTg0MTk1ZjM0Y2I1YTY3NDQ1MTEzN2JlOThmIDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViQ29yZS9QQUwvcGFsL3NwaS9jZy9Db3JlR3JhcGhpY3NTUEkuaAorKysgYi9Tb3VyY2Uv V2ViQ29yZS9QQUwvcGFsL3NwaS9jZy9Db3JlR3JhcGhpY3NTUEkuaApAQCAtMzgsMTIgKzM4LDIy IEBACiAKICNpZiBVU0UoQVBQTEVfSU5URVJOQUxfU0RLKQogCisvLyBGSVhNRSAoNzc5ODMzNjEp OiBSZW1vdmUgdGhpcyB3b3JrYXJvdW5kIHdoZW4gPHJkYXI6Ly9wcm9ibGVtLzc3OTc3MjE2PiBp cyBmaXhlZC4KKyNpZiBkZWZpbmVkKE5ERUJVRykgJiYgTkRFQlVHCisjZGVmaW5lIFdLX05ERUJV RyAxCisjZW5kaWYKKwogI2luY2x1ZGUgPENvcmVHcmFwaGljcy9DR0NvbnRleHREZWxlZ2F0ZVBy aXZhdGUuaD4KICNpbmNsdWRlIDxDb3JlR3JhcGhpY3MvQ0dGb250Q2FjaGUuaD4KICNpbmNsdWRl IDxDb3JlR3JhcGhpY3MvQ0dQYXRoUHJpdmF0ZS5oPgogI2luY2x1ZGUgPENvcmVHcmFwaGljcy9D b3JlR3JhcGhpY3NQcml2YXRlLmg+CiAjaW5jbHVkZSA8Q29yZUdyYXBoaWNzL0NHU3R5bGVQcml2 YXRlLmg+CiAKKyNpZiBkZWZpbmVkKFdLX05ERUJVRykgJiYgIWRlZmluZWQoTkRFQlVHKQorI2Rl ZmluZSBOREVCVUcgMQorI3VuZGVmIFdLX05ERUJVRworI2VuZGlmCisKICNpZiBQTEFURk9STShN QUMpCiAjaW5jbHVkZSA8Q29sb3JTeW5jL0NvbG9yU3luY1ByaXYuaD4KICNpbmNsdWRlIDxDb3Jl R3JhcGhpY3MvQ0dBY2Nlc3NpYmlsaXR5Lmg+CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9Q QUwvcGFsL3NwaS9pb3MvR3JhcGhpY3NTZXJ2aWNlc1NQSS5oIGIvU291cmNlL1dlYkNvcmUvUEFM L3BhbC9zcGkvaW9zL0dyYXBoaWNzU2VydmljZXNTUEkuaAppbmRleCBlODk5ZTIxZjRjYTcyMDNi OGRmMGYwYTkyOWFiMzY2NTJkYmU1OTA5Li40ZTAwMTQxMzc1ODk1ZDI2NmE0OGNlMzgzNzU1MWM3 OGQ2YjhmNzliIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9QQUwvcGFsL3NwaS9pb3MvR3Jh cGhpY3NTZXJ2aWNlc1NQSS5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL1BBTC9wYWwvc3BpL2lvcy9H cmFwaGljc1NlcnZpY2VzU1BJLmgKQEAgLTMxLDggKzMxLDE4IEBACiAKICNpZiBVU0UoQVBQTEVf SU5URVJOQUxfU0RLKQogCisvLyBGSVhNRSAoNzc5ODMzNjEpOiBSZW1vdmUgdGhpcyB3b3JrYXJv dW5kIHdoZW4gPHJkYXI6Ly9wcm9ibGVtLzc3OTc3MjE2PiBpcyBmaXhlZC4KKyNpZiBkZWZpbmVk KE5ERUJVRykgJiYgTkRFQlVHCisjZGVmaW5lIFdLX05ERUJVRyAxCisjZW5kaWYKKwogI2ltcG9y dCA8R3JhcGhpY3NTZXJ2aWNlcy9HcmFwaGljc1NlcnZpY2VzLmg+CiAKKyNpZiBkZWZpbmVkKFdL X05ERUJVRykgJiYgIWRlZmluZWQoTkRFQlVHKQorI2RlZmluZSBOREVCVUcgMQorI3VuZGVmIFdL X05ERUJVRworI2VuZGlmCisKICNlbmRpZgogCiBXVEZfRVhURVJOX0NfQkVHSU4KZGlmZiAtLWdp dCBhL1NvdXJjZS9XZWJLaXQvUGxhdGZvcm0vc3BpL2lvcy9VSUtpdFNQSS5oIGIvU291cmNlL1dl YktpdC9QbGF0Zm9ybS9zcGkvaW9zL1VJS2l0U1BJLmgKaW5kZXggMWYyNGU1NjEzOGQxYmM4MzFi MTMzYWJhMDNkZjAyNzYxNjUzMDA1Yi4uMWZiMmU5ZDU4ZTIwNjEzZGU3YWIxOTljYTI0MzI5YTkz YjA2ZDg3NyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9QbGF0Zm9ybS9zcGkvaW9zL1VJS2l0 U1BJLmgKKysrIGIvU291cmNlL1dlYktpdC9QbGF0Zm9ybS9zcGkvaW9zL1VJS2l0U1BJLmgKQEAg LTI3LDYgKzI3LDExIEBACiAKICNpZiBVU0UoQVBQTEVfSU5URVJOQUxfU0RLKQogCisvLyBGSVhN RSAoNzc5ODMzNjEpOiBSZW1vdmUgdGhpcyB3b3JrYXJvdW5kIHdoZW4gPHJkYXI6Ly9wcm9ibGVt Lzc3OTc3MjE2PiBpcyBmaXhlZC4KKyNpZiBkZWZpbmVkKE5ERUJVRykgJiYgTkRFQlVHCisjZGVm aW5lIFdLX05ERUJVRyAxCisjZW5kaWYKKwogI2ltcG9ydCA8VUlLaXQvTlNUZXh0QWx0ZXJuYXRp dmVzLmg+CiAjaW1wb3J0IDxVSUtpdC9VSUFsZXJ0Q29udHJvbGxlcl9Qcml2YXRlLmg+CiAjaW1w b3J0IDxVSUtpdC9VSUFwcGxpY2F0aW9uX1ByaXZhdGUuaD4KQEAgLTEzNSw2ICsxNDAsMTEgQEAK ICNpbXBvcnQgPFVJS2l0L1VJUG9pbnRlclN0eWxlX1ByaXZhdGUuaD4KICNlbmRpZgogCisjaWYg ZGVmaW5lZChXS19OREVCVUcpICYmICFkZWZpbmVkKE5ERUJVRykKKyNkZWZpbmUgTkRFQlVHIDEK KyN1bmRlZiBXS19OREVCVUcKKyNlbmRpZgorCiAjZWxzZSAvLyBVU0UoQVBQTEVfSU5URVJOQUxf U0RLKQogCiAjaWYgRU5BQkxFKERSQUdfU1VQUE9SVCkK