225777 2021-05-13 13:19:15 -0700 Misc GCC warning cleanup 2021-05-20 12:46:41 -0700 1 1 1 Unclassified WebKit WebCore Misc. WebKit Nightly Build PC Linux RESOLVED FIXED InRadar P2 Normal --- 1 mcatanzaro mcatanzaro bugs-noreply cgarcia dino eric.carlson estea ews-watchlist fmalita glenn gyuyoung.kim jer.noble mcatanzaro pdr philipj sabouhallawa schenney sergio webkit-bug-importer oldest_to_newest 1759807 0 mcatanzaro 2021-05-13 13:19:15 -0700 Regular boring compiler warning cleanup: [909/5319] Building CXX object Source/WebDriver/CMakeFiles/WebDriver.dir/glib/WebDriverServiceGLib.cpp.o ../../Source/WebDriver/glib/WebDriverServiceGLib.cpp: In function ‘bool WebDriver::parseVersion(const WTF::String&, uint64_t&, uint64_t&, uint64_t&)’: ../../Source/WebDriver/glib/WebDriverServiceGLib.cpp:38:10: warning: unused variable ‘ok’ [-Wunused-variable] 38 | bool ok; | ^~ Can be removed. [2471/5319] Building CXX object Source/WebCore/CMakeFiles...vedSources/unified-sources/UnifiedSource-68aea4ac-2.cpp.o In file included from WebCore/DerivedSources/unified-sources/UnifiedSource-68aea4ac-2.cpp:7: ../../Source/WebCore/bindings/js/JSAudioNodeCustom.cpp: In function ‘JSC::JSValue WebCore::toJSNewlyCreated(JSC::JSGlobalObject*, WebCore::JSDOMGlobalObject*, WTF::Ref<WebCore::AudioNode>&&)’: ../../Source/WebCore/bindings/js/JSAudioNodeCustom.cpp:134:1: warning: control reaches end of non-void function [-Wreturn-type] 134 | } | ^ Trivial, just needs RELEASE_ASSERT_NOT_REACHED(). [2791/5319] Building CXX object Source/WebCore/CMakeFiles...edSources/unified-sources/UnifiedSource-8feba646-15.cpp.o In file included from WebCore/DerivedSources/unified-sources/UnifiedSource-8feba646-15.cpp:5: ../../Source/WebCore/svg/SVGToOTFFontConversion.cpp: In constructor ‘WebCore::SVGToOTFFontConverter::SVGToOTFFontConverter(const WebCore::SVGFontElement&)’: ../../Source/WebCore/svg/SVGToOTFFontConversion.cpp:1454:99: warning: comparison is always true due to limited range of data type [-Wtype-limits] 1454 | if (auto value = parseIntegerAllowingTrailingJunk<uint16_t>(segment); value && *value >= 0 && *value < 1000) { | ~~~~~~~^~~~ This last warning comes from r277245 which changed an int to unsigned int. I squinted at it for a bit and think that looks probably fine. 1759808 1 428555 mcatanzaro 2021-05-13 13:21:37 -0700 Created attachment 428555 Patch 1760010 2 ews-feeder 2021-05-13 22:53:19 -0700 Committed r277483 (237718@main): <https://commits.webkit.org/237718@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 428555. 1760011 3 webkit-bug-importer 2021-05-13 22:54:15 -0700 <rdar://problem/78004670> 1762098 4 pnormand 2021-05-20 12:46:41 -0700 *** Bug 225694 has been marked as a duplicate of this bug. *** 428555 2021-05-13 13:21:37 -0700 2021-05-13 22:53:21 -0700 Patch bug-225777-20210513152136.patch text/plain 3605 mcatanzaro U3VidmVyc2lvbiBSZXZpc2lvbjogMjc3NDQ3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNjQ2ZDdkNjU3ZjlhMTZl M2JkYTllMGJlNDA0NTRiN2RiMTgxODQ3MS4uM2YzM2E1ODlkNzI3MWVlZmM5ZmEyOGI5ZGEwZjM0 ZjE3NDcxNTM3MCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDIxLTA1LTEzICBNaWNo YWVsIENhdGFuemFybyAgPG1jYXRhbnphcm9AZ25vbWUub3JnPgorCisgICAgICAgIE1pc2MgR0ND IHdhcm5pbmcgY2xlYW51cAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9MjI1Nzc3CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgKiBiaW5kaW5ncy9qcy9KU0F1ZGlvTm9kZUN1c3RvbS5jcHA6CisgICAgICAgIChX ZWJDb3JlOjp0b0pTTmV3bHlDcmVhdGVkKTogQWRkIG1pc3NpbmcgUkVMRUFTRV9BU1NFUlRfTk9U X1JFQUNIRUQoKS4KKyAgICAgICAgKiBzdmcvU1ZHVG9PVEZGb250Q29udmVyc2lvbi5jcHA6Cisg ICAgICAgIChXZWJDb3JlOjpTVkdUb09URkZvbnRDb252ZXJ0ZXI6OlNWR1RvT1RGRm9udENvbnZl cnRlcik6IFJlbW92ZSByZWR1bmRhbnQgY29uZGl0aW9uLgorCiAyMDIxLTA1LTEzICBKZXIgTm9i bGUgIDxqZXIubm9ibGVAYXBwbGUuY29tPgogCiAgICAgICAgIFsgbWFjT1MgV2syIF0gbWVkaWEv bWVkaWEtZnJhZ21lbnRzL1RDMDA1MS5odG1sIGlzIGZsYWtleSBjcmFzaGluZwpkaWZmIC0tZ2l0 IGEvU291cmNlL1dlYkRyaXZlci9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViRHJpdmVyL0NoYW5nZUxv ZwppbmRleCA5M2EwZTMxNmVmMzVlZDBhM2Y2M2Q0NmJhMzkxODE3ZjY3NGFhODQ4Li5iODlmMzM4 OThmNTY0MDNjNmY0ZGYzZjA1Y2E3Njg3OTU2YTRiOGQ5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2Vi RHJpdmVyL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViRHJpdmVyL0NoYW5nZUxvZwpAQCAtMSwz ICsxLDE1IEBACisyMDIxLTA1LTEzICBNaWNoYWVsIENhdGFuemFybyAgPG1jYXRhbnphcm9AZ25v bWUub3JnPgorCisgICAgICAgIE1pc2MgR0NDIHdhcm5pbmcgY2xlYW51cAorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjI1Nzc3CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgUmVtb3ZlIHVudXNlZCB2YXJpYWJs ZS4KKworICAgICAgICAqIGdsaWIvV2ViRHJpdmVyU2VydmljZUdMaWIuY3BwOgorICAgICAgICAo V2ViRHJpdmVyOjpwYXJzZVZlcnNpb24pOgorCiAyMDIxLTA1LTEzICBEYXJpbiBBZGxlciAgPGRh cmluQGFwcGxlLmNvbT4KIAogICAgICAgICBSZW1vdmUgU3RyaW5nQnVpbGRlcjo6YXBwZW5kTnVt YmVyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9qcy9KU0F1ZGlvTm9kZUN1 c3RvbS5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9qcy9KU0F1ZGlvTm9kZUN1c3RvbS5j cHAKaW5kZXggZjJkYmQ5ODc4NjJhZWZmZWYyZDM1OTE5ZDA3MGQxNDRkNDNiN2U2Yi4uNWE0YzY2 OWJjMDZjMzgwNDQ3NTE5OThiYmIwNThhMGU3ODFlNDMyZCAxMDA2NDQKLS0tIGEvU291cmNlL1dl YkNvcmUvYmluZGluZ3MvanMvSlNBdWRpb05vZGVDdXN0b20uY3BwCisrKyBiL1NvdXJjZS9XZWJD b3JlL2JpbmRpbmdzL2pzL0pTQXVkaW9Ob2RlQ3VzdG9tLmNwcApAQCAtMTMxLDYgKzEzMSw3IEBA IEpTVmFsdWUgdG9KU05ld2x5Q3JlYXRlZChKU0dsb2JhbE9iamVjdCosIEpTRE9NR2xvYmFsT2Jq ZWN0KiBnbG9iYWxPYmplY3QsIFJlZjxBCiAgICAgY2FzZSBBdWRpb05vZGU6Ok5vZGVUeXBlV29y a2xldDoKICAgICAgICAgcmV0dXJuIGNyZWF0ZVdyYXBwZXI8QXVkaW9Xb3JrbGV0Tm9kZT4oZ2xv YmFsT2JqZWN0LCBXVEZNb3ZlKG5vZGUpKTsKICAgICB9CisgICAgUkVMRUFTRV9BU1NFUlRfTk9U X1JFQUNIRUQoKTsKIH0KIAogSlNWYWx1ZSB0b0pTKEpTR2xvYmFsT2JqZWN0KiBsZXhpY2FsR2xv YmFsT2JqZWN0LCBKU0RPTUdsb2JhbE9iamVjdCogZ2xvYmFsT2JqZWN0LCBBdWRpb05vZGUmIG5v ZGUpCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9zdmcvU1ZHVG9PVEZGb250Q29udmVyc2lv bi5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9zdmcvU1ZHVG9PVEZGb250Q29udmVyc2lvbi5jcHAKaW5k ZXggNjA2YzFmNjlhYTQzMjk4NzIyYTVjNWM4NWI5ZTBhZmM2ZGYzNmU0Yi4uNWYyMDM5NDNiMDU3 YjViM2JmZGNlMmJhMmYxNDk5Y2Q4NDBjNGNiMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUv c3ZnL1NWR1RvT1RGRm9udENvbnZlcnNpb24uY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3N2Zy9T VkdUb09URkZvbnRDb252ZXJzaW9uLmNwcApAQCAtMTQ1MSw3ICsxNDUxLDcgQEAgU1ZHVG9PVEZG b250Q29udmVydGVyOjpTVkdUb09URkZvbnRDb252ZXJ0ZXIoY29uc3QgU1ZHRm9udEVsZW1lbnQm IGZvbnRFbGVtZW50KQogICAgICAgICAgICAgICAgIG1fd2VpZ2h0ID0gNzsKICAgICAgICAgICAg ICAgICBicmVhazsKICAgICAgICAgICAgIH0KLSAgICAgICAgICAgIGlmIChhdXRvIHZhbHVlID0g cGFyc2VJbnRlZ2VyQWxsb3dpbmdUcmFpbGluZ0p1bms8dWludDE2X3Q+KHNlZ21lbnQpOyB2YWx1 ZSAmJiAqdmFsdWUgPj0gMCAmJiAqdmFsdWUgPCAxMDAwKSB7CisgICAgICAgICAgICBpZiAoYXV0 byB2YWx1ZSA9IHBhcnNlSW50ZWdlckFsbG93aW5nVHJhaWxpbmdKdW5rPHVpbnQxNl90PihzZWdt ZW50KTsgdmFsdWUgJiYgKnZhbHVlIDwgMTAwMCkgewogICAgICAgICAgICAgICAgIG1fd2VpZ2h0 ID0gKCp2YWx1ZSArIDUwKSAvIDEwMDsKICAgICAgICAgICAgICAgICBicmVhazsKICAgICAgICAg ICAgIH0KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJEcml2ZXIvZ2xpYi9XZWJEcml2ZXJTZXJ2aWNl R0xpYi5jcHAgYi9Tb3VyY2UvV2ViRHJpdmVyL2dsaWIvV2ViRHJpdmVyU2VydmljZUdMaWIuY3Bw CmluZGV4IGQ2ZmQyMTk5N2YzOWVkMWUwNDFjNTE4NTk2M2E2OGMxZjRjZWRkNTIuLjY2MmY5MjA3 NTUzN2Y0MDI3Mzg3NzZhNTI1YmM5NzUwOGI1YjgzNWUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJE cml2ZXIvZ2xpYi9XZWJEcml2ZXJTZXJ2aWNlR0xpYi5jcHAKKysrIGIvU291cmNlL1dlYkRyaXZl ci9nbGliL1dlYkRyaXZlclNlcnZpY2VHTGliLmNwcApAQCAtMzUsNyArMzUsNiBAQCBzdGF0aWMg Ym9vbCBwYXJzZVZlcnNpb24oY29uc3QgU3RyaW5nJiB2ZXJzaW9uLCB1aW50NjRfdCYgbWFqb3Is IHVpbnQ2NF90JiBtaW5vcgogICAgIG1ham9yID0gbWlub3IgPSBtaWNybyA9IDA7CiAKICAgICBW ZWN0b3I8U3RyaW5nPiB0b2tlbnMgPSB2ZXJzaW9uLnNwbGl0KCcuJyk7Ci0gICAgYm9vbCBvazsK ICAgICBzd2l0Y2ggKHRva2Vucy5zaXplKCkpIHsKICAgICBjYXNlIDM6IHsKICAgICAgICAgYXV0 byBwYXJzZWRNaWNybyA9IHBhcnNlSW50ZWdlckFsbG93aW5nVHJhaWxpbmdKdW5rPHVpbnQ2NF90 Pih0b2tlbnNbMl0pOwo=