22577 2008-12-01 16:10:56 -0800 Add a test to verify accessing INPUT elements with duplicate names 2008-12-17 13:41:43 -0800 1 1 1 Unclassified WebKit DOM 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 pam abarth abarth oldest_to_newest 100907 0 pam 2008-12-01 16:10:56 -0800 Make sure checkboxes and radio buttons with identical names are mapped to a collection when accessed via document.form.name. 100908 1 25642 pam 2008-12-01 16:15:56 -0800 Created attachment 25642 New test + result 101256 2 25722 pam 2008-12-03 13:38:28 -0800 Created attachment 25722 Patch addressing Eric's comments in IRC You can get to the list of elements with the same name either through document.(form).(name) or document.getElementsByName(name). Oddly, not only is there no consistency in what object different browsers map the two access methods to, but most don't even map the two to the same thing. [browser: document.form.name and document.getElementsByName()] Safari 3.2.1 and trunk: Collection and NodeList Firefox 3.0.4: NodeList and HTMLCollection Chrome 0.4.154.29: NodeList and NodeList IE 6: object and object Hard even to call that a bug, since nobody can be relying on it for anything much. So the test still checks only that whatever object they each map to has a length property. I've also clarified the description and added getElementsByName checks. 101326 3 25722 darin 2008-12-04 09:15:01 -0800 Comment on attachment 25722 Patch addressing Eric's comments in IRC r=me For future reference, even if something is not standardized it's good to have the regression test check it. These aren't portable tests for other browsers, but rather regression tests for WebKit. It's sensible to structure the test so that those things are separate, but we want to exercise as much code as possible so we should test everything, even things that are not consistent. 102791 4 abarth 2008-12-17 11:23:27 -0800 Will land. 102797 5 pam 2008-12-17 11:56:40 -0800 Sorry for leaving this on the queue. I was hoping to write a more thorough test, but I've since gotten mired in other things and won't be getting back to this for a bit. So you're welcome to land it; I'll improve it later. 102809 6 abarth 2008-12-17 13:41:43 -0800 LayoutTests/ChangeLog: locally modified LayoutTests/fast/dom/null-document-xmlhttprequest-open.html: locally modified LayoutTests/fast/dom/xmlhttprequest-invalid-values.html: locally modified M LayoutTests/ChangeLog A LayoutTests/fast/dom/HTMLInputElement/duplicate-element-names-expected.txt A LayoutTests/fast/dom/HTMLInputElement/duplicate-element-names.html Committed r39364 M LayoutTests/ChangeLog A LayoutTests/fast/dom/HTMLInputElement/duplicate-element-names-expected.txt A LayoutTests/fast/dom/HTMLInputElement/duplicate-element-names.html r39364 = 182b729ccd692478c593c94b7895ca69cde1118d (trunk) 25642 2008-12-01 16:15:56 -0800 2008-12-03 13:38:28 -0800 New test + result 22577a.txt text/plain 2804 pam SW5kZXg6IENoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBDaGFuZ2VMb2cJKHJldmlzaW9uIDM4ODgw KQorKysgQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTQgQEAKKzIwMDgtMTIt MDEgIFBhbWVsYSBHcmVlbmUgIDxwYW1AY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0yMjU3NworICAgICAgICBBZGQgYSB0ZXN0IHRvIGVuc3VyZSB0aGF0IGNo ZWNrYm94ZXMgYW5kIHJhZGlvIGJ1dHRvbnMgd2l0aCBkdXBsaWNhdGUKKyAgICAgICAgbmFtZXMg bWFwIHRvIGEgY29sbGVjdGlvbi4KKworICAgICAgICAqIGZhc3QvZG9tL0hUTUxJbnB1dEVsZW1l bnQvZHVwbGljYXRlLWVsZW1lbnQtbmFtZXMtZXhwZWN0ZWQudHh0OiBBZGRlZC4KKyAgICAgICAg KiBmYXN0L2RvbS9IVE1MSW5wdXRFbGVtZW50L2R1cGxpY2F0ZS1lbGVtZW50LW5hbWVzLmh0bWw6 IEFkZGVkLgorCiAyMDA4LTEyLTAxICBQYW1lbGEgR3JlZW5lICA8cGFtQGNocm9taXVtLm9yZz4K IAogICAgICAgICBSZXZpZXdlZCBieSBEYXJpbiBBZGxlci4KSW5kZXg6IGZhc3QvZG9tL0hUTUxJ bnB1dEVsZW1lbnQvZHVwbGljYXRlLWVsZW1lbnQtbmFtZXMtZXhwZWN0ZWQudHh0Cj09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT0KLS0tIGZhc3QvZG9tL0hUTUxJbnB1dEVsZW1lbnQvZHVwbGljYXRlLWVsZW1lbnQtbmFtZXMt ZXhwZWN0ZWQudHh0CShyZXZpc2lvbiAwKQorKysgZmFzdC9kb20vSFRNTElucHV0RWxlbWVudC9k dXBsaWNhdGUtZWxlbWVudC1uYW1lcy1leHBlY3RlZC50eHQJKHJldmlzaW9uIDApCkBAIC0wLDAg KzEsMTcgQEAKK011bHRpcGxlIHJhZGlvIGJ1dHRvbnMvY2hlY2tib3hlcyB3aXRoIHRoZSBzYW1l IG5hbWUgc2hvdWxkIG1hcCB0byAnb2JqZWN0OmNvbGxlY3Rpb24nIHdoZW4gYWNjZXNzZWQgdGhy b3VnaCBkb2N1bWVudC5mb3JtLm5hbWUuCisKK09uIHN1Y2Nlc3MsIHlvdSB3aWxsIHNlZSBhIHNl cmllcyBvZiAiUEFTUyIgbWVzc2FnZXMsIGZvbGxvd2VkIGJ5ICJURVNUIENPTVBMRVRFIi4KKwor CitSYWRpbyBidXR0b246ICBNYWxlICBGZW1hbGUKK0NoZWNrYm94OiAgMQorQ2hlY2tib3g6ICAx ICAyCisKK1BBU1MgdHlwZW9mIGRvY3VtZW50LmYuY2IwIGlzICd1bmRlZmluZWQnCitQQVNTIGRv Y3VtZW50LmYuY2IxLm5vZGVOYW1lIGlzICdJTlBVVCcKK1BBU1MgZG9jdW1lbnQuZi5jYjIubGVu Z3RoIGlzIDIKK1BBU1MgZG9jdW1lbnQuZi5yYjIubGVuZ3RoIGlzIDIKK1BBU1Mgc3VjY2Vzc2Z1 bGx5UGFyc2VkIGlzIHRydWUKKworVEVTVCBDT01QTEVURQorCkluZGV4OiBmYXN0L2RvbS9IVE1M SW5wdXRFbGVtZW50L2R1cGxpY2F0ZS1lbGVtZW50LW5hbWVzLmh0bWwKPT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0g ZmFzdC9kb20vSFRNTElucHV0RWxlbWVudC9kdXBsaWNhdGUtZWxlbWVudC1uYW1lcy5odG1sCShy ZXZpc2lvbiAwKQorKysgZmFzdC9kb20vSFRNTElucHV0RWxlbWVudC9kdXBsaWNhdGUtZWxlbWVu dC1uYW1lcy5odG1sCShyZXZpc2lvbiAwKQpAQCAtMCwwICsxLDQyIEBACis8aHRtbD4KKzxoZWFk PgorPGxpbmsgcmVsPSJzdHlsZXNoZWV0IiBocmVmPSIuLi8uLi9qcy9yZXNvdXJjZXMvanMtdGVz dC1zdHlsZS5jc3MiPgorPHNjcmlwdCBzcmM9Ii4uLy4uL2pzL3Jlc291cmNlcy9qcy10ZXN0LXBy ZS5qcyI+PC9zY3JpcHQ+Cis8L2hlYWQ+Cis8Ym9keT4KKzxwIGlkPSJkZXNjcmlwdGlvbiI+PC9w PgorCis8Zm9ybSBuYW1lPSJmIj4KKyAgPHVsPgorICAgIDxsaT5SYWRpbyBidXR0b246CisgICAg ICA8aW5wdXQgdHlwZT0icmFkaW8iIG5hbWU9InJiMiIvPk1hbGUKKyAgICAgIDxpbnB1dCB0eXBl PSJyYWRpbyIgbmFtZT0icmIyIi8+RmVtYWxlCisgICAgPC9saT4KKworICAgIDxsaT5DaGVja2Jv eDoKKyAgICAgIDxpbnB1dCB0eXBlPSJjaGVja2JveCIgbmFtZT0iY2IxIi8+MQorICAgIDwvbGk+ CisKKyAgICA8bGk+Q2hlY2tib3g6CisgICAgICA8aW5wdXQgdHlwZT0iY2hlY2tib3giIG5hbWU9 ImNiMiIvPjEKKyAgICAgIDxpbnB1dCB0eXBlPSJjaGVja2JveCIgbmFtZT0iY2IyIi8+MgorICAg IDwvbGk+CisgIDwvdWw+Cis8L2Zvcm0+Cis8YnI+CisKKzxkaXYgaWQ9ImNvbnNvbGUiPjwvZGl2 PgorCis8c2NyaXB0PgorZGVzY3JpcHRpb24oIk11bHRpcGxlIHJhZGlvIGJ1dHRvbnMvY2hlY2ti b3hlcyB3aXRoIHRoZSBzYW1lIG5hbWUgc2hvdWxkIG1hcCB0byAnb2JqZWN0OmNvbGxlY3Rpb24n IHdoZW4gYWNjZXNzZWQgdGhyb3VnaCBkb2N1bWVudC5mb3JtLm5hbWUuIik7CisKK3Nob3VsZEJl KCJ0eXBlb2YgZG9jdW1lbnQuZi5jYjAiLCAiJ3VuZGVmaW5lZCciKTsKK3Nob3VsZEJlKCJkb2N1 bWVudC5mLmNiMS5ub2RlTmFtZSIsICInSU5QVVQnIik7CitzaG91bGRCZSgiZG9jdW1lbnQuZi5j YjIubGVuZ3RoIiwgIjIiKTsKK3Nob3VsZEJlKCJkb2N1bWVudC5mLnJiMi5sZW5ndGgiLCAiMiIp OworCit2YXIgc3VjY2Vzc2Z1bGx5UGFyc2VkID0gdHJ1ZTsKKzwvc2NyaXB0PgorPHNjcmlwdCBz cmM9Ii4uLy4uL2pzL3Jlc291cmNlcy9qcy10ZXN0LXBvc3QuanMiPjwvc2NyaXB0PgorPC9ib2R5 PgorPC9odG1sPgo= 25722 2008-12-03 13:38:28 -0800 2008-12-04 09:15:01 -0800 Patch addressing Eric's comments in IRC 22577b.txt text/plain 3447 pam SW5kZXg6IENoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBDaGFuZ2VMb2cJKHJldmlzaW9uIDM4OTU5 KQorKysgQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTQgQEAKKzIwMDgtMTIt MDMgIFBhbWVsYSBHcmVlbmUgIDxwYW1AY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0yMjU3NworICAgICAgICBBZGQgYSB0ZXN0IHRvIGVuc3VyZSB0aGF0IGNo ZWNrYm94ZXMgYW5kIHJhZGlvIGJ1dHRvbnMgd2l0aCBkdXBsaWNhdGUKKyAgICAgICAgbmFtZXMg bWFwIHRvIGEgY29sbGVjdGlvbi4KKworICAgICAgICAqIGZhc3QvZG9tL0hUTUxJbnB1dEVsZW1l bnQvZHVwbGljYXRlLWVsZW1lbnQtbmFtZXMtZXhwZWN0ZWQudHh0OiBBZGRlZC4KKyAgICAgICAg KiBmYXN0L2RvbS9IVE1MSW5wdXRFbGVtZW50L2R1cGxpY2F0ZS1lbGVtZW50LW5hbWVzLmh0bWw6 IEFkZGVkLgorCiAyMDA4LTEyLTAzICBEZWFuIEphY2tzb24gIDxkaW5vQGFwcGxlLmNvbT4KIAog ICAgICAgICBSZXZpZXdlZCBieSBEYW4gQmVybnN0ZWluLgpJbmRleDogZmFzdC9kb20vSFRNTElu cHV0RWxlbWVudC9kdXBsaWNhdGUtZWxlbWVudC1uYW1lcy1leHBlY3RlZC50eHQKPT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PQotLS0gZmFzdC9kb20vSFRNTElucHV0RWxlbWVudC9kdXBsaWNhdGUtZWxlbWVudC1uYW1lcy1l eHBlY3RlZC50eHQJKHJldmlzaW9uIDApCisrKyBmYXN0L2RvbS9IVE1MSW5wdXRFbGVtZW50L2R1 cGxpY2F0ZS1lbGVtZW50LW5hbWVzLWV4cGVjdGVkLnR4dAkocmV2aXNpb24gMCkKQEAgLTAsMCAr MSwxOSBAQAorTXVsdGlwbGUgcmFkaW8gYnV0dG9ucy9jaGVja2JveGVzIHdpdGggdGhlIHNhbWUg bmFtZSBzaG91bGQgbWFwIHRvIGEgY291bnRhYmxlIGNvbGxlY3Rpb24gb2JqZWN0IHdoZW4gYWNj ZXNzZWQgdGhyb3VnaCBlaXRoZXIgZG9jdW1lbnQuZm9ybS5uYW1lIG9yIGRvY3VtZW50LmdldEVs ZW1lbnRzYnlOYW1lKCkuIFRoZXJlIGlzIG5vIHN0YW5kYXJkaXphdGlvbiBmb3Igd2hhdCB0aGF0 IG9iamVjdCBpcyBjYWxsZWQgKENvbGxlY3Rpb24sIE5vZGVMaXN0LCBIVE1MQ29sbGVjdGlvbiwg ZXRjLiksIG5vciBpcyBpdCBhbHdheXMgdGhlIHNhbWUgZm9yIGJvdGggbWV0aG9kcyBvZiBhY2Nl c3MuCisKK09uIHN1Y2Nlc3MsIHlvdSB3aWxsIHNlZSBhIHNlcmllcyBvZiAiUEFTUyIgbWVzc2Fn ZXMsIGZvbGxvd2VkIGJ5ICJURVNUIENPTVBMRVRFIi4KKworCitSYWRpbyBidXR0b246ICBNYWxl ICBGZW1hbGUKK0NoZWNrYm94OiAgMQorQ2hlY2tib3g6ICAxICAyCisKK1BBU1MgdHlwZW9mIGRv Y3VtZW50LmYuY2IwIGlzICd1bmRlZmluZWQnCitQQVNTIGRvY3VtZW50LmYuY2IxLm5vZGVOYW1l IGlzICdJTlBVVCcKK1BBU1MgZG9jdW1lbnQuZi5jYjIubGVuZ3RoIGlzIDIKK1BBU1MgZG9jdW1l bnQuZi5yYjIubGVuZ3RoIGlzIDIKK1BBU1MgZG9jdW1lbnQuZ2V0RWxlbWVudHNCeU5hbWUoJ2Ni MicpLmxlbmd0aCBpcyAyCitQQVNTIGRvY3VtZW50LmdldEVsZW1lbnRzQnlOYW1lKCdyYjInKS5s ZW5ndGggaXMgMgorUEFTUyBzdWNjZXNzZnVsbHlQYXJzZWQgaXMgdHJ1ZQorCitURVNUIENPTVBM RVRFCisKSW5kZXg6IGZhc3QvZG9tL0hUTUxJbnB1dEVsZW1lbnQvZHVwbGljYXRlLWVsZW1lbnQt bmFtZXMuaHRtbAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09Ci0tLSBmYXN0L2RvbS9IVE1MSW5wdXRFbGVtZW50L2R1cGxp Y2F0ZS1lbGVtZW50LW5hbWVzLmh0bWwJKHJldmlzaW9uIDApCisrKyBmYXN0L2RvbS9IVE1MSW5w dXRFbGVtZW50L2R1cGxpY2F0ZS1lbGVtZW50LW5hbWVzLmh0bWwJKHJldmlzaW9uIDApCkBAIC0w LDAgKzEsNDYgQEAKKzxodG1sPgorPGhlYWQ+Cis8bGluayByZWw9InN0eWxlc2hlZXQiIGhyZWY9 Ii4uLy4uL2pzL3Jlc291cmNlcy9qcy10ZXN0LXN0eWxlLmNzcyI+Cis8c2NyaXB0IHNyYz0iLi4v Li4vanMvcmVzb3VyY2VzL2pzLXRlc3QtcHJlLmpzIj48L3NjcmlwdD4KKzwvaGVhZD4KKzxib2R5 PgorPHAgaWQ9ImRlc2NyaXB0aW9uIj48L3A+CisKKzxmb3JtIG5hbWU9ImYiPgorICA8dWw+Cisg ICAgPGxpPlJhZGlvIGJ1dHRvbjoKKyAgICAgIDxpbnB1dCB0eXBlPSJyYWRpbyIgbmFtZT0icmIy Ii8+TWFsZQorICAgICAgPGlucHV0IHR5cGU9InJhZGlvIiBuYW1lPSJyYjIiLz5GZW1hbGUKKyAg ICA8L2xpPgorCisgICAgPGxpPkNoZWNrYm94OgorICAgICAgPGlucHV0IHR5cGU9ImNoZWNrYm94 IiBuYW1lPSJjYjEiLz4xCisgICAgPC9saT4KKworICAgIDxsaT5DaGVja2JveDoKKyAgICAgIDxp bnB1dCB0eXBlPSJjaGVja2JveCIgbmFtZT0iY2IyIi8+MQorICAgICAgPGlucHV0IHR5cGU9ImNo ZWNrYm94IiBuYW1lPSJjYjIiLz4yCisgICAgPC9saT4KKyAgPC91bD4KKzwvZm9ybT4KKzxicj4K KworPGRpdiBpZD0iY29uc29sZSI+PC9kaXY+CisKKzxzY3JpcHQ+CitkZXNjcmlwdGlvbigiTXVs dGlwbGUgcmFkaW8gYnV0dG9ucy9jaGVja2JveGVzIHdpdGggdGhlIHNhbWUgbmFtZSBzaG91bGQg bWFwIHRvIGEgY291bnRhYmxlIGNvbGxlY3Rpb24gb2JqZWN0IHdoZW4gYWNjZXNzZWQgdGhyb3Vn aCBlaXRoZXIgZG9jdW1lbnQuZm9ybS5uYW1lIG9yIGRvY3VtZW50LmdldEVsZW1lbnRzYnlOYW1l KCkuIFRoZXJlIGlzIG5vIHN0YW5kYXJkaXphdGlvbiBmb3Igd2hhdCB0aGF0IG9iamVjdCBpcyBj YWxsZWQgKENvbGxlY3Rpb24sIE5vZGVMaXN0LCBIVE1MQ29sbGVjdGlvbiwgZXRjLiksIG5vciBp cyBpdCBhbHdheXMgdGhlIHNhbWUgZm9yIGJvdGggbWV0aG9kcyBvZiBhY2Nlc3MuIik7CisKK3No b3VsZEJlKCJ0eXBlb2YgZG9jdW1lbnQuZi5jYjAiLCAiJ3VuZGVmaW5lZCciKTsKK3Nob3VsZEJl KCJkb2N1bWVudC5mLmNiMS5ub2RlTmFtZSIsICInSU5QVVQnIik7CisKK3Nob3VsZEJlKCJkb2N1 bWVudC5mLmNiMi5sZW5ndGgiLCAiMiIpOworc2hvdWxkQmUoImRvY3VtZW50LmYucmIyLmxlbmd0 aCIsICIyIik7CisKK3Nob3VsZEJlKCJkb2N1bWVudC5nZXRFbGVtZW50c0J5TmFtZSgnY2IyJyku bGVuZ3RoIiwgIjIiKTsKK3Nob3VsZEJlKCJkb2N1bWVudC5nZXRFbGVtZW50c0J5TmFtZSgncmIy JykubGVuZ3RoIiwgIjIiKTsKKwordmFyIHN1Y2Nlc3NmdWxseVBhcnNlZCA9IHRydWU7Cis8L3Nj cmlwdD4KKzxzY3JpcHQgc3JjPSIuLi8uLi9qcy9yZXNvdXJjZXMvanMtdGVzdC1wb3N0LmpzIj48 L3NjcmlwdD4KKzwvYm9keT4KKzwvaHRtbD4K