225741 2021-05-13 03:00:36 -0700 Few webkitpy unit-tests fails in non-PST timezones 2021-10-23 06:57:29 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=218079 https://bugs.webkit.org/show_bug.cgi?id=232197 InRadar P2 Normal --- 1 aakash_jain jbedard aakash_jain webkit-bug-importer oldest_to_newest 1759603 0 aakash_jain 2021-05-13 03:00:36 -0700 [Scripts]$./test-webkitpy ... [1450/1990] webkitscmpy.test.svn_unittest.TestRemoteSvn.test_commits_branch failed: Traceback (most recent call last): File "OpenSource/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/test/svn_unittest.py", line 374, in test_commits_branch ]), Commit.Encoder().default(list(svn.commits(begin=dict(argument='r1'), end=dict(argument='r7'))))) AssertionError: Lists differ: [{'re[47 chars]1601640900, 'order': 0, 'message': '7th commit[809 chars]nk'}] != [{'re[47 chars]1601651700, 'order': 0, 'message': '7th commit[809 chars]nk'}] First differing element 0: {'rev[46 chars]1601640900, 'order': 0, 'message': '7th commit[128 chars]h-a'} {'rev[46 chars]1601651700, 'order': 0, 'message': '7th commit[128 chars]h-a'} Diff is 1372 characters long. Set self.maxDiff to None to see it. [1802/1990] webkitscmpy.test.svn_unittest.TestRemoteSvn.test_commits failed: Traceback (most recent call last): File "OpenSource/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/test/svn_unittest.py", line 364, in test_commits ]), Commit.Encoder().default(list(svn.commits(begin=dict(revision='r1'), end=dict(revision='r6'))))) AssertionError: Lists differ: [{'re[44 chars]1601639900, 'order': 0, 'message': '6th commit[796 chars]nk'}] != [{'re[44 chars]1601650700, 'order': 0, 'message': '6th commit[796 chars]nk'}] First differing element 0: {'rev[43 chars]1601639900, 'order': 0, 'message': '6th commit[123 chars]unk'} {'rev[43 chars]1601650700, 'order': 0, 'message': '6th commit[123 chars]unk'} [{'author': {'emails': ['jbedard@apple.com'], 'name': 'jbedard@apple.com'}, 'branch': 'trunk', 'identifier': '4@trunk', 'message': '6th commit', 'order': 0, 'repository_id': 'webkit', 'revision': 6, - 'timestamp': 1601639900}, ? ^^^ + 'timestamp': 1601650700}, ? ^^^ {'author': {'emails': ['jbedard@apple.com'], 'name': 'jbedard@apple.com'}, 'branch': 'trunk', 'identifier': '3@trunk', 'message': '4th commit', 'order': 0, 'repository_id': 'webkit', 'revision': 4, - 'timestamp': 1601637900}, ? ^ - + 'timestamp': 1601648700}, ? ^^ {'author': {'emails': ['jbedard@apple.com'], 'name': 'jbedard@apple.com'}, 'branch': 'trunk', 'identifier': '2@trunk', 'message': '2nd commit', 'order': 0, 'repository_id': 'webkit', 'revision': 2, - 'timestamp': 1601635900}, ? ^^^ + 'timestamp': 1601646700}, ? ^^^ {'author': {'emails': ['jbedard@apple.com'], 'name': 'jbedard@apple.com'}, 'branch': 'trunk', 'identifier': '1@trunk', 'message': '1st commit', 'order': 0, 'repository_id': 'webkit', 'revision': 1, - 'timestamp': 1601634900}] ? - ^ + 'timestamp': 1601645700}] ? ^^ Mock process 68639 send signal 9 Mock process 68639 send signal 9 Mock process 68624 send signal 9 Mock process 68624 send signal 9 Ran 1990 tests in 6.933s FAILED (failures=2, errors=0) These tests pass when I set my timezone to PST. 1759713 1 428522 jbedard 2021-05-13 09:28:48 -0700 Created attachment 428522 Patch 1759735 2 ews-feeder 2021-05-13 10:36:11 -0700 Committed r277440 (237688@main): <https://commits.webkit.org/237688@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 428522. 1759737 3 webkit-bug-importer 2021-05-13 10:37:16 -0700 <rdar://problem/77973121> 428522 2021-05-13 09:28:48 -0700 2021-05-13 10:36:11 -0700 Patch bug-225741-20210513092847.patch text/plain 2922 jbedard SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDI3NzQzNykKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE1IEBACisyMDIxLTA1LTEzICBKb25hdGhhbiBCZWRhcmQgIDxqYmVkYXJkQGFwcGxlLmNv bT4KKworICAgICAgICBGZXcgd2Via2l0cHkgdW5pdC10ZXN0cyBmYWlscyBpbiBub24tUFNUIHRp bWV6b25lcworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MjI1NzQxCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg KiBTY3JpcHRzL2xpYnJhcmllcy93ZWJraXRzY21weS9zZXR1cC5weTogQnVtcCB2ZXJzaW9uLgor ICAgICAgICAqIFNjcmlwdHMvbGlicmFyaWVzL3dlYmtpdHNjbXB5L3dlYmtpdHNjbXB5L19faW5p dF9fLnB5OgorICAgICAgICAqIFNjcmlwdHMvbGlicmFyaWVzL3dlYmtpdHNjbXB5L3dlYmtpdHNj bXB5L21vY2tzL3JlbW90ZS9zdm4ucHk6IERpdHRvLgorICAgICAgICAoU3ZuLnJlcXVlc3QpOiBT ZXJ2ZSBTVk4gY29udGVudCBmcm9tIENhbGlmb3JuaWEgdGltZSAobGlrZSBvdXIgU1ZOIHNlcnZl cikKKwogMjAyMS0wNS0xMyAgRGFyaW4gQWRsZXIgIDxkYXJpbkBhcHBsZS5jb20+CiAKICAgICAg ICAgUmVtb3ZlIFN0cmluZ0J1aWxkZXI6OmFwcGVuZE51bWJlcgpJbmRleDogVG9vbHMvU2NyaXB0 cy9saWJyYXJpZXMvd2Via2l0c2NtcHkvc2V0dXAucHkKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gVG9vbHMvU2Ny aXB0cy9saWJyYXJpZXMvd2Via2l0c2NtcHkvc2V0dXAucHkJKHJldmlzaW9uIDI3NzQzNSkKKysr IFRvb2xzL1NjcmlwdHMvbGlicmFyaWVzL3dlYmtpdHNjbXB5L3NldHVwLnB5CSh3b3JraW5nIGNv cHkpCkBAIC0yOSw3ICsyOSw3IEBAIGRlZiByZWFkbWUoKToKIAogc2V0dXAoCiAgICAgbmFtZT0n d2Via2l0c2NtcHknLAotICAgIHZlcnNpb249JzAuMTQuMCcsCisgICAgdmVyc2lvbj0nMC4xNC4x JywKICAgICBkZXNjcmlwdGlvbj0nTGlicmFyeSBkZXNpZ25lZCB0byBpbnRlcmFjdCB3aXRoIGdp dCBhbmQgc3ZuIHJlcG9zaXRvcmllcy4nLAogICAgIGxvbmdfZGVzY3JpcHRpb249cmVhZG1lKCks CiAgICAgY2xhc3NpZmllcnM9WwpJbmRleDogVG9vbHMvU2NyaXB0cy9saWJyYXJpZXMvd2Via2l0 c2NtcHkvd2Via2l0c2NtcHkvX19pbml0X18ucHkKPT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gVG9vbHMvU2NyaXB0 cy9saWJyYXJpZXMvd2Via2l0c2NtcHkvd2Via2l0c2NtcHkvX19pbml0X18ucHkJKHJldmlzaW9u IDI3NzQzNSkKKysrIFRvb2xzL1NjcmlwdHMvbGlicmFyaWVzL3dlYmtpdHNjbXB5L3dlYmtpdHNj bXB5L19faW5pdF9fLnB5CSh3b3JraW5nIGNvcHkpCkBAIC00Niw3ICs0Niw3IEBAIGV4Y2VwdCBJ bXBvcnRFcnJvcjoKICAgICAgICAgIlBsZWFzZSBpbnN0YWxsIHdlYmtpdGNvcmVweSB3aXRoIGBw aXAgaW5zdGFsbCB3ZWJraXRjb3JlcHkgLS1leHRyYS1pbmRleC11cmwgPHBhY2thZ2UgaW5kZXgg VVJMPmAiCiAgICAgKQogCi12ZXJzaW9uID0gVmVyc2lvbigwLCAxNCwgMCkKK3ZlcnNpb24gPSBW ZXJzaW9uKDAsIDE0LCAxKQogCiBBdXRvSW5zdGFsbC5yZWdpc3RlcihQYWNrYWdlKCdmYXN0ZW5l cnMnLCBWZXJzaW9uKDAsIDE1LCAwKSkpCiBBdXRvSW5zdGFsbC5yZWdpc3RlcihQYWNrYWdlKCdt b25vdG9uaWMnLCBWZXJzaW9uKDEsIDUpKSkKSW5kZXg6IFRvb2xzL1NjcmlwdHMvbGlicmFyaWVz L3dlYmtpdHNjbXB5L3dlYmtpdHNjbXB5L21vY2tzL3JlbW90ZS9zdm4ucHkKPT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQot LS0gVG9vbHMvU2NyaXB0cy9saWJyYXJpZXMvd2Via2l0c2NtcHkvd2Via2l0c2NtcHkvbW9ja3Mv cmVtb3RlL3N2bi5weQkocmV2aXNpb24gMjc3NDM1KQorKysgVG9vbHMvU2NyaXB0cy9saWJyYXJp ZXMvd2Via2l0c2NtcHkvd2Via2l0c2NtcHkvbW9ja3MvcmVtb3RlL3N2bi5weQkod29ya2luZyBj b3B5KQpAQCAtMjc4LDcgKzI3OCw3IEBAIGNsYXNzIFN2bihtb2Nrcy5SZXF1ZXN0cyk6CiAgICAg ICAgICAgICAgICAgICAgICAgICAnPFM6ZGF0ZT57fTwvUzpkYXRlPlxuJwogICAgICAgICAgICAg ICAgICAgICAgICAgJ3t9e308L1M6bG9nLWl0ZW0+XG4nLmZvcm1hdCgKICAgICAgICAgICAgICAg ICAgICAgICAgICAgICBjb21taXQucmV2aXNpb24sCi0gICAgICAgICAgICAgICAgICAgICAgICAg ICAgZGF0ZXRpbWUuZnJvbXRpbWVzdGFtcChjb21taXQudGltZXN0YW1wKS5zdHJmdGltZSgnJVkt JW0tJWRUJUg6JU06JVMuMTAzNzU0WicpLAorICAgICAgICAgICAgICAgICAgICAgICAgICAgIGRh dGV0aW1lLnV0Y2Zyb210aW1lc3RhbXAoY29tbWl0LnRpbWVzdGFtcCAtIHRpbWVkZWx0YShob3Vy cz03KS5zZWNvbmRzKS5zdHJmdGltZSgnJVktJW0tJWRUJUg6JU06JVMuMTAzNzU0WicpLAogICAg ICAgICAgICAgICAgICAgICAgICAgICAgICcnIGlmIGRhdGFbJ1M6bG9nLXJlcG9ydCddLmdldCgn UzpyZXZwcm8nKSBlbHNlICc8RDpjb21tZW50Pnt9PC9EOmNvbW1lbnQ+XG4nCiAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgJzxEOmNyZWF0b3ItZGlzcGxheW5hbWU+e308L0Q6Y3JlYXRvci1k aXNwbGF5bmFtZT5cbicuZm9ybWF0KAogICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBj b21taXQubWVzc2FnZSwK