22574 2008-12-01 14:53:07 -0800 [GTK] Make webkit_web_view_set_window_features internal 2008-12-19 09:17:08 -0800 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED Gtk P2 Normal --- 1 zecke webkit-unassigned oldest_to_newest 100887 0 zecke 2008-12-01 14:53:07 -0800 Make webkit_web_view_set_window_features internal as it has the risk of missing a notify::window-features and there is no need to set that from the outside. 100888 1 25638 zecke 2008-12-01 14:56:37 -0800 Created attachment 25638 Make webkit_web_view_set_window_features internal Make it internal, switch the user of this function over to use g_object_set. 102307 2 zecke 2008-12-11 17:31:43 -0800 Landed in r39223. 102991 3 25638 zecke 2008-12-19 09:17:08 -0800 Comment on attachment 25638 Make webkit_web_view_set_window_features internal Clear review, it was reviewed and landed. 25638 2008-12-01 14:56:37 -0800 2008-12-19 09:17:08 -0800 Make webkit_web_view_set_window_features internal 0003-Make-webkit_web_view_set_window_features-internal.patch text/plain 5169 zecke RnJvbSA3MDFhMzUwMjUxNTAxMzU1ZDI3MjFlNzRkYjZhMzliM2MwZTBlZDUzIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBIb2xnZXIgSGFucyBQZXRlciBGcmV5dGhlciA8emVja2VAc2Vs ZmlzaC5vcmc+CkRhdGU6IFNhdCwgMjkgTm92IDIwMDggMjE6MTc6MTggKzAxMDAKU3ViamVjdDog W1BBVENIXSBNYWtlIHdlYmtpdF93ZWJfdmlld19zZXRfd2luZG93X2ZlYXR1cmVzIGludGVybmFs CgogICAgQ2FsbGluZyB0aGlzIG1ldGhvZCB3aWxsIG5vdCByZXN1bHQgaW4gYSBub3RpZnk6Ondp bmRvdy1mZWF0dXJlcwogICAgc2lnbmFsIGJlaW5nIGVtaXR0ZWQuIFRoaXMgd291bGQgYWxsb3cg cmVwbGFjaW5nIGEKICAgIFdlYktpdFdlYldpbmRvd0ZlYXR1cmUgb24gYSBXZWJLaXRXZWJWaWV3 IHdpdGhvdXQgYW55b25lIG5vdGljaW5nCiAgICBhbmQgdGhlIGNsaWVudCBjb2RlIHdvdWxkIHN0 aWxsIG1vbml0b3IgdGhlIG9sZCBvbmUuCi0tLQogV2ViS2l0L2d0ay9DaGFuZ2VMb2cgICAgICAg ICAgICAgICAgICAgICAgICAgIHwgICAxNiArKysrKysrKysrKysrKysrCiBXZWJLaXQvZ3RrL1dl YkNvcmVTdXBwb3J0L0Nocm9tZUNsaWVudEd0ay5jcHAgfCAgICAyICstCiBXZWJLaXQvZ3RrL3dl YmtpdC93ZWJraXR3ZWJ2aWV3LmNwcCAgICAgICAgICAgfCAgIDIyICsrKy0tLS0tLS0tLS0tLS0t LS0tLS0KIFdlYktpdC9ndGsvd2Via2l0L3dlYmtpdHdlYnZpZXcuaCAgICAgICAgICAgICB8ICAg IDQgLS0tLQogNCBmaWxlcyBjaGFuZ2VkLCAyMCBpbnNlcnRpb25zKCspLCAyNCBkZWxldGlvbnMo LSkKCmRpZmYgLS1naXQgYS9XZWJLaXQvZ3RrL0NoYW5nZUxvZyBiL1dlYktpdC9ndGsvQ2hhbmdl TG9nCmluZGV4IDAyNmMzNzQuLjRjNjZkZmEgMTAwNjQ0Ci0tLSBhL1dlYktpdC9ndGsvQ2hhbmdl TG9nCisrKyBiL1dlYktpdC9ndGsvQ2hhbmdlTG9nCkBAIC0yLDYgKzIsMjIgQEAKIAogICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KIAorICAgICAgICBNYWtlIHdlYmtpdF93ZWJf dmlld19zZXRfd2luZG93X2ZlYXR1cmVzIGludGVybmFsCisKKyAgICAgICAgQ2FsbGluZyB0aGlz IG1ldGhvZCB3aWxsIG5vdCByZXN1bHQgaW4gYSBub3RpZnk6OndpbmRvdy1mZWF0dXJlcworICAg ICAgICBzaWduYWwgYmVpbmcgZW1pdHRlZC4gVGhpcyB3b3VsZCBhbGxvdyByZXBsYWNpbmcgYQor ICAgICAgICBXZWJLaXRXZWJXaW5kb3dGZWF0dXJlIG9uIGEgV2ViS2l0V2ViVmlldyB3aXRob3V0 IGFueW9uZSBub3RpY2luZworICAgICAgICBhbmQgdGhlIGNsaWVudCBjb2RlIHdvdWxkIHN0aWxs IG1vbml0b3IgdGhlIG9sZCBvbmUuCisKKyAgICAgICAgKiBXZWJDb3JlU3VwcG9ydC9DaHJvbWVD bGllbnRHdGsuY3BwOgorICAgICAgICAoV2ViS2l0OjpDaHJvbWVDbGllbnQ6OmNyZWF0ZVdpbmRv dyk6CisgICAgICAgICogd2Via2l0L3dlYmtpdHdlYnZpZXcuY3BwOgorICAgICAgICAqIHdlYmtp dC93ZWJraXR3ZWJ2aWV3Lmg6CisKKzIwMDgtMTEtMjkgIEhvbGdlciBIYW5zIFBldGVyIEZyZXl0 aGVyICA8emVja2VAc2VsZmlzaC5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKICAgICAgICAgQWRkIHNlY3Rpb24gaW5mb3JtYXRpb24gZm9yIFZpZXcsIEZyYW1l LCBTZXR0aW5ncywgSGlzdG9yeUl0ZW0sIEJhY2tGb3J3YXJkTGlzdCwgV2luZG93RmVhdHVyZXMg YW5kIEluc3BlY3RvcgogICAgICAgICAKICAgICAgICAgQWRkIHNlY3Rpb24gaW5mb3JtYXRpb24g YW5kIGluZm9ybWFsIGV4YW1wbGVzIGZvciBXZWJLaXRXZWJWaWV3LApkaWZmIC0tZ2l0IGEvV2Vi S2l0L2d0ay9XZWJDb3JlU3VwcG9ydC9DaHJvbWVDbGllbnRHdGsuY3BwIGIvV2ViS2l0L2d0ay9X ZWJDb3JlU3VwcG9ydC9DaHJvbWVDbGllbnRHdGsuY3BwCmluZGV4IDMyOGM1ZDcuLjcwYWE1NjMg MTAwNjQ0Ci0tLSBhL1dlYktpdC9ndGsvV2ViQ29yZVN1cHBvcnQvQ2hyb21lQ2xpZW50R3RrLmNw cAorKysgYi9XZWJLaXQvZ3RrL1dlYkNvcmVTdXBwb3J0L0Nocm9tZUNsaWVudEd0ay5jcHAKQEAg LTExOSw3ICsxMTksNyBAQCBQYWdlKiBDaHJvbWVDbGllbnQ6OmNyZWF0ZVdpbmRvdyhGcmFtZSog ZnJhbWUsIGNvbnN0IEZyYW1lTG9hZFJlcXVlc3QmIGZyYW1lTG9hZAogICAgICAgICByZXR1cm4g MDsKIAogICAgIFdlYktpdFdlYldpbmRvd0ZlYXR1cmVzKiB3ZWJXaW5kb3dGZWF0dXJlcyA9IHdl YmtpdF93ZWJfd2luZG93X2ZlYXR1cmVzX25ld19mcm9tX2NvcmVfZmVhdHVyZXMoY29yZUZlYXR1 cmVzKTsKLSAgICB3ZWJraXRfd2ViX3ZpZXdfc2V0X3dpbmRvd19mZWF0dXJlcyh3ZWJWaWV3LCB3 ZWJXaW5kb3dGZWF0dXJlcyk7CisgICAgZ19vYmplY3Rfc2V0KHdlYlZpZXcsICJ3aW5kb3ctZmVh dHVyZXMiLCB3ZWJXaW5kb3dGZWF0dXJlcywgTlVMTCk7CiAgICAgZ19vYmplY3RfdW5yZWYoR19P QkpFQ1Qod2ViV2luZG93RmVhdHVyZXMpKTsKIAogICAgIGlmICghZnJhbWVMb2FkUmVxdWVzdC5p c0VtcHR5KCkpCmRpZmYgLS1naXQgYS9XZWJLaXQvZ3RrL3dlYmtpdC93ZWJraXR3ZWJ2aWV3LmNw cCBiL1dlYktpdC9ndGsvd2Via2l0L3dlYmtpdHdlYnZpZXcuY3BwCmluZGV4IDRjNTNmYWIuLmI0 NmFjYjggMTAwNjQ0Ci0tLSBhL1dlYktpdC9ndGsvd2Via2l0L3dlYmtpdHdlYnZpZXcuY3BwCisr KyBiL1dlYktpdC9ndGsvd2Via2l0L3dlYmtpdHdlYnZpZXcuY3BwCkBAIC0xNTEsNiArMTUxLDcg QEAgc3RhdGljIGd1aW50IHdlYmtpdF93ZWJfdmlld19zaWduYWxzW0xBU1RfU0lHTkFMXSA9IHsg MCwgfTsKIEdfREVGSU5FX1RZUEUoV2ViS2l0V2ViVmlldywgd2Via2l0X3dlYl92aWV3LCBHVEtf VFlQRV9DT05UQUlORVIpCiAKIHN0YXRpYyB2b2lkIHdlYmtpdF93ZWJfdmlld19zZXR0aW5nc19u b3RpZnkoV2ViS2l0V2ViU2V0dGluZ3MqIHdlYlNldHRpbmdzLCBHUGFyYW1TcGVjKiBwc3BlYywg V2ViS2l0V2ViVmlldyogd2ViVmlldyk7CitzdGF0aWMgdm9pZCB3ZWJraXRfd2ViX3ZpZXdfc2V0 X3dpbmRvd19mZWF0dXJlcyhXZWJLaXRXZWJWaWV3KiB3ZWJWaWV3LCBXZWJLaXRXZWJXaW5kb3dG ZWF0dXJlcyogd2ViV2luZG93RmVhdHVyZXMpOwogCiBzdGF0aWMgdm9pZCB3ZWJraXRfd2ViX3Zp ZXdfY29udGV4dF9tZW51X3Bvc2l0aW9uX2Z1bmMoR3RrTWVudSosIGdpbnQqIHgsIGdpbnQqIHks IGdib29sZWFuKiBwdXNoSW4sIFdlYktpdFdlYlZpZXdQcml2YXRlKiBkYXRhKQogewpAQCAtMTc0 NSwyNiArMTc0Niw5IEBAIFdlYktpdFdlYkluc3BlY3Rvciogd2Via2l0X3dlYl92aWV3X2dldF9p bnNwZWN0b3IoV2ViS2l0V2ViVmlldyogd2ViVmlldykKICAgICByZXR1cm4gcHJpdi0+d2ViSW5z cGVjdG9yOwogfQogCi0vKioKLSAqIHdlYmtpdF93ZWJfdmlld19zZXRfd2luZG93X2ZlYXR1cmVz Ci0gKiBAd2ViX3ZpZXc6IGEgI1dlYktpdFdlYlZpZXcKLSAqIEB3aW5kb3dfZmVhdHVyZXM6IGEg I1dlYktpdFdlYldpbmRvd0ZlYXR1cmVzCi0gKgotICogVGhpcyB3aWxsIHNldCBob3cgdGhlIHdp bmRvdyBjb250YWluaW5nIHRoZSAjV2ViS2l0V2ViVmlldyBzaG91bGQKLSAqIGxvb2sgYW5kIGJl aGF2ZS4gQXBwbGljYXRpb25zIG1heSB3YW50IHRvIG1vbml0b3IgdGhpcyBwcm9wZXJ0eSBhbmQK LSAqIGFwcGx5IHRoZSBzZXR0aW5ncyBpdCBjYXJyaWVzIHRvIHRoZSB3aW5kb3cgaG9sZGluZyB0 aGUgcmVsZXZhbnQKLSAqICNXZWJLaXRXZWJWaWV3LiBXaGVuIHRoZSBAd2luZG93X2ZlYXR1cmVz IGlzIGVxdWFsIHRvIHRoZSBjdXJyZW50Ci0gKiAjV2ViS2l0V2ViV2luZG93RmVhdHVyZXMgbm90 aGluZyB3aWxsIGJlIGRvbmUuIFlvdSBub3JtYWxseSBkbyBub3QKLSAqIG5lZWQgdG8gY2FsbCB0 aGlzIGZ1bmN0aW9uLgotICoKLSAqCi0gKiBTaW5jZTogMS4wLjMKLSAqLwotdm9pZCB3ZWJraXRf d2ViX3ZpZXdfc2V0X3dpbmRvd19mZWF0dXJlcyhXZWJLaXRXZWJWaWV3KiB3ZWJWaWV3LCBXZWJL aXRXZWJXaW5kb3dGZWF0dXJlcyogd2ViV2luZG93RmVhdHVyZXMpCisvLyBpbnRlcm5hbAorc3Rh dGljIHZvaWQgd2Via2l0X3dlYl92aWV3X3NldF93aW5kb3dfZmVhdHVyZXMoV2ViS2l0V2ViVmll dyogd2ViVmlldywgV2ViS2l0V2ViV2luZG93RmVhdHVyZXMqIHdlYldpbmRvd0ZlYXR1cmVzKQog ewotICAgIGdfcmV0dXJuX2lmX2ZhaWwoV0VCS0lUX0lTX1dFQl9WSUVXKHdlYlZpZXcpKTsKLSAg ICBnX3JldHVybl9pZl9mYWlsKFdFQktJVF9JU19XRUJfV0lORE9XX0ZFQVRVUkVTKHdlYldpbmRv d0ZlYXR1cmVzKSk7Ci0KICAgICBXZWJLaXRXZWJWaWV3UHJpdmF0ZSogcHJpdiA9IHdlYlZpZXct PnByaXY7CiAKICAgICBpZih3ZWJraXRfd2ViX3dpbmRvd19mZWF0dXJlc19lcXVhbChwcml2LT53 ZWJXaW5kb3dGZWF0dXJlcywgd2ViV2luZG93RmVhdHVyZXMpKQpkaWZmIC0tZ2l0IGEvV2ViS2l0 L2d0ay93ZWJraXQvd2Via2l0d2Vidmlldy5oIGIvV2ViS2l0L2d0ay93ZWJraXQvd2Via2l0d2Vi dmlldy5oCmluZGV4IDIxOGJmNzguLmQ0ZDE3MGUgMTAwNjQ0Ci0tLSBhL1dlYktpdC9ndGsvd2Vi a2l0L3dlYmtpdHdlYnZpZXcuaAorKysgYi9XZWJLaXQvZ3RrL3dlYmtpdC93ZWJraXR3ZWJ2aWV3 LmgKQEAgLTI1MiwxMCArMjUyLDYgQEAgd2Via2l0X3dlYl92aWV3X2dldF9zZXR0aW5ncyAgICAg ICAgICAgICAgICAgICAgKFdlYktpdFdlYlZpZXcgICAgICAgICp3ZWJfdmlldykKIFdFQktJVF9B UEkgV2ViS2l0V2ViSW5zcGVjdG9yICoKIHdlYmtpdF93ZWJfdmlld19nZXRfaW5zcGVjdG9yICAg ICAgICAgICAgICAgICAgIChXZWJLaXRXZWJWaWV3ICAgICAgICAqd2ViX3ZpZXcpOwogCi1XRUJL SVRfQVBJIHZvaWQKLXdlYmtpdF93ZWJfdmlld19zZXRfd2luZG93X2ZlYXR1cmVzICAgICAgICAg ICAgIChXZWJLaXRXZWJWaWV3ICAgICAgICAqd2ViX3ZpZXcsCi0gICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgV2ViS2l0V2ViV2luZG93RmVhdHVyZXMgKndp bmRvd19mZWF0dXJlcyk7Ci0KIFdFQktJVF9BUEkgV2ViS2l0V2ViV2luZG93RmVhdHVyZXMqCiB3 ZWJraXRfd2ViX3ZpZXdfZ2V0X3dpbmRvd19mZWF0dXJlcyAgICAgICAgICAgICAoV2ViS2l0V2Vi VmlldyAgICAgICAgKndlYl92aWV3KTsKIAotLSAKMS41LjYuMwoK