225725 2021-05-12 16:52:08 -0700 Some webgl/2.0.0/conformance/textures/image_bitmap_from_image_data tests are failing after r277369 if !USE(ACCELERATE) 2021-05-12 20:00:16 -0700 1 1 1 Unclassified WebKit WebGL WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 fujii fujii dino kbr kkinnunen sam webkit-bug-importer oldest_to_newest 1759463 0 fujii 2021-05-12 16:52:08 -0700 [WinCairo] Some webgl/2.0.0/conformance/textures/image_bitmap_from_image_data are failing after r277369 r277369 (237627@main) bug 225673 – Factor copyImagePixel pixel conversion code into its own file https://build.webkit.org/#/builders/60/builds/1282 Regressions: Unexpected text-only failures (71) webgl/2.0.0/conformance/textures/image_bitmap_from_image_data/tex-2d-rgb-rgb-unsigned_byte.html [ Failure ] webgl/2.0.0/conformance/textures/image_bitmap_from_image_data/tex-2d-rgb-rgb-unsigned_short_5_6_5.html [ Failure ] webgl/2.0.0/conformance/textures/image_bitmap_from_image_data/tex-2d-rgba-rgba-unsigned_byte.html [ Failure ] webgl/2.0.0/conformance/textures/image_bitmap_from_image_data/tex-2d-rgba-rgba-unsigned_short_4_4_4_4.html [ Failure ] webgl/2.0.0/conformance/textures/image_bitmap_from_image_data/tex-2d-rgba-rgba-unsigned_short_5_5_5_1.html [ Failure ] webgl/2.0.0/conformance2/textures/image_bitmap_from_image_data/tex-2d-r11f_g11f_b10f-rgb-float.html [ Failure ] webgl/2.0.0/conformance2/textures/image_bitmap_from_image_data/tex-2d-r11f_g11f_b10f-rgb-half_float.html [ Failure ] webgl/2.0.0/conformance2/textures/image_bitmap_from_image_data/tex-2d-r11f_g11f_b10f-rgb-unsigned_int_10f_11f_11f_rev.html [ Failure ] webgl/2.0.0/conformance2/textures/image_bitmap_from_image_data/tex-2d-r16f-red-float.html [ Failure ] webgl/2.0.0/conformance2/textures/image_bitmap_from_image_data/tex-2d-r16f-red-half_float.html [ Failure ] webgl/2.0.0/conformance2/textures/image_bitmap_from_image_data/tex-2d-r32f-red-float.html [ Failure ] webgl/2.0.0/conformance2/textures/image_bitmap_from_image_data/tex-2d-r8-red-unsigned_byte.html [ Failure ] webgl/2.0.0/conformance2/textures/image_bitmap_from_image_data/tex-2d-r8ui-red_integer-unsigned_byte.html [ Failure ] webgl/2.0.0/conformance2/textures/image_bitmap_from_image_data/tex-2d-rg16f-rg-float.html [ Failure ] webgl/2.0.0/conformance2/textures/image_bitmap_from_image_data/tex-2d-rg16f-rg-half_float.html [ Failure ] webgl/2.0.0/conformance2/textures/image_bitmap_from_image_data/tex-2d-rg32f-rg-float.html [ Failure ] webgl/2.0.0/conformance2/textures/image_bitmap_from_image_data/tex-2d-rg8-rg-unsigned_byte.html [ Failure ] webgl/2.0.0/conformance2/textures/image_bitmap_from_image_data/tex-2d-rg8ui-rg_integer-unsigned_byte.html [ Failure ] webgl/2.0.0/conformance2/textures/image_bitmap_from_image_data/tex-2d-rgb16f-rgb-float.html [ Failure ] webgl/2.0.0/conformance2/textures/image_bitmap_from_image_data/tex-2d-rgb16f-rgb-half_float.html [ Failure ] webgl/2.0.0/conformance2/textures/image_bitmap_from_image_data/tex-2d-rgb32f-rgb-float.html [ Failure ] webgl/2.0.0/conformance2/textures/image_bitmap_from_image_data/tex-2d-rgb565-rgb-unsigned_byte.html [ Failure ] webgl/2.0.0/conformance2/textures/image_bitmap_from_image_data/tex-2d-rgb565-rgb-unsigned_short_5_6_5.html [ Failure ] webgl/2.0.0/conformance2/textures/image_bitmap_from_image_data/tex-2d-rgb5_a1-rgba-unsigned_byte.html [ Failure ] webgl/2.0.0/conformance2/textures/image_bitmap_from_image_data/tex-2d-rgb5_a1-rgba-unsigned_short_5_5_5_1.html [ Failure ] webgl/2.0.0/conformance2/textures/image_bitmap_from_image_data/tex-2d-rgb8-rgb-unsigned_byte.html [ Failure ] webgl/2.0.0/conformance2/textures/image_bitmap_from_image_data/tex-2d-rgb8ui-rgb_integer-unsigned_byte.html [ Failure ] webgl/2.0.0/conformance2/textures/image_bitmap_from_image_data/tex-2d-rgb9_e5-rgb-float.html [ Failure ] webgl/2.0.0/conformance2/textures/image_bitmap_from_image_data/tex-2d-rgb9_e5-rgb-half_float.html [ Failure ] webgl/2.0.0/conformance2/textures/image_bitmap_from_image_data/tex-2d-rgba16f-rgba-float.html [ Failure ] webgl/2.0.0/conformance2/textures/image_bitmap_from_image_data/tex-2d-rgba16f-rgba-half_float.html [ Failure ] webgl/2.0.0/conformance2/textures/image_bitmap_from_image_data/tex-2d-rgba32f-rgba-float.html [ Failure ] webgl/2.0.0/conformance2/textures/image_bitmap_from_image_data/tex-2d-rgba4-rgba-unsigned_byte.html [ Failure ] webgl/2.0.0/conformance2/textures/image_bitmap_from_image_data/tex-2d-rgba4-rgba-unsigned_short_4_4_4_4.html [ Failure ] webgl/2.0.0/conformance2/textures/image_bitmap_from_image_data/tex-2d-rgba8-rgba-unsigned_byte.html [ Failure ] webgl/2.0.0/conformance2/textures/image_bitmap_from_image_data/tex-2d-rgba8ui-rgba_integer-unsigned_byte.html [ Failure ] webgl/2.0.0/conformance2/textures/image_bitmap_from_image_data/tex-2d-srgb8-rgb-unsigned_byte.html [ Failure ] webgl/2.0.0/conformance2/textures/image_bitmap_from_image_data/tex-2d-srgb8_alpha8-rgba-unsigned_byte.html [ Failure ] webgl/2.0.0/conformance2/textures/image_bitmap_from_image_data/tex-3d-r11f_g11f_b10f-rgb-float.html [ Failure ] webgl/2.0.0/conformance2/textures/image_bitmap_from_image_data/tex-3d-r11f_g11f_b10f-rgb-half_float.html [ Failure ] webgl/2.0.0/conformance2/textures/image_bitmap_from_image_data/tex-3d-r11f_g11f_b10f-rgb-unsigned_int_10f_11f_11f_rev.html [ Failure ] webgl/2.0.0/conformance2/textures/image_bitmap_from_image_data/tex-3d-r16f-red-float.html [ Failure ] webgl/2.0.0/conformance2/textures/image_bitmap_from_image_data/tex-3d-r16f-red-half_float.html [ Failure ] webgl/2.0.0/conformance2/textures/image_bitmap_from_image_data/tex-3d-r32f-red-float.html [ Failure ] webgl/2.0.0/conformance2/textures/image_bitmap_from_image_data/tex-3d-r8-red-unsigned_byte.html [ Failure ] webgl/2.0.0/conformance2/textures/image_bitmap_from_image_data/tex-3d-r8ui-red_integer-unsigned_byte.html [ Failure ] webgl/2.0.0/conformance2/textures/image_bitmap_from_image_data/tex-3d-rg16f-rg-float.html [ Failure ] webgl/2.0.0/conformance2/textures/image_bitmap_from_image_data/tex-3d-rg16f-rg-half_float.html [ Failure ] webgl/2.0.0/conformance2/textures/image_bitmap_from_image_data/tex-3d-rg32f-rg-float.html [ Failure ] webgl/2.0.0/conformance2/textures/image_bitmap_from_image_data/tex-3d-rg8-rg-unsigned_byte.html [ Failure ] webgl/2.0.0/conformance2/textures/image_bitmap_from_image_data/tex-3d-rg8ui-rg_integer-unsigned_byte.html [ Failure ] webgl/2.0.0/conformance2/textures/image_bitmap_from_image_data/tex-3d-rgb16f-rgb-float.html [ Failure ] webgl/2.0.0/conformance2/textures/image_bitmap_from_image_data/tex-3d-rgb16f-rgb-half_float.html [ Failure ] webgl/2.0.0/conformance2/textures/image_bitmap_from_image_data/tex-3d-rgb32f-rgb-float.html [ Failure ] webgl/2.0.0/conformance2/textures/image_bitmap_from_image_data/tex-3d-rgb565-rgb-unsigned_byte.html [ Failure ] webgl/2.0.0/conformance2/textures/image_bitmap_from_image_data/tex-3d-rgb565-rgb-unsigned_short_5_6_5.html [ Failure ] webgl/2.0.0/conformance2/textures/image_bitmap_from_image_data/tex-3d-rgb5_a1-rgba-unsigned_byte.html [ Failure ] webgl/2.0.0/conformance2/textures/image_bitmap_from_image_data/tex-3d-rgb5_a1-rgba-unsigned_short_5_5_5_1.html [ Failure ] webgl/2.0.0/conformance2/textures/image_bitmap_from_image_data/tex-3d-rgb8-rgb-unsigned_byte.html [ Failure ] webgl/2.0.0/conformance2/textures/image_bitmap_from_image_data/tex-3d-rgb8ui-rgb_integer-unsigned_byte.html [ Failure ] webgl/2.0.0/conformance2/textures/image_bitmap_from_image_data/tex-3d-rgb9_e5-rgb-float.html [ Failure ] webgl/2.0.0/conformance2/textures/image_bitmap_from_image_data/tex-3d-rgb9_e5-rgb-half_float.html [ Failure ] webgl/2.0.0/conformance2/textures/image_bitmap_from_image_data/tex-3d-rgba16f-rgba-float.html [ Failure ] webgl/2.0.0/conformance2/textures/image_bitmap_from_image_data/tex-3d-rgba16f-rgba-half_float.html [ Failure ] webgl/2.0.0/conformance2/textures/image_bitmap_from_image_data/tex-3d-rgba32f-rgba-float.html [ Failure ] webgl/2.0.0/conformance2/textures/image_bitmap_from_image_data/tex-3d-rgba4-rgba-unsigned_byte.html [ Failure ] webgl/2.0.0/conformance2/textures/image_bitmap_from_image_data/tex-3d-rgba4-rgba-unsigned_short_4_4_4_4.html [ Failure ] webgl/2.0.0/conformance2/textures/image_bitmap_from_image_data/tex-3d-rgba8-rgba-unsigned_byte.html [ Failure ] webgl/2.0.0/conformance2/textures/image_bitmap_from_image_data/tex-3d-rgba8ui-rgba_integer-unsigned_byte.html [ Failure ] webgl/2.0.0/conformance2/textures/image_bitmap_from_image_data/tex-3d-srgb8-rgb-unsigned_byte.html [ Failure ] webgl/2.0.0/conformance2/textures/image_bitmap_from_image_data/tex-3d-srgb8_alpha8-rgba-unsigned_byte.html [ Failure ] 1759478 1 428438 fujii 2021-05-12 17:35:04 -0700 Created attachment 428438 Patch 1759507 2 428438 sam 2021-05-12 19:49:08 -0700 Comment on attachment 428438 Patch Sorry about that. Thanks for the fix. 1759511 3 fujii 2021-05-12 19:59:19 -0700 Committed r277418 (237668@main): <https://commits.webkit.org/237668@main> 1759512 4 fujii 2021-05-12 19:59:52 -0700 No problem. WinCairo has no testing EWS. Thank you for the review. 1759513 5 webkit-bug-importer 2021-05-12 20:00:16 -0700 <rdar://problem/77948086> 428438 2021-05-12 17:35:04 -0700 2021-05-12 19:49:08 -0700 Patch bug-225725-20210513093503.patch text/plain 2022 fujii U3VidmVyc2lvbiBSZXZpc2lvbjogMjc3Mzg5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMDU1Y2FmODcwZmI1OTZk N2M3MTQ0NTZlZjgyZDA5NmYwMTYyNjUyYS4uMzA1NWNkMmZiOTQ5ZjUzNTdhYWUyMmQ5OTIyZmYy MDJjZTU4YWQ5MiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDIxLTA1LTEyICBGdWpp aSBIaXJvbm9yaSAgPEhpcm9ub3JpLkZ1amlpQHNvbnkuY29tPgorCisgICAgICAgIFtXaW5DYWly b10gU29tZSB3ZWJnbC8yLjAuMC9jb25mb3JtYW5jZS90ZXh0dXJlcy9pbWFnZV9iaXRtYXBfZnJv bV9pbWFnZV9kYXRhIGFyZSBmYWlsaW5nIGFmdGVyIHIyNzczNjkKKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIyNTcyNQorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvUGl4ZWxC dWZmZXJDb252ZXJzaW9uLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OmNvbnZlcnRJbWFnZVBpeGVs cyk6IEZpeGVkIHRoZSB3cm9uZyBjb25maXRpb24gZm9yICFVU0UoQUNDRUxFUkFURSkgY2FzZS4K KwogMjAyMS0wNS0xMiAgU2FpZCBBYm91LUhhbGxhd2EgIDxzYWlkQGFwcGxlLmNvbT4KIAogICAg ICAgICBSZW1vdmluZyB0aGUgdHJhbnNmb3JtIENTUyBwcm9wZXJ0eSBmcm9tIHRoZSBTVkcgZWxl bWVudCBkb2VzIG5vdCBjYXVzZSBpbnZhbGlkYXRpb24KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJD b3JlL3BsYXRmb3JtL2dyYXBoaWNzL1BpeGVsQnVmZmVyQ29udmVyc2lvbi5jcHAgYi9Tb3VyY2Uv V2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9QaXhlbEJ1ZmZlckNvbnZlcnNpb24uY3BwCmluZGV4 IDc2YjZmNmUzYWZiNzc5ZWM1NWQ1ZjEzOTFlNjUxYzg0NjhmOTlmYjcuLmExZTU5NmQ5YjI3MGQ0 YzU1OGExYmZlZWMyOGY0NDAyNWU4YjNjNGEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3Bs YXRmb3JtL2dyYXBoaWNzL1BpeGVsQnVmZmVyQ29udmVyc2lvbi5jcHAKKysrIGIvU291cmNlL1dl YkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvUGl4ZWxCdWZmZXJDb252ZXJzaW9uLmNwcApAQCAtMjA0 LDcgKzIwNCw3IEBAIHZvaWQgY29udmVydEltYWdlUGl4ZWxzKGNvbnN0IENvbnN0UGl4ZWxCdWZm ZXJDb252ZXJzaW9uVmlldyYgc291cmNlLCBjb25zdCBQaXhlCiAgICAgICAgICAgICBlbHNlCiAg ICAgICAgICAgICAgICAgY29udmVydEltYWdlUGl4ZWxzVW5hY2NlbGVyYXRlZDxjb252ZXJ0U2lu Z2xlUGl4ZWxVbnByZW11bHRpcGxpZWRUb1VucHJlbXVsdGlwbGllZDxQaXhlbEZvcm1hdENvbnZl cnNpb246Ok5vbmU+Pihzb3VyY2UsIGRlc3RpbmF0aW9uLCBkZXN0aW5hdGlvblNpemUpOwogICAg ICAgICB9IGVsc2UgewotICAgICAgICAgICAgaWYgKGRlc3RpbmF0aW9uLmFscGhhRm9ybWF0ID09 IEFscGhhUHJlbXVsdGlwbGljYXRpb246OlVucHJlbXVsdGlwbGllZCkKKyAgICAgICAgICAgIGlm IChkZXN0aW5hdGlvbi5hbHBoYUZvcm1hdCA9PSBBbHBoYVByZW11bHRpcGxpY2F0aW9uOjpQcmVt dWx0aXBsaWVkKQogICAgICAgICAgICAgICAgIGNvbnZlcnRJbWFnZVBpeGVsc1VuYWNjZWxlcmF0 ZWQ8Y29udmVydFNpbmdsZVBpeGVsUHJlbXVsdGlwbGllZFRvUHJlbXVsdGlwbGllZDxQaXhlbEZv cm1hdENvbnZlcnNpb246OlBlcm11dGU+Pihzb3VyY2UsIGRlc3RpbmF0aW9uLCBkZXN0aW5hdGlv blNpemUpOwogICAgICAgICAgICAgZWxzZQogICAgICAgICAgICAgICAgIGNvbnZlcnRJbWFnZVBp eGVsc1VuYWNjZWxlcmF0ZWQ8Y29udmVydFNpbmdsZVBpeGVsVW5wcmVtdWx0aXBsaWVkVG9VbnBy ZW11bHRpcGxpZWQ8UGl4ZWxGb3JtYXRDb252ZXJzaW9uOjpQZXJtdXRlPj4oc291cmNlLCBkZXN0 aW5hdGlvbiwgZGVzdGluYXRpb25TaXplKTsK