22572 2008-12-01 14:05:24 -0800 AccessibleBase.cpp should null-check the results of documentFrameView() calls 2008-12-01 14:11:02 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Mac OS X 10.5 RESOLVED FIXED P2 Normal --- 1 eric webkit-unassigned oldest_to_newest 100874 0 eric 2008-12-01 14:05:24 -0800 AccessibleBase.cpp should null-check the results of documentFrameView() calls Calling accLocation() when documentFrameView() could return NULL was the cause of the current #1 crasher in Chromium renderer processes. I don't expect this crash may even be possible in Win Safari. But given that documentFrameView() clearly can return null (see implementation) it makes sense IMO to add these preventative checks. In our tree we've fixed the crash by checking mainFrame()->frameView() before ever calling this AX code. It's possible this code is causing crashes for win safari like it was for Chrome, I don't have access to any win safari crash logs to confirm or deny. 100875 1 25636 eric 2008-12-01 14:06:21 -0800 Created attachment 25636 Add preventative NULL-check to AX calls WebKit/win/AccessibleBase.cpp | 7 +++++-- WebKit/win/ChangeLog | 19 +++++++++++++++++++ 2 files changed, 24 insertions(+), 2 deletions(-) 100876 2 eric 2008-12-01 14:06:35 -0800 Adam Roben reviewed over irc. Landing... 100877 3 eric 2008-12-01 14:11:02 -0800 Committing to http://svn.webkit.org/repository/webkit/trunk ... M WebKit/win/AccessibleBase.cpp M WebKit/win/ChangeLog Committed r38873 25636 2008-12-01 14:06:21 -0800 2008-12-01 14:07:15 -0800 Add preventative NULL-check to AX calls Add-preventative-NULL-check-to-AX-calls.patch text/plain 2307 eric OWI4YmQzZjRhMTM1YTlhNTQ3Nzg1NzA1OTFmZGRmMjc0MmIyNWQ0NgpkaWZmIC0tZ2l0IGEvV2Vi S2l0L3dpbi9BY2Nlc3NpYmxlQmFzZS5jcHAgYi9XZWJLaXQvd2luL0FjY2Vzc2libGVCYXNlLmNw cAppbmRleCBmZGY5NDA0Li5kZjkxMTUxIDEwMDY0NAotLS0gYS9XZWJLaXQvd2luL0FjY2Vzc2li bGVCYXNlLmNwcAorKysgYi9XZWJLaXQvd2luL0FjY2Vzc2libGVCYXNlLmNwcApAQCAtMTAyLDcg KzEwMiw3IEBAIEhSRVNVTFQgU1RETUVUSE9EQ0FMTFRZUEUgQWNjZXNzaWJsZUJhc2U6OmdldF9h Y2NQYXJlbnQoSURpc3BhdGNoKiogcGFyZW50KQogewogICAgICpwYXJlbnQgPSAwOwogCi0gICAg aWYgKCFtX29iamVjdCkKKyAgICBpZiAoIW1fb2JqZWN0IHx8ICFtX29iamVjdC0+dG9wRG9jdW1l bnRGcmFtZVZpZXcoKSkKICAgICAgICAgcmV0dXJuIEVfRkFJTDsKIAogICAgIHJldHVybiBXZWJW aWV3OjpBY2Nlc3NpYmxlT2JqZWN0RnJvbVdpbmRvdyhtX29iamVjdC0+dG9wRG9jdW1lbnRGcmFt ZVZpZXcoKS0+aG9zdFdpbmRvdygpLT5wbGF0Zm9ybVdpbmRvdygpLApAQCAtMzkzLDYgKzM5Myw5 IEBAIEhSRVNVTFQgU1RETUVUSE9EQ0FMTFRZUEUgQWNjZXNzaWJsZUJhc2U6OmFjY0xvY2F0aW9u KGxvbmcqIGxlZnQsIGxvbmcqIHRvcCwgbG9uCiAgICAgaWYgKEZBSUxFRChocikpCiAgICAgICAg IHJldHVybiBocjsKIAorICAgIGlmICghY2hpbGRPYmotPmRvY3VtZW50RnJhbWVWaWV3KCkpCisg ICAgICAgIHJldHVybiBFX0ZBSUw7CisKICAgICBJbnRSZWN0IHNjcmVlblJlY3QoY2hpbGRPYmot PmRvY3VtZW50RnJhbWVWaWV3KCktPmNvbnRlbnRzVG9TY3JlZW4oY2hpbGRPYmotPmJvdW5kaW5n Qm94UmVjdCgpKSk7CiAgICAgKmxlZnQgPSBzY3JlZW5SZWN0LngoKTsKICAgICAqdG9wID0gc2Ny ZWVuUmVjdC55KCk7CkBAIC00NjUsNyArNDY4LDcgQEAgSFJFU1VMVCBTVERNRVRIT0RDQUxMVFlQ RSBBY2Nlc3NpYmxlQmFzZTo6YWNjSGl0VGVzdChsb25nIHgsIGxvbmcgeSwgVkFSSUFOVCogcHYK IAogICAgIDo6VmFyaWFudEluaXQocHZDaGlsZEF0UG9pbnQpOwogCi0gICAgaWYgKCFtX29iamVj dCkKKyAgICBpZiAoIW1fb2JqZWN0IHx8ICFtX29iamVjdC0+ZG9jdW1lbnRGcmFtZVZpZXcoKSkK ICAgICAgICAgcmV0dXJuIEVfRkFJTDsKIAogICAgIEludFBvaW50IHBvaW50ID0gbV9vYmplY3Qt PmRvY3VtZW50RnJhbWVWaWV3KCktPnNjcmVlblRvQ29udGVudHMoSW50UG9pbnQoeCwgeSkpOwpk aWZmIC0tZ2l0IGEvV2ViS2l0L3dpbi9DaGFuZ2VMb2cgYi9XZWJLaXQvd2luL0NoYW5nZUxvZwpp bmRleCA4ZWVjN2JmLi4xNDc4NjE3IDEwMDY0NAotLS0gYS9XZWJLaXQvd2luL0NoYW5nZUxvZwor KysgYi9XZWJLaXQvd2luL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIyIEBACisyMDA4LTEyLTAxICBF cmljIFNlaWRlbCAgPGVyaWNAd2Via2l0Lm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBOVUxMLWNoZWNrIGRvY3VtZW50RnJhbWVWaWV3KCkgYW5k IHRvcERvY3VtZW50RnJhbWVWaWV3KCkKKworICAgICAgICBDYWxsaW5nIGFjY0xvY2F0aW9uKCkg d2hlbiBkb2N1bWVudEZyYW1lVmlldygpIGNvdWxkIHJldHVybiBOVUxMIHdhcyB0aGUKKyAgICAg ICAgY2F1c2Ugb2YgdGhlIGN1cnJlbnQgIzEgY3Jhc2hlciBpbiBDaHJvbWl1bSByZW5kZXJlciBw cm9jZXNzZXMuCisgICAgICAgIEkgZG9uJ3QgZXhwZWN0IHRoaXMgY3Jhc2ggbWF5IGV2ZW4gYmUg cG9zc2libGUgaW4gV2luIFNhZmFyaS4gIEJ1dCBnaXZlbgorICAgICAgICB0aGF0IGRvY3VtZW50 RnJhbWVWaWV3KCkgY2xlYXJseSBjYW4gcmV0dXJuIG51bGwgKHNlZSBpbXBsZW1lbnRhdGlvbikK KyAgICAgICAgaXQgbWFrZXMgc2Vuc2UgSU1PIHRvIGFkZCB0aGVzZSBwcmV2ZW50YXRpdmUgY2hl Y2tzLgorICAgICAgICBJbiBvdXIgdHJlZSB3ZSd2ZSBmaXhlZCB0aGUgY3Jhc2ggYnkgY2hlY2tp bmcgbWFpbkZyYW1lKCktPmZyYW1lVmlldygpCisgICAgICAgIGJlZm9yZSBldmVyIGNhbGxpbmcg dGhpcyBBWCBjb2RlLgorCisgICAgICAgICogQWNjZXNzaWJsZUJhc2UuY3BwOgorICAgICAgICAo QWNjZXNzaWJsZUJhc2U6OmdldF9hY2NQYXJlbnQpOgorICAgICAgICAoQWNjZXNzaWJsZUJhc2U6 OmFjY0xvY2F0aW9uKToKKyAgICAgICAgKEFjY2Vzc2libGVCYXNlOjphY2NIaXRUZXN0KToKKwog MjAwOC0xMS0zMCAgQW50dGkgS29pdmlzdG8gIDxhbnR0aUBhcHBsZS5jb20+CiAKICAgICAgICAg QW5vdGhlciBXaW5kb3dzIGJ1aWxkIGZpeC4K