225708 2021-05-12 11:54:51 -0700 Remove inline annoatations for static functions in PixelBufferConversion 2021-05-12 13:12:16 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 sam sam darin webkit-bug-importer oldest_to_newest 1759336 0 sam 2021-05-12 11:54:51 -0700 Remove inline annoatations for static functions in PixelBufferConversion 1759339 1 428398 sam 2021-05-12 12:04:28 -0700 Created attachment 428398 Patch 1759347 2 428398 darin 2021-05-12 12:12:12 -0700 Comment on attachment 428398 Patch Please note that I did not say that I’m *sure* inline is *never* a useful compiler hint. But I do think this is the right thing to do here. 1759368 3 ews-feeder 2021-05-12 13:11:29 -0700 Committed r277384 (237640@main): <https://commits.webkit.org/237640@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 428398. 1759369 4 webkit-bug-importer 2021-05-12 13:12:16 -0700 <rdar://problem/77927531> 428398 2021-05-12 12:04:28 -0700 2021-05-12 13:11:29 -0700 Patch bug-225708-20210512120427.patch text/plain 5104 sam SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDI3NzM4MikKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDI0IEBACisyMDIxLTA1LTEyICBTYW0gV2Vp bmlnICA8d2VpbmlnQGFwcGxlLmNvbT4KKworICAgICAgICBSZW1vdmUgaW5saW5lIGFubm9hdGF0 aW9ucyBmb3Igc3RhdGljIGZ1bmN0aW9ucyBpbiBQaXhlbEJ1ZmZlckNvbnZlcnNpb24KKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIyNTcwOAorCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFJlbW92ZSBpbmxpbmUg YW5ub2F0YXRpb25zIGZvciBzdGF0aWMgZnVuY3Rpb25zIGluIFBpeGVsQnVmZmVyQ29udmVyc2lv bgorICAgICAgICBhcyBzdWdnZXN0ZWQgYnkgRGFyaW4uIFRoZSB0aGVvcnkgaGVyZSBpcyB0aGF0 IG91dHNpZGUgb2YgYSBoZWFkZXIsIHRoZQorICAgICAgICB1c2Ugb2YgJ2lubGluZScgc2VydmVz IG5vIHB1cnBvc2UgYXMgdGhlIGNvbXBpbGVyIGlzIHBlcmZlY3RseSBhbGxvd2VkIAorICAgICAg ICBhbmQgY2FwYWJsZSBvZiBpbmxpbmluZyB0aGVzZSBmdW5jdGlvbnMuCisKKyAgICAgICAgKiBw bGF0Zm9ybS9ncmFwaGljcy9QaXhlbEJ1ZmZlckNvbnZlcnNpb24uY3BwOgorICAgICAgICAoV2Vi Q29yZTo6bWFrZVZJbWFnZUJ1ZmZlcik6CisgICAgICAgIChXZWJDb3JlOjpjb252ZXJ0SW1hZ2VQ aXhlbHNBY2NlbGVyYXRlZCk6CisgICAgICAgIChXZWJDb3JlOjpjb252ZXJ0U2luZ2xlUGl4ZWxQ cmVtdWx0aXBsaWVkVG9QcmVtdWx0aXBsaWVkKToKKyAgICAgICAgKFdlYkNvcmU6OmNvbnZlcnRT aW5nbGVQaXhlbFByZW11bHRpcGxpZWRUb1VucHJlbXVsdGlwbGllZCk6CisgICAgICAgIChXZWJD b3JlOjpjb252ZXJ0U2luZ2xlUGl4ZWxVbnByZW11bHRpcGxpZWRUb1ByZW11bHRpcGxpZWQpOgor ICAgICAgICAoV2ViQ29yZTo6Y29udmVydFNpbmdsZVBpeGVsVW5wcmVtdWx0aXBsaWVkVG9VbnBy ZW11bHRpcGxpZWQpOgorICAgICAgICAoV2ViQ29yZTo6Y29udmVydEZ1bmN0b3IpOgorCiAyMDIx LTA1LTEyICBBbGV4IENocmlzdGVuc2VuICA8YWNocmlzdGVuc2VuQHdlYmtpdC5vcmc+CiAKICAg ICAgICAgVXNlIEhhc2hTZXQ8UmVmUHRyPE5vZGU+PiBpbnN0ZWFkIG9mIEhhc2hTZXQ8Tm9kZSo+ CkluZGV4OiBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9QaXhlbEJ1ZmZlckNvbnZl cnNpb24uY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNz L1BpeGVsQnVmZmVyQ29udmVyc2lvbi5jcHAJKHJldmlzaW9uIDI3NzM3MSkKKysrIFNvdXJjZS9X ZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL1BpeGVsQnVmZmVyQ29udmVyc2lvbi5jcHAJKHdvcmtp bmcgY29weSkKQEAgLTM5LDcgKzM5LDcgQEAgbmFtZXNwYWNlIFdlYkNvcmUgewogCiAjaWYgVVNF KEFDQ0VMRVJBVEUpCiAKLXRlbXBsYXRlPHR5cGVuYW1lIFZpZXc+IHN0YXRpYyBpbmxpbmUgdklt YWdlX0J1ZmZlciBtYWtlVkltYWdlQnVmZmVyKGNvbnN0IFZpZXcmIHZpZXcsIGNvbnN0IEludFNp emUmIHNpemUpCit0ZW1wbGF0ZTx0eXBlbmFtZSBWaWV3PiBzdGF0aWMgdkltYWdlX0J1ZmZlciBt YWtlVkltYWdlQnVmZmVyKGNvbnN0IFZpZXcmIHZpZXcsIGNvbnN0IEludFNpemUmIHNpemUpCiB7 CiAgICAgdkltYWdlX0J1ZmZlciB2SW1hZ2VCdWZmZXI7CiAKQEAgLTUxLDcgKzUxLDcgQEAgdGVt cGxhdGU8dHlwZW5hbWUgVmlldz4gc3RhdGljIGlubGluZSB2SQogICAgIHJldHVybiB2SW1hZ2VC dWZmZXI7CiB9CiAKLXN0YXRpYyBpbmxpbmUgdm9pZCBjb252ZXJ0SW1hZ2VQaXhlbHNBY2NlbGVy YXRlZChjb25zdCBDb25zdFBpeGVsQnVmZmVyQ29udmVyc2lvblZpZXcmIHNvdXJjZSwgY29uc3Qg UGl4ZWxCdWZmZXJDb252ZXJzaW9uVmlldyYgZGVzdGluYXRpb24sIGNvbnN0IEludFNpemUmIGRl c3RpbmF0aW9uU2l6ZSkKK3N0YXRpYyB2b2lkIGNvbnZlcnRJbWFnZVBpeGVsc0FjY2VsZXJhdGVk KGNvbnN0IENvbnN0UGl4ZWxCdWZmZXJDb252ZXJzaW9uVmlldyYgc291cmNlLCBjb25zdCBQaXhl bEJ1ZmZlckNvbnZlcnNpb25WaWV3JiBkZXN0aW5hdGlvbiwgY29uc3QgSW50U2l6ZSYgZGVzdGlu YXRpb25TaXplKQogewogICAgIGF1dG8gc291cmNlVkltYWdlQnVmZmVyID0gbWFrZVZJbWFnZUJ1 ZmZlcihzb3VyY2UsIGRlc3RpbmF0aW9uU2l6ZSk7CiAgICAgYXV0byBkZXN0aW5hdGlvblZJbWFn ZUJ1ZmZlciA9IG1ha2VWSW1hZ2VCdWZmZXIoZGVzdGluYXRpb24sIGRlc3RpbmF0aW9uU2l6ZSk7 CkBAIC03OCwxMiArNzgsMTMgQEAgc3RhdGljIGlubGluZSB2b2lkIGNvbnZlcnRJbWFnZVBpeGVs c0FjYwogICAgICAgICB2SW1hZ2VQZXJtdXRlQ2hhbm5lbHNfQVJHQjg4ODgoJnNvdXJjZVZJbWFn ZUJ1ZmZlciwgJmRlc3RpbmF0aW9uVkltYWdlQnVmZmVyLCBtYXAsIGt2SW1hZ2VOb0ZsYWdzKTsK ICAgICB9CiB9CisKICNlbmRpZgogCiBlbnVtIGNsYXNzIFBpeGVsRm9ybWF0Q29udmVyc2lvbiB7 IE5vbmUsIFBlcm11dGUgfTsKIAogdGVtcGxhdGU8UGl4ZWxGb3JtYXRDb252ZXJzaW9uIHBpeGVs Rm9ybWF0Q29udmVyc2lvbj4KLXN0YXRpYyBpbmxpbmUgdm9pZCBjb252ZXJ0U2luZ2xlUGl4ZWxQ cmVtdWx0aXBsaWVkVG9QcmVtdWx0aXBsaWVkKGNvbnN0IHVpbnQ4X3QqIHNvdXJjZVBpeGVsLCB1 aW50OF90KiBkZXN0aW5hdGlvblBpeGVsKQorc3RhdGljIHZvaWQgY29udmVydFNpbmdsZVBpeGVs UHJlbXVsdGlwbGllZFRvUHJlbXVsdGlwbGllZChjb25zdCB1aW50OF90KiBzb3VyY2VQaXhlbCwg dWludDhfdCogZGVzdGluYXRpb25QaXhlbCkKIHsKICAgICB1aW50OF90IGFscGhhID0gc291cmNl UGl4ZWxbM107CiAgICAgaWYgKCFhbHBoYSkgewpAQCAtMTAzLDcgKzEwNCw3IEBAIHN0YXRpYyBp bmxpbmUgdm9pZCBjb252ZXJ0U2luZ2xlUGl4ZWxQcmUKIH0KIAogdGVtcGxhdGU8UGl4ZWxGb3Jt YXRDb252ZXJzaW9uIHBpeGVsRm9ybWF0Q29udmVyc2lvbj4KLXN0YXRpYyBpbmxpbmUgdm9pZCBj b252ZXJ0U2luZ2xlUGl4ZWxQcmVtdWx0aXBsaWVkVG9VbnByZW11bHRpcGxpZWQoY29uc3QgdWlu dDhfdCogc291cmNlUGl4ZWwsIHVpbnQ4X3QqIGRlc3RpbmF0aW9uUGl4ZWwpCitzdGF0aWMgdm9p ZCBjb252ZXJ0U2luZ2xlUGl4ZWxQcmVtdWx0aXBsaWVkVG9VbnByZW11bHRpcGxpZWQoY29uc3Qg dWludDhfdCogc291cmNlUGl4ZWwsIHVpbnQ4X3QqIGRlc3RpbmF0aW9uUGl4ZWwpCiB7CiAgICAg dWludDhfdCBhbHBoYSA9IHNvdXJjZVBpeGVsWzNdOwogICAgIGlmICghYWxwaGEgfHwgYWxwaGEg PT0gMjU1KSB7CkBAIC0xMjYsNyArMTI3LDcgQEAgc3RhdGljIGlubGluZSB2b2lkIGNvbnZlcnRT aW5nbGVQaXhlbFByZQogfQogCiB0ZW1wbGF0ZTxQaXhlbEZvcm1hdENvbnZlcnNpb24gcGl4ZWxG b3JtYXRDb252ZXJzaW9uPgotc3RhdGljIGlubGluZSB2b2lkIGNvbnZlcnRTaW5nbGVQaXhlbFVu cHJlbXVsdGlwbGllZFRvUHJlbXVsdGlwbGllZChjb25zdCB1aW50OF90KiBzb3VyY2VQaXhlbCwg dWludDhfdCogZGVzdGluYXRpb25QaXhlbCkKK3N0YXRpYyB2b2lkIGNvbnZlcnRTaW5nbGVQaXhl bFVucHJlbXVsdGlwbGllZFRvUHJlbXVsdGlwbGllZChjb25zdCB1aW50OF90KiBzb3VyY2VQaXhl bCwgdWludDhfdCogZGVzdGluYXRpb25QaXhlbCkKIHsKICAgICB1aW50OF90IGFscGhhID0gc291 cmNlUGl4ZWxbM107CiAgICAgaWYgKCFhbHBoYSB8fCBhbHBoYSA9PSAyNTUpIHsKQEAgLTE0OSw3 ICsxNTAsNyBAQCBzdGF0aWMgaW5saW5lIHZvaWQgY29udmVydFNpbmdsZVBpeGVsVW5wCiB9CiAK IHRlbXBsYXRlPFBpeGVsRm9ybWF0Q29udmVyc2lvbiBwaXhlbEZvcm1hdENvbnZlcnNpb24+Ci1z dGF0aWMgaW5saW5lIHZvaWQgY29udmVydFNpbmdsZVBpeGVsVW5wcmVtdWx0aXBsaWVkVG9VbnBy ZW11bHRpcGxpZWQoY29uc3QgdWludDhfdCogc291cmNlUGl4ZWwsIHVpbnQ4X3QqIGRlc3RpbmF0 aW9uUGl4ZWwpCitzdGF0aWMgdm9pZCBjb252ZXJ0U2luZ2xlUGl4ZWxVbnByZW11bHRpcGxpZWRU b1VucHJlbXVsdGlwbGllZChjb25zdCB1aW50OF90KiBzb3VyY2VQaXhlbCwgdWludDhfdCogZGVz dGluYXRpb25QaXhlbCkKIHsKICAgICBpZiBjb25zdGV4cHIgKHBpeGVsRm9ybWF0Q29udmVyc2lv biA9PSBQaXhlbEZvcm1hdENvbnZlcnNpb246Ok5vbmUpCiAgICAgICAgIHJlaW50ZXJwcmV0X2Nh c3Q8dWludDMyX3QqPihkZXN0aW5hdGlvblBpeGVsKVswXSA9IHJlaW50ZXJwcmV0X2Nhc3Q8Y29u c3QgdWludDMyX3QqPihzb3VyY2VQaXhlbClbMF07CkBAIC0xNjMsNyArMTY0LDcgQEAgc3RhdGlj IGlubGluZSB2b2lkIGNvbnZlcnRTaW5nbGVQaXhlbFVucAogfQogCiB0ZW1wbGF0ZTx2b2lkICgq Y29udmVydEZ1bmN0b3IpKGNvbnN0IHVpbnQ4X3QqLCB1aW50OF90Kik+Ci1zdGF0aWMgaW5saW5l IHZvaWQgY29udmVydEltYWdlUGl4ZWxzVW5hY2NlbGVyYXRlZChjb25zdCBDb25zdFBpeGVsQnVm ZmVyQ29udmVyc2lvblZpZXcmIHNvdXJjZSwgY29uc3QgUGl4ZWxCdWZmZXJDb252ZXJzaW9uVmll dyYgZGVzdGluYXRpb24sIGNvbnN0IEludFNpemUmIGRlc3RpbmF0aW9uU2l6ZSkKK3N0YXRpYyB2 b2lkIGNvbnZlcnRJbWFnZVBpeGVsc1VuYWNjZWxlcmF0ZWQoY29uc3QgQ29uc3RQaXhlbEJ1ZmZl ckNvbnZlcnNpb25WaWV3JiBzb3VyY2UsIGNvbnN0IFBpeGVsQnVmZmVyQ29udmVyc2lvblZpZXcm IGRlc3RpbmF0aW9uLCBjb25zdCBJbnRTaXplJiBkZXN0aW5hdGlvblNpemUpCiB7CiAgICAgY29u c3QgdWludDhfdCogc291cmNlUm93cyA9IHNvdXJjZS5yb3dzOwogICAgIHVpbnQ4X3QqIGRlc3Rp bmF0aW9uUm93cyA9IGRlc3RpbmF0aW9uLnJvd3M7Cg==