225703 2021-05-12 10:56:44 -0700 [TestWebKitAPI] Explicitly exit after completing tests 2021-05-12 14:11:18 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 jbedard jbedard aakash_jain ap darin dewei_zhu hi ryanhaddad webkit-bug-importer oldest_to_newest 1759298 0 jbedard 2021-05-12 10:56:44 -0700 Our API tests run in a non-standard way. We can't rely on the system to exit the process cleanly or immediately after returning from main because iOS does not ordinarily support command line programs. 1759300 1 jbedard 2021-05-12 10:57:08 -0700 <rdar://problem/77673980> 1759304 2 428385 jbedard 2021-05-12 11:01:06 -0700 Created attachment 428385 Patch 1759315 3 428385 ap 2021-05-12 11:27:43 -0700 Comment on attachment 428385 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=428385&action=review > Tools/TestWebKitAPI/ios/mainIOS.mm:56 > - return passed ? EXIT_SUCCESS : EXIT_FAILURE; > + exit(passed ? EXIT_SUCCESS : EXIT_FAILURE); If this works, it works, but please add a comment linking to a radar that tracks investigating the root cause here. 1759338 4 428397 jbedard 2021-05-12 12:04:17 -0700 Created attachment 428397 Patch 1759384 5 ews-feeder 2021-05-12 13:40:58 -0700 Committed r277387 (237643@main): <https://commits.webkit.org/237643@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 428397. 1759401 6 428397 darin 2021-05-12 14:11:18 -0700 Comment on attachment 428397 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=428397&action=review > Tools/TestWebKitAPI/ios/mainIOS.mm:56 > + // FIXME: Work-around for <rdar://problem/77922262> I understand that Alexey requested a comment. And a comment is good. However, we do not need a FIXME. We can use exit() forever and need never go back to using return here. The comment can help us remember not to change the code back! 428385 2021-05-12 11:01:06 -0700 2021-05-12 12:04:15 -0700 Patch bug-225703-20210512110105.patch text/plain 1117 jbedard SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDI3NzM3NykKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE0IEBACisyMDIxLTA1LTEyICBKb25hdGhhbiBCZWRhcmQgIDxqYmVkYXJkQGFwcGxlLmNv bT4KKworICAgICAgICBbVGVzdFdlYktpdEFQSV0gRXhwbGljaXRseSBleGl0IGFmdGVyIGNvbXBs ZXRpbmcgdGVzdHMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTIyNTcwMworICAgICAgICA8cmRhcjovL3Byb2JsZW0vNzc2NzM5ODA+CisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBUZXN0V2ViS2l0QVBJL2lv cy9tYWluSU9TLm1tOgorICAgICAgICAobWFpbik6IEV4cGxpY2l0bHkgZXhpdCB0aGUgdGVzdGlu ZyBwcm9jZXNzLgorCiAyMDIxLTA1LTEyICBDaHJpcyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+ CiAKICAgICAgICAgUXVldWUgbm90aWZpY2F0aW9uIHBlcm1pc3Npb24gcmVxdWVzdHMgZm9yIHRo ZSBzYW1lIG9yaWdpbiBvbiBXZWJLaXQgc2lkZQpJbmRleDogVG9vbHMvVGVzdFdlYktpdEFQSS9p b3MvbWFpbklPUy5tbQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9UZXN0V2ViS2l0QVBJL2lvcy9tYWlu SU9TLm1tCShyZXZpc2lvbiAyNzczMzcpCisrKyBUb29scy9UZXN0V2ViS2l0QVBJL2lvcy9tYWlu SU9TLm1tCSh3b3JraW5nIGNvcHkpCkBAIC01Myw1ICs1Myw1IEBAIGludCBtYWluKGludCBhcmdj LCBjaGFyKiogYXJndikKICAgICAgICAgcGFzc2VkID0gVGVzdFdlYktpdEFQSTo6VGVzdHNDb250 cm9sbGVyOjpzaW5nbGV0b24oKS5ydW4oYXJnYywgYXJndik7CiAgICAgfQogCi0gICAgcmV0dXJu IHBhc3NlZCA/IEVYSVRfU1VDQ0VTUyA6IEVYSVRfRkFJTFVSRTsKKyAgICBleGl0KHBhc3NlZCA/ IEVYSVRfU1VDQ0VTUyA6IEVYSVRfRkFJTFVSRSk7CiB9Cg== 428397 2021-05-12 12:04:17 -0700 2021-05-12 13:40:59 -0700 Patch bug-225703-20210512120416.patch text/plain 1179 jbedard SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDI3NzM3NykKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE0IEBACisyMDIxLTA1LTEyICBKb25hdGhhbiBCZWRhcmQgIDxqYmVkYXJkQGFwcGxlLmNv bT4KKworICAgICAgICBbVGVzdFdlYktpdEFQSV0gRXhwbGljaXRseSBleGl0IGFmdGVyIGNvbXBs ZXRpbmcgdGVzdHMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTIyNTcwMworICAgICAgICA8cmRhcjovL3Byb2JsZW0vNzc2NzM5ODA+CisKKyAgICAgICAg UmV2aWV3ZWQgYnkgQWxleGV5IFByb3NrdXJ5YWtvdi4KKworICAgICAgICAqIFRlc3RXZWJLaXRB UEkvaW9zL21haW5JT1MubW06CisgICAgICAgIChtYWluKTogRXhwbGljaXRseSBleGl0IHRoZSB0 ZXN0aW5nIHByb2Nlc3MuCisKIDIwMjEtMDUtMTIgIENocmlzIER1bWV6ICA8Y2R1bWV6QGFwcGxl LmNvbT4KIAogICAgICAgICBRdWV1ZSBub3RpZmljYXRpb24gcGVybWlzc2lvbiByZXF1ZXN0cyBm b3IgdGhlIHNhbWUgb3JpZ2luIG9uIFdlYktpdCBzaWRlCkluZGV4OiBUb29scy9UZXN0V2ViS2l0 QVBJL2lvcy9tYWluSU9TLm1tCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFRvb2xzL1Rlc3RXZWJLaXRBUEkvaW9z L21haW5JT1MubW0JKHJldmlzaW9uIDI3NzMzNykKKysrIFRvb2xzL1Rlc3RXZWJLaXRBUEkvaW9z L21haW5JT1MubW0JKHdvcmtpbmcgY29weSkKQEAgLTUzLDUgKzUzLDYgQEAgaW50IG1haW4oaW50 IGFyZ2MsIGNoYXIqKiBhcmd2KQogICAgICAgICBwYXNzZWQgPSBUZXN0V2ViS2l0QVBJOjpUZXN0 c0NvbnRyb2xsZXI6OnNpbmdsZXRvbigpLnJ1bihhcmdjLCBhcmd2KTsKICAgICB9CiAKLSAgICBy ZXR1cm4gcGFzc2VkID8gRVhJVF9TVUNDRVNTIDogRVhJVF9GQUlMVVJFOworICAgIC8vIEZJWE1F OiBXb3JrLWFyb3VuZCBmb3IgPHJkYXI6Ly9wcm9ibGVtLzc3OTIyMjYyPgorICAgIGV4aXQocGFz c2VkID8gRVhJVF9TVUNDRVNTIDogRVhJVF9GQUlMVVJFKTsKIH0K