225700 2021-05-12 09:02:24 -0700 HTMLMediaElement::mediaLoadingFailedFatally() does direct dispatch of events; should schedule 2021-05-13 20:27:46 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=225797 InRadar P2 Normal --- 1 jer.noble jer.noble calvaris cdumez changseok darin eric.carlson esprehn+autocc ews-watchlist glenn gyuyoung.kim jean-yves.avenard peng.liu6 philipj rniwa sergio sojulibra oldest_to_newest 1759264 0 jer.noble 2021-05-12 09:02:24 -0700 HTMLMediaElement::mediaLoadingFailedFatally() does direct dispatch of events; should schedule 1759265 1 jer.noble 2021-05-12 09:03:05 -0700 <rdar://75576322> 1759267 2 428376 jer.noble 2021-05-12 09:08:21 -0700 Created attachment 428376 Patch 1759268 3 428377 jer.noble 2021-05-12 09:19:12 -0700 Created attachment 428377 Patch 1759303 4 ews-feeder 2021-05-12 11:00:31 -0700 Committed r277379 (237635@main): <https://commits.webkit.org/237635@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 428377. 1759525 5 428377 darin 2021-05-12 20:50:07 -0700 Comment on attachment 428377 Patch Seems like we could make this more foolproof if we set some kind of "event dispatch forbidden" or "JavaScript forbidden" state somewhere so we can spot mistakes like this instantly with test failures without more sophisticated testing. 1759542 6 rniwa 2021-05-12 22:02:07 -0700 (In reply to Darin Adler from comment #5) > Comment on attachment 428377 [details] > Patch > > Seems like we could make this more foolproof if we set some kind of "event > dispatch forbidden" or "JavaScript forbidden" state somewhere so we can spot > mistakes like this instantly with test failures without more sophisticated > testing. Yeah, we should probably do that in a separate bug since we want to keep this fix small enough to merge into a branch. 1759719 7 darin 2021-05-13 09:58:33 -0700 (In reply to Ryosuke Niwa from comment #6) > Yeah, we should probably do that in a separate bug since we want to keep > this fix small enough to merge into a branch. Of course! This bug is already fixed. 428376 2021-05-12 09:08:21 -0700 2021-05-12 09:25:15 -0700 Patch bug-225700-20210512090820.patch text/plain 2065 jer.noble U3VidmVyc2lvbiBSZXZpc2lvbjogMjc3MjgxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYjQxMGU3MmM1ZGNhZjQx N2M3MTQ0ODkzMDBhNmIyMGM4MjM2MzdmNS4uM2IzY2VmNWE4MjUwZmEzOTZlZjQ4NDY2NGE4YTA2 MjA0ZDFlNTg4NSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDIxLTA1LTEyICBKZXIg Tm9ibGUgIDxqZXIubm9ibGVAYXBwbGUuY29tPgorCisgICAgICAgIEhUTUxNZWRpYUVsZW1lbnQ6 Om1lZGlhTG9hZGluZ0ZhaWxlZEZhdGFsbHkoKSBkb2VzIGRpcmVjdCBkaXNwYXRjaCBvZiBldmVu dHM7IHNob3VsZCBlbnF1ZXVlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD0yMjU3MDAKKyAgICAgICAgPHJkYXI6Ly83NTU3NjMyMj4KKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBJbiByMjc0NTU5LCBhbiB1cGRh dGUgd2FzIG1hZGUgdG8gbWVkaWFMb2FkaW5nRmFpbGVkRmF0YWxseSB0byBhZG9wdCByZWNlbnQg c3BlYyBjaGFuZ2VzLCBhbmQgYXMKKyAgICAgICAgcGFydCBvZiB0aGF0IGNoYW5nZSwgYW4gImVy cm9yIiBldmVudCB3YXMgY2hhbmdlZCBmcm9tIGJlaW5nIGVucXVldWVkIHRvIGJlaW5nIGRpcmVj dGx5IGRpc3BhdGNoZWQuCisgICAgICAgIEhvd2V2ZXIsIGRpcmVjdGx5IGRpc3BhdGNoaW5nIGV2 ZW50cyBleHBvc2VzIHRoZSBlbGVtZW50IHRvIEpTIGFuZCBoYXMgdGhlIHBvdGVudGlhbCB0byBj YXVzZSB0aGUKKyAgICAgICAgZWxlbWVudCB0byBiZSBnYXJiYWdlIGNvbGxlY3RlZCwgZGVsZXRp bmcgdGhlIG9iamVjdCBhbmQgcG90ZW50aWFsbHkgb3RoZXIgb2JqZWN0cyBpbiB0aGUgYmFja3Ry YWNlLgorICAgICAgICBFdmVudHMgc2hvdWxkIGFsd2F5cyBiZSBlbnF1ZXVlZCwgcmF0aGVyIHRo YW4gZGlyZWN0eSBkaXNwYXRjaGVkLCBmb3IgdGhpcyByZWFzb24uCisKKyAgICAgICAgKiBodG1s L0hUTUxNZWRpYUVsZW1lbnQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6SFRNTE1lZGlhRWxlbWVu dDo6bWVkaWFMb2FkaW5nRmFpbGVkRmF0YWxseSk6CisKIDIwMjEtMDUtMDQgIEplciBOb2JsZSAg PGplci5ub2JsZUBhcHBsZS5jb20+CiAKICAgICAgICAgW01lZGlhIGluIEdQVSBQcm9jZXNzXSBN b3ZlIEF1ZGlvU2Vzc2lvblJvdXRpbmdBcmJpdHJhdG9yUHJveHkgdG8gdGhlIEdQVSBwcm9jZXNz CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxNZWRpYUVsZW1lbnQuY3BwIGIv U291cmNlL1dlYkNvcmUvaHRtbC9IVE1MTWVkaWFFbGVtZW50LmNwcAppbmRleCAxODFkYWI0Nzg5 ZmVhYzkzYTJhMDZlZThkYjU5MTg4NWE1YjM2MjBkLi44NzYwYzljN2ZhNTI2MDJhM2QzYzVkNDk2 YTYyNDI5MDU5YjY2MmViIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxNZWRp YUVsZW1lbnQuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTE1lZGlhRWxlbWVudC5j cHAKQEAgLTIxNDMsNyArMjE0Myw3IEBAIHZvaWQgSFRNTE1lZGlhRWxlbWVudDo6bWVkaWFMb2Fk aW5nRmFpbGVkRmF0YWxseShNZWRpYVBsYXllcjo6TmV0d29ya1N0YXRlIGVycm9yCiAgICAgc2V0 U2hvdWxkRGVsYXlMb2FkRXZlbnQoZmFsc2UpOwogCiAgICAgLy8gNSAtIEZpcmUgYW4gZXZlbnQg bmFtZWQgZXJyb3IgYXQgdGhlIG1lZGlhIGVsZW1lbnQuCi0gICAgZGlzcGF0Y2hFdmVudChFdmVu dDo6Y3JlYXRlKGV2ZW50TmFtZXMoKS5lcnJvckV2ZW50LCBFdmVudDo6Q2FuQnViYmxlOjpObywg RXZlbnQ6OklzQ2FuY2VsYWJsZTo6Tm8pKTsKKyAgICBzY2hlZHVsZUV2ZW50KEV2ZW50OjpjcmVh dGUoZXZlbnROYW1lcygpLmVycm9yRXZlbnQpOwogCiAgICAgLy8gNiAtIEFib3J0IHRoZSBvdmVy YWxsIHJlc291cmNlIHNlbGVjdGlvbiBhbGdvcml0aG0uCiAgICAgbV9jdXJyZW50U291cmNlTm9k ZSA9IG51bGxwdHI7Cg== 428377 2021-05-12 09:19:12 -0700 2021-05-12 11:00:32 -0700 Patch bug-225700-20210512091911.patch text/plain 2051 jer.noble U3VidmVyc2lvbiBSZXZpc2lvbjogMjc3MjgxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYjQxMGU3MmM1ZGNhZjQx N2M3MTQ0ODkzMDBhNmIyMGM4MjM2MzdmNS4uM2IzY2VmNWE4MjUwZmEzOTZlZjQ4NDY2NGE4YTA2 MjA0ZDFlNTg4NSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDIxLTA1LTEyICBKZXIg Tm9ibGUgIDxqZXIubm9ibGVAYXBwbGUuY29tPgorCisgICAgICAgIEhUTUxNZWRpYUVsZW1lbnQ6 Om1lZGlhTG9hZGluZ0ZhaWxlZEZhdGFsbHkoKSBkb2VzIGRpcmVjdCBkaXNwYXRjaCBvZiBldmVu dHM7IHNob3VsZCBlbnF1ZXVlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD0yMjU3MDAKKyAgICAgICAgPHJkYXI6Ly83NTU3NjMyMj4KKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBJbiByMjc0NTU5LCBhbiB1cGRh dGUgd2FzIG1hZGUgdG8gbWVkaWFMb2FkaW5nRmFpbGVkRmF0YWxseSB0byBhZG9wdCByZWNlbnQg c3BlYyBjaGFuZ2VzLCBhbmQgYXMKKyAgICAgICAgcGFydCBvZiB0aGF0IGNoYW5nZSwgYW4gImVy cm9yIiBldmVudCB3YXMgY2hhbmdlZCBmcm9tIGJlaW5nIGVucXVldWVkIHRvIGJlaW5nIGRpcmVj dGx5IGRpc3BhdGNoZWQuCisgICAgICAgIEhvd2V2ZXIsIGRpcmVjdGx5IGRpc3BhdGNoaW5nIGV2 ZW50cyBleHBvc2VzIHRoZSBlbGVtZW50IHRvIEpTIGFuZCBoYXMgdGhlIHBvdGVudGlhbCB0byBj YXVzZSB0aGUKKyAgICAgICAgZWxlbWVudCB0byBiZSBnYXJiYWdlIGNvbGxlY3RlZCwgZGVsZXRp bmcgdGhlIG9iamVjdCBhbmQgcG90ZW50aWFsbHkgb3RoZXIgb2JqZWN0cyBpbiB0aGUgYmFja3Ry YWNlLgorICAgICAgICBFdmVudHMgc2hvdWxkIGFsd2F5cyBiZSBlbnF1ZXVlZCwgcmF0aGVyIHRo YW4gZGlyZWN0eSBkaXNwYXRjaGVkLCBmb3IgdGhpcyByZWFzb24uCisKKyAgICAgICAgKiBodG1s L0hUTUxNZWRpYUVsZW1lbnQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6SFRNTE1lZGlhRWxlbWVu dDo6bWVkaWFMb2FkaW5nRmFpbGVkRmF0YWxseSk6CisKIDIwMjEtMDUtMDQgIEplciBOb2JsZSAg PGplci5ub2JsZUBhcHBsZS5jb20+CiAKICAgICAgICAgW01lZGlhIGluIEdQVSBQcm9jZXNzXSBN b3ZlIEF1ZGlvU2Vzc2lvblJvdXRpbmdBcmJpdHJhdG9yUHJveHkgdG8gdGhlIEdQVSBwcm9jZXNz CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxNZWRpYUVsZW1lbnQuY3BwIGIv U291cmNlL1dlYkNvcmUvaHRtbC9IVE1MTWVkaWFFbGVtZW50LmNwcAppbmRleCAxODFkYWI0Nzg5 ZmVhYzkzYTJhMDZlZThkYjU5MTg4NWE1YjM2MjBkLi5kNGQxYWEzMGYxMWU3NGVjMmY1NjMxYjg2 NzlkMGIwOGI2YjQ5ZGE1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxNZWRp YUVsZW1lbnQuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTE1lZGlhRWxlbWVudC5j cHAKQEAgLTIxNDMsNyArMjE0Myw3IEBAIHZvaWQgSFRNTE1lZGlhRWxlbWVudDo6bWVkaWFMb2Fk aW5nRmFpbGVkRmF0YWxseShNZWRpYVBsYXllcjo6TmV0d29ya1N0YXRlIGVycm9yCiAgICAgc2V0 U2hvdWxkRGVsYXlMb2FkRXZlbnQoZmFsc2UpOwogCiAgICAgLy8gNSAtIEZpcmUgYW4gZXZlbnQg bmFtZWQgZXJyb3IgYXQgdGhlIG1lZGlhIGVsZW1lbnQuCi0gICAgZGlzcGF0Y2hFdmVudChFdmVu dDo6Y3JlYXRlKGV2ZW50TmFtZXMoKS5lcnJvckV2ZW50LCBFdmVudDo6Q2FuQnViYmxlOjpObywg RXZlbnQ6OklzQ2FuY2VsYWJsZTo6Tm8pKTsKKyAgICBzY2hlZHVsZUV2ZW50KGV2ZW50TmFtZXMo KS5lcnJvckV2ZW50KTsKIAogICAgIC8vIDYgLSBBYm9ydCB0aGUgb3ZlcmFsbCByZXNvdXJjZSBz ZWxlY3Rpb24gYWxnb3JpdGhtLgogICAgIG1fY3VycmVudFNvdXJjZU5vZGUgPSBudWxscHRyOwo=