225697 2021-05-12 07:13:25 -0700 [GStreamer] media/track/in-band/track-in-band-srt-mkv-kind.html is a flaky crash 2021-05-13 06:55:14 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 dpino eocanha aboya bugs-noreply calvaris cgarcia eocanha ews-watchlist gustavo menard pnormand vjaquez webkit-bug-importer oldest_to_newest 1759240 0 dpino 2021-05-12 07:13:25 -0700 Results dashboard: https://results.webkit.org/?suite=layout-tests&test=media%2Ftrack%2Fin-band%2Ftrack-in-band-srt-mkv-kind.html&platform=GTK&platform=WPE Stacktrace: https://build.webkit.org/results/GTK-Linux-64-bit-Release-Tests/r277365%20(1704)/media/track/in-band/track-in-band-srt-mkv-kind-crash-log.txt Using host libthread_db library "/usr/lib/x86_64-linux-gnu/libthread_db.so.1". Core was generated by `/app/webkit/WebKitBuild/Release/bin/WebKitWebProcess 279 13 --configure-jsc-for'. Program terminated with signal SIGSEGV, Segmentation fault. #0 0x00007fde48001069 in WebCore::MediaPlayerPrivateGStreamer::handleTextSample(_GstSample*, char const*) () from /app/webkit/WebKitBuild/Release/lib/libwebkit2gtk-4.1.so.0 [Current thread is 1 (Thread 0x7fde3d9d2e80 (LWP 120958))] Thread 1 (Thread 0x7fde3d9d2e80 (LWP 120958)): #0 0x00007fde48001069 in WebCore::MediaPlayerPrivateGStreamer::handleTextSample(_GstSample*, char const*) () at /app/webkit/WebKitBuild/Release/lib/libwebkit2gtk-4.1.so.0 #1 0x00007fde438000bb in WTF::RunLoop::performWork() () at /app/webkit/WebKitBuild/Release/lib/libjavascriptcoregtk-4.1.so.0 #2 0x00007fde4386e8f9 in WTF::RunLoop::RunLoop()::{lambda(void*)#1}::_FUN(void*) () at /app/webkit/WebKitBuild/Release/lib/libjavascriptcoregtk-4.1.so.0 #3 0x00007fde4386f3df in WTF::RunLoop::{lambda(_GSource*, int (*)(void*), void*)#1}::_FUN(_GSource*, int (*)(void*), void*) () at /app/webkit/WebKitBuild/Release/lib/libjavascriptcoregtk-4.1.so.0 #4 0x00007fde400b6dbf in g_main_dispatch (context=0x560e3f468930) at ../glib/gmain.c:3337 #5 g_main_context_dispatch (context=0x560e3f468930) at ../glib/gmain.c:4055 #6 0x00007fde400b7168 in g_main_context_iterate (context=0x560e3f468930, block=block@entry=1, dispatch=dispatch@entry=1, self=<optimized out>) at ../glib/gmain.c:4131 #7 0x00007fde400b7483 in g_main_loop_run (loop=0x560e3f497740) at ../glib/gmain.c:4329 #8 0x00007fde4386f528 in WTF::RunLoop::run() () at /app/webkit/WebKitBuild/Release/lib/libjavascriptcoregtk-4.1.so.0 #9 0x00007fde45d60b5f in int WebKit::AuxiliaryProcessMain<WebKit::WebProcessMainGtk>(int, char**) () at /app/webkit/WebKitBuild/Release/lib/libwebkit2gtk-4.1.so.0 #10 0x00007fde3fa59062 in __libc_start_main (main=0x560e3f23f850 <main>, argc=4, argv=0x7ffe284dccf8, init=<optimized out>, fini=<optimized out>, rtld_fini=<optimized out>, stack_end=0x7ffe284dcce8) at ../csu/libc-start.c:308 #11 0x0000560e3f23f88e in _start () at ../sysdeps/x86_64/start.S:120 There was recent change in the line where the test is crashing (https://webkit-search.igalia.com/webkit/source/Source/WebCore/platform/graphics/gstreamer/TextSinkGStreamer.cpp#67), but I think it's unrelated since the test has been crashing sporadically before that. The test doesn't seem to crash in Debug. 1759672 1 428511 eocanha 2021-05-13 06:11:05 -0700 Created attachment 428511 Patch 1759674 2 428511 aboya 2021-05-13 06:20:26 -0700 Comment on attachment 428511 Patch LGTM. It's important to be careful with callbacks indeed. 1759677 3 ews-feeder 2021-05-13 06:54:51 -0700 Committed r277432 (237680@main): <https://commits.webkit.org/237680@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 428511. 1759678 4 webkit-bug-importer 2021-05-13 06:55:14 -0700 <rdar://problem/77964181> 428511 2021-05-13 06:11:05 -0700 2021-05-13 06:54:52 -0700 Patch bug-225697-20210513151104.patch text/plain 4011 eocanha U3VidmVyc2lvbiBSZXZpc2lvbjogMjc3NDI4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMzRjZTAzODVjY2Q4NzM1 MGIwYjg4YzM4MDA3ZWY5NmU2OTMxZDMwOS4uNjI5YmQ3YTM0ZjNjMWRkMmFlOGM3YmJhMGNmYzQx OTU3ZDg2NDQ5ZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDIxLTA1LTEzICBFbnJp cXVlIE9jYcOxYSBHb256w6FsZXogIDxlb2NhbmhhQGlnYWxpYS5jb20+CisKKyAgICAgICAgW0dT dHJlYW1lcl0gbWVkaWEvdHJhY2svaW4tYmFuZC90cmFjay1pbi1iYW5kLXNydC1ta3Yta2luZC5o dG1sIGlzIGEgZmxha3kgY3Jhc2gKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTIyNTY5NworCisgICAgICAgIFRoaXMgaXMgYSB0ZW50YXRpdmUgZml4IGZv ciB0aGUgZmxha3kgY3Jhc2ggKEkgY2FuJ3QgcmVwcm9kdWNlIGl0IGxvY2FsbHkgYWZ0ZXIgMTAw MDAKKyAgICAgICAgcmVwZXRpdGlvbnMpLiBJdCBtYWtlcyBzdXJlIHRoYXQgbWVkaWFQbGF5ZXJQ cml2YXRlIGFuZCBhbnkgcGFyYW1ldGVyIHBhc3NlZCB0bworICAgICAgICBoYW5kbGVUZXh0U2Ft cGxlKCkgY2FuIGVpdGhlciBzdXJ2aXZlIG9yIGRldGVjdGVkIHRvIGJlIGludmFsaWQgd2hlbiB0 aGUgbGFtYmRhIGlzIHJhbiBpbgorICAgICAgICB0aGUgbWFpbiB0aHJlYWQuCisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQ292ZXJlZCBieSBleGlzdGlu ZyB0ZXN0cy4KKworICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL2dzdHJlYW1lci9UZXh0U2lu a0dTdHJlYW1lci5jcHA6CisgICAgICAgICh3ZWJraXRUZXh0U2lua0hhbmRsZVNhbXBsZSk6IFBy b3RlY3QgbWVkaWFQbGF5ZXJQcml2YXRlIGFuZCBzdHJlYWRJZCBhbmQgY2hlY2sgaWYgdGhlIG1l ZGlhUGxheWVyUHJpdmF0ZSBXZWFrUmVmIGlzIHN0aWxsIGFsaXZlLgorCiAyMDIxLTA1LTEyICBG cmVkZXJpYyBXYW5nICA8ZndhbmdAaWdhbGlhLmNvbT4KIAogICAgICAgICBSRUxFQVNFX0FTU0VS VChtX3NlbGVjdGlvbi0+aXNOb25lKCkpIGZhaWxzIGluIERvY3VtZW50OjpyZW1vdmVkTGFzdFJl ZgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZ3N0cmVhbWVy L1RleHRTaW5rR1N0cmVhbWVyLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNz L2dzdHJlYW1lci9UZXh0U2lua0dTdHJlYW1lci5jcHAKaW5kZXggNzhiMDFkN2ZlMTIxMjdjNWE3 NDdlN2QxM2Y2OTUyMGRkNTc2MzEwYi4uOTBiYzEyNjFjMGUzMmIzNmI3OTQ2N2IyNWZiZmZiMjQx YWI3NTg3OSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZ3N0 cmVhbWVyL1RleHRTaW5rR1N0cmVhbWVyLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9y bS9ncmFwaGljcy9nc3RyZWFtZXIvVGV4dFNpbmtHU3RyZWFtZXIuY3BwCkBAIC02MSwxMCArNjEs MTMgQEAgc3RhdGljIHZvaWQgd2Via2l0VGV4dFNpbmtIYW5kbGVTYW1wbGUoV2ViS2l0VGV4dFNp bmsqIHNlbGYsIEdSZWZQdHI8R3N0U2FtcGxlPiYKICAgICB9CiAKICAgICBpZiAocHJpdi0+c3Ry ZWFtSWQpIHsKLSAgICAgICAgLy8gQXMgdGhlIG1lZGlhUGxheWVyUHJpdmF0ZSBXZWFrUHRyIGlz IGNvbnN0cnVjdGVkIGZyb20gdGhlIG1haW4gdGhyZWFkLCB3ZSBoYXZlIHRvIHVzZSBpdAotICAg ICAgICAvLyBmcm9tIHRoZSBtYWluIHRocmVhZCBhcyB3ZWxsLgotICAgICAgICBjYWxsT25NYWlu VGhyZWFkKFtwcml2LCBzYW1wbGUgPSBXVEZNb3ZlKHNhbXBsZSldIHsKLSAgICAgICAgICAgIHBy aXYtPm1lZGlhUGxheWVyUHJpdmF0ZS0+aGFuZGxlVGV4dFNhbXBsZShzYW1wbGUuZ2V0KCksIHBy aXYtPnN0cmVhbUlkKTsKKyAgICAgICAgLy8gUGxheWVyIHByaXZhdGUgbWV0aG9kcyB0aGF0IGlu dGVyYWN0IHdpdGggV2ViQ29yZSBtdXN0IHJ1biBmcm9tIHRoZSBtYWluIHRocmVhZC4gVGhpbmdz IGNhbiBiZSBkZXN0cm95ZWQgYmVmb3JlIHRoYXQKKyAgICAgICAgLy8gY29kZSBydW5zLCBpbmNs dWRpbmcgdGhlIHRleHQgc2luayBhbmQgcHJpdiwgc28gcGFzcyBldmVyeXRoaW5nIGluIGEgc2Fm ZSB3YXkuCisgICAgICAgIGNhbGxPbk1haW5UaHJlYWQoW21lZGlhUGxheWVyUHJpdmF0ZSA9IFdl YWtQdHI8TWVkaWFQbGF5ZXJQcml2YXRlR1N0cmVhbWVyPihwcml2LT5tZWRpYVBsYXllclByaXZh dGUpLAorICAgICAgICAgICAgc3RyZWFtSWQgPSBwcml2LT5zdHJlYW1JZCwgc2FtcGxlID0gV1RG TW92ZShzYW1wbGUpXSB7CisgICAgICAgICAgICBpZiAoIW1lZGlhUGxheWVyUHJpdmF0ZSkKKyAg ICAgICAgICAgICAgICByZXR1cm47CisgICAgICAgICAgICBtZWRpYVBsYXllclByaXZhdGUtPmhh bmRsZVRleHRTYW1wbGUoc2FtcGxlLmdldCgpLCBzdHJlYW1JZCk7CiAgICAgICAgIH0pOwogICAg ICAgICByZXR1cm47CiAgICAgfQpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nIGIv TGF5b3V0VGVzdHMvQ2hhbmdlTG9nCmluZGV4IDEzYjEwZDNiOTM5MmFlYzk0MjE0OTU4ZDYyZGIz ZWUyMTUwODQ1ZTguLjdiZWViMjBmMTQyZTkwOTkyMDg4ZjUyODI0MjY5NjNhZWZmMTMxYzcgMTAw NjQ0Ci0tLSBhL0xheW91dFRlc3RzL0NoYW5nZUxvZworKysgYi9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKQEAgLTEsMyArMSwxMiBAQAorMjAyMS0wNS0xMyAgRW5yaXF1ZSBPY2HDsWEgR29uesOhbGV6 ICA8ZW9jYW5oYUBpZ2FsaWEuY29tPgorCisgICAgICAgIFtHU3RyZWFtZXJdIG1lZGlhL3RyYWNr L2luLWJhbmQvdHJhY2staW4tYmFuZC1zcnQtbWt2LWtpbmQuaHRtbCBpcyBhIGZsYWt5IGNyYXNo CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMjU2OTcK KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIHBsYXRm b3JtL2dsaWIvVGVzdEV4cGVjdGF0aW9uczogVW5za2lwcGVkIHRlc3QuCisKIDIwMjEtMDUtMTIg IENocmlzIER1bWV6ICA8Y2R1bWV6QGFwcGxlLmNvbT4KIAogICAgICAgICBOb3RpZmljYXRpb24u cmVxdWVzdFBlcm1pc3Npb24oKSBzaG91bGQgcmV0dXJuIGEgUHJvbWlzZQpkaWZmIC0tZ2l0IGEv TGF5b3V0VGVzdHMvcGxhdGZvcm0vZ2xpYi9UZXN0RXhwZWN0YXRpb25zIGIvTGF5b3V0VGVzdHMv cGxhdGZvcm0vZ2xpYi9UZXN0RXhwZWN0YXRpb25zCmluZGV4IDVkYTZlNTYwZDRmNGVmMzdkMzM3 MDRlOTFkM2UwYzEyYzkxMzMzNWEuLjhhNTFmYmZhMWM0M2M0MzVkNjIwNWJiNWFiN2I4MjQ4YjIz ZDRiOWUgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL3BsYXRmb3JtL2dsaWIvVGVzdEV4cGVjdGF0 aW9ucworKysgYi9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9nbGliL1Rlc3RFeHBlY3RhdGlvbnMKQEAg LTIzODEsOCArMjM4MSw2IEBAIHdlYmtpdC5vcmcvYi8yMjU0NjYgaW1wb3J0ZWQvdzNjL3dlYi1w bGF0Zm9ybS10ZXN0cy9jc3MvY3NzLWNvbG9yLWFkanVzdC9yZW5kZXJpCiAjIEZhaWxpbmcgc2lu Y2UgcjI3NzA5MS4KIHdlYmtpdC5vcmcvYi8yMjU0OTkgaW1wb3J0ZWQvdzNjL3dlYi1wbGF0Zm9y bS10ZXN0cy9jc3MvY3NzLWZvbnRzL2ZvbnQtZmVhdHVyZS1yZXNvbHV0aW9uLTAwMi5odG1sIFsg SW1hZ2VPbmx5RmFpbHVyZSBdCiAKLXdlYmtpdC5vcmcvYi8yMjU2OTcgbWVkaWEvdHJhY2svaW4t YmFuZC90cmFjay1pbi1iYW5kLXNydC1ta3Yta2luZC5odG1sIFsgQ3Jhc2ggUGFzcyBdCi0KICMg RW5kOiBDb21tb24gZmFpbHVyZXMgYmV0d2VlbiBHVEsgYW5kIFdQRS4KIAogIy8vLy8vLy8vLy8v Ly8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8v Ly8vLy8vLy8vLy8vLy8vLy8vLy8K