<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>225676</bug_id>
          
          <creation_ts>2021-05-11 15:54:03 -0700</creation_ts>
          <short_desc>ConservativeRoots triggers page demand on Speedometer</short_desc>
          <delta_ts>2021-05-12 14:06:45 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>New Bugs</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          <dependson>225705</dependson>
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Geoffrey Garen">ggaren</reporter>
          <assigned_to name="Geoffrey Garen">ggaren</assigned_to>
          <cc>commit-queue</cc>
    
    <cc>ews-watchlist</cc>
    
    <cc>fpizlo</cc>
    
    <cc>keith_miller</cc>
    
    <cc>mark.lam</cc>
    
    <cc>msaboff</cc>
    
    <cc>saam</cc>
    
    <cc>tzagallo</cc>
    
    <cc>webkit-bug-importer</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1759083</commentid>
    <comment_count>0</comment_count>
    <who name="Geoffrey Garen">ggaren</who>
    <bug_when>2021-05-11 15:54:03 -0700</bug_when>
    <thetext>ConservativeRoots triggers page demand on Speedometer</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1759084</commentid>
    <comment_count>1</comment_count>
      <attachid>428319</attachid>
    <who name="Geoffrey Garen">ggaren</who>
    <bug_when>2021-05-11 15:57:57 -0700</bug_when>
    <thetext>Created attachment 428319
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1759108</commentid>
    <comment_count>2</comment_count>
      <attachid>428319</attachid>
    <who name="Geoffrey Garen">ggaren</who>
    <bug_when>2021-05-11 17:21:45 -0700</bug_when>
    <thetext>Comment on attachment 428319
Patch

cq+</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1759113</commentid>
    <comment_count>3</comment_count>
    <who name="EWS">ews-feeder</who>
    <bug_when>2021-05-11 17:52:18 -0700</bug_when>
    <thetext>Committed r277346 (237604@main): &lt;https://commits.webkit.org/237604@main&gt;

All reviewed patches have been landed. Closing bug and clearing flags on attachment 428319.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1759114</commentid>
    <comment_count>4</comment_count>
    <who name="Radar WebKit Bug Importer">webkit-bug-importer</who>
    <bug_when>2021-05-11 17:53:16 -0700</bug_when>
    <thetext>&lt;rdar://problem/77872621&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1759258</commentid>
    <comment_count>5</comment_count>
      <attachid>428319</attachid>
    <who name="Filip Pizlo">fpizlo</who>
    <bug_when>2021-05-12 08:40:18 -0700</bug_when>
    <thetext>Comment on attachment 428319
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=428319&amp;action=review

&gt; Source/JavaScriptCore/heap/ConservativeRoots.cpp:61
&gt; +            m_roots.append(bitwise_cast&lt;HeapCell*&gt;(p));

Doesn&apos;t this code while some threads are thread_suspended?

In that case, I think you just introduced one of my favorite deadlocks:
- The append() calls malloc, which tries to grab some lock.
- Meanwhile some other thread is thread_suspended while holding that lock.

Nothing says that thread_suspend can&apos;t stop a thread while it&apos;s inside fastMalloc, system malloc, or anything else that holds locks.  I think that&apos;s why this code previously used a super janky want of allocating memory -- it was that way so that it didn&apos;t have to take locks to allocate.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1759321</commentid>
    <comment_count>6</comment_count>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2021-05-12 11:32:35 -0700</bug_when>
    <thetext>Re-opened since this is blocked by bug 225705</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1759363</commentid>
    <comment_count>7</comment_count>
      <attachid>428405</attachid>
    <who name="Geoffrey Garen">ggaren</who>
    <bug_when>2021-05-12 12:56:16 -0700</bug_when>
    <thetext>Created attachment 428405
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1759372</commentid>
    <comment_count>8</comment_count>
      <attachid>428405</attachid>
    <who name="Geoffrey Garen">ggaren</who>
    <bug_when>2021-05-12 13:14:31 -0700</bug_when>
    <thetext>Comment on attachment 428405
Patch

cq+</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1759398</commentid>
    <comment_count>9</comment_count>
    <who name="EWS">ews-feeder</who>
    <bug_when>2021-05-12 14:06:43 -0700</bug_when>
    <thetext>Committed r277388 (237644@main): &lt;https://commits.webkit.org/237644@main&gt;

All reviewed patches have been landed. Closing bug and clearing flags on attachment 428405.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>428319</attachid>
            <date>2021-05-11 15:57:57 -0700</date>
            <delta_ts>2021-05-12 12:56:14 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-225676-20210511155756.patch</filename>
            <type>text/plain</type>
            <size>5779</size>
            <attacher name="Geoffrey Garen">ggaren</attacher>
            
              <data encoding="base64">SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291
cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMjc3MzQxKQorKysgU291cmNl
L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDI5IEBA
CisyMDIxLTA1LTExICBHZW9mZnJleSBHYXJlbiAgPGdnYXJlbkBhcHBsZS5jb20+CisKKyAgICAg
ICAgQ29uc2VydmF0aXZlUm9vdHMgdHJpZ2dlcnMgcGFnZSBkZW1hbmQgb24gU3BlZWRvbWV0ZXIK
KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIyNTY3Ngor
CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFVzZSBhIFZl
Y3RvciBpbnN0ZWFkIG9mIE9TQWxsb2NhdG9yIHRvIGF2b2lkIG1tYXAoKSBhbmQgcGFnZSBmYXVs
dCAtLQorICAgICAgICBhbmQsIGxpa2UsIGNvbWUgb24uCisKKyAgICAgICAgQnVtcCBkZWZhdWx0
IGlubGluZUNhcGFjaXR5IHVwIHRvIDEwMjQgYmVjYXVzZSB3ZSBzZWVtIHRvIG92ZXJmbG93Cisg
ICAgICAgIGZyZXF1ZW50bHkuCisKKyAgICAgICAgKiBoZWFwL0NvbnNlcnZhdGl2ZVJvb3RzLmNw
cDoKKyAgICAgICAgKEpTQzo6Q29uc2VydmF0aXZlUm9vdHM6OkNvbnNlcnZhdGl2ZVJvb3RzKToK
KyAgICAgICAgKEpTQzo6Q29uc2VydmF0aXZlUm9vdHM6On5Db25zZXJ2YXRpdmVSb290cyk6Cisg
ICAgICAgIChKU0M6OkNvbnNlcnZhdGl2ZVJvb3RzOjpnZW5lcmljQWRkUG9pbnRlcik6CisgICAg
ICAgIChKU0M6OkNvbnNlcnZhdGl2ZVJvb3RzOjpncm93KTogRGVsZXRlZC4KKyAgICAgICAgKiBo
ZWFwL0NvbnNlcnZhdGl2ZVJvb3RzLmg6CisgICAgICAgIChKU0M6OkNvbnNlcnZhdGl2ZVJvb3Rz
Ojpyb290cyBjb25zdCk6CisgICAgICAgIChKU0M6OkNvbnNlcnZhdGl2ZVJvb3RzOjpzaXplIGNv
bnN0KTogRGVsZXRlZC4KKyAgICAgICAgKiBoZWFwL1Nsb3RWaXNpdG9yLmNwcDoKKyAgICAgICAg
KEpTQzo6U2xvdFZpc2l0b3I6OmFwcGVuZCk6CisgICAgICAgICogaGVhcC9WZXJpZmllclNsb3RW
aXNpdG9yLmNwcDoKKyAgICAgICAgKEpTQzo6VmVyaWZpZXJTbG90VmlzaXRvcjo6YXBwZW5kKToK
KwogMjAyMS0wNS0xMCAgRmlsaXAgUGl6bG8gIDxmcGl6bG9AYXBwbGUuY29tPgogCiAgICAgICAg
IFR1bmUgbnVtYmVyIG9mIHRocmVhZHMgZm9yIEFTCkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENv
cmUvaGVhcC9Db25zZXJ2YXRpdmVSb290cy5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFT
Y3JpcHRDb3JlL2hlYXAvQ29uc2VydmF0aXZlUm9vdHMuY3BwCShyZXZpc2lvbiAyNzczNDEpCisr
KyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvaGVhcC9Db25zZXJ2YXRpdmVSb290cy5jcHAJKHdvcmtp
bmcgY29weSkKQEAgLTM4LDI4ICszOCwxMiBAQAogbmFtZXNwYWNlIEpTQyB7CiAKIENvbnNlcnZh
dGl2ZVJvb3RzOjpDb25zZXJ2YXRpdmVSb290cyhIZWFwJiBoZWFwKQotICAgIDogbV9yb290cyht
X2lubGluZVJvb3RzKQotICAgICwgbV9zaXplKDApCi0gICAgLCBtX2NhcGFjaXR5KGlubGluZUNh
cGFjaXR5KQotICAgICwgbV9oZWFwKGhlYXApCisgICAgOiBtX2hlYXAoaGVhcCkKIHsKIH0KIAog
Q29uc2VydmF0aXZlUm9vdHM6On5Db25zZXJ2YXRpdmVSb290cygpCiB7Ci0gICAgaWYgKG1fcm9v
dHMgIT0gbV9pbmxpbmVSb290cykKLSAgICAgICAgT1NBbGxvY2F0b3I6OmRlY29tbWl0QW5kUmVs
ZWFzZShtX3Jvb3RzLCBtX2NhcGFjaXR5ICogc2l6ZW9mKEhlYXBDZWxsKikpOwotfQotCi12b2lk
IENvbnNlcnZhdGl2ZVJvb3RzOjpncm93KCkKLXsKLSAgICBzaXplX3QgbmV3Q2FwYWNpdHkgPSBt
X2NhcGFjaXR5ID09IGlubGluZUNhcGFjaXR5ID8gbm9uSW5saW5lQ2FwYWNpdHkgOiBtX2NhcGFj
aXR5ICogMjsKLSAgICBIZWFwQ2VsbCoqIG5ld1Jvb3RzID0gc3RhdGljX2Nhc3Q8SGVhcENlbGwq
Kj4oT1NBbGxvY2F0b3I6OnJlc2VydmVBbmRDb21taXQobmV3Q2FwYWNpdHkgKiBzaXplb2YoSGVh
cENlbGwqKSkpOwotICAgIG1lbWNweShuZXdSb290cywgbV9yb290cywgbV9zaXplICogc2l6ZW9m
KEhlYXBDZWxsKikpOwotICAgIGlmIChtX3Jvb3RzICE9IG1faW5saW5lUm9vdHMpCi0gICAgICAg
IE9TQWxsb2NhdG9yOjpkZWNvbW1pdEFuZFJlbGVhc2UobV9yb290cywgbV9jYXBhY2l0eSAqIHNp
emVvZihIZWFwQ2VsbCopKTsKLSAgICBtX2NhcGFjaXR5ID0gbmV3Q2FwYWNpdHk7Ci0gICAgbV9y
b290cyA9IG5ld1Jvb3RzOwogfQogCiB0ZW1wbGF0ZTx0eXBlbmFtZSBNYXJrSG9vaz4KQEAgLTc0
LDEwICs1OCw3IEBAIGlubGluZSB2b2lkIENvbnNlcnZhdGl2ZVJvb3RzOjpnZW5lcmljQWQKICAg
ICAgICAgICAgIGlmIChpc0pTQ2VsbEtpbmQoY2VsbEtpbmQpKQogICAgICAgICAgICAgICAgIG1h
cmtIb29rLm1hcmtLbm93bkpTQ2VsbChzdGF0aWNfY2FzdDxKU0NlbGwqPihwKSk7CiAgICAgICAg
ICAgICAKLSAgICAgICAgICAgIGlmIChtX3NpemUgPT0gbV9jYXBhY2l0eSkKLSAgICAgICAgICAg
ICAgICBncm93KCk7Ci0gICAgICAgICAgICAKLSAgICAgICAgICAgIG1fcm9vdHNbbV9zaXplKytd
ID0gYml0d2lzZV9jYXN0PEhlYXBDZWxsKj4ocCk7CisgICAgICAgICAgICBtX3Jvb3RzLmFwcGVu
ZChiaXR3aXNlX2Nhc3Q8SGVhcENlbGwqPihwKSk7CiAgICAgICAgIH0pOwogfQogCkluZGV4OiBT
b3VyY2UvSmF2YVNjcmlwdENvcmUvaGVhcC9Db25zZXJ2YXRpdmVSb290cy5oCj09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0K
LS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9oZWFwL0NvbnNlcnZhdGl2ZVJvb3RzLmgJKHJldmlz
aW9uIDI3NzM0MSkKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9oZWFwL0NvbnNlcnZhdGl2ZVJv
b3RzLmgJKHdvcmtpbmcgY29weSkKQEAgLTM0LDYgKzM0LDggQEAgY2xhc3MgSGVhcENlbGw7CiBj
bGFzcyBKSVRTdHViUm91dGluZVNldDsKIAogY2xhc3MgQ29uc2VydmF0aXZlUm9vdHMgeworICAg
IHN0YXRpYyBjb25zdGV4cHIgc2l6ZV90IGlubGluZUNhcGFjaXR5ID0gMTAyNDsKKyAgICAKIHB1
YmxpYzoKICAgICBDb25zZXJ2YXRpdmVSb290cyhIZWFwJik7CiAgICAgfkNvbnNlcnZhdGl2ZVJv
b3RzKCk7CkBAIC00MSwzNiArNDMsMTcgQEAgcHVibGljOgogICAgIHZvaWQgYWRkKHZvaWQqIGJl
Z2luLCB2b2lkKiBlbmQpOwogICAgIHZvaWQgYWRkKHZvaWQqIGJlZ2luLCB2b2lkKiBlbmQsIEpJ
VFN0dWJSb3V0aW5lU2V0JiwgQ29kZUJsb2NrU2V0Jik7CiAgICAgCi0gICAgc2l6ZV90IHNpemUo
KSBjb25zdDsKLSAgICBIZWFwQ2VsbCoqIHJvb3RzKCkgY29uc3Q7CisgICAgY29uc3QgVmVjdG9y
PEhlYXBDZWxsKiwgaW5saW5lQ2FwYWNpdHk+JiByb290cygpIGNvbnN0IHsgcmV0dXJuIG1fcm9v
dHM7IH07CiAKIHByaXZhdGU6Ci0gICAgc3RhdGljIGNvbnN0ZXhwciBzaXplX3QgaW5saW5lQ2Fw
YWNpdHkgPSAxMjg7Ci0gICAgc3RhdGljIGNvbnN0ZXhwciBzaXplX3Qgbm9uSW5saW5lQ2FwYWNp
dHkgPSA4MTkyIC8gc2l6ZW9mKEhlYXBDZWxsKik7Ci0gICAgCiAgICAgdGVtcGxhdGU8dHlwZW5h
bWUgTWFya0hvb2s+CiAgICAgdm9pZCBnZW5lcmljQWRkUG9pbnRlcih2b2lkKiwgSGVhcFZlcnNp
b24gbWFya2luZ1ZlcnNpb24sIEhlYXBWZXJzaW9uIG5ld2x5QWxsb2NhdGVkVmVyc2lvbiwgVGlu
eUJsb29tRmlsdGVyLCBNYXJrSG9vayYpOwogCiAgICAgdGVtcGxhdGU8dHlwZW5hbWUgTWFya0hv
b2s+CiAgICAgdm9pZCBnZW5lcmljQWRkU3Bhbih2b2lkKiwgdm9pZCogZW5kLCBNYXJrSG9vayYp
OwogICAgIAotICAgIHZvaWQgZ3JvdygpOwotCi0gICAgSGVhcENlbGwqKiBtX3Jvb3RzOwotICAg
IHNpemVfdCBtX3NpemU7Ci0gICAgc2l6ZV90IG1fY2FwYWNpdHk7CiAgICAgSGVhcCYgbV9oZWFw
OwotICAgIEhlYXBDZWxsKiBtX2lubGluZVJvb3RzW2lubGluZUNhcGFjaXR5XTsKKyAgICBWZWN0
b3I8SGVhcENlbGwqLCBpbmxpbmVDYXBhY2l0eT4gbV9yb290czsKIH07CiAKLWlubGluZSBzaXpl
X3QgQ29uc2VydmF0aXZlUm9vdHM6OnNpemUoKSBjb25zdAotewotICAgIHJldHVybiBtX3NpemU7
Ci19Ci0KLWlubGluZSBIZWFwQ2VsbCoqIENvbnNlcnZhdGl2ZVJvb3RzOjpyb290cygpIGNvbnN0
Ci17Ci0gICAgcmV0dXJuIG1fcm9vdHM7Ci19Ci0KIH0gLy8gbmFtZXNwYWNlIEpTQwpJbmRleDog
U291cmNlL0phdmFTY3JpcHRDb3JlL2hlYXAvU2xvdFZpc2l0b3IuY3BwCj09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0t
IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9oZWFwL1Nsb3RWaXNpdG9yLmNwcAkocmV2aXNpb24gMjc3
MzQxKQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL2hlYXAvU2xvdFZpc2l0b3IuY3BwCSh3b3Jr
aW5nIGNvcHkpCkBAIC0xMjksMTAgKzEyOSw4IEBAIHZvaWQgU2xvdFZpc2l0b3I6OmNsZWFyTWFy
a1N0YWNrcygpCiAKIHZvaWQgU2xvdFZpc2l0b3I6OmFwcGVuZChjb25zdCBDb25zZXJ2YXRpdmVS
b290cyYgY29uc2VydmF0aXZlUm9vdHMpCiB7Ci0gICAgSGVhcENlbGwqKiByb290cyA9IGNvbnNl
cnZhdGl2ZVJvb3RzLnJvb3RzKCk7Ci0gICAgc2l6ZV90IHNpemUgPSBjb25zZXJ2YXRpdmVSb290
cy5zaXplKCk7Ci0gICAgZm9yIChzaXplX3QgaSA9IDA7IGkgPCBzaXplOyArK2kpCi0gICAgICAg
IGFwcGVuZEpTQ2VsbE9yQXV4aWxpYXJ5KHJvb3RzW2ldKTsKKyAgICBmb3IgKGF1dG8gcm9vdCA6
IGNvbnNlcnZhdGl2ZVJvb3RzLnJvb3RzKCkpCisgICAgICAgIGFwcGVuZEpTQ2VsbE9yQXV4aWxp
YXJ5KHJvb3QpOwogfQogCiB2b2lkIFNsb3RWaXNpdG9yOjphcHBlbmRKU0NlbGxPckF1eGlsaWFy
eShIZWFwQ2VsbCogaGVhcENlbGwpCkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvaGVhcC9W
ZXJpZmllclNsb3RWaXNpdG9yLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENv
cmUvaGVhcC9WZXJpZmllclNsb3RWaXNpdG9yLmNwcAkocmV2aXNpb24gMjc3MzQxKQorKysgU291
cmNlL0phdmFTY3JpcHRDb3JlL2hlYXAvVmVyaWZpZXJTbG90VmlzaXRvci5jcHAJKHdvcmtpbmcg
Y29weSkKQEAgLTE0OCwxMCArMTQ4LDggQEAgdm9pZCBWZXJpZmllclNsb3RWaXNpdG9yOjphcHBl
bmQoY29uc3QgQwogICAgICAgICB9CiAgICAgfTsKIAotICAgIEhlYXBDZWxsKiogcm9vdHMgPSBj
b25zZXJ2YXRpdmVSb290cy5yb290cygpOwotICAgIHNpemVfdCBzaXplID0gY29uc2VydmF0aXZl
Um9vdHMuc2l6ZSgpOwotICAgIGZvciAoc2l6ZV90IGkgPSAwOyBpIDwgc2l6ZTsgKytpKQotICAg
ICAgICBhcHBlbmRKU0NlbGxPckF1eGlsaWFyeShyb290c1tpXSk7CisgICAgZm9yIChhdXRvIHJv
b3QgOiBjb25zZXJ2YXRpdmVSb290cy5yb290cygpKQorICAgICAgICBhcHBlbmRKU0NlbGxPckF1
eGlsaWFyeShyb290KTsKIH0KIAogdm9pZCBWZXJpZmllclNsb3RWaXNpdG9yOjphcHBlbmRUb01h
cmtTdGFjayhKU0NlbGwqIGNlbGwpCg==
</data>

          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>428405</attachid>
            <date>2021-05-12 12:56:16 -0700</date>
            <delta_ts>2021-05-12 14:06:44 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-225676-20210512125615.patch</filename>
            <type>text/plain</type>
            <size>2353</size>
            <attacher name="Geoffrey Garen">ggaren</attacher>
            
              <data encoding="base64">SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291
cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMjc3MzgzKQorKysgU291cmNl
L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIxIEBA
CisyMDIxLTA1LTEyICBHZW9mZnJleSBHYXJlbiAgPGdnYXJlbkBhcHBsZS5jb20+CisKKyAgICAg
ICAgQ29uc2VydmF0aXZlUm9vdHMgdHJpZ2dlcnMgcGFnZSBkZW1hbmQgb24gU3BlZWRvbWV0ZXIK
KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIyNTY3Ngor
CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFVzZSBhIDIw
NDggaXRlbSAvIDE2a0IgaW5saW5lIGJ1ZmZlci4gVGhhdCdzIGFib3V0IDEwJSBiaWdnZXIgdGhh
biB0aGUKKyAgICAgICAgbWF4IGNhcGFjaXR5IG9ic2VydmVkIG9uIFNwZWVkb21ldGVyLCBhbmQg
c21hbGwgZW5vdWdoIHRvIHJlYXNvbmFibHkgZml0CisgICAgICAgIG9uIHRoZSBzdGFjay4KKwor
ICAgICAgICBSZW1vdmVkIHRoZSBzZXBhcmF0ZSBvdXQgb2YgbGluZSBjYXBhY2l0eSBiZWNhdXNl
IGl0IHdhcyBzbWFsbGVyIHRoYW4KKyAgICAgICAgdGhlIG5ldyBpbmxpbmUgY2FwYWNpdHkuCisK
KyAgICAgICAgKiBoZWFwL0NvbnNlcnZhdGl2ZVJvb3RzLmNwcDoKKyAgICAgICAgKEpTQzo6Q29u
c2VydmF0aXZlUm9vdHM6Omdyb3cpOgorICAgICAgICAqIGhlYXAvQ29uc2VydmF0aXZlUm9vdHMu
aDoKKwogMjAyMS0wNS0xMiAgTWFyayBMYW0gIDxtYXJrLmxhbUBhcHBsZS5jb20+CiAKICAgICAg
ICAgSW1wbGVtZW50IHNvbWUgY29tbW9uIEJhc2VsaW5lIEpJVCBzbG93IHBhdGhzIHVzaW5nIEpJ
VCB0aHVua3MuCkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvaGVhcC9Db25zZXJ2YXRpdmVS
b290cy5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL2hlYXAvQ29uc2Vy
dmF0aXZlUm9vdHMuY3BwCShyZXZpc2lvbiAyNzczODMpCisrKyBTb3VyY2UvSmF2YVNjcmlwdENv
cmUvaGVhcC9Db25zZXJ2YXRpdmVSb290cy5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTUzLDcgKzUz
LDcgQEAgQ29uc2VydmF0aXZlUm9vdHM6On5Db25zZXJ2YXRpdmVSb290cygpCiAKIHZvaWQgQ29u
c2VydmF0aXZlUm9vdHM6Omdyb3coKQogewotICAgIHNpemVfdCBuZXdDYXBhY2l0eSA9IG1fY2Fw
YWNpdHkgPT0gaW5saW5lQ2FwYWNpdHkgPyBub25JbmxpbmVDYXBhY2l0eSA6IG1fY2FwYWNpdHkg
KiAyOworICAgIHNpemVfdCBuZXdDYXBhY2l0eSA9IG1fY2FwYWNpdHkgKiAyOwogICAgIEhlYXBD
ZWxsKiogbmV3Um9vdHMgPSBzdGF0aWNfY2FzdDxIZWFwQ2VsbCoqPihPU0FsbG9jYXRvcjo6cmVz
ZXJ2ZUFuZENvbW1pdChuZXdDYXBhY2l0eSAqIHNpemVvZihIZWFwQ2VsbCopKSk7CiAgICAgbWVt
Y3B5KG5ld1Jvb3RzLCBtX3Jvb3RzLCBtX3NpemUgKiBzaXplb2YoSGVhcENlbGwqKSk7CiAgICAg
aWYgKG1fcm9vdHMgIT0gbV9pbmxpbmVSb290cykKSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29y
ZS9oZWFwL0NvbnNlcnZhdGl2ZVJvb3RzLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3Jp
cHRDb3JlL2hlYXAvQ29uc2VydmF0aXZlUm9vdHMuaAkocmV2aXNpb24gMjc3MzgzKQorKysgU291
cmNlL0phdmFTY3JpcHRDb3JlL2hlYXAvQ29uc2VydmF0aXZlUm9vdHMuaAkod29ya2luZyBjb3B5
KQpAQCAtNDUsOCArNDUsNyBAQCBwdWJsaWM6CiAgICAgSGVhcENlbGwqKiByb290cygpIGNvbnN0
OwogCiBwcml2YXRlOgotICAgIHN0YXRpYyBjb25zdGV4cHIgc2l6ZV90IGlubGluZUNhcGFjaXR5
ID0gMTI4OwotICAgIHN0YXRpYyBjb25zdGV4cHIgc2l6ZV90IG5vbklubGluZUNhcGFjaXR5ID0g
ODE5MiAvIHNpemVvZihIZWFwQ2VsbCopOworICAgIHN0YXRpYyBjb25zdGV4cHIgc2l6ZV90IGlu
bGluZUNhcGFjaXR5ID0gMjA0ODsKICAgICAKICAgICB0ZW1wbGF0ZTx0eXBlbmFtZSBNYXJrSG9v
az4KICAgICB2b2lkIGdlbmVyaWNBZGRQb2ludGVyKHZvaWQqLCBIZWFwVmVyc2lvbiBtYXJraW5n
VmVyc2lvbiwgSGVhcFZlcnNpb24gbmV3bHlBbGxvY2F0ZWRWZXJzaW9uLCBUaW55Qmxvb21GaWx0
ZXIsIE1hcmtIb29rJik7Cg==
</data>

          </attachment>
      

    </bug>

</bugzilla>