225660 2021-05-11 10:22:07 -0700 [BMalloc] Temporarily disable bmalloc in debug builds while examining 76167814 2021-12-12 08:43:50 -0800 1 1 1 Unclassified WebKit bmalloc WebKit Nightly Build Unspecified Unspecified RESOLVED WONTFIX InRadar P2 Normal --- 1 dino dino cdumez ggaren webkit-bug-importer oldest_to_newest 1758948 0 dino 2021-05-11 10:22:07 -0700 [BMalloc] Temporarily disable bmalloc in debug builds while examining 76167814 1758950 1 webkit-bug-importer 2021-05-11 10:24:29 -0700 <rdar://problem/77852400> 1758952 2 ggaren 2021-05-11 10:26:58 -0700 Kinda sketchy to lose debug testing coverage for bmalloc and gigacage. Maybe release coverage is sufficient? Maybe. 1758954 3 428292 dino 2021-05-11 10:30:11 -0700 Created attachment 428292 Patch 1758956 4 dino 2021-05-11 10:32:50 -0700 (In reply to Geoffrey Garen from comment #2) > Kinda sketchy to lose debug testing coverage for bmalloc and gigacage. Maybe > release coverage is sufficient? Maybe. The original bug hasn't been touched in weeks, which is more sketchy :) 1758959 5 dino 2021-05-11 10:33:39 -0700 (In reply to Dean Jackson from comment #4) > (In reply to Geoffrey Garen from comment #2) > > Kinda sketchy to lose debug testing coverage for bmalloc and gigacage. Maybe > > release coverage is sufficient? Maybe. > > The original bug hasn't been touched in weeks, which is more sketchy :) Sorry, I meant months. 1758979 6 428292 cdumez 2021-05-11 11:03:08 -0700 Comment on attachment 428292 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=428292&action=review > Source/bmalloc/ChangeLog:3 > + [BMalloc] Temporarily disable bmalloc in debug builds while examining 76167814 Why can't people use the environment variables to disable bmalloc when debugging? Disabling BMalloc for everybody in debug seems aggressive. 1758983 7 dino 2021-05-11 11:05:05 -0700 (In reply to Chris Dumez from comment #6) > Comment on attachment 428292 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=428292&action=review > > > Source/bmalloc/ChangeLog:3 > > + [BMalloc] Temporarily disable bmalloc in debug builds while examining 76167814 > > Why can't people use the environment variables to disable bmalloc when > debugging? Disabling BMalloc for everybody in debug seems aggressive. Because it is difficult to do this for the simulator, and people will have to remember to undo the workaround. Seems better to track this officially. Well, the best would be to address the real bug, which is almost certainly in the toolchain :) 1758988 8 cdumez 2021-05-11 11:08:08 -0700 We're loosing useful test coverage on bots and local machines just for the purpose of making the debugger work. It doesn't seem like a good trade-offs. We want to be running something as close as possible to the configuration we ship. 1759266 9 dino 2021-05-12 09:06:46 -0700 (In reply to Chris Dumez from comment #8) > We're loosing useful test coverage on bots and local machines just for the > purpose of making the debugger work. It doesn't seem like a good trade-offs. > We want to be running something as close as possible to the configuration we > ship. We don't ship debug builds. But to be clear, I don't want to do this. I want the actual bug to be examined - it's been more than a month and nothing has happened. I should remove the r? flag because I don't expect anyone will want to land this, but it serves as a patch that people can apply to get things working locally. 428292 2021-05-11 10:30:11 -0700 2021-12-12 08:43:50 -0800 Patch bug-225660-20210512033010.patch text/plain 1847 dino U3VidmVyc2lvbiBSZXZpc2lvbjogMjc3MDM0CmRpZmYgLS1naXQgYS9Tb3VyY2UvYm1hbGxvYy9D aGFuZ2VMb2cgYi9Tb3VyY2UvYm1hbGxvYy9DaGFuZ2VMb2cKaW5kZXggZTExMWRhODFjYzYxODVk MDQ3MDBhNDZmYWUyYTJhMzk3YjMxZGE2NC4uZWQwMmRjZjM5YTJhMDdmY2E5YmU3ZTZkYjIzZDc1 ZjBhY2NlNzQ0ZiAxMDA2NDQKLS0tIGEvU291cmNlL2JtYWxsb2MvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9ibWFsbG9jL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDIxLTA1LTExICBEZWFu IEphY2tzb24gIDxkaW5vQGFwcGxlLmNvbT4KKworICAgICAgICBbQk1hbGxvY10gVGVtcG9yYXJp bHkgZGlzYWJsZSBibWFsbG9jIGluIGRlYnVnIGJ1aWxkcyB3aGlsZSBleGFtaW5pbmcgNzYxNjc4 MTQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIyNTY2 MAorICAgICAgICByZGFyOi8vNzc4NTI0MDAKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBUaGUgaXNzdWUgaW4gcmRhcjovLzc2MTY3ODE0IGJyZWFrcyBk ZWJ1Z2dpbmcuIFRlbXBvcmFyaWx5IHR1cm4gb2ZmIGJtYWxsb2MKKyAgICAgICAgd2hlbiBidWls ZGluZyBmb3IgZGVidWcgdW50aWwgdGhhdCBpcyByZXNvbHZlZC4KKworICAgICAgICAqIGJtYWxs b2MvRW52aXJvbm1lbnQuY3BwOgorICAgICAgICAoYm1hbGxvYzo6aXNEZWJ1Z0J1aWxkV2hpbGU3 NjE2NzgxNGlzT3Blbik6CisgICAgICAgIChibWFsbG9jOjpFbnZpcm9ubWVudDo6Y29tcHV0ZUlz RGVidWdIZWFwRW5hYmxlZCk6CisKIDIwMjEtMDQtMTkgIE1pY2hhZWwgU2Fib2ZmICA8bXNhYm9m ZkBhcHBsZS5jb20+CiAKICAgICAgICAgW2JtYWxsb2NdIEVuYWJsZSBBZGFwdGl2ZSBTY2F2ZW5n ZXIgZm9yIE1hYwpkaWZmIC0tZ2l0IGEvU291cmNlL2JtYWxsb2MvYm1hbGxvYy9FbnZpcm9ubWVu dC5jcHAgYi9Tb3VyY2UvYm1hbGxvYy9ibWFsbG9jL0Vudmlyb25tZW50LmNwcAppbmRleCA2Yjlh OWE4ZTUzMmQwMTZhMGVjYzZlNWNlNzI2ZmU0NzcyNDllNGFiLi4zNTMwOWY4NjJkMGU3ZDVjMDMy ZTcwZjhkY2Y3NTkyZWU2NDFmMDA2IDEwMDY0NAotLS0gYS9Tb3VyY2UvYm1hbGxvYy9ibWFsbG9j L0Vudmlyb25tZW50LmNwcAorKysgYi9Tb3VyY2UvYm1hbGxvYy9ibWFsbG9jL0Vudmlyb25tZW50 LmNwcApAQCAtMTMxLDYgKzEzMSwxNSBAQCBzdGF0aWMgYm9vbCBpc05hbm9NYWxsb2NFbmFibGVk KCkKIH0KICNlbmRpZgogCitzdGF0aWMgYm9vbCBpc0RlYnVnQnVpbGRXaGlsZTc2MTY3ODE0aXNP cGVuKCkKK3sKKyNpZiBkZWZpbmVkKE5ERUJVRykKKyAgICByZXR1cm4gdHJ1ZTsKKyNlbHNlCisg ICAgcmV0dXJuIGZhbHNlOworI2VuZGlmCit9CisKIERFRklORV9TVEFUSUNfUEVSX1BST0NFU1Nf U1RPUkFHRShFbnZpcm9ubWVudCk7CiAKIEVudmlyb25tZW50OjpFbnZpcm9ubWVudChjb25zdCBM b2NrSG9sZGVyJikKQEAgLTE0MCw2ICsxNDksOSBAQCBFbnZpcm9ubWVudDo6RW52aXJvbm1lbnQo Y29uc3QgTG9ja0hvbGRlciYpCiAKIGJvb2wgRW52aXJvbm1lbnQ6OmNvbXB1dGVJc0RlYnVnSGVh cEVuYWJsZWQoKQogeworICAgIC8vIEZJWE1FOiBUZW1wb3JhcmlseSBkaXNhYmxlIGJtYWxsb2Mg d2hpbGUgcmRhcjovLzc2MTY3ODE0IGlzIG9wZW4uCisgICAgaWYgKGlzRGVidWdCdWlsZFdoaWxl NzYxNjc4MTRpc09wZW4oKSkKKyAgICAgICAgcmV0dXJuIHRydWU7CiAgICAgaWYgKGlzTWFsbG9j RW52aXJvbm1lbnRWYXJpYWJsZVNldCgpKQogICAgICAgICByZXR1cm4gdHJ1ZTsKICAgICBpZiAo aXNMaWJnbWFsbG9jRW5hYmxlZCgpKQo=