225659 2021-05-11 09:50:57 -0700 REGRESSION(r277262): test imported/w3c/web-platform-tests/css/selectors/focus-visible-002.html is crashing 2021-05-13 02:53:30 -0700 1 1 1 Unclassified WebKit WebKitGTK WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=224967 Gtk, LayoutTestFailure, Regression P2 Normal --- 1 cgarcia webkit-unassigned aperez berto bugs-noreply ews-watchlist gustavo oldest_to_newest 1758931 0 cgarcia 2021-05-11 09:50:57 -0700 This test is now crashing since r277262. r277261 TEXT (Expected: FAIL) [r277262-r277264] CRASH (Expected: FAIL) [r277265-r277267] UNKNOWN Craslog: https://build.webkit.org/results/GTK-Linux-64-bit-Debug-Tests/r277315%20(1048)/imported/w3c/web-platform-tests/css/selectors/focus-visible-002-crash-log.txt Program terminated with signal SIGSEGV, Segmentation fault. #0 g_type_check_instance_is_fundamentally_a (type_instance=type_instance@entry=0x561af58003d0, fundamental_type=fundamental_type@entry=80) at ../gobject/gtype.c:4082 4082 node = lookup_type_node_I (type_instance->g_class->g_type); [Current thread is 1 (Thread 0x7f97210a2200 (LWP 14256))] Thread 1 (Thread 0x7f97210a2200 (LWP 14256)): #0 g_type_check_instance_is_fundamentally_a (type_instance=type_instance@entry=0x561af58003d0, fundamental_type=fundamental_type@entry=0x50 [GObject]) at ../gobject/gtype.c:4082 #1 0x00007f9722962e82 in g_object_ref (_object=_object@entry=0x561af58003d0) at ../gobject/gobject.c:3389 #2 0x00007f97243aaddd in gtk_window_real_set_focus (window=<optimized out>, focus=0x561af55ed080 [WebKitWebViewBase]) at ../gtk/gtkwindow.c:8711 #9 0x00007f97229779c3 in <emit signal ??? on instance 0x561af55ed080 [WebKitWebViewBase] or 0x561af5882a50 [GtkWindow]> (instance=instance@entry=0x561af55ed080, signal_id=<optimized out>, detail=detail@entry=0) at ../gobject/gsignal.c:3553 #3 0x00007f972295df3f in g_closure_invoke (closure=closure@entry=0x561af506cef0, return_value=return_value@entry=0x0, n_param_values=2, param_values=param_values@entry=0x7ffe4d3fbd70, invocation_hint=invocation_hint@entry=0x7ffe4d3fbcf0) at ../gobject/gclosure.c:810 #4 0x00007f9722970769 in signal_emit_unlocked_R (node=node@entry=0x561af505bb70, detail=detail@entry=0, instance=instance@entry=0x561af5882a50, emission_return=emission_return@entry=0x0, instance_and_params=instance_and_params@entry=0x7ffe4d3fbd70) at ../gobject/gsignal.c:3780 #5 0x00007f9722977861 in g_signal_emit_valist (instance=<optimized out>, signal_id=<optimized out>, detail=<optimized out>, var_args=var_args@entry=0x7ffe4d3fbf10) at ../gobject/gsignal.c:3497 #6 0x00007f97229779c3 in g_signal_emit (instance=<optimized out>, signal_id=<optimized out>, detail=<optimized out>) at ../gobject/gsignal.c:3553 #7 0x00007f972295e179 in _g_closure_invoke_va (closure=closure@entry=0x561af506dc60, return_value=return_value@entry=0x0, instance=instance@entry=0x561af55ed080, args=args@entry=0x7ffe4d3fc1e0, n_params=0, param_types=0x0) at ../gobject/gclosure.c:873 #8 0x00007f97229777df in g_signal_emit_valist (instance=0x561af55ed080, signal_id=<optimized out>, detail=0, var_args=var_args@entry=0x7ffe4d3fc1e0) at ../gobject/gsignal.c:3406 #10 0x00007f972439762a in gtk_widget_grab_focus (widget=0x561af55ed080 [WebKitWebViewBase]) at ../gtk/gtkwidget.c:8097 #11 0x00007f972bb596b0 in webkitWebViewBaseSynthesizeMouseEvent(_WebKitWebViewBase*, MouseEventType, unsigned int, unsigned short, int, int, unsigned int, int, WTF::String const&) (webViewBase=0x561af55ed080 [WebKitWebViewBase], type=MouseEventType::Press, button=1, buttons=256, x=96, y=444, modifiers=0, clickCount=1, pointerType=...) at ../../Source/WebKit/UIProcess/API/gtk/WebKitWebViewBase.cpp:2726 1758933 1 428286 cgarcia 2021-05-11 09:54:18 -0700 Created attachment 428286 Patch 1758934 2 ews-watchlist 2021-05-11 09:55:27 -0700 Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See https://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API 1759599 3 cgarcia 2021-05-13 02:53:30 -0700 Committed r277428 (237676@main): <https://commits.webkit.org/237676@main> 428286 2021-05-11 09:54:18 -0700 2021-05-12 09:00:16 -0700 Patch wkgtk-grab-focus-crash.diff text/plain 2009 cgarcia ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9DaGFu Z2VMb2cKaW5kZXggZDExYWU1ZTYwOTdlLi4zM2YwZmUyN2FhYzYgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMg KzEsMTYgQEAKKzIwMjEtMDUtMTEgIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2Fs aWEuY29tPgorCisgICAgICAgIFJFR1JFU1NJT04ocjI3NzI2Mik6IHRlc3QgaW1wb3J0ZWQvdzNj L3dlYi1wbGF0Zm9ybS10ZXN0cy9jc3Mvc2VsZWN0b3JzL2ZvY3VzLXZpc2libGUtMDAyLmh0bWwg aXMgY3Jhc2hpbmcKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTIyNTY1OQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgIERvIG5vdCB0cnkgdG8gZ3JhYiBmb2N1cyBvbiBXZWJWaWV3IHdpZGdldCBmb3Igc3ludGhl c2l6ZWQgbW91c2UgcHJlc3MgYW5kIHJlbGVhc2UgZXZlbnRzIGlmIHRoZSB3aWRnZXQgaGFzCisg ICAgICAgIGFscmVhZHkgdGhlIGZvY3VzIG9yIGlzIG5vdCB0aGUgY3VycmVudCB0b3BsZXZlbCBm b2N1cyB3aWRnZXQuCisKKyAgICAgICAgKiBVSVByb2Nlc3MvQVBJL2d0ay9XZWJLaXRXZWJWaWV3 QmFzZS5jcHA6CisgICAgICAgICh3ZWJraXRXZWJWaWV3QmFzZVN5bnRoZXNpemVNb3VzZUV2ZW50 KToKKwogMjAyMS0wNS0xMCAgV2Vuc29uIEhzaWVoICA8d2Vuc29uX2hzaWVoQGFwcGxlLmNvbT4K IAogICAgICAgICBbbWFjT1NdIEFsbG93IGltbWVkaWF0ZSBhY3Rpb24gZ2VzdHVyZXMgdG8gYmVn aW4gd2hlbiBmb3JjZSBjbGlja2luZyB0ZXh0IGluc2lkZSBpbWFnZSBvdmVybGF5cwpkaWZmIC0t Z2l0IGEvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvQVBJL2d0ay9XZWJLaXRXZWJWaWV3QmFzZS5j cHAgYi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9BUEkvZ3RrL1dlYktpdFdlYlZpZXdCYXNlLmNw cAppbmRleCAyZWEwMDU4ODJlM2QuLmU3ODI4NTQ5NGM4MiAxMDA2NDQKLS0tIGEvU291cmNlL1dl YktpdC9VSVByb2Nlc3MvQVBJL2d0ay9XZWJLaXRXZWJWaWV3QmFzZS5jcHAKKysrIGIvU291cmNl L1dlYktpdC9VSVByb2Nlc3MvQVBJL2d0ay9XZWJLaXRXZWJWaWV3QmFzZS5jcHAKQEAgLTI3MjMs MTEgKzI3MjMsMTMgQEAgdm9pZCB3ZWJraXRXZWJWaWV3QmFzZVN5bnRoZXNpemVNb3VzZUV2ZW50 KFdlYktpdFdlYlZpZXdCYXNlKiB3ZWJWaWV3QmFzZSwgTW91c2UKICAgICAgICAgICAgIHByaXYt PmNvbnRleHRNZW51RXZlbnQgPSBXVEZNb3ZlKGV2ZW50KTsKICAgICAgICAgfQogI2VuZGlmCi0g ICAgICAgIGd0a193aWRnZXRfZ3JhYl9mb2N1cyhHVEtfV0lER0VUKHdlYlZpZXdCYXNlKSk7Cisg ICAgICAgIGlmICghZ3RrX3dpZGdldF9oYXNfZm9jdXMoR1RLX1dJREdFVCh3ZWJWaWV3QmFzZSkp ICYmIGd0a193aWRnZXRfaXNfZm9jdXMoR1RLX1dJREdFVCh3ZWJWaWV3QmFzZSkpKQorICAgICAg ICAgICAgZ3RrX3dpZGdldF9ncmFiX2ZvY3VzKEdUS19XSURHRVQod2ViVmlld0Jhc2UpKTsKICAg ICAgICAgYnJlYWs7CiAgICAgY2FzZSBNb3VzZUV2ZW50VHlwZTo6UmVsZWFzZToKICAgICAgICAg d2ViRXZlbnRUeXBlID0gV2ViRXZlbnQ6Ok1vdXNlVXA7Ci0gICAgICAgIGd0a193aWRnZXRfZ3Jh Yl9mb2N1cyhHVEtfV0lER0VUKHdlYlZpZXdCYXNlKSk7CisgICAgICAgIGlmICghZ3RrX3dpZGdl dF9oYXNfZm9jdXMoR1RLX1dJREdFVCh3ZWJWaWV3QmFzZSkpICYmIGd0a193aWRnZXRfaXNfZm9j dXMoR1RLX1dJREdFVCh3ZWJWaWV3QmFzZSkpKQorICAgICAgICAgICAgZ3RrX3dpZGdldF9ncmFi X2ZvY3VzKEdUS19XSURHRVQod2ViVmlld0Jhc2UpKTsKICAgICAgICAgYnJlYWs7CiAgICAgY2Fz ZSBNb3VzZUV2ZW50VHlwZTo6TW90aW9uOgogICAgICAgICB3ZWJFdmVudFR5cGUgPSBXZWJFdmVu dDo6TW91c2VNb3ZlOwo=