225649 2021-05-11 04:28:15 -0700 REGRESSION(r277083): Proximity scroll snap is broken on iOS 2021-05-12 01:10:16 -0700 1 1 1 Unclassified WebKit Scrolling WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 mrobinson mrobinson simon.fraser webkit-bug-importer oldest_to_newest 1758872 0 mrobinson 2021-05-11 04:28:15 -0700 Instead of respecting the proximity setting, scroll snap always uses the mandatory setting. 1758883 1 428267 mrobinson 2021-05-11 06:13:53 -0700 Created attachment 428267 Patch 1758887 2 428270 mrobinson 2021-05-11 06:37:12 -0700 Created attachment 428270 Patch 1758965 3 428270 simon.fraser 2021-05-11 10:40:44 -0700 Comment on attachment 428270 Patch Please check the failing tests. 1759191 4 428270 mrobinson 2021-05-12 01:00:17 -0700 Comment on attachment 428270 Patch Thanks for the review! It looks like all the EWS bubbles are green so I'm going to land this one. 1759196 5 ews-feeder 2021-05-12 01:09:15 -0700 Committed r277362 (237620@main): <https://commits.webkit.org/237620@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 428270. 1759197 6 webkit-bug-importer 2021-05-12 01:10:16 -0700 <rdar://problem/77889995> 428267 2021-05-11 06:13:53 -0700 2021-05-11 06:47:12 -0700 Patch bug-225649-20210511151352.patch text/plain 2979 mrobinson U3VidmVyc2lvbiBSZXZpc2lvbjogMjc3MzE5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGQxMWFlNWU2MDk3ZTNjOGJm Yjc1ZDk4ZWQ5N2EyMmVlOWQ2MzBkZTcuLjI0ZmMxMGFiNmRhOWFlOWYwYTkwN2Q0N2M0MmEyMmMz ZDVmZGY3YjQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTggQEAKKzIwMjEtMDUtMTEgIE1hcnRpbiBS b2JpbnNvbiAgPG1yb2JpbnNvbkBpZ2FsaWEuY29tPgorCisgICAgICAgIFJFR1JFU1NJT04ocjI3 NzA4Myk6IFByb3hpbWl0eSBzY3JvbGwgc25hcCBpcyBicm9rZW4gb24gaU9TCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMjU2NDkKKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBObyBuZXcgdGVzdHMuIGlPUyBk b2VzIG5vdCBoYXZlIGdyZWF0IHN1cHBvcnQgZm9yIHRoZSBldmVudCBzZW5kaW5nIHRlc3QKKyAg ICAgICAgaW5mcmFzdHJ1Y3R1cmUgdXNlZCB0byB0ZXN0IHNjcm9sbCBzbmFwLgorCisgICAgICAg ICogU2hhcmVkL1JlbW90ZUxheWVyVHJlZS9SZW1vdGVTY3JvbGxpbmdDb29yZGluYXRvclRyYW5z YWN0aW9uLmNwcDoKKyAgICAgICAgKEFyZ3VtZW50Q29kZXI8RmxvYXRTY3JvbGxTbmFwT2Zmc2V0 c0luZm8+OjplbmNvZGUpOiBJbmNsdWRlIHRoZSBzbmFwIHR5cGUgd2hlbiBlbmNvZGluZyBTY3Jv bGxTbmFwT2Zmc2V0c0luZm8uCisgICAgICAgIChBcmd1bWVudENvZGVyPEZsb2F0U2Nyb2xsU25h cE9mZnNldHNJbmZvPjo6ZGVjb2RlKTogSW5jbHVkZSB0aGUgc25hcCB0eXBlIHdoZW4gZGVjb2Rp bmcgU2Nyb2xsU25hcE9mZnNldHNJbmZvLgorICAgICAgICAqIFNoYXJlZC9XZWJDb3JlQXJndW1l bnRDb2RlcnMuaDogQWRkZWQgRW51bVRyYWl0cyBmb3IgU2Nyb2xsU25hcFN0cmljdG5lc3MuCisK IDIwMjEtMDUtMTAgIFdlbnNvbiBIc2llaCAgPHdlbnNvbl9oc2llaEBhcHBsZS5jb20+CiAKICAg ICAgICAgW21hY09TXSBBbGxvdyBpbW1lZGlhdGUgYWN0aW9uIGdlc3R1cmVzIHRvIGJlZ2luIHdo ZW4gZm9yY2UgY2xpY2tpbmcgdGV4dCBpbnNpZGUgaW1hZ2Ugb3ZlcmxheXMKZGlmZiAtLWdpdCBh L1NvdXJjZS9XZWJLaXQvU2hhcmVkL1JlbW90ZUxheWVyVHJlZS9SZW1vdGVTY3JvbGxpbmdDb29y ZGluYXRvclRyYW5zYWN0aW9uLmNwcCBiL1NvdXJjZS9XZWJLaXQvU2hhcmVkL1JlbW90ZUxheWVy VHJlZS9SZW1vdGVTY3JvbGxpbmdDb29yZGluYXRvclRyYW5zYWN0aW9uLmNwcAppbmRleCA4NzAx MDVjNjM2MjhmNTRjMjU4ODY4YmQzMmE5NWNiYTA4ODBmM2NjLi41ZDRhOTc4OGY0MzZkNjg3NmY0 YWRjZWM4YTJjMmIyYjliYzExNTdmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L1NoYXJlZC9S ZW1vdGVMYXllclRyZWUvUmVtb3RlU2Nyb2xsaW5nQ29vcmRpbmF0b3JUcmFuc2FjdGlvbi5jcHAK KysrIGIvU291cmNlL1dlYktpdC9TaGFyZWQvUmVtb3RlTGF5ZXJUcmVlL1JlbW90ZVNjcm9sbGlu Z0Nvb3JkaW5hdG9yVHJhbnNhY3Rpb24uY3BwCkBAIC01NTAsNiArNTUwLDcgQEAgdm9pZCBBcmd1 bWVudENvZGVyPEZsb2F0U2Nyb2xsU25hcE9mZnNldHNJbmZvPjo6ZW5jb2RlKEVuY29kZXImIGVu Y29kZXIsIGNvbnN0IEYKIHsKICAgICBlbmNvZGVyIDw8IGluZm8uaG9yaXpvbnRhbFNuYXBPZmZz ZXRzOwogICAgIGVuY29kZXIgPDwgaW5mby52ZXJ0aWNhbFNuYXBPZmZzZXRzOworICAgIGVuY29k ZXIgPDwgaW5mby5zdHJpY3RuZXNzOwogICAgIGVuY29kZXIgPDwgaW5mby5zbmFwQXJlYXM7CiB9 CiAKQEAgLTU1OSw2ICs1NjAsOCBAQCBib29sIEFyZ3VtZW50Q29kZXI8RmxvYXRTY3JvbGxTbmFw T2Zmc2V0c0luZm8+OjpkZWNvZGUoRGVjb2RlciYgZGVjb2RlciwgRmxvYXRTYwogICAgICAgICBy ZXR1cm4gZmFsc2U7CiAgICAgaWYgKCFkZWNvZGVyLmRlY29kZShpbmZvLnZlcnRpY2FsU25hcE9m ZnNldHMpKQogICAgICAgICByZXR1cm4gZmFsc2U7CisgICAgaWYgKCFkZWNvZGVyLmRlY29kZShp bmZvLnN0cmljdG5lc3MpKQorICAgICAgICByZXR1cm4gZmFsc2U7CiAgICAgaWYgKCFkZWNvZGVy LmRlY29kZShpbmZvLnNuYXBBcmVhcykpCiAgICAgICAgIHJldHVybiBmYWxzZTsKICAgICByZXR1 cm4gdHJ1ZTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvU2hhcmVkL1dlYkNvcmVBcmd1bWVu dENvZGVycy5oIGIvU291cmNlL1dlYktpdC9TaGFyZWQvV2ViQ29yZUFyZ3VtZW50Q29kZXJzLmgK aW5kZXggMjZiYjIwNTA3NDExMzE0ZjgzOWFiNzg0YjNkYWJkYWRkZTY3ZDI0My4uZTZmZjcyMGUy NjBjODNlOGQ3NDA0MDYyNGFlYmE3MTQyYjQ5MzY0ZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktp dC9TaGFyZWQvV2ViQ29yZUFyZ3VtZW50Q29kZXJzLmgKKysrIGIvU291cmNlL1dlYktpdC9TaGFy ZWQvV2ViQ29yZUFyZ3VtZW50Q29kZXJzLmgKQEAgLTEwMTIsNCArMTAxMiwxMyBAQCB0ZW1wbGF0 ZSA8PiBzdHJ1Y3QgRW51bVRyYWl0czxXZWJDb3JlOjpHcmFwaGljc0NvbnRleHRHTDo6U2ltdWxh dGVkRXZlbnRGb3JUZXN0aQogfTsKICNlbmRpZgogCit0ZW1wbGF0ZTw+IHN0cnVjdCBXVEY6OkVu dW1UcmFpdHM8V2ViQ29yZTo6U2Nyb2xsU25hcFN0cmljdG5lc3M+IHsKKyAgICB1c2luZyB2YWx1 ZXMgPSBXVEY6OkVudW1WYWx1ZXM8CisgICAgICAgIFdlYkNvcmU6OlNjcm9sbFNuYXBTdHJpY3Ru ZXNzLAorICAgICAgICBXZWJDb3JlOjpTY3JvbGxTbmFwU3RyaWN0bmVzczo6Tm9uZSwKKyAgICAg ICAgV2ViQ29yZTo6U2Nyb2xsU25hcFN0cmljdG5lc3M6OlByb3hpbWl0eSwKKyAgICAgICAgV2Vi Q29yZTo6U2Nyb2xsU25hcFN0cmljdG5lc3M6Ok1hbmRhdG9yeQorICAgID47Cit9OworCiB9IC8v IG5hbWVzcGFjZSBXVEYK 428270 2021-05-11 06:37:12 -0700 2021-05-12 01:09:15 -0700 Patch bug-225649-20210511153711.patch text/plain 2969 mrobinson U3VidmVyc2lvbiBSZXZpc2lvbjogMjc3MzE5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGQxMWFlNWU2MDk3ZTNjOGJm Yjc1ZDk4ZWQ5N2EyMmVlOWQ2MzBkZTcuLjI0ZmMxMGFiNmRhOWFlOWYwYTkwN2Q0N2M0MmEyMmMz ZDVmZGY3YjQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTggQEAKKzIwMjEtMDUtMTEgIE1hcnRpbiBS b2JpbnNvbiAgPG1yb2JpbnNvbkBpZ2FsaWEuY29tPgorCisgICAgICAgIFJFR1JFU1NJT04ocjI3 NzA4Myk6IFByb3hpbWl0eSBzY3JvbGwgc25hcCBpcyBicm9rZW4gb24gaU9TCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMjU2NDkKKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBObyBuZXcgdGVzdHMuIGlPUyBk b2VzIG5vdCBoYXZlIGdyZWF0IHN1cHBvcnQgZm9yIHRoZSBldmVudCBzZW5kaW5nIHRlc3QKKyAg ICAgICAgaW5mcmFzdHJ1Y3R1cmUgdXNlZCB0byB0ZXN0IHNjcm9sbCBzbmFwLgorCisgICAgICAg ICogU2hhcmVkL1JlbW90ZUxheWVyVHJlZS9SZW1vdGVTY3JvbGxpbmdDb29yZGluYXRvclRyYW5z YWN0aW9uLmNwcDoKKyAgICAgICAgKEFyZ3VtZW50Q29kZXI8RmxvYXRTY3JvbGxTbmFwT2Zmc2V0 c0luZm8+OjplbmNvZGUpOiBJbmNsdWRlIHRoZSBzbmFwIHR5cGUgd2hlbiBlbmNvZGluZyBTY3Jv bGxTbmFwT2Zmc2V0c0luZm8uCisgICAgICAgIChBcmd1bWVudENvZGVyPEZsb2F0U2Nyb2xsU25h cE9mZnNldHNJbmZvPjo6ZGVjb2RlKTogSW5jbHVkZSB0aGUgc25hcCB0eXBlIHdoZW4gZGVjb2Rp bmcgU2Nyb2xsU25hcE9mZnNldHNJbmZvLgorICAgICAgICAqIFNoYXJlZC9XZWJDb3JlQXJndW1l bnRDb2RlcnMuaDogQWRkZWQgRW51bVRyYWl0cyBmb3IgU2Nyb2xsU25hcFN0cmljdG5lc3MuCisK IDIwMjEtMDUtMTAgIFdlbnNvbiBIc2llaCAgPHdlbnNvbl9oc2llaEBhcHBsZS5jb20+CiAKICAg ICAgICAgW21hY09TXSBBbGxvdyBpbW1lZGlhdGUgYWN0aW9uIGdlc3R1cmVzIHRvIGJlZ2luIHdo ZW4gZm9yY2UgY2xpY2tpbmcgdGV4dCBpbnNpZGUgaW1hZ2Ugb3ZlcmxheXMKZGlmZiAtLWdpdCBh L1NvdXJjZS9XZWJLaXQvU2hhcmVkL1JlbW90ZUxheWVyVHJlZS9SZW1vdGVTY3JvbGxpbmdDb29y ZGluYXRvclRyYW5zYWN0aW9uLmNwcCBiL1NvdXJjZS9XZWJLaXQvU2hhcmVkL1JlbW90ZUxheWVy VHJlZS9SZW1vdGVTY3JvbGxpbmdDb29yZGluYXRvclRyYW5zYWN0aW9uLmNwcAppbmRleCA4NzAx MDVjNjM2MjhmNTRjMjU4ODY4YmQzMmE5NWNiYTA4ODBmM2NjLi41ZDRhOTc4OGY0MzZkNjg3NmY0 YWRjZWM4YTJjMmIyYjliYzExNTdmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L1NoYXJlZC9S ZW1vdGVMYXllclRyZWUvUmVtb3RlU2Nyb2xsaW5nQ29vcmRpbmF0b3JUcmFuc2FjdGlvbi5jcHAK KysrIGIvU291cmNlL1dlYktpdC9TaGFyZWQvUmVtb3RlTGF5ZXJUcmVlL1JlbW90ZVNjcm9sbGlu Z0Nvb3JkaW5hdG9yVHJhbnNhY3Rpb24uY3BwCkBAIC01NTAsNiArNTUwLDcgQEAgdm9pZCBBcmd1 bWVudENvZGVyPEZsb2F0U2Nyb2xsU25hcE9mZnNldHNJbmZvPjo6ZW5jb2RlKEVuY29kZXImIGVu Y29kZXIsIGNvbnN0IEYKIHsKICAgICBlbmNvZGVyIDw8IGluZm8uaG9yaXpvbnRhbFNuYXBPZmZz ZXRzOwogICAgIGVuY29kZXIgPDwgaW5mby52ZXJ0aWNhbFNuYXBPZmZzZXRzOworICAgIGVuY29k ZXIgPDwgaW5mby5zdHJpY3RuZXNzOwogICAgIGVuY29kZXIgPDwgaW5mby5zbmFwQXJlYXM7CiB9 CiAKQEAgLTU1OSw2ICs1NjAsOCBAQCBib29sIEFyZ3VtZW50Q29kZXI8RmxvYXRTY3JvbGxTbmFw T2Zmc2V0c0luZm8+OjpkZWNvZGUoRGVjb2RlciYgZGVjb2RlciwgRmxvYXRTYwogICAgICAgICBy ZXR1cm4gZmFsc2U7CiAgICAgaWYgKCFkZWNvZGVyLmRlY29kZShpbmZvLnZlcnRpY2FsU25hcE9m ZnNldHMpKQogICAgICAgICByZXR1cm4gZmFsc2U7CisgICAgaWYgKCFkZWNvZGVyLmRlY29kZShp bmZvLnN0cmljdG5lc3MpKQorICAgICAgICByZXR1cm4gZmFsc2U7CiAgICAgaWYgKCFkZWNvZGVy LmRlY29kZShpbmZvLnNuYXBBcmVhcykpCiAgICAgICAgIHJldHVybiBmYWxzZTsKICAgICByZXR1 cm4gdHJ1ZTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvU2hhcmVkL1dlYkNvcmVBcmd1bWVu dENvZGVycy5oIGIvU291cmNlL1dlYktpdC9TaGFyZWQvV2ViQ29yZUFyZ3VtZW50Q29kZXJzLmgK aW5kZXggMjZiYjIwNTA3NDExMzE0ZjgzOWFiNzg0YjNkYWJkYWRkZTY3ZDI0My4uY2ZjMzk2Mjhh OTUwZjQyYzFhNjE0YmU5N2M3ZTU1MjE1NGM4Y2E1OSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktp dC9TaGFyZWQvV2ViQ29yZUFyZ3VtZW50Q29kZXJzLmgKKysrIGIvU291cmNlL1dlYktpdC9TaGFy ZWQvV2ViQ29yZUFyZ3VtZW50Q29kZXJzLmgKQEAgLTEwMTIsNCArMTAxMiwxMyBAQCB0ZW1wbGF0 ZSA8PiBzdHJ1Y3QgRW51bVRyYWl0czxXZWJDb3JlOjpHcmFwaGljc0NvbnRleHRHTDo6U2ltdWxh dGVkRXZlbnRGb3JUZXN0aQogfTsKICNlbmRpZgogCit0ZW1wbGF0ZTw+IHN0cnVjdCBFbnVtVHJh aXRzPFdlYkNvcmU6OlNjcm9sbFNuYXBTdHJpY3RuZXNzPiB7CisgICAgdXNpbmcgdmFsdWVzID0g RW51bVZhbHVlczwKKyAgICAgICAgV2ViQ29yZTo6U2Nyb2xsU25hcFN0cmljdG5lc3MsCisgICAg ICAgIFdlYkNvcmU6OlNjcm9sbFNuYXBTdHJpY3RuZXNzOjpOb25lLAorICAgICAgICBXZWJDb3Jl OjpTY3JvbGxTbmFwU3RyaWN0bmVzczo6UHJveGltaXR5LAorICAgICAgICBXZWJDb3JlOjpTY3Jv bGxTbmFwU3RyaWN0bmVzczo6TWFuZGF0b3J5CisgICAgPjsKK307CisKIH0gLy8gbmFtZXNwYWNl IFdURgo=