225648 2021-05-11 04:15:09 -0700 Many canvas/media aspect-ratio failures 2021-05-18 04:16:18 -0700 1 1 1 Unclassified WebKit CSS WebKit Nightly Build Unspecified Unspecified NEW InRadar P2 Normal --- 217529 1 annevk webkit-unassigned cathiechen gsnedders rbuis simon.fraser webkit-bug-importer oldest_to_newest 1758870 0 annevk 2021-05-11 04:15:09 -0700 In cleaning up some aspects of the specification around aspect-ratio, I found that WebKit fails a bunch of tests: https://github.com/web-platform-tests/wpt/pull/28932. Cleanup happening in https://github.com/whatwg/html/pull/6529. 1759015 1 rbuis 2021-05-11 11:55:45 -0700 Cathie, IIRC you implemented this for one of video, image or canvas? We probably have existing bugs for these, which if fixed would fix these tests. 1759016 2 rbuis 2021-05-11 12:01:40 -0700 I think bugs like this have to be fixed first: https://bugs.webkit.org/show_bug.cgi?id=217529 1759163 3 annevk 2021-05-11 22:27:44 -0700 Ah thanks for finding that Rob! that might be the whole issue here for all I know. 1759216 4 cathiechen 2021-05-12 01:59:53 -0700 (In reply to Rob Buis from comment #1) > Cathie, IIRC you implemented this for one of video, image or canvas? We > probably have existing bugs for these, which if fixed would fix these tests. Yeah, I'm working on implementing this for video and picture. It seems most failures are `test_computed_style_aspect_ratio` which is related to bug 217529, i.e. implement mapping width height to aspect ratio by using CSS aspect-ratio. Currently, the implementation in WebKit does not depend on CSS aspect-ratio. 1761123 5 webkit-bug-importer 2021-05-18 04:16:18 -0700 <rdar://problem/78149269>