225642 2021-05-11 01:24:10 -0700 Fix compile warning in non-CG platforms after r277232 2021-05-13 01:26:36 -0700 1 1 1 Unclassified WebKit Platform WebKit Nightly Build Unspecified Unspecified RESOLVED CONFIGURATION CHANGED https://bugs.webkit.org/show_bug.cgi?id=225335 P2 Normal --- 1 cgarcia webkit-unassigned aperez ggaren lmoura mmaxfield simon.fraser oldest_to_newest 1758847 0 cgarcia 2021-05-11 01:24:10 -0700 In file included from WebCore/PrivateHeaders/WebCore/Font.h:30, from WebCore/PrivateHeaders/WebCore/FontCascade.h:28, from WebCore/PrivateHeaders/WebCore/GraphicsContext.h:32, from WebCore/PrivateHeaders/WebCore/FrameView.h:31, from ../../Source/WebKit/WebProcess/InjectedBundle/API/glib/WebKitWebPage.cpp:56: WebCore/PrivateHeaders/WebCore/GlyphBuffer.h: In member function ‘WTF::Optional<unsigned int> WebCore::GlyphBuffer::checkedStringOffsetAt(unsigned int, unsigned int) const’: WebCore/PrivateHeaders/WebCore/GlyphBuffer.h:81:20: warning: comparison of unsigned expression in ‘< 0’ is always false [-Wtype-limits] 81 | if (result < 0 || static_cast<unsigned>(result) >= stringLength) | 1758848 1 428255 cgarcia 2021-05-11 01:25:35 -0700 Created attachment 428255 Patch 1759575 2 ews-feeder 2021-05-13 01:08:30 -0700 Tools/Scripts/svn-apply failed to apply attachment 428255 to trunk. Please resolve the conflicts and upload a new patch. 1759578 3 cgarcia 2021-05-13 01:26:36 -0700 Darin fixed this in r277355 428255 2021-05-11 01:25:35 -0700 2021-05-13 01:26:04 -0700 Patch wcore-warning.diff text/plain 1427 cgarcia ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBlMzk1ZTNmMzg3YzYuLjFhZjRhNjFiZTUwMCAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAt MSwzICsxLDE1IEBACisyMDIxLTA1LTExICBDYXJsb3MgR2FyY2lhIENhbXBvcyAgPGNnYXJjaWFA aWdhbGlhLmNvbT4KKworICAgICAgICBGaXggY29tcGlsZSB3YXJuaW5nIGluIG5vbi1DRyBwbGF0 Zm9ybXMgYWZ0ZXIgcjI3NzIzMgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MjI1NjQyCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgR2x5cGhCdWZmZXJTdHJpbmdPZmZzZXQgaXMgdW5zaWduZWQgaW4gbm9uLUNH IHBsYXRmb3Jtcy4KKworICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL0dseXBoQnVmZmVyLmg6 CisgICAgICAgIChXZWJDb3JlOjpHbHlwaEJ1ZmZlcjo6Y2hlY2tlZFN0cmluZ09mZnNldEF0IGNv bnN0KToKKwogMjAyMS0wNS0xMCAgV2Vuc29uIEhzaWVoICA8d2Vuc29uX2hzaWVoQGFwcGxlLmNv bT4KIAogICAgICAgICBbbWFjT1NdIEFsbG93IGltbWVkaWF0ZSBhY3Rpb24gZ2VzdHVyZXMgdG8g YmVnaW4gd2hlbiBmb3JjZSBjbGlja2luZyB0ZXh0IGluc2lkZSBpbWFnZSBvdmVybGF5cwpkaWZm IC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvR2x5cGhCdWZmZXIuaCBi L1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL0dseXBoQnVmZmVyLmgKaW5kZXggOWFk MTljN2E0ZjU0Li5hZmQ1NjAyMzRjNjEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRm b3JtL2dyYXBoaWNzL0dseXBoQnVmZmVyLmgKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0v Z3JhcGhpY3MvR2x5cGhCdWZmZXIuaApAQCAtNzgsOCArNzgsMTMgQEAgcHVibGljOgogICAgIE9w dGlvbmFsPEdseXBoQnVmZmVyU3RyaW5nT2Zmc2V0PiBjaGVja2VkU3RyaW5nT2Zmc2V0QXQodW5z aWduZWQgaW5kZXgsIHVuc2lnbmVkIHN0cmluZ0xlbmd0aCkgY29uc3QKICAgICB7CiAgICAgICAg IGF1dG8gcmVzdWx0ID0gdW5jaGVja2VkU3RyaW5nT2Zmc2V0QXQoaW5kZXgpOworI2lmIFVTRShD RykKICAgICAgICAgaWYgKHJlc3VsdCA8IDAgfHwgc3RhdGljX2Nhc3Q8dW5zaWduZWQ+KHJlc3Vs dCkgPj0gc3RyaW5nTGVuZ3RoKQogICAgICAgICAgICAgcmV0dXJuIFdURjo6bnVsbG9wdDsKKyNl bHNlCisgICAgICAgIGlmIChyZXN1bHQgPj0gc3RyaW5nTGVuZ3RoKQorICAgICAgICAgICAgcmV0 dXJuIFdURjo6bnVsbG9wdDsKKyNlbmRpZgogICAgICAgICByZXR1cm4gcmVzdWx0OwogICAgIH0K IAo=