225627 2021-05-10 17:26:53 -0700 Removed unused CallRecord::bytecodeIndex field. 2021-05-10 17:46:19 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 mark.lam mark.lam ews-watchlist keith_miller msaboff saam tzagallo webkit-bug-importer ysuzuki oldest_to_newest 1758749 0 mark.lam 2021-05-10 17:26:53 -0700 Patch coming. 1758750 1 428229 mark.lam 2021-05-10 17:30:25 -0700 Created attachment 428229 proposed patch. 1758751 2 428229 ysuzuki 2021-05-10 17:32:22 -0700 Comment on attachment 428229 proposed patch. r=me 1758755 3 mark.lam 2021-05-10 17:45:45 -0700 Thanks for the review. Landed in r277312: <http://trac.webkit.org/r277312>. 1758756 4 webkit-bug-importer 2021-05-10 17:46:19 -0700 <rdar://problem/77798056> 428229 2021-05-10 17:30:25 -0700 2021-05-10 17:32:22 -0700 proposed patch. bug-225627.patch text/plain 5430 mark.lam SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMjc3MzA4KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE4IEBA CisyMDIxLTA1LTEwICBNYXJrIExhbSAgPG1hcmsubGFtQGFwcGxlLmNvbT4KKworICAgICAgICBS ZW1vdmVkIHVudXNlZCBDYWxsUmVjb3JkOjpieXRlY29kZUluZGV4IGZpZWxkLgorICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjI1NjI3CisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBqaXQvSklULmNwcDoKKyAg ICAgICAgKEpTQzo6SklUOjpwcml2YXRlQ29tcGlsZUV4Y2VwdGlvbkhhbmRsZXJzKToKKyAgICAg ICAgKiBqaXQvSklULmg6CisgICAgICAgIChKU0M6OkNhbGxSZWNvcmQ6OkNhbGxSZWNvcmQpOgor ICAgICAgICAqIGppdC9KSVRJbmxpbmVzLmg6CisgICAgICAgIChKU0M6OkpJVDo6ZW1pdE5ha2Vk TmVhckNhbGwpOgorICAgICAgICAoSlNDOjpKSVQ6OmVtaXROYWtlZE5lYXJUYWlsQ2FsbCk6CisK IDIwMjEtMDUtMTAgIE1hcmsgTGFtICA8bWFyay5sYW1AYXBwbGUuY29tPgogCiAgICAgICAgIEFk ZCBzdXBwb3J0IHRvIGNvbGxlY3Qgc3RhdHMgb24gY3VtdWxhdGl2ZSBMaW5rQnVmZmVyIGxpbmtl ZCBzaXplcyBiYXNlZCBvbiBwcm9maWxlcy4KSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9q aXQvSklULmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvaml0L0pJVC5j cHAJKHJldmlzaW9uIDI3NzMwNykKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9qaXQvSklULmNw cAkod29ya2luZyBjb3B5KQpAQCAtMTAyNyw3ICsxMDI3LDcgQEAgdm9pZCBKSVQ6OnByaXZhdGVD b21waWxlRXhjZXB0aW9uSGFuZGxlcgogICAgICAgICAvLyBvcGVyYXRpb25Mb29rdXBFeGNlcHRp b25IYW5kbGVyRnJvbUNhbGxlckZyYW1lIGlzIHBhc3NlZCBvbmUgYXJndW1lbnQsIHRoZSBWTSou CiAgICAgICAgIG1vdmUoVHJ1c3RlZEltbVB0cigmdm0oKSksIEdQUkluZm86OmFyZ3VtZW50R1BS MCk7CiAgICAgICAgIHByZXBhcmVDYWxsT3BlcmF0aW9uKHZtKCkpOwotICAgICAgICBtX2ZhckNh bGxzLmFwcGVuZChGYXJDYWxsUmVjb3JkKGNhbGwoT3BlcmF0aW9uUHRyVGFnKSwgQnl0ZWNvZGVJ bmRleCgpLCBGdW5jdGlvblB0cjxPcGVyYXRpb25QdHJUYWc+KG9wZXJhdGlvbkxvb2t1cEV4Y2Vw dGlvbkhhbmRsZXJGcm9tQ2FsbGVyRnJhbWUpKSk7CisgICAgICAgIG1fZmFyQ2FsbHMuYXBwZW5k KEZhckNhbGxSZWNvcmQoY2FsbChPcGVyYXRpb25QdHJUYWcpLCBGdW5jdGlvblB0cjxPcGVyYXRp b25QdHJUYWc+KG9wZXJhdGlvbkxvb2t1cEV4Y2VwdGlvbkhhbmRsZXJGcm9tQ2FsbGVyRnJhbWUp KSk7CiAgICAgICAgIGp1bXBUb0V4Y2VwdGlvbkhhbmRsZXIodm0oKSk7CiAgICAgfQogCkBAIC0x MDQwLDcgKzEwNDAsNyBAQCB2b2lkIEpJVDo6cHJpdmF0ZUNvbXBpbGVFeGNlcHRpb25IYW5kbGVy CiAgICAgICAgIC8vIG9wZXJhdGlvbkxvb2t1cEV4Y2VwdGlvbkhhbmRsZXIgaXMgcGFzc2VkIG9u ZSBhcmd1bWVudCwgdGhlIFZNKi4KICAgICAgICAgbW92ZShUcnVzdGVkSW1tUHRyKCZ2bSgpKSwg R1BSSW5mbzo6YXJndW1lbnRHUFIwKTsKICAgICAgICAgcHJlcGFyZUNhbGxPcGVyYXRpb24odm0o KSk7Ci0gICAgICAgIG1fZmFyQ2FsbHMuYXBwZW5kKEZhckNhbGxSZWNvcmQoY2FsbChPcGVyYXRp b25QdHJUYWcpLCBCeXRlY29kZUluZGV4KCksIEZ1bmN0aW9uUHRyPE9wZXJhdGlvblB0clRhZz4o b3BlcmF0aW9uTG9va3VwRXhjZXB0aW9uSGFuZGxlcikpKTsKKyAgICAgICAgbV9mYXJDYWxscy5h cHBlbmQoRmFyQ2FsbFJlY29yZChjYWxsKE9wZXJhdGlvblB0clRhZyksIEZ1bmN0aW9uUHRyPE9w ZXJhdGlvblB0clRhZz4ob3BlcmF0aW9uTG9va3VwRXhjZXB0aW9uSGFuZGxlcikpKTsKICAgICAg ICAganVtcFRvRXhjZXB0aW9uSGFuZGxlcih2bSgpKTsKICAgICB9CiB9CkluZGV4OiBTb3VyY2Uv SmF2YVNjcmlwdENvcmUvaml0L0pJVC5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0 Q29yZS9qaXQvSklULmgJKHJldmlzaW9uIDI3NzMwNykKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29y ZS9qaXQvSklULmgJKHdvcmtpbmcgY29weSkKQEAgLTc4LDE2ICs3OCwxNCBAQCBuYW1lc3BhY2Ug SlNDIHsKICAgICB0ZW1wbGF0ZTxQdHJUYWcgdGFnPgogICAgIHN0cnVjdCBDYWxsUmVjb3JkIHsK ICAgICAgICAgTWFjcm9Bc3NlbWJsZXI6OkNhbGwgZnJvbTsKLSAgICAgICAgQnl0ZWNvZGVJbmRl eCBieXRlY29kZUluZGV4OwogICAgICAgICBGdW5jdGlvblB0cjx0YWc+IGNhbGxlZTsKIAogICAg ICAgICBDYWxsUmVjb3JkKCkKICAgICAgICAgewogICAgICAgICB9CiAKLSAgICAgICAgQ2FsbFJl Y29yZChNYWNyb0Fzc2VtYmxlcjo6Q2FsbCBmcm9tLCBCeXRlY29kZUluZGV4IGJ5dGVjb2RlSW5k ZXgsIEZ1bmN0aW9uUHRyPHRhZz4gY2FsbGVlKQorICAgICAgICBDYWxsUmVjb3JkKE1hY3JvQXNz ZW1ibGVyOjpDYWxsIGZyb20sIEZ1bmN0aW9uUHRyPHRhZz4gY2FsbGVlKQogICAgICAgICAgICAg OiBmcm9tKGZyb20pCi0gICAgICAgICAgICAsIGJ5dGVjb2RlSW5kZXgoYnl0ZWNvZGVJbmRleCkK ICAgICAgICAgICAgICwgY2FsbGVlKGNhbGxlZSkKICAgICAgICAgewogICAgICAgICB9CkBAIC0y NzksNyArMjc3LDcgQEAgbmFtZXNwYWNlIEpTQyB7CiAgICAgICAgIENhbGwgYXBwZW5kQ2FsbChj b25zdCBGdW5jdGlvblB0cjxDRnVuY3Rpb25QdHJUYWc+IGZ1bmN0aW9uKQogICAgICAgICB7CiAg ICAgICAgICAgICBDYWxsIGZ1bmN0aW9uQ2FsbCA9IGNhbGwoT3BlcmF0aW9uUHRyVGFnKTsKLSAg ICAgICAgICAgIG1fZmFyQ2FsbHMuYXBwZW5kKEZhckNhbGxSZWNvcmQoZnVuY3Rpb25DYWxsLCBt X2J5dGVjb2RlSW5kZXgsIGZ1bmN0aW9uLnJldGFnZ2VkPE9wZXJhdGlvblB0clRhZz4oKSkpOwor ICAgICAgICAgICAgbV9mYXJDYWxscy5hcHBlbmQoRmFyQ2FsbFJlY29yZChmdW5jdGlvbkNhbGws IGZ1bmN0aW9uLnJldGFnZ2VkPE9wZXJhdGlvblB0clRhZz4oKSkpOwogICAgICAgICAgICAgcmV0 dXJuIGZ1bmN0aW9uQ2FsbDsKICAgICAgICAgfQogCkBAIC0yODcsNyArMjg1LDcgQEAgbmFtZXNw YWNlIEpTQyB7CiAgICAgICAgIENhbGwgYXBwZW5kQ2FsbFdpdGhTbG93UGF0aFJldHVyblR5cGUo Y29uc3QgRnVuY3Rpb25QdHI8Q0Z1bmN0aW9uUHRyVGFnPiBmdW5jdGlvbikKICAgICAgICAgewog ICAgICAgICAgICAgQ2FsbCBmdW5jdGlvbkNhbGwgPSBjYWxsV2l0aFNsb3dQYXRoUmV0dXJuVHlw ZShPcGVyYXRpb25QdHJUYWcpOwotICAgICAgICAgICAgbV9mYXJDYWxscy5hcHBlbmQoRmFyQ2Fs bFJlY29yZChmdW5jdGlvbkNhbGwsIG1fYnl0ZWNvZGVJbmRleCwgZnVuY3Rpb24ucmV0YWdnZWQ8 T3BlcmF0aW9uUHRyVGFnPigpKSk7CisgICAgICAgICAgICBtX2ZhckNhbGxzLmFwcGVuZChGYXJD YWxsUmVjb3JkKGZ1bmN0aW9uQ2FsbCwgZnVuY3Rpb24ucmV0YWdnZWQ8T3BlcmF0aW9uUHRyVGFn PigpKSk7CiAgICAgICAgICAgICByZXR1cm4gZnVuY3Rpb25DYWxsOwogICAgICAgICB9CiAjZW5k aWYKSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9qaXQvSklUSW5saW5lcy5oCj09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9qaXQvSklUSW5saW5lcy5oCShyZXZpc2lvbiAy NzczMDcpCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvaml0L0pJVElubGluZXMuaAkod29ya2lu ZyBjb3B5KQpAQCAtMSw1ICsxLDUgQEAKIC8qCi0gKiBDb3B5cmlnaHQgKEMpIDIwMDgtMjAxOSBB cHBsZSBJbmMuIEFsbCByaWdodHMgcmVzZXJ2ZWQuCisgKiBDb3B5cmlnaHQgKEMpIDIwMDgtMjAy MSBBcHBsZSBJbmMuIEFsbCByaWdodHMgcmVzZXJ2ZWQuCiAgKgogICogUmVkaXN0cmlidXRpb24g YW5kIHVzZSBpbiBzb3VyY2UgYW5kIGJpbmFyeSBmb3Jtcywgd2l0aCBvciB3aXRob3V0CiAgKiBt b2RpZmljYXRpb24sIGFyZSBwZXJtaXR0ZWQgcHJvdmlkZWQgdGhhdCB0aGUgZm9sbG93aW5nIGNv bmRpdGlvbnMKQEAgLTkzLDcgKzkzLDcgQEAgQUxXQVlTX0lOTElORSBKSVQ6OkNhbGwgSklUOjpl bWl0TmFrZWROZQogewogICAgIEFTU0VSVChtX2J5dGVjb2RlSW5kZXgpOyAvLyBUaGlzIG1ldGhv ZCBzaG91bGQgb25seSBiZSBjYWxsZWQgZHVyaW5nIGhvdC9jb2xkIHBhdGggZ2VuZXJhdGlvbiwg c28gdGhhdCBtX2J5dGVjb2RlSW5kZXggaXMgc2V0LgogICAgIENhbGwgbmFrZWRDYWxsID0gbmVh ckNhbGwoKTsKLSAgICBtX25lYXJDYWxscy5hcHBlbmQoTmVhckNhbGxSZWNvcmQobmFrZWRDYWxs LCBtX2J5dGVjb2RlSW5kZXgsIEZ1bmN0aW9uUHRyPEpTSW50ZXJuYWxQdHJUYWc+KHRhcmdldC5y ZXRhZ2dlZDxKU0ludGVybmFsUHRyVGFnPigpKSkpOworICAgIG1fbmVhckNhbGxzLmFwcGVuZChO ZWFyQ2FsbFJlY29yZChuYWtlZENhbGwsIEZ1bmN0aW9uUHRyPEpTSW50ZXJuYWxQdHJUYWc+KHRh cmdldC5yZXRhZ2dlZDxKU0ludGVybmFsUHRyVGFnPigpKSkpOwogICAgIHJldHVybiBuYWtlZENh bGw7CiB9CiAKQEAgLTEwMSw3ICsxMDEsNyBAQCBBTFdBWVNfSU5MSU5FIEpJVDo6Q2FsbCBKSVQ6 OmVtaXROYWtlZE5lCiB7CiAgICAgQVNTRVJUKG1fYnl0ZWNvZGVJbmRleCk7IC8vIFRoaXMgbWV0 aG9kIHNob3VsZCBvbmx5IGJlIGNhbGxlZCBkdXJpbmcgaG90L2NvbGQgcGF0aCBnZW5lcmF0aW9u LCBzbyB0aGF0IG1fYnl0ZWNvZGVJbmRleCBpcyBzZXQuCiAgICAgQ2FsbCBuYWtlZENhbGwgPSBu ZWFyVGFpbENhbGwoKTsKLSAgICBtX25lYXJDYWxscy5hcHBlbmQoTmVhckNhbGxSZWNvcmQobmFr ZWRDYWxsLCBtX2J5dGVjb2RlSW5kZXgsIEZ1bmN0aW9uUHRyPEpTSW50ZXJuYWxQdHJUYWc+KHRh cmdldC5yZXRhZ2dlZDxKU0ludGVybmFsUHRyVGFnPigpKSkpOworICAgIG1fbmVhckNhbGxzLmFw cGVuZChOZWFyQ2FsbFJlY29yZChuYWtlZENhbGwsIEZ1bmN0aW9uUHRyPEpTSW50ZXJuYWxQdHJU YWc+KHRhcmdldC5yZXRhZ2dlZDxKU0ludGVybmFsUHRyVGFnPigpKSkpOwogICAgIHJldHVybiBu YWtlZENhbGw7CiB9CiAK