225605 2021-05-10 12:25:10 -0700 Add null check in CachedResource::clearLoader 2021-05-10 14:17:21 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 achristensen achristensen cdumez ews-watchlist ggaren japhet webkit-bug-importer oldest_to_newest 1758593 0 achristensen 2021-05-10 12:25:10 -0700 Add null check in CachedResource::clearLoader 1758594 1 428193 achristensen 2021-05-10 12:26:03 -0700 Created attachment 428193 Patch 1758595 2 achristensen 2021-05-10 12:26:06 -0700 <rdar://problem/69912354> 1758599 3 428193 ggaren 2021-05-10 12:46:59 -0700 Comment on attachment 428193 Patch r=me You can make this fewer lines of code if you keep it as ASSERT(m_loader). 1758600 4 428193 achristensen 2021-05-10 12:49:33 -0700 Comment on attachment 428193 Patch I agree. I have received the feedback many times in the past that the WebKit developers don't like having code that looks like this: ASSERT(something); if (something) somethingIsTrue(); But for some reason they are ok with this. Maybe we should have another super-long style discussion on webkit-dev. 1758629 5 ews-feeder 2021-05-10 14:17:18 -0700 Committed r277292 (237553@main): <https://commits.webkit.org/237553@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 428193. 428193 2021-05-10 12:26:03 -0700 2021-05-10 14:17:20 -0700 Patch bug-225605-20210510122602.patch text/plain 1611 achristensen U3VidmVyc2lvbiBSZXZpc2lvbjogMjc3MjcxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMjRkMjljYmI3N2NkZDE5 ZTM3MWU0MmMzNDdhZGEyNDUxOGI2OWQ2MC4uZmY3NjQ0MGMxMzU3ZmMyNjY3YWFkZjdjN2QwMjY1 M2QxNzI4OWYxZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDIxLTA1LTEwICBBbGV4 IENocmlzdGVuc2VuICA8YWNocmlzdGVuc2VuQHdlYmtpdC5vcmc+CisKKyAgICAgICAgQWRkIG51 bGwgY2hlY2sgaW4gQ2FjaGVkUmVzb3VyY2U6OmNsZWFyTG9hZGVyCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMjU2MDUKKyAgICAgICAgPHJkYXI6Ly82 OTkxMjM1ND4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBBcyBtdWNoIGFzIHdlIHdvdWxkIGxpa2UgaXQgbm90IHRvIGJlIHRoZSBjYXNlLCB3ZSBoYXZl IHJlY29yZHMgdGhhdCBtX2xvYWRlciBjYW4gYmUgbnVsbC4KKyAgICAgICAgSWYgaXQncyBudWxs LCBsZXQncyBub3QgY3Jhc2guCisKKyAgICAgICAgKiBsb2FkZXIvY2FjaGUvQ2FjaGVkUmVzb3Vy Y2UuY3BwOgorICAgICAgICAoV2ViQ29yZTo6Q2FjaGVkUmVzb3VyY2U6OmNsZWFyTG9hZGVyKToK KwogMjAyMS0wNS0xMCAgRGV2aW4gUm91c3NvICA8ZHJvdXNzb0BhcHBsZS5jb20+CiAKICAgICAg ICAgQWRkIHN1cHBvcnQgZm9yIGEgYG1lZGlhYCBhdHRyaWJ1dGUgb24gYDxtZXRhIG5hbWU9InRo ZW1lLWNvbG9yIiBjb250ZW50PSIuLi4iPmAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2xv YWRlci9jYWNoZS9DYWNoZWRSZXNvdXJjZS5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9sb2FkZXIvY2Fj aGUvQ2FjaGVkUmVzb3VyY2UuY3BwCmluZGV4IGMxMmU3MzdkOWRiNTA2NzMwZjUyMWQ0ZDJlMTU4 ZmUxYzYxZDkxMmUuLmE0YjM1YTg0ZjlmZWUwMWNjOGI2ZTQyYjFhYmYwNWM2NmY3MTUwZjUgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2xvYWRlci9jYWNoZS9DYWNoZWRSZXNvdXJjZS5jcHAK KysrIGIvU291cmNlL1dlYkNvcmUvbG9hZGVyL2NhY2hlL0NhY2hlZFJlc291cmNlLmNwcApAQCAt NDg1LDggKzQ4NSwxMCBAQCB2b2lkIENhY2hlZFJlc291cmNlOjpyZXNwb25zZVJlY2VpdmVkKGNv bnN0IFJlc291cmNlUmVzcG9uc2UmIHJlc3BvbnNlKQogCiB2b2lkIENhY2hlZFJlc291cmNlOjpj bGVhckxvYWRlcigpCiB7Ci0gICAgQVNTRVJUKG1fbG9hZGVyKTsKLSAgICBtX2lkZW50aWZpZXJG b3JMb2FkV2l0aG91dFJlc291cmNlTG9hZGVyID0gbV9sb2FkZXItPmlkZW50aWZpZXIoKTsKKyAg ICBpZiAobV9sb2FkZXIpCisgICAgICAgIG1faWRlbnRpZmllckZvckxvYWRXaXRob3V0UmVzb3Vy Y2VMb2FkZXIgPSBtX2xvYWRlci0+aWRlbnRpZmllcigpOworICAgIGVsc2UKKyAgICAgICAgQVNT RVJUX05PVF9SRUFDSEVEKCk7CiAgICAgbV9sb2FkZXIgPSBudWxscHRyOwogICAgIGRlbGV0ZUlm UG9zc2libGUoKTsKIH0K