22560 2008-11-29 18:36:04 -0800 [GTK] Some Gtk Screen functions assume widgets are realized, leading to segfaults. 2008-12-11 02:26:54 -0800 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) PC Linux RESOLVED FIXED P2 Normal --- 1 racarr webkit-unassigned hortont424 oldest_to_newest 100744 0 racarr 2008-11-29 18:36:04 -0800 Code in PlatformScreenGtk for screenDepth and screenRect can not assume that the platformWindow for the widget has a valid "window" member, and doing so causes segfaults (screenDepth) or GLib warnings (screenRect). For example, the case of, a new browser view opening as a child of a GtkNotebook, but never being switched to, or manually realized. Solve by using the toplevel window of the widget, rather than the widget itself. 100745 1 25603 racarr 2008-11-29 18:37:07 -0800 Created attachment 25603 Patch to fix described problem, + changelog entry. 100747 2 25603 zecke 2008-11-29 19:41:46 -0800 Comment on attachment 25603 Patch to fix described problem, + changelog entry. > - GdkVisual* visual = gdk_drawable_get_visual(GDK_DRAWABLE(GTK_WIDGET(widget->root()->hostWindow()->platformWindow())->window)); > + if (!GTK_WIDGET_REALIZED(container)) > + { > + GtkWidget * toplevel = gtk_widget_get_toplevel(container); > + if (GTK_WIDGET_TOPLEVEL(toplevel)) > + container = toplevel; > + else > + return 24; > + } please see the WebKit.org CodingStyle guideleines. the '{' is on the wrong line, your indention is messed up, also the indention of the ChangeLog is messed. Please fix this and attach an updated version of the patch. 100749 3 25605 hortont424 2008-11-29 20:09:50 -0800 Created attachment 25605 Update to previous patch, fixing style mistakes. 100857 4 25605 eric 2008-12-01 12:40:36 -0800 Comment on attachment 25605 Update to previous patch, fixing style mistakes. You can leave the Requestee field blank when requesting review. 101468 5 25605 zecke 2008-12-05 04:01:21 -0800 Comment on attachment 25605 Update to previous patch, fixing style mistakes. > + Code in PlatformScreenGtk for screenDepth and screenRect can not oh well, It can assume it. In fact the current code shows that it can assume it. It should not assume the widget to be realized. :) > + assume that the platformWindow for the widget has a valid "window" > + member. For example in the case of, a new browser view opening as a remove bogus space when landing... 102223 6 zecke 2008-12-11 02:26:54 -0800 This did land in r39203. 25603 2008-11-29 18:37:07 -0800 2008-12-01 12:40:08 -0800 Patch to fix described problem, + changelog entry. unrealized-widgets.patch text/plain 2272 racarr SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiAzODg0OCkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTggQEAKKzIwMDgtMTEtMjkgIFJvYmVydCBDYXJyICA8cmFjYXJyQHN2bi5nbm9t ZS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKwlDb2RlIGlu IFBsYXRmb3JtU2NyZWVuR3RrIGZvciBzY3JlZW5EZXB0aCBhbmQgc2NyZWVuUmVjdCBjYW4gbm90 CisJYXNzdW1lIHRoYXQgdGhlIHBsYXRmb3JtV2luZG93IGZvciB0aGUgd2lkZ2V0IGhhcyBhIHZh bGlkICJ3aW5kb3ciIAorCW1lbWJlci4JRm9yIGV4YW1wbGUgaW4gdGhlIGNhc2Ugb2YsIGEgbmV3 IGJyb3dzZXIgdmlldyBvcGVuaW5nIGFzIGEKKwljaGlsZCBvZiBhIEd0a05vdGVib29rLCBidXQg bmV2ZXIgYmVpbmcgc3dpdGNoZWQgdG8sIG9yIG1hbnVhbGx5CisJcmVhbGl6ZWQuIFNvbHZlIGJ5 IHVzaW5nIHRoZSB0b3BsZXZlbCB3aW5kb3cgb2YgdGhlIHdpZGdldCwgcmF0aGVyCisJdGhhbiB0 aGUgd2lkZ2V0IGl0c2VsZi4KKworICAgICAgICAqIHBsYXRmb3JtL2d0ay9QbGF0Zm9ybVNjcmVl bkd0ay5jcHA6CisgICAgICAgIChXZWJDb3JlOjpzY3JlZW5EZXB0aCk6CisgICAgICAgIChXZWJD b3JlOjpzY3JlZW5SZWN0KToKKwogMjAwOC0xMS0yOSAgQnJlbnQgRnVsZ2hhbSAgPGJmdWxnaGFt QGdtYWlsLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBBbGV4ZXkgUHJvc2t1cnlha292LgpJ bmRleDogV2ViQ29yZS9wbGF0Zm9ybS9ndGsvUGxhdGZvcm1TY3JlZW5HdGsuY3BwCj09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT0KLS0tIFdlYkNvcmUvcGxhdGZvcm0vZ3RrL1BsYXRmb3JtU2NyZWVuR3RrLmNwcAkocmV2aXNp b24gMzg4NDYpCisrKyBXZWJDb3JlL3BsYXRmb3JtL2d0ay9QbGF0Zm9ybVNjcmVlbkd0ay5jcHAJ KHdvcmtpbmcgY29weSkKQEAgLTQ3LDEwICs0NywyMSBAQCBuYW1lc3BhY2UgV2ViQ29yZSB7CiBp bnQgc2NyZWVuRGVwdGgoV2lkZ2V0KiB3aWRnZXQpCiB7CiAgICAgR3RrV2lkZ2V0KiBjb250YWlu ZXIgPSBHVEtfV0lER0VUKHdpZGdldC0+cm9vdCgpLT5ob3N0V2luZG93KCktPnBsYXRmb3JtV2lu ZG93KCkpOworCQogICAgIGlmICghY29udGFpbmVyKQogICAgICAgICByZXR1cm4gMjQ7CiAKLSAg ICBHZGtWaXN1YWwqIHZpc3VhbCA9IGdka19kcmF3YWJsZV9nZXRfdmlzdWFsKEdES19EUkFXQUJM RShHVEtfV0lER0VUKHdpZGdldC0+cm9vdCgpLT5ob3N0V2luZG93KCktPnBsYXRmb3JtV2luZG93 KCkpLT53aW5kb3cpKTsKKwlpZiAoIUdUS19XSURHRVRfUkVBTElaRUQoY29udGFpbmVyKSkKKwl7 CisJCUd0a1dpZGdldCAqIHRvcGxldmVsID0gZ3RrX3dpZGdldF9nZXRfdG9wbGV2ZWwoY29udGFp bmVyKTsKKwkJaWYgKEdUS19XSURHRVRfVE9QTEVWRUwodG9wbGV2ZWwpKQorCQkJY29udGFpbmVy ID0gdG9wbGV2ZWw7CisJCWVsc2UKKwkJCXJldHVybiAyNDsKKwl9CisKKworICAgIEdka1Zpc3Vh bCogdmlzdWFsID0gZ2RrX2RyYXdhYmxlX2dldF92aXN1YWwoR0RLX0RSQVdBQkxFKGNvbnRhaW5l ci0+d2luZG93KSk7CiAgICAgcmV0dXJuIHZpc3VhbC0+ZGVwdGg7CiB9CiAKQEAgLTc1LDggKzg2 LDggQEAgYm9vbCBzY3JlZW5Jc01vbm9jaHJvbWUoV2lkZ2V0KiB3aWRnZXQpCiAKIEZsb2F0UmVj dCBzY3JlZW5SZWN0KFdpZGdldCogd2lkZ2V0KQogewotICAgIEd0a1dpZGdldCogY29udGFpbmVy ID0gR1RLX1dJREdFVCh3aWRnZXQtPnJvb3QoKS0+aG9zdFdpbmRvdygpLT5wbGF0Zm9ybVdpbmRv dygpKTsKLSAgICBpZiAoIWNvbnRhaW5lcikKKyAgICBHdGtXaWRnZXQqIGNvbnRhaW5lciA9IGd0 a193aWRnZXRfZ2V0X3RvcGxldmVsKEdUS19XSURHRVQod2lkZ2V0LT5yb290KCktPmhvc3RXaW5k b3coKS0+cGxhdGZvcm1XaW5kb3coKSkpOworICAgIGlmICghR1RLX1dJREdFVF9UT1BMRVZFTChj b250YWluZXIpKQogICAgICAgICByZXR1cm4gRmxvYXRSZWN0KCk7CiAKICAgICBHZGtTY3JlZW4q IHNjcmVlbiA9IGd0a193aWRnZXRfaGFzX3NjcmVlbihjb250YWluZXIpID8gZ3RrX3dpZGdldF9n ZXRfc2NyZWVuKGNvbnRhaW5lcikgOiBnZGtfc2NyZWVuX2dldF9kZWZhdWx0KCk7Cg== 25605 2008-11-29 20:09:50 -0800 2008-12-05 04:01:21 -0800 Update to previous patch, fixing style mistakes. unrealized-widgets-style.patch text/plain 2292 hortont424 SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiAzODg0OCkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTggQEAKKzIwMDgtMTEtMjkgIFJvYmVydCBDYXJyICA8cmFjYXJyQHN2bi5nbm9t ZS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg Q29kZSBpbiBQbGF0Zm9ybVNjcmVlbkd0ayBmb3Igc2NyZWVuRGVwdGggYW5kIHNjcmVlblJlY3Qg Y2FuIG5vdAorICAgICAgICBhc3N1bWUgdGhhdCB0aGUgcGxhdGZvcm1XaW5kb3cgZm9yIHRoZSB3 aWRnZXQgaGFzIGEgdmFsaWQgIndpbmRvdyIgCisgICAgICAgIG1lbWJlci4JRm9yIGV4YW1wbGUg aW4gdGhlIGNhc2Ugb2YsIGEgbmV3IGJyb3dzZXIgdmlldyBvcGVuaW5nIGFzIGEKKyAgICAgICAg Y2hpbGQgb2YgYSBHdGtOb3RlYm9vaywgYnV0IG5ldmVyIGJlaW5nIHN3aXRjaGVkIHRvLCBvciBt YW51YWxseQorICAgICAgICByZWFsaXplZC4gU29sdmUgYnkgdXNpbmcgdGhlIHRvcGxldmVsIHdp bmRvdyBvZiB0aGUgd2lkZ2V0LCByYXRoZXIKKyAgICAgICAgdGhhbiB0aGUgd2lkZ2V0IGl0c2Vs Zi4KKworICAgICAgICAqIHBsYXRmb3JtL2d0ay9QbGF0Zm9ybVNjcmVlbkd0ay5jcHA6CisgICAg ICAgIChXZWJDb3JlOjpzY3JlZW5EZXB0aCk6CisgICAgICAgIChXZWJDb3JlOjpzY3JlZW5SZWN0 KToKKwogMjAwOC0xMS0yOSAgQnJlbnQgRnVsZ2hhbSAgPGJmdWxnaGFtQGdtYWlsLmNvbT4KIAog ICAgICAgICBSZXZpZXdlZCBieSBBbGV4ZXkgUHJvc2t1cnlha292LgpJbmRleDogV2ViQ29yZS9w bGF0Zm9ybS9ndGsvUGxhdGZvcm1TY3JlZW5HdGsuY3BwCj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUv cGxhdGZvcm0vZ3RrL1BsYXRmb3JtU2NyZWVuR3RrLmNwcAkocmV2aXNpb24gMzg4NDgpCisrKyBX ZWJDb3JlL3BsYXRmb3JtL2d0ay9QbGF0Zm9ybVNjcmVlbkd0ay5jcHAJKHdvcmtpbmcgY29weSkK QEAgLTQ3LDEwICs0NywyMCBAQAogaW50IHNjcmVlbkRlcHRoKFdpZGdldCogd2lkZ2V0KQogewog ICAgIEd0a1dpZGdldCogY29udGFpbmVyID0gR1RLX1dJREdFVCh3aWRnZXQtPnJvb3QoKS0+aG9z dFdpbmRvdygpLT5wbGF0Zm9ybVdpbmRvdygpKTsKKwogICAgIGlmICghY29udGFpbmVyKQogICAg ICAgICByZXR1cm4gMjQ7CiAKLSAgICBHZGtWaXN1YWwqIHZpc3VhbCA9IGdka19kcmF3YWJsZV9n ZXRfdmlzdWFsKEdES19EUkFXQUJMRShHVEtfV0lER0VUKHdpZGdldC0+cm9vdCgpLT5ob3N0V2lu ZG93KCktPnBsYXRmb3JtV2luZG93KCkpLT53aW5kb3cpKTsKKyAgICBpZiAoIUdUS19XSURHRVRf UkVBTElaRUQoY29udGFpbmVyKSkgeworICAgICAgICBHdGtXaWRnZXQqIHRvcGxldmVsID0gZ3Rr X3dpZGdldF9nZXRfdG9wbGV2ZWwoY29udGFpbmVyKTsKKyAgICAgICAgaWYgKEdUS19XSURHRVRf VE9QTEVWRUwodG9wbGV2ZWwpKQorICAgICAgICAgICAgY29udGFpbmVyID0gdG9wbGV2ZWw7Cisg ICAgICAgIGVsc2UKKyAgICAgICAgICAgIHJldHVybiAyNDsKKyAgICB9CisKKworICAgIEdka1Zp c3VhbCogdmlzdWFsID0gZ2RrX2RyYXdhYmxlX2dldF92aXN1YWwoR0RLX0RSQVdBQkxFKGNvbnRh aW5lci0+d2luZG93KSk7CiAgICAgcmV0dXJuIHZpc3VhbC0+ZGVwdGg7CiB9CiAKQEAgLTc1LDgg Kzg1LDggQEAKIAogRmxvYXRSZWN0IHNjcmVlblJlY3QoV2lkZ2V0KiB3aWRnZXQpCiB7Ci0gICAg R3RrV2lkZ2V0KiBjb250YWluZXIgPSBHVEtfV0lER0VUKHdpZGdldC0+cm9vdCgpLT5ob3N0V2lu ZG93KCktPnBsYXRmb3JtV2luZG93KCkpOwotICAgIGlmICghY29udGFpbmVyKQorICAgIEd0a1dp ZGdldCogY29udGFpbmVyID0gZ3RrX3dpZGdldF9nZXRfdG9wbGV2ZWwoR1RLX1dJREdFVCh3aWRn ZXQtPnJvb3QoKS0+aG9zdFdpbmRvdygpLT5wbGF0Zm9ybVdpbmRvdygpKSk7CisgICAgaWYgKCFH VEtfV0lER0VUX1RPUExFVkVMKGNvbnRhaW5lcikpCiAgICAgICAgIHJldHVybiBGbG9hdFJlY3Qo KTsKIAogICAgIEdka1NjcmVlbiogc2NyZWVuID0gZ3RrX3dpZGdldF9oYXNfc2NyZWVuKGNvbnRh aW5lcikgPyBndGtfd2lkZ2V0X2dldF9zY3JlZW4oY29udGFpbmVyKSA6IGdka19zY3JlZW5fZ2V0 X2RlZmF1bHQoKTsK