225571 2021-05-08 18:23:29 -0700 Remove calls to the String::toInt family of functions from JavaScriptCore 2021-05-08 21:16:25 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 darin darin ews-watchlist hi joepeck keith_miller mark.lam msaboff saam sam tzagallo webkit-bug-importer oldest_to_newest 1758250 0 darin 2021-05-08 18:23:29 -0700 Remove calls to the String::toInt family of functions from JavaScriptCore 1758252 1 428105 darin 2021-05-08 18:26:09 -0700 Created attachment 428105 Patch 1758261 2 darin 2021-05-08 19:06:43 -0700 Style checker is complaining that I am using the word fuzzer in the change log. This is very silly since it’s in the file name of a file I am modifying. 1758264 3 428105 sam 2021-05-08 19:16:54 -0700 Comment on attachment 428105 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=428105&action=review > Source/JavaScriptCore/ChangeLog:10 > + (Inspector::parseLocation): Use parseIntegerAllowingTrailingJunk<uintptr_t> instead of > + String::toIntPtr. Why the change from intptr_t to uintptr_t here? 1758268 4 428105 darin 2021-05-08 20:42:17 -0700 Comment on attachment 428105 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=428105&action=review >> Source/JavaScriptCore/ChangeLog:10 >> + String::toIntPtr. > > Why the change from intptr_t to uintptr_t here? Unintentional. I will change it back. 1758278 5 428105 darin 2021-05-08 21:13:16 -0700 Comment on attachment 428105 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=428105&action=review >>> Source/JavaScriptCore/ChangeLog:10 >>> + String::toIntPtr. >> >> Why the change from intptr_t to uintptr_t here? > > Unintentional. I will change it back. Actually, the type is JSC::SourceID, not intptr_t and not uintptr_t either. I am changing to that. 1758279 6 darin 2021-05-08 21:15:29 -0700 Committed r277240 (237509@main): <https://commits.webkit.org/237509@main> 1758280 7 webkit-bug-importer 2021-05-08 21:16:25 -0700 <rdar://problem/77704068> 428105 2021-05-08 18:26:09 -0700 2021-05-08 20:42:17 -0700 Patch bug-225571-20210508182608.patch text/plain 7149 darin U3VidmVyc2lvbiBSZXZpc2lvbjogMjc3MjM0CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCAy ZDE1NjlkZTZmNjdmY2Q5MjY5NWVlOWIzMWJkYTAxZTNmYWRhYjdhLi41YjViNzdiMzM3ODhmYzEz ZmMyODhkMGYzZDQ0ZGNkNDJkMWFjNjlkIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwyNiBAQAorMjAyMS0wNS0wOCAgRGFyaW4gQWRsZXIgIDxkYXJpbkBhcHBsZS5jb20+CisK KyAgICAgICAgUmVtb3ZlIGNhbGxzIHRvIHRoZSBTdHJpbmc6OnRvSW50IGZhbWlseSBvZiBmdW5j dGlvbnMgZnJvbSBKYXZhU2NyaXB0Q29yZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MjI1NTcxCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgKiBpbnNwZWN0b3IvYWdlbnRzL0luc3BlY3RvckRlYnVnZ2VyQWdl bnQuY3BwOgorICAgICAgICAoSW5zcGVjdG9yOjpwYXJzZUxvY2F0aW9uKTogVXNlIHBhcnNlSW50 ZWdlckFsbG93aW5nVHJhaWxpbmdKdW5rPHVpbnRwdHJfdD4gaW5zdGVhZCBvZgorICAgICAgICBT dHJpbmc6OnRvSW50UHRyLgorICAgICAgICAoSW5zcGVjdG9yOjpJbnNwZWN0b3JEZWJ1Z2dlckFn ZW50OjpzZWFyY2hJbkNvbnRlbnQpOiBEaXR0by4KKyAgICAgICAgKEluc3BlY3Rvcjo6SW5zcGVj dG9yRGVidWdnZXJBZ2VudDo6Z2V0U2NyaXB0U291cmNlKTogRGl0dG8uCisKKyAgICAgICAgKiBp bnNwZWN0b3IvYWdlbnRzL0luc3BlY3RvclJ1bnRpbWVBZ2VudC5jcHA6CisgICAgICAgIChJbnNw ZWN0b3I6Okluc3BlY3RvclJ1bnRpbWVBZ2VudDo6Z2V0UnVudGltZVR5cGVzRm9yVmFyaWFibGVz QXRPZmZzZXRzKTogVXNlCisgICAgICAgIHBhcnNlSW50ZWdlcjx1aW50cHRyX3Q+IGluc3RlYWQg b2YgU3RyaW5nOjp0b0ludFB0clN0cmljdC4KKyAgICAgICAgKEluc3BlY3Rvcjo6SW5zcGVjdG9y UnVudGltZUFnZW50OjpnZXRCYXNpY0Jsb2Nrcyk6IFVzZQorICAgICAgICBwYXJzZUludGVnZXJB bGxvd2luZ1RyYWlsaW5nSnVuazx1aW50cHRyX3Q+IGluc3RlYWQgb2YgU3RyaW5nOjp0b0ludFB0 ci4KKworICAgICAgICAqIHJ1bnRpbWUvRnV6emVyUHJlZGljdGlvbnMuY3BwOgorICAgICAgICAo SlNDOjpGdXp6ZXJQcmVkaWN0aW9uczo6RnV6emVyUHJlZGljdGlvbnMpOiBVc2UgcGFyc2VJbnRl Z2VyPHVpbnQ2NF90PgorICAgICAgICBpbnN0ZWFkIG9mIFN0cmluZzo6dG9VSW50NjRTdHJpY3Qu CisKIDIwMjEtMDUtMDggIENocmlzIER1bWV6ICA8Y2R1bWV6QGFwcGxlLmNvbT4KIAogICAgICAg ICBQb3J0IEZpbGVzeXN0ZW06OnBhdGhCeUFwcGVuZGluZ0NvbXBvbmVudCgpICYgRmlsZXN5c3Rl bTo6IHBhdGhCeUFwcGVuZGluZ0NvbXBvbmVudHMoKSB0byBzdGQ6OmZpbGVzeXN0ZW0KZGlmZiAt LWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9pbnNwZWN0b3IvYWdlbnRzL0luc3BlY3RvckRl YnVnZ2VyQWdlbnQuY3BwIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2luc3BlY3Rvci9hZ2VudHMv SW5zcGVjdG9yRGVidWdnZXJBZ2VudC5jcHAKaW5kZXggNWMyNjkxNmMyYWExMDUzMTk3YWVjNTUz ZWJhYjAxZDUyNzExMzBmNS4uMGUxYTg1Yzg3OGNjMzk5NzNmNjIwZGZlYjBmZGExZTBmNmRmNzI5 ZCAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2luc3BlY3Rvci9hZ2VudHMvSW5z cGVjdG9yRGVidWdnZXJBZ2VudC5jcHAKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2luc3Bl Y3Rvci9hZ2VudHMvSW5zcGVjdG9yRGVidWdnZXJBZ2VudC5jcHAKQEAgLTQ0LDYgKzQ0LDcgQEAK ICNpbmNsdWRlIDx3dGYvRnVuY3Rpb24uaD4KICNpbmNsdWRlIDx3dGYvSlNPTlZhbHVlcy5oPgog I2luY2x1ZGUgPHd0Zi9TdG9wd2F0Y2guaD4KKyNpbmNsdWRlIDx3dGYvdGV4dC9TdHJpbmdUb0lu dGVnZXJDb252ZXJzaW9uLmg+CiAjaW5jbHVkZSA8d3RmL3RleHQvV1RGU3RyaW5nLmg+CiAKIG5h bWVzcGFjZSBJbnNwZWN0b3IgewpAQCAtNTMzLDcgKzUzNCw3IEBAIHN0YXRpYyBib29sIHBhcnNl TG9jYXRpb24oUHJvdG9jb2w6OkVycm9yU3RyaW5nJiBlcnJvclN0cmluZywgY29uc3QgSlNPTjo6 T2JqZWN0CiAgICAgICAgIHJldHVybiBmYWxzZTsKICAgICB9CiAKLSAgICBzb3VyY2VJRCA9IHNj cmlwdElEU3RyLnRvSW50UHRyKCk7CisgICAgc291cmNlSUQgPSBwYXJzZUludGVnZXJBbGxvd2lu Z1RyYWlsaW5nSnVuazx1aW50cHRyX3Q+KHNjcmlwdElEU3RyKS52YWx1ZU9yKDApOwogICAgIGNv bHVtbk51bWJlciA9IGxvY2F0aW9uLmdldEludGVnZXIoUHJvdG9jb2w6OkRlYnVnZ2VyOjpMb2Nh dGlvbjo6Y29sdW1uTnVtYmVyS2V5KS52YWx1ZU9yKDApOwogICAgIHJldHVybiB0cnVlOwogfQpA QCAtNzI5LDcgKzczMCw3IEBAIFByb3RvY29sOjpFcnJvclN0cmluZ09yPHZvaWQ+IEluc3BlY3Rv ckRlYnVnZ2VyQWdlbnQ6OmNvbnRpbnVlVG9Mb2NhdGlvbihSZWY8SlNPCiAKIFByb3RvY29sOjpF cnJvclN0cmluZ09yPFJlZjxKU09OOjpBcnJheU9mPFByb3RvY29sOjpHZW5lcmljVHlwZXM6OlNl YXJjaE1hdGNoPj4+IEluc3BlY3RvckRlYnVnZ2VyQWdlbnQ6OnNlYXJjaEluQ29udGVudChjb25z dCBQcm90b2NvbDo6RGVidWdnZXI6OlNjcmlwdElkJiBzY3JpcHRJZCwgY29uc3QgU3RyaW5nJiBx dWVyeSwgT3B0aW9uYWw8Ym9vbD4mJiBjYXNlU2Vuc2l0aXZlLCBPcHRpb25hbDxib29sPiYmIGlz UmVnZXgpCiB7Ci0gICAgYXV0byBpdCA9IG1fc2NyaXB0cy5maW5kKHNjcmlwdElkLnRvSW50UHRy KCkpOworICAgIGF1dG8gaXQgPSBtX3NjcmlwdHMuZmluZChwYXJzZUludGVnZXJBbGxvd2luZ1Ry YWlsaW5nSnVuazx1aW50cHRyX3Q+KHNjcmlwdElkKS52YWx1ZU9yKDApKTsKICAgICBpZiAoaXQg PT0gbV9zY3JpcHRzLmVuZCgpKQogICAgICAgICByZXR1cm4gbWFrZVVuZXhwZWN0ZWQoIk1pc3Np bmcgc2NyaXB0IGZvciBnaXZlbiBzY3JpcHRJZCJfcyk7CiAKQEAgLTczOCw3ICs3MzksNyBAQCBQ cm90b2NvbDo6RXJyb3JTdHJpbmdPcjxSZWY8SlNPTjo6QXJyYXlPZjxQcm90b2NvbDo6R2VuZXJp Y1R5cGVzOjpTZWFyY2hNYXRjaD4+PgogCiBQcm90b2NvbDo6RXJyb3JTdHJpbmdPcjxTdHJpbmc+ IEluc3BlY3RvckRlYnVnZ2VyQWdlbnQ6OmdldFNjcmlwdFNvdXJjZShjb25zdCBQcm90b2NvbDo6 RGVidWdnZXI6OlNjcmlwdElkJiBzY3JpcHRJZCkKIHsKLSAgICBhdXRvIGl0ID0gbV9zY3JpcHRz LmZpbmQoc2NyaXB0SWQudG9JbnRQdHIoKSk7CisgICAgYXV0byBpdCA9IG1fc2NyaXB0cy5maW5k KHBhcnNlSW50ZWdlckFsbG93aW5nVHJhaWxpbmdKdW5rPHVpbnRwdHJfdD4oc2NyaXB0SWQpLnZh bHVlT3IoMCkpOwogICAgIGlmIChpdCA9PSBtX3NjcmlwdHMuZW5kKCkpCiAgICAgICAgIHJldHVy biBtYWtlVW5leHBlY3RlZCgiTWlzc2luZyBzY3JpcHQgZm9yIGdpdmVuIHNjcmlwdElkIik7CiAK ZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9pbnNwZWN0b3IvYWdlbnRzL0luc3Bl Y3RvclJ1bnRpbWVBZ2VudC5jcHAgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvaW5zcGVjdG9yL2Fn ZW50cy9JbnNwZWN0b3JSdW50aW1lQWdlbnQuY3BwCmluZGV4IDJiNjk1YTI5NzZjZTA2MDg1NWFi MmQ3MGU4MGM0ZmYwMGRmMjg3ODkuLjQwNDM3MjExZjEzMmVhOTU3NDgwODZiNWVhM2VkMjg2ODM0 MWU3NjYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9pbnNwZWN0b3IvYWdlbnRz L0luc3BlY3RvclJ1bnRpbWVBZ2VudC5jcHAKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2lu c3BlY3Rvci9hZ2VudHMvSW5zcGVjdG9yUnVudGltZUFnZW50LmNwcApAQCAtNDQsNiArNDQsNyBA QAogI2luY2x1ZGUgIlR5cGVQcm9maWxlci5oIgogI2luY2x1ZGUgIlR5cGVQcm9maWxlckxvZy5o IgogI2luY2x1ZGUgPHd0Zi9KU09OVmFsdWVzLmg+CisjaW5jbHVkZSA8d3RmL3RleHQvU3RyaW5n VG9JbnRlZ2VyQ29udmVyc2lvbi5oPgogCiBuYW1lc3BhY2UgSW5zcGVjdG9yIHsKIApAQCAtMzk1 LDkgKzM5Niw3IEBAIFByb3RvY29sOjpFcnJvclN0cmluZ09yPFJlZjxKU09OOjpBcnJheU9mPFBy b3RvY29sOjpSdW50aW1lOjpUeXBlRGVzY3JpcHRpb24+Pj4KICAgICAgICAgYXV0byBzb3VyY2VJ RFN0cmluZyA9IGxvY2F0aW9uLT5nZXRTdHJpbmcoUHJvdG9jb2w6OlJ1bnRpbWU6OlR5cGVMb2Nh dGlvbjo6c291cmNlSURLZXkpOwogICAgICAgICBhdXRvIGRpdm90ID0gbG9jYXRpb24tPmdldElu dGVnZXIoUHJvdG9jb2w6OlJ1bnRpbWU6OlR5cGVMb2NhdGlvbjo6ZGl2b3RLZXkpLnZhbHVlT3Io MCk7CiAKLSAgICAgICAgYm9vbCBva2F5OwotICAgICAgICBUeXBlTG9jYXRpb24qIHR5cGVMb2Nh dGlvbiA9IG1fdm0udHlwZVByb2ZpbGVyKCktPmZpbmRMb2NhdGlvbihkaXZvdCwgc291cmNlSURT dHJpbmcudG9JbnRQdHJTdHJpY3QoJm9rYXkpLCBzdGF0aWNfY2FzdDxUeXBlUHJvZmlsZXJTZWFy Y2hEZXNjcmlwdG9yPihkZXNjcmlwdG9yKSwgbV92bSk7Ci0gICAgICAgIEFTU0VSVChva2F5KTsK KyAgICAgICAgYXV0byB0eXBlTG9jYXRpb24gPSBtX3ZtLnR5cGVQcm9maWxlcigpLT5maW5kTG9j YXRpb24oZGl2b3QsIHBhcnNlSW50ZWdlcjx1aW50cHRyX3Q+KHNvdXJjZUlEU3RyaW5nKS52YWx1 ZSgpLCBzdGF0aWNfY2FzdDxUeXBlUHJvZmlsZXJTZWFyY2hEZXNjcmlwdG9yPihkZXNjcmlwdG9y KSwgbV92bSk7CiAKICAgICAgICAgUmVmUHRyPFR5cGVTZXQ+IHR5cGVTZXQ7CiAgICAgICAgIGlm ICh0eXBlTG9jYXRpb24pIHsKQEAgLTUwNCw3ICs1MDMsNyBAQCBQcm90b2NvbDo6RXJyb3JTdHJp bmdPcjxSZWY8SlNPTjo6QXJyYXlPZjxQcm90b2NvbDo6UnVudGltZTo6QmFzaWNCbG9jaz4+PiBJ bnNwZQogICAgICAgICByZXR1cm4gbWFrZVVuZXhwZWN0ZWQoIlZNIGhhcyBubyBjb250cm9sIGZs b3cgaW5mb3JtYXRpb24iX3MpOwogCiAgICAgYXV0byBiYXNpY0Jsb2NrcyA9IEpTT046OkFycmF5 T2Y8UHJvdG9jb2w6OlJ1bnRpbWU6OkJhc2ljQmxvY2s+OjpjcmVhdGUoKTsKLSAgICBmb3IgKGNv bnN0IGF1dG8mIGJsb2NrIDogbV92bS5jb250cm9sRmxvd1Byb2ZpbGVyKCktPmdldEJhc2ljQmxv Y2tzRm9yU291cmNlSUQoc291cmNlSUQudG9JbnRQdHIoKSwgbV92bSkpIHsKKyAgICBmb3IgKGNv bnN0IGF1dG8mIGJsb2NrIDogbV92bS5jb250cm9sRmxvd1Byb2ZpbGVyKCktPmdldEJhc2ljQmxv Y2tzRm9yU291cmNlSUQocGFyc2VJbnRlZ2VyQWxsb3dpbmdUcmFpbGluZ0p1bms8dWludHB0cl90 Pihzb3VyY2VJRCkudmFsdWVPcigwKSwgbV92bSkpIHsKICAgICAgICAgYXV0byBsb2NhdGlvbiA9 IFByb3RvY29sOjpSdW50aW1lOjpCYXNpY0Jsb2NrOjpjcmVhdGUoKQogICAgICAgICAgICAgLnNl dFN0YXJ0T2Zmc2V0KGJsb2NrLm1fc3RhcnRPZmZzZXQpCiAgICAgICAgICAgICAuc2V0RW5kT2Zm c2V0KGJsb2NrLm1fZW5kT2Zmc2V0KQpkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3Jl L3J1bnRpbWUvRnV6emVyUHJlZGljdGlvbnMuY3BwIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL3J1 bnRpbWUvRnV6emVyUHJlZGljdGlvbnMuY3BwCmluZGV4IGMyZTQ0MDEwZTI3MGRiMDYyNWNmY2Iy MGIzMzY2MDhjMWM1NTVhMTguLjVhYjVkOWE4YTY1MTdmNzc0NWY1ZjNkMjM5MTU4NjQ5ODg3MzM5 ZmIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL0Z1enplclByZWRp Y3Rpb25zLmNwcAorKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9GdXp6ZXJQcmVk aWN0aW9ucy5jcHAKQEAgLTI2LDYgKzI2LDggQEAKICNpbmNsdWRlICJjb25maWcuaCIKICNpbmNs dWRlICJGdXp6ZXJQcmVkaWN0aW9ucy5oIgogCisjaW5jbHVkZSA8d3RmL3RleHQvU3RyaW5nVG9J bnRlZ2VyQ29udmVyc2lvbi5oPgorCiBuYW1lc3BhY2UgSlNDIHsKIAogc3RhdGljIFN0cmluZyBy ZWFkRmlsZUludG9TdHJpbmcoY29uc3QgY2hhciogZmlsZU5hbWUpCkBAIC03NSwxMSArNzcsMTAg QEAgRnV6emVyUHJlZGljdGlvbnM6OkZ1enplclByZWRpY3Rpb25zKGNvbnN0IGNoYXIqIGZpbGVu YW1lKQogICAgICAgICBSRUxFQVNFX0FTU0VSVF9XSVRIX01FU1NBR0UobGluZVBhcnRzLnNpemUo KSA9PSAyLCAiRXhwZWN0ZWQgbGluZSB3aXRoIHR3byBwYXJ0cyBkZWxpbWl0ZWQgYnkgYSBjb2xv bi4gRm91bmQgbGluZSB3aXRoICV6dSBwYXJ0cy4iLCBsaW5lUGFydHMuc2l6ZSgpKTsKICAgICAg ICAgY29uc3QgU3RyaW5nJiBsb29rdXBLZXkgPSBsaW5lUGFydHNbMF07CiAgICAgICAgIGNvbnN0 IFN0cmluZyYgcHJlZGljdGlvblN0cmluZyA9IGxpbmVQYXJ0c1sxXTsKLSAgICAgICAgYm9vbCBv azsKLSAgICAgICAgU3BlY3VsYXRlZFR5cGUgcHJlZGljdGlvbiA9IHByZWRpY3Rpb25TdHJpbmcu dG9VSW50NjRTdHJpY3QoJm9rLCAweDEwKTsKLSAgICAgICAgUkVMRUFTRV9BU1NFUlRfV0lUSF9N RVNTQUdFKG9rLCAiQ291bGQgbm90IHBhcnNlIHByZWRpY3Rpb24gZnJvbSAnJXMnIiwgcHJlZGlj dGlvblN0cmluZy51dGY4KCkuZGF0YSgpKTsKLSAgICAgICAgUkVMRUFTRV9BU1NFUlQoc3BlY3Vs YXRpb25DaGVja2VkKHByZWRpY3Rpb24sIFNwZWNGdWxsVG9wKSk7Ci0gICAgICAgIG1fcHJlZGlj dGlvbnMuc2V0KGxvb2t1cEtleSwgcHJlZGljdGlvbik7CisgICAgICAgIGF1dG8gcHJlZGljdGlv biA9IHBhcnNlSW50ZWdlcjx1aW50NjRfdD4ocHJlZGljdGlvblN0cmluZywgMHgxMCk7CisgICAg ICAgIFJFTEVBU0VfQVNTRVJUX1dJVEhfTUVTU0FHRShwcmVkaWN0aW9uLCAiQ291bGQgbm90IHBh cnNlIHByZWRpY3Rpb24gZnJvbSAnJXMnIiwgcHJlZGljdGlvblN0cmluZy51dGY4KCkuZGF0YSgp KTsKKyAgICAgICAgUkVMRUFTRV9BU1NFUlQoc3BlY3VsYXRpb25DaGVja2VkKCpwcmVkaWN0aW9u LCBTcGVjRnVsbFRvcCkpOworICAgICAgICBtX3ByZWRpY3Rpb25zLnNldChsb29rdXBLZXksICpw cmVkaWN0aW9uKTsKICAgICB9CiB9CiAK