225551 2021-05-07 18:00:57 -0700 [GLIB] REGRESSION(r277158) imported/w3c/web-platform-tests/xhr/FormData-append.html is crashing 2021-05-08 09:55:14 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 dpino dpino benjamin bugs-noreply cdumez cgarcia cmarcelo ews-watchlist webkit-bug-importer zdobersek oldest_to_newest 1758125 0 dpino 2021-05-07 18:00:57 -0700 The test started crashing after r277158: https://results.webkit.org/?suite=layout-tests&test=imported%2Fw3c%2Fweb-platform-tests%2Fxhr%2FFormData-append.html&platform=GTK&platform=WPE&platform=ios&platform=mac Stack trace: https://build.webkit.org/results/GTK-Linux-64-bit-Debug-Tests/r277196%20(1013)/imported/w3c/web-platform-tests/xhr/FormData-append-crash-log.txt Thread 1 (Thread 0x7f29685acec0 (LWP 6316)): #0 __strlen_avx2 () at ../sysdeps/x86_64/multiarch/strlen-avx2.S:65 #1 0x00007f29724d311c in std::char_traits<char>::length(char const*) (__s=0x0) at /usr/include/c++/10.2.0/bits/char_traits.h:357 #2 0x00007f2973895546 in std::basic_string_view<char, std::char_traits<char> >::basic_string_view(char const*) (this=0x7ffc1ed0ede0, __str=0x0) at /usr/include/c++/10.2.0/string_view:128 #3 0x00007f296ed0cc5f in std::filesystem::__cxx11::path::_S_convert(char const*, std::filesystem::__cxx11::__detail::__null_terminated) (__src=0x0) at /usr/include/c++/10.2.0/bits/fs_path.h:541 #4 0x00007f296ed0daa7 in std::filesystem::__cxx11::path::path<char const*, std::filesystem::__cxx11::path>(char const* const&, std::filesystem::__cxx11::path::format) (this=0x7ffc1ed0eec0, __source=@0x7ffc1ed0eea8: 0x0) at /usr/include/c++/10.2.0/bits/fs_path.h:225 #5 0x00007f296ed0b9f5 in WTF::FileSystemImpl::getFileModificationTime(WTF::String const&) (path=...) at ../../Source/WTF/wtf/FileSystem.cpp:667 #6 0x00007f29757cdc39 in WebCore::File::lastModified() const (this=0x7f29248ce3b0) at ../../Source/WebCore/fileapi/File.cpp:113 #7 0x00007f2973d39329 in WebCore::jsFile_lastModifiedGetter(JSC::JSGlobalObject&, WebCore::JSFile&) (lexicalGlobalObject=..., thisObject=...) at WebCore/DerivedSources/JSFile.cpp:285 #8 0x00007f2973d437e9 in WebCore::IDLAttribute<WebCore::JSFile>::get<WebCore::jsFile_lastModifiedGetter, (WebCore::CastedThisErrorBehavior)3>(JSC::JSGlobalObject&, JSC::EncodedJSValue, JSC::PropertyName) (lexicalGlobalObject=..., thisValue=139814311776008, attributeName=...) at ../../Source/WebCore/bindings/js/JSDOMAttribute.h:90 #9 0x00007f2973d3939f in WebCore::jsFile_lastModified(JSC::JSGlobalObject*, JSC::EncodedJSValue, JSC::PropertyName) (lexicalGlobalObject=0x7f290c2e0000, thisValue=139814311776008, attributeName=...) at WebCore/DerivedSources/JSFile.cpp:290 #10 0x00007f296e88685a in JSC::PropertySlot::customGetter(JSC::JSGlobalObject*, JSC::PropertyName) const (this=0x7ffc1ed0f360, globalObject=0x7f290c2e0000, propertyName=...) at ../../Source/JavaScriptCore/runtime/PropertySlot.cpp:46 #11 0x00007f296d248bd3 in JSC::PropertySlot::getValue(JSC::JSGlobalObject*, JSC::PropertyName) const (this=0x7ffc1ed0f360, globalObject=0x7f290c2e0000, propertyName=...) at ../../Source/JavaScriptCore/runtime/PropertySlot.h:408 #12 0x00007f296d2695f5 in JSC::JSValue::get(JSC::JSGlobalObject*, JSC::PropertyName, JSC::PropertySlot&) const (this=0x7ffc1ed0f2a0, globalObject=0x7f290c2e0000, propertyName=..., slot=...) at ../../Source/JavaScriptCore/runtime/JSCJSValueInlines.h:950 #13 0x00007f296e3af5db in JSC::LLInt::performLLIntGetByID(JSC::Instruction const*, JSC::CodeBlock*, JSC::JSGlobalObject*, JSC::JSValue, JSC::Identifier const&, JSC::GetByIdModeMetadata&) (pc=0x7f290c4f55d5, codeBlock=0x7f290d88e2e0, globalObject=0x7f290c2e0000, baseValue=..., ident=..., metadata=...) at ../../Source/JavaScriptCore/llint/LLIntSlowPaths.cpp:760 #14 0x00007f296e3afdf9 in JSC::LLInt::llint_slow_path_get_by_id(JSC::CallFrame*, JSC::Instruction const*) (callFrame=0x7ffc1ed0f5b0, pc=0x7f290c4f55d5) at ../../Source/JavaScriptCore/llint/LLIntSlowPaths.cpp:834 #15 0x00007f296d215359 in llint_op_get_by_id () at /app/webkit/Source/JavaScriptCore/llint/LowLevelInterpreter64.asm:97 1758128 1 428068 dpino 2021-05-07 18:05:17 -0700 Created attachment 428068 Patch 1758141 2 cdumez 2021-05-07 19:14:10 -0700 Note that fileSystemRepresentation() seems wrong for the glib port. It returns CString() instead of CString("") when the string is the empty string. It should only return CString() is the String is null. 1758143 3 cdumez 2021-05-07 19:15:46 -0700 (In reply to Chris Dumez from comment #2) > Note that fileSystemRepresentation() seems wrong for the glib port. It > returns CString() instead of CString("") when the string is the empty > string. It should only return CString() is the String is null. Maybe fixing Glib's fileSystemRepresentation() would mean we wouldn't need those isEmpty() checks in all FileSystem functions, unless glib ports are really calling those functions will null Strings.. 1758150 4 428076 dpino 2021-05-07 20:32:14 -0700 Created attachment 428076 Patch 1758151 5 dpino 2021-05-07 20:33:58 -0700 (In reply to Chris Dumez from comment #3) > (In reply to Chris Dumez from comment #2) > > Note that fileSystemRepresentation() seems wrong for the glib port. It > > returns CString() instead of CString("") when the string is the empty > > string. It should only return CString() is the String is null. > > Maybe fixing Glib's fileSystemRepresentation() would mean we wouldn't need > those isEmpty() checks in all FileSystem functions, unless glib ports are > really calling those functions will null Strings.. Thanks for the pointer. I also agree fixing this error at GLib is a better fix. Patch updated. 1758152 6 428077 dpino 2021-05-07 20:40:24 -0700 Created attachment 428077 Patch 1758154 7 428077 cdumez 2021-05-07 20:58:53 -0700 Comment on attachment 428077 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=428077&action=review > Source/WTF/wtf/glib/FileSystemGlib.cpp:77 > + return CString("", 0); I think this should be: If (path.isNull()) Return { }; If (path.isEmpty()) Return CString(“”); Seems weird to return an empty string if the input string was null. 1758155 8 428077 cdumez 2021-05-07 20:58:54 -0700 Comment on attachment 428077 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=428077&action=review > Source/WTF/wtf/glib/FileSystemGlib.cpp:77 > + return CString("", 0); I think this should be: If (path.isNull()) Return { }; If (path.isEmpty()) Return CString(“”); Seems weird to return an empty string if the input string was null. 1758176 9 428083 dpino 2021-05-08 03:30:33 -0700 Created attachment 428083 Patch 1758191 10 ews-feeder 2021-05-08 09:54:16 -0700 Committed r277229 (237498@main): <https://commits.webkit.org/237498@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 428083. 1758192 11 webkit-bug-importer 2021-05-08 09:55:14 -0700 <rdar://problem/77697036> 428068 2021-05-07 18:05:17 -0700 2021-05-07 20:32:07 -0700 Patch bug-225551-20210508090512.patch text/plain 1367 dpino U3VidmVyc2lvbiBSZXZpc2lvbjogMjc3MjE3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IGJlZTA2NWI0ODI4Yjc2ZjBjMGMzMjA2 MjFlNmZmMDRlYTlmMmJmN2IuLjUxMzAxMTRiOGVhMjM0YjY1ODNkODVjZTQ2NDhkNDA4NzYwNWMx YmUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMjEtMDUtMDcgIERpZWdvIFBpbm8gR2FyY2lhICA8 ZHBpbm9AaWdhbGlhLmNvbT4KKworICAgICAgICBbR0xJQl0gUkVHUkVTU0lPTihyMjc3MTU4KSBp bXBvcnRlZC93M2Mvd2ViLXBsYXRmb3JtLXRlc3RzL3hoci9Gb3JtRGF0YS1hcHBlbmQuaHRtbCBp cyBjcmFzaGluZworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9MjI1NTUxCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgKiB3dGYvRmlsZVN5c3RlbS5jcHA6CisgICAgICAgIChXVEY6OkZpbGVTeXN0ZW1JbXBsOjpn ZXRGaWxlTW9kaWZpY2F0aW9uVGltZSk6IFJldHVybiBXVEY6bnVsbG9wdCBpZiBwYXRoIGlzIGVt cHR5LgorCiAyMDIxLTA1LTA3ICBUaW0gSG9ydG9uICA8dGltb3RoeV9ob3J0b25AYXBwbGUuY29t PgogCiAgICAgICAgIEFkZCBhbiBleHBlcmltZW50YWwgYWx0ZXJuYXRpdmUgZGlzcGxheS1saXN0 LWJhc2VkIFJlbW90ZUxheWVyQmFja2luZ1N0b3JlIGltcGxlbWVudGF0aW9uCmRpZmYgLS1naXQg YS9Tb3VyY2UvV1RGL3d0Zi9GaWxlU3lzdGVtLmNwcCBiL1NvdXJjZS9XVEYvd3RmL0ZpbGVTeXN0 ZW0uY3BwCmluZGV4IGJkMTc3YWIyMDBmOWFmZjdmMTA2NWJlNzMwMzczMzg0MzBhZjI3MmUuLmRm Y2MyMGQ5ZDBjZGQyNGI5MDA3MjdkYWJhOTg1MWNhMDViOGI2NjggMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XVEYvd3RmL0ZpbGVTeXN0ZW0uY3BwCisrKyBiL1NvdXJjZS9XVEYvd3RmL0ZpbGVTeXN0ZW0u Y3BwCkBAIC02NjMsNiArNjYzLDggQEAgYm9vbCBkZWxldGVOb25FbXB0eURpcmVjdG9yeShjb25z dCBTdHJpbmcmIHBhdGgpCiAKIE9wdGlvbmFsPFdhbGxUaW1lPiBnZXRGaWxlTW9kaWZpY2F0aW9u VGltZShjb25zdCBTdHJpbmcmIHBhdGgpCiB7CisgICAgaWYgKHBhdGguaXNFbXB0eSgpKQorICAg ICAgICByZXR1cm4gV1RGOjpudWxsb3B0OwogICAgIHN0ZDo6ZXJyb3JfY29kZSBlYzsKICAgICBh dXRvIG1vZGlmaWNhdGlvblRpbWUgPSBzdGQ6OmZpbGVzeXN0ZW06Omxhc3Rfd3JpdGVfdGltZShm aWxlU3lzdGVtUmVwcmVzZW50YXRpb24ocGF0aCkuZGF0YSgpLCBlYyk7CiAgICAgaWYgKGVjKQo= 428076 2021-05-07 20:32:14 -0700 2021-05-07 20:40:14 -0700 Patch bug-225551-20210508113211.patch text/plain 2054 dpino U3VidmVyc2lvbiBSZXZpc2lvbjogMjc3MjIyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IGNkNmI5N2IzM2VmOGY2Y2MwYmMzYzc5 MjQzYWYxNTA4MmExY2UxZGQuLmUzODE1YTdlZDIzNWQ4MjY0MmVlYWZlNjE3YmNkMmIxM2I5Mzli YjkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMjEtMDUtMDcgIERpZWdvIFBpbm8gR2FyY2lhICA8 ZHBpbm9AaWdhbGlhLmNvbT4KKworICAgICAgICBbR0xJQl0gUkVHUkVTU0lPTihyMjc3MTU4KSBp bXBvcnRlZC93M2Mvd2ViLXBsYXRmb3JtLXRlc3RzL3hoci9Gb3JtRGF0YS1hcHBlbmQuaHRtbCBp cyBjcmFzaGluZworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9MjI1NTUxCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgKiB3dGYvRmlsZVN5c3RlbS5jcHA6CisgICAgICAgIChXVEY6OkZpbGVTeXN0ZW1JbXBsOjpm aWxlSXNEaXJlY3RvcnkpOiBSZW1vdmUgdW5uZWNlc3NhcnkgcGF0aC5pc0VtcHR5IGNoZWNrLgor ICAgICAgICAqIHd0Zi9nbGliL0ZpbGVTeXN0ZW1HbGliLmNwcDoKKyAgICAgICAgKFdURjo6Rmls ZVN5c3RlbUltcGw6OmZpbGVTeXN0ZW1SZXByZXNlbnRhdGlvbik6IFJldHVybiBlbXB0eSBDU3Ry aW5nCisJaWYgcGF0aCBpcyBlbXB0eS4KKwogMjAyMS0wNS0wNyAgQ2hyaXMgRHVtZXogIDxjZHVt ZXpAYXBwbGUuY29tPgogCiAgICAgICAgIFBvcnQgRmlsZVN5c3RlbTo6cGF0aEdldEZpbGVOYW1l KCkgJiBGaWxlc3lzdGVtOjpkaXJlY3RvcnlOYW1lKCkgdG8gc3RkOjpmaWxlc3lzdGVtCmRpZmYg LS1naXQgYS9Tb3VyY2UvV1RGL3d0Zi9GaWxlU3lzdGVtLmNwcCBiL1NvdXJjZS9XVEYvd3RmL0Zp bGVTeXN0ZW0uY3BwCmluZGV4IGUyNzZhZjNlZWZkOTA4NjUzYzAwYmU5MGJlODVhNWEyOTFkOTVm NWQuLjE1YTEwNzQ1NzVmNzFjZmRkNGQ0OThlZGZiYTVlMTA3ZDExOWZmNDAgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XVEYvd3RmL0ZpbGVTeXN0ZW0uY3BwCisrKyBiL1NvdXJjZS9XVEYvd3RmL0ZpbGVT eXN0ZW0uY3BwCkBAIC01OTgsOCArNTk4LDYgQEAgYm9vbCBnZXRGaWxlU2l6ZShjb25zdCBTdHJp bmcmIHBhdGgsIGxvbmcgbG9uZyYgcmVzdWx0KQogCiBib29sIGZpbGVJc0RpcmVjdG9yeShjb25z dCBTdHJpbmcmIHBhdGgsIFNob3VsZEZvbGxvd1N5bWJvbGljTGlua3Mgc2hvdWxkRm9sbG93U3lt Ym9saWNMaW5rcykKIHsKLSAgICBpZiAocGF0aC5pc0VtcHR5KCkpCi0gICAgICAgIHJldHVybiBm YWxzZTsKICAgICBzdGQ6OmVycm9yX2NvZGUgZWM7CiAgICAgc3RkOjpmaWxlc3lzdGVtOjpmaWxl X3N0YXR1cyBmaWxlU3RhdHVzOwogICAgIGlmIChzaG91bGRGb2xsb3dTeW1ib2xpY0xpbmtzID09 IFNob3VsZEZvbGxvd1N5bWJvbGljTGlua3M6OlllcykKZGlmZiAtLWdpdCBhL1NvdXJjZS9XVEYv d3RmL2dsaWIvRmlsZVN5c3RlbUdsaWIuY3BwIGIvU291cmNlL1dURi93dGYvZ2xpYi9GaWxlU3lz dGVtR2xpYi5jcHAKaW5kZXggOTJkNWU2NmZiZWNmOThkMDc3OWRiZjU0ZmQxOGU3YjJjMjhlNjhi OC4uZWIxM2ZhZGVlNmQ1MWEyMzZjYTUzYTcyZjRhNTQyMjhjZDQ4ZGY3ZSAxMDA2NDQKLS0tIGEv U291cmNlL1dURi93dGYvZ2xpYi9GaWxlU3lzdGVtR2xpYi5jcHAKKysrIGIvU291cmNlL1dURi93 dGYvZ2xpYi9GaWxlU3lzdGVtR2xpYi5jcHAKQEAgLTc0LDcgKzc0LDcgQEAgU3RyaW5nIHN0cmlu Z0Zyb21GaWxlU3lzdGVtUmVwcmVzZW50YXRpb24oY29uc3QgY2hhciogcmVwcmVzZW50YXRpb24p CiBDU3RyaW5nIGZpbGVTeXN0ZW1SZXByZXNlbnRhdGlvbihjb25zdCBTdHJpbmcmIHBhdGgpCiB7 CiAgICAgaWYgKHBhdGguaXNFbXB0eSgpKQotICAgICAgICByZXR1cm4geyB9OworICAgICAgICBy ZXR1cm4gQ1N0cmluZygiIiwgMCk7CiAKICAgICBDU3RyaW5nIHV0ZjggPSBwYXRoLnV0ZjgoKTsK IAo= 428077 2021-05-07 20:40:24 -0700 2021-05-08 03:30:24 -0700 Patch bug-225551-20210508114021.patch text/plain 2052 dpino U3VidmVyc2lvbiBSZXZpc2lvbjogMjc3MjIyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IGNkNmI5N2IzM2VmOGY2Y2MwYmMzYzc5 MjQzYWYxNTA4MmExY2UxZGQuLmQzZmVkZWQxMzI2M2NmOTJiNTUyY2NmZDVmMTViMWVlNGFiYzg1 YjMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMjEtMDUtMDcgIERpZWdvIFBpbm8gR2FyY2lhICA8 ZHBpbm9AaWdhbGlhLmNvbT4KKworICAgICAgICBbR0xJQl0gUkVHUkVTU0lPTihyMjc3MTU4KSBp bXBvcnRlZC93M2Mvd2ViLXBsYXRmb3JtLXRlc3RzL3hoci9Gb3JtRGF0YS1hcHBlbmQuaHRtbCBp cyBjcmFzaGluZworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9MjI1NTUxCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgKiB3dGYvRmlsZVN5c3RlbS5jcHA6CisgICAgICAgIChXVEY6OkZpbGVTeXN0ZW1JbXBsOjpm aWxlSXNEaXJlY3RvcnkpOiBSZW1vdmUgdW5uZWNlc3NhcnkgcGF0aC5pc0VtcHR5IGNoZWNrLgor ICAgICAgICAqIHd0Zi9nbGliL0ZpbGVTeXN0ZW1HbGliLmNwcDoKKyAgICAgICAgKFdURjo6Rmls ZVN5c3RlbUltcGw6OmZpbGVTeXN0ZW1SZXByZXNlbnRhdGlvbik6IFJldHVybiBlbXB0eSBDU3Ry aW5nIGlmIHBhdGggaXMgZW1wdHkuCisKIDIwMjEtMDUtMDcgIENocmlzIER1bWV6ICA8Y2R1bWV6 QGFwcGxlLmNvbT4KIAogICAgICAgICBQb3J0IEZpbGVTeXN0ZW06OnBhdGhHZXRGaWxlTmFtZSgp ICYgRmlsZXN5c3RlbTo6ZGlyZWN0b3J5TmFtZSgpIHRvIHN0ZDo6ZmlsZXN5c3RlbQpkaWZmIC0t Z2l0IGEvU291cmNlL1dURi93dGYvRmlsZVN5c3RlbS5jcHAgYi9Tb3VyY2UvV1RGL3d0Zi9GaWxl U3lzdGVtLmNwcAppbmRleCBlMjc2YWYzZWVmZDkwODY1M2MwMGJlOTBiZTg1YTVhMjkxZDk1ZjVk Li4xNWExMDc0NTc1ZjcxY2ZkZDRkNDk4ZWRmYmE1ZTEwN2QxMTlmZjQwIDEwMDY0NAotLS0gYS9T b3VyY2UvV1RGL3d0Zi9GaWxlU3lzdGVtLmNwcAorKysgYi9Tb3VyY2UvV1RGL3d0Zi9GaWxlU3lz dGVtLmNwcApAQCAtNTk4LDggKzU5OCw2IEBAIGJvb2wgZ2V0RmlsZVNpemUoY29uc3QgU3RyaW5n JiBwYXRoLCBsb25nIGxvbmcmIHJlc3VsdCkKIAogYm9vbCBmaWxlSXNEaXJlY3RvcnkoY29uc3Qg U3RyaW5nJiBwYXRoLCBTaG91bGRGb2xsb3dTeW1ib2xpY0xpbmtzIHNob3VsZEZvbGxvd1N5bWJv bGljTGlua3MpCiB7Ci0gICAgaWYgKHBhdGguaXNFbXB0eSgpKQotICAgICAgICByZXR1cm4gZmFs c2U7CiAgICAgc3RkOjplcnJvcl9jb2RlIGVjOwogICAgIHN0ZDo6ZmlsZXN5c3RlbTo6ZmlsZV9z dGF0dXMgZmlsZVN0YXR1czsKICAgICBpZiAoc2hvdWxkRm9sbG93U3ltYm9saWNMaW5rcyA9PSBT aG91bGRGb2xsb3dTeW1ib2xpY0xpbmtzOjpZZXMpCmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL3d0 Zi9nbGliL0ZpbGVTeXN0ZW1HbGliLmNwcCBiL1NvdXJjZS9XVEYvd3RmL2dsaWIvRmlsZVN5c3Rl bUdsaWIuY3BwCmluZGV4IDkyZDVlNjZmYmVjZjk4ZDA3NzlkYmY1NGZkMThlN2IyYzI4ZTY4Yjgu LmViMTNmYWRlZTZkNTFhMjM2Y2E1M2E3MmY0YTU0MjI4Y2Q0OGRmN2UgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XVEYvd3RmL2dsaWIvRmlsZVN5c3RlbUdsaWIuY3BwCisrKyBiL1NvdXJjZS9XVEYvd3Rm L2dsaWIvRmlsZVN5c3RlbUdsaWIuY3BwCkBAIC03NCw3ICs3NCw3IEBAIFN0cmluZyBzdHJpbmdG cm9tRmlsZVN5c3RlbVJlcHJlc2VudGF0aW9uKGNvbnN0IGNoYXIqIHJlcHJlc2VudGF0aW9uKQog Q1N0cmluZyBmaWxlU3lzdGVtUmVwcmVzZW50YXRpb24oY29uc3QgU3RyaW5nJiBwYXRoKQogewog ICAgIGlmIChwYXRoLmlzRW1wdHkoKSkKLSAgICAgICAgcmV0dXJuIHsgfTsKKyAgICAgICAgcmV0 dXJuIENTdHJpbmcoIiIsIDApOwogCiAgICAgQ1N0cmluZyB1dGY4ID0gcGF0aC51dGY4KCk7CiAK 428083 2021-05-08 03:30:33 -0700 2021-05-08 09:54:18 -0700 Patch bug-225551-20210508183031.patch text/plain 2101 dpino U3VidmVyc2lvbiBSZXZpc2lvbjogMjc3MjIyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IGNkNmI5N2IzM2VmOGY2Y2MwYmMzYzc5 MjQzYWYxNTA4MmExY2UxZGQuLmQzZmVkZWQxMzI2M2NmOTJiNTUyY2NmZDVmMTViMWVlNGFiYzg1 YjMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMjEtMDUtMDcgIERpZWdvIFBpbm8gR2FyY2lhICA8 ZHBpbm9AaWdhbGlhLmNvbT4KKworICAgICAgICBbR0xJQl0gUkVHUkVTU0lPTihyMjc3MTU4KSBp bXBvcnRlZC93M2Mvd2ViLXBsYXRmb3JtLXRlc3RzL3hoci9Gb3JtRGF0YS1hcHBlbmQuaHRtbCBp cyBjcmFzaGluZworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9MjI1NTUxCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgKiB3dGYvRmlsZVN5c3RlbS5jcHA6CisgICAgICAgIChXVEY6OkZpbGVTeXN0ZW1JbXBsOjpm aWxlSXNEaXJlY3RvcnkpOiBSZW1vdmUgdW5uZWNlc3NhcnkgcGF0aC5pc0VtcHR5IGNoZWNrLgor ICAgICAgICAqIHd0Zi9nbGliL0ZpbGVTeXN0ZW1HbGliLmNwcDoKKyAgICAgICAgKFdURjo6Rmls ZVN5c3RlbUltcGw6OmZpbGVTeXN0ZW1SZXByZXNlbnRhdGlvbik6IFJldHVybiBlbXB0eSBDU3Ry aW5nIGlmIHBhdGggaXMgZW1wdHkuCisKIDIwMjEtMDUtMDcgIENocmlzIER1bWV6ICA8Y2R1bWV6 QGFwcGxlLmNvbT4KIAogICAgICAgICBQb3J0IEZpbGVTeXN0ZW06OnBhdGhHZXRGaWxlTmFtZSgp ICYgRmlsZXN5c3RlbTo6ZGlyZWN0b3J5TmFtZSgpIHRvIHN0ZDo6ZmlsZXN5c3RlbQpkaWZmIC0t Z2l0IGEvU291cmNlL1dURi93dGYvRmlsZVN5c3RlbS5jcHAgYi9Tb3VyY2UvV1RGL3d0Zi9GaWxl U3lzdGVtLmNwcAppbmRleCBlMjc2YWYzZWVmZDkwODY1M2MwMGJlOTBiZTg1YTVhMjkxZDk1ZjVk Li4xNWExMDc0NTc1ZjcxY2ZkZDRkNDk4ZWRmYmE1ZTEwN2QxMTlmZjQwIDEwMDY0NAotLS0gYS9T b3VyY2UvV1RGL3d0Zi9GaWxlU3lzdGVtLmNwcAorKysgYi9Tb3VyY2UvV1RGL3d0Zi9GaWxlU3lz dGVtLmNwcApAQCAtNTk4LDggKzU5OCw2IEBAIGJvb2wgZ2V0RmlsZVNpemUoY29uc3QgU3RyaW5n JiBwYXRoLCBsb25nIGxvbmcmIHJlc3VsdCkKIAogYm9vbCBmaWxlSXNEaXJlY3RvcnkoY29uc3Qg U3RyaW5nJiBwYXRoLCBTaG91bGRGb2xsb3dTeW1ib2xpY0xpbmtzIHNob3VsZEZvbGxvd1N5bWJv bGljTGlua3MpCiB7Ci0gICAgaWYgKHBhdGguaXNFbXB0eSgpKQotICAgICAgICByZXR1cm4gZmFs c2U7CiAgICAgc3RkOjplcnJvcl9jb2RlIGVjOwogICAgIHN0ZDo6ZmlsZXN5c3RlbTo6ZmlsZV9z dGF0dXMgZmlsZVN0YXR1czsKICAgICBpZiAoc2hvdWxkRm9sbG93U3ltYm9saWNMaW5rcyA9PSBT aG91bGRGb2xsb3dTeW1ib2xpY0xpbmtzOjpZZXMpCmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL3d0 Zi9nbGliL0ZpbGVTeXN0ZW1HbGliLmNwcCBiL1NvdXJjZS9XVEYvd3RmL2dsaWIvRmlsZVN5c3Rl bUdsaWIuY3BwCmluZGV4IDkyZDVlNjZmYmVjZjk4ZDA3NzlkYmY1NGZkMThlN2IyYzI4ZTY4Yjgu LmM2ZWRjYmY3NDI0ZTk1ODAyOWU5MmUzMTMzNzA5ODA2ZjI0M2Y0YjcgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XVEYvd3RmL2dsaWIvRmlsZVN5c3RlbUdsaWIuY3BwCisrKyBiL1NvdXJjZS9XVEYvd3Rm L2dsaWIvRmlsZVN5c3RlbUdsaWIuY3BwCkBAIC03Myw4ICs3MywxMCBAQCBTdHJpbmcgc3RyaW5n RnJvbUZpbGVTeXN0ZW1SZXByZXNlbnRhdGlvbihjb25zdCBjaGFyKiByZXByZXNlbnRhdGlvbikK IAogQ1N0cmluZyBmaWxlU3lzdGVtUmVwcmVzZW50YXRpb24oY29uc3QgU3RyaW5nJiBwYXRoKQog ewotICAgIGlmIChwYXRoLmlzRW1wdHkoKSkKKyAgICBpZiAocGF0aC5pc051bGwoKSkKICAgICAg ICAgcmV0dXJuIHsgfTsKKyAgICBpZiAocGF0aC5pc0VtcHR5KCkpCisgICAgICAgIHJldHVybiBD U3RyaW5nKCIiKTsKIAogICAgIENTdHJpbmcgdXRmOCA9IHBhdGgudXRmOCgpOwogCg==