225532 2021-05-07 11:52:58 -0700 [iOS] fix inconsistency around the meaning of `rate` and `defaultPlaybackRate` between WebKit and AVKit 2021-08-09 19:25:30 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=228939 InRadar P2 Normal --- 1 hi hi eric.carlson hi peng.liu6 webkit-bug-importer oldest_to_newest 1757941 0 hi 2021-05-07 11:52:58 -0700 In AVKit, the `defaultPlaybackRate` is used when playback starts, such as resuming after pausing. In WebKit, however, `defaultPlaybackRate` is only used when first loading and after ending scanning, instead using the `playbackRate` is used in all other cases, including when resuming after pausing. 1757942 1 hi 2021-05-07 11:53:14 -0700 <rdar://problem/77629276> 1757943 2 428016 hi 2021-05-07 11:54:55 -0700 Created attachment 428016 Patch 1757955 3 428016 peng.liu6 2021-05-07 12:23:28 -0700 Comment on attachment 428016 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=428016&action=review > Source/WebCore/platform/ios/PlaybackSessionInterfaceAVKit.mm:130 > + [m_playerController setRate:isPlaying ? playbackRate : 0.]; Is this change intended? > Source/WebCore/platform/ios/WebAVPlayerController.mm:201 > + // ending scanning, instead using the `playbackRate` is used in all other cases, including when Nit. s/instead using/instead/ 1757959 4 428016 hi 2021-05-07 12:37:08 -0700 Comment on attachment 428016 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=428016&action=review >> Source/WebCore/platform/ios/PlaybackSessionInterfaceAVKit.mm:130 >> + [m_playerController setRate:isPlaying ? playbackRate : 0.]; > > Is this change intended? Yes. This is because ultimately we want the `rate` to be the source of truth, so we want to set it last. >> Source/WebCore/platform/ios/WebAVPlayerController.mm:201 >> + // ending scanning, instead using the `playbackRate` is used in all other cases, including when > > Nit. > s/instead using/instead/ Oops, will change :) 1757964 5 428025 hi 2021-05-07 12:45:36 -0700 Created attachment 428025 Patch 1758022 6 ews-feeder 2021-05-07 15:01:07 -0700 Committed r277203 (237475@main): <https://commits.webkit.org/237475@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 428025. 428016 2021-05-07 11:54:55 -0700 2021-05-07 12:45:36 -0700 Patch 225532.diff text/plain 3447 hi ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCAwNjY2YjMyMGViYjIuLmY2NmQ3NzE0MDI5NCAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAt MSwzICsxLDI2IEBACisyMDIxLTA1LTA3ICBEZXZpbiBSb3Vzc28gIDxkcm91c3NvQGFwcGxlLmNv bT4KKworICAgICAgICBbaU9TXSBmaXggaW5jb25zaXN0ZW5jeSBhcm91bmQgdGhlIG1lYW5pbmcg b2YgYHJhdGVgIGFuZCBgZGVmYXVsdFBsYXliYWNrUmF0ZWAgYmV0d2VlbiBXZWJLaXQgYW5kIEFW S2l0CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMjU1 MzIKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzc3NjI5Mjc2PgorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEluIEFWS2l0LCB0aGUgYGRlZmF1bHRQbGF5 YmFja1JhdGVgIGlzIHVzZWQgd2hlbiBwbGF5YmFjayBzdGFydHMsIHN1Y2ggYXMgcmVzdW1pbmcg YWZ0ZXIKKyAgICAgICAgcGF1c2luZy4gSW4gV2ViS2l0LCBob3dldmVyLCBgZGVmYXVsdFBsYXli YWNrUmF0ZWAgaXMgb25seSB1c2VkIHdoZW4gZmlyc3QgbG9hZGluZyBhbmQgYWZ0ZXIKKyAgICAg ICAgZW5kaW5nIHNjYW5uaW5nLCBpbnN0ZWFkIHVzaW5nIHRoZSBgcGxheWJhY2tSYXRlYCBpcyB1 c2VkIGluIGFsbCBvdGhlciBjYXNlcywgaW5jbHVkaW5nIHdoZW4KKyAgICAgICAgcmVzdW1pbmcg YWZ0ZXIgcGF1c2luZy4gQXMgc3VjaCwgV2ViS2l0IHNob3VsZCByZXR1cm4gdGhlIGBwbGF5YmFj a1JhdGVgIGluc3RlYWQgb2YgdGhlCisgICAgICAgIGBkZWZhdWx0UGxheWJhY2tSYXRlYCBpbiB0 aGVzZSBjYXNlcyB3aGVuIGNvbW11bmljYXRpbmcgd2l0aCBBVktpdC4KKworICAgICAgICAqIHBs YXRmb3JtL2lvcy9XZWJBVlBsYXllckNvbnRyb2xsZXIubW06CisgICAgICAgICgtW1dlYkFWUGxh eWVyQ29udHJvbGxlciBzZXRSYXRlOl0pOgorICAgICAgICBBbHNvIGBzZXREZWZhdWx0UGxheWJh Y2tSYXRlOmAgaWYgbm90IHBhdXNlZCAoaS5lLiBgcmF0ZSAhPSAwYCkgc2luY2UgV2ViS2l0J3Mg ZGVmaW5pdGlvbiBvZgorICAgICAgICBgcGxheWJhY2tSYXRlYCBkb2VzIG5vdCBjaGFuZ2Ugd2hl biBwYXVzZWQuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9pb3MvUGxheWJhY2tTZXNzaW9uSW50ZXJm YWNlQVZLaXQubW06CisgICAgICAgIChXZWJDb3JlOjpQbGF5YmFja1Nlc3Npb25JbnRlcmZhY2VB VktpdDo6cmF0ZUNoYW5nZWQpOgorICAgICAgICBNYWtlIHN1cmUgdG8gYHNldERlZmF1bHRQbGF5 YmFja1JhdGU6YCBiZWZvcmUgYHNldFJhdGU6YCBhcyB0aGUgbGF0dGVyIGNhbiBhZmZlY3QgdGhl IGZvcm1lci4KKwogMjAyMS0wNS0wNiAgRGV2aW4gUm91c3NvICA8ZHJvdXNzb0BhcHBsZS5jb20+ CiAKICAgICAgICAgU2FtcGxlZCBQYWdlIFRvcCBDb2xvcjogbWFrZSBoaXQgdGVzdHMgY29uc2lk ZXIgZWxlbWVudHMgd2l0aCBgcG9pbnRlci1ldmVudHM6IG5vbmVgCmRpZmYgLS1naXQgYS9Tb3Vy Y2UvV2ViQ29yZS9wbGF0Zm9ybS9pb3MvUGxheWJhY2tTZXNzaW9uSW50ZXJmYWNlQVZLaXQubW0g Yi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9pb3MvUGxheWJhY2tTZXNzaW9uSW50ZXJmYWNlQVZL aXQubW0KaW5kZXggYmQ2YmVjNzdlMTVhLi5iMjY4NTM5MWM1ZjYgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJDb3JlL3BsYXRmb3JtL2lvcy9QbGF5YmFja1Nlc3Npb25JbnRlcmZhY2VBVktpdC5tbQor KysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9pb3MvUGxheWJhY2tTZXNzaW9uSW50ZXJmYWNl QVZLaXQubW0KQEAgLTEyNiw4ICsxMjYsOCBAQCB2b2lkIFBsYXliYWNrU2Vzc2lvbkludGVyZmFj ZUFWS2l0OjpidWZmZXJlZFRpbWVDaGFuZ2VkKGRvdWJsZSBidWZmZXJlZFRpbWUpCiAKIHZvaWQg UGxheWJhY2tTZXNzaW9uSW50ZXJmYWNlQVZLaXQ6OnJhdGVDaGFuZ2VkKGJvb2wgaXNQbGF5aW5n LCBmbG9hdCBwbGF5YmFja1JhdGUsIGZsb2F0IGRlZmF1bHRQbGF5YmFja1JhdGUpCiB7Ci0gICAg W21fcGxheWVyQ29udHJvbGxlciBzZXRSYXRlOmlzUGxheWluZyA/IHBsYXliYWNrUmF0ZSA6IDAu XTsKICAgICBbbV9wbGF5ZXJDb250cm9sbGVyIHNldERlZmF1bHRQbGF5YmFja1JhdGU6ZGVmYXVs dFBsYXliYWNrUmF0ZV07CisgICAgW21fcGxheWVyQ29udHJvbGxlciBzZXRSYXRlOmlzUGxheWlu ZyA/IHBsYXliYWNrUmF0ZSA6IDAuXTsKIH0KIAogdm9pZCBQbGF5YmFja1Nlc3Npb25JbnRlcmZh Y2VBVktpdDo6c2Vla2FibGVSYW5nZXNDaGFuZ2VkKGNvbnN0IFRpbWVSYW5nZXMmIHRpbWVSYW5n ZXMsIGRvdWJsZSBsYXN0TW9kaWZpZWRUaW1lLCBkb3VibGUgbGl2ZVVwZGF0ZUludGVydmFsKQpk aWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vaW9zL1dlYkFWUGxheWVyQ29udHJv bGxlci5tbSBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2lvcy9XZWJBVlBsYXllckNvbnRyb2xs ZXIubW0KaW5kZXggYzYzZjE3M2JmYmIzLi44NjY1NDQ3MzRlZDggMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJDb3JlL3BsYXRmb3JtL2lvcy9XZWJBVlBsYXllckNvbnRyb2xsZXIubW0KKysrIGIvU291 cmNlL1dlYkNvcmUvcGxhdGZvcm0vaW9zL1dlYkFWUGxheWVyQ29udHJvbGxlci5tbQpAQCAtMTk2 LDYgKzE5NiwxMyBAQCAtICh2b2lkKXNldFJhdGU6KGRvdWJsZSlyYXRlCiAgICAgaWYgKCFfcmF0 ZSkKICAgICAgICAgcmV0dXJuOwogCisgICAgLy8gSW4gQVZLaXQsIHRoZSBgZGVmYXVsdFBsYXli YWNrUmF0ZWAgaXMgdXNlZCB3aGVuIHBsYXliYWNrIHN0YXJ0cywgc3VjaCBhcyByZXN1bWluZyBh ZnRlcgorICAgIC8vIHBhdXNpbmcuIEluIFdlYktpdCwgaG93ZXZlciwgYGRlZmF1bHRQbGF5YmFj a1JhdGVgIGlzIG9ubHkgdXNlZCB3aGVuIGZpcnN0IGxvYWRpbmcgYW5kIGFmdGVyCisgICAgLy8g ZW5kaW5nIHNjYW5uaW5nLCBpbnN0ZWFkIHVzaW5nIHRoZSBgcGxheWJhY2tSYXRlYCBpcyB1c2Vk IGluIGFsbCBvdGhlciBjYXNlcywgaW5jbHVkaW5nIHdoZW4KKyAgICAvLyByZXN1bWluZyBhZnRl ciBwYXVzaW5nLiBBcyBzdWNoLCBXZWJLaXQgc2hvdWxkIHJldHVybiB0aGUgYHBsYXliYWNrUmF0 ZWAgaW5zdGVhZCBvZiB0aGUKKyAgICAvLyBgZGVmYXVsdFBsYXliYWNrUmF0ZWAgaW4gdGhlc2Ug Y2FzZXMgd2hlbiBjb21tdW5pY2F0aW5nIHdpdGggQVZLaXQuCisgICAgW3NlbGYgc2V0RGVmYXVs dFBsYXliYWNrUmF0ZTpfcmF0ZV07CisKICAgICBpZiAoc2VsZi5kZWxlZ2F0ZSAmJiBzZWxmLmRl bGVnYXRlLT5wbGF5YmFja1JhdGUoKSAhPSBfcmF0ZSkKICAgICAgICAgc2VsZi5kZWxlZ2F0ZS0+ c2V0UGxheWJhY2tSYXRlKF9yYXRlKTsKIH0K 428025 2021-05-07 12:45:36 -0700 2021-05-07 15:01:07 -0700 Patch 225532.diff text/plain 3435 hi ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCAwNjY2YjMyMGViYjIuLmY2NmQ3NzE0MDI5NCAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAt MSwzICsxLDI2IEBACisyMDIxLTA1LTA3ICBEZXZpbiBSb3Vzc28gIDxkcm91c3NvQGFwcGxlLmNv bT4KKworICAgICAgICBbaU9TXSBmaXggaW5jb25zaXN0ZW5jeSBhcm91bmQgdGhlIG1lYW5pbmcg b2YgYHJhdGVgIGFuZCBgZGVmYXVsdFBsYXliYWNrUmF0ZWAgYmV0d2VlbiBXZWJLaXQgYW5kIEFW S2l0CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMjU1 MzIKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzc3NjI5Mjc2PgorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEluIEFWS2l0LCB0aGUgYGRlZmF1bHRQbGF5 YmFja1JhdGVgIGlzIHVzZWQgd2hlbiBwbGF5YmFjayBzdGFydHMsIHN1Y2ggYXMgcmVzdW1pbmcg YWZ0ZXIKKyAgICAgICAgcGF1c2luZy4gSW4gV2ViS2l0LCBob3dldmVyLCBgZGVmYXVsdFBsYXli YWNrUmF0ZWAgaXMgb25seSB1c2VkIHdoZW4gZmlyc3QgbG9hZGluZyBhbmQgYWZ0ZXIKKyAgICAg ICAgZW5kaW5nIHNjYW5uaW5nLCB3aXRoIHRoZSBgcGxheWJhY2tSYXRlYCBiZWluZyB1c2VkIGlu IGFsbCBvdGhlciBjYXNlcywgaW5jbHVkaW5nIHdoZW4KKyAgICAgICAgcmVzdW1pbmcgYWZ0ZXIg cGF1c2luZy4gQXMgc3VjaCwgV2ViS2l0IHNob3VsZCByZXR1cm4gdGhlIGBwbGF5YmFja1JhdGVg IGluc3RlYWQgb2YgdGhlCisgICAgICAgIGBkZWZhdWx0UGxheWJhY2tSYXRlYCBpbiB0aGVzZSBj YXNlcyB3aGVuIGNvbW11bmljYXRpbmcgd2l0aCBBVktpdC4KKworICAgICAgICAqIHBsYXRmb3Jt L2lvcy9XZWJBVlBsYXllckNvbnRyb2xsZXIubW06CisgICAgICAgICgtW1dlYkFWUGxheWVyQ29u dHJvbGxlciBzZXRSYXRlOl0pOgorICAgICAgICBBbHNvIGBzZXREZWZhdWx0UGxheWJhY2tSYXRl OmAgaWYgbm90IHBhdXNlZCAoaS5lLiBgcmF0ZSAhPSAwYCkgc2luY2UgV2ViS2l0J3MgZGVmaW5p dGlvbiBvZgorICAgICAgICBgcGxheWJhY2tSYXRlYCBkb2VzIG5vdCBjaGFuZ2Ugd2hlbiBwYXVz ZWQuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9pb3MvUGxheWJhY2tTZXNzaW9uSW50ZXJmYWNlQVZL aXQubW06CisgICAgICAgIChXZWJDb3JlOjpQbGF5YmFja1Nlc3Npb25JbnRlcmZhY2VBVktpdDo6 cmF0ZUNoYW5nZWQpOgorICAgICAgICBNYWtlIHN1cmUgdG8gYHNldERlZmF1bHRQbGF5YmFja1Jh dGU6YCBiZWZvcmUgYHNldFJhdGU6YCBhcyB0aGUgbGF0dGVyIGNhbiBhZmZlY3QgdGhlIGZvcm1l ci4KKwogMjAyMS0wNS0wNiAgRGV2aW4gUm91c3NvICA8ZHJvdXNzb0BhcHBsZS5jb20+CiAKICAg ICAgICAgU2FtcGxlZCBQYWdlIFRvcCBDb2xvcjogbWFrZSBoaXQgdGVzdHMgY29uc2lkZXIgZWxl bWVudHMgd2l0aCBgcG9pbnRlci1ldmVudHM6IG5vbmVgCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi Q29yZS9wbGF0Zm9ybS9pb3MvUGxheWJhY2tTZXNzaW9uSW50ZXJmYWNlQVZLaXQubW0gYi9Tb3Vy Y2UvV2ViQ29yZS9wbGF0Zm9ybS9pb3MvUGxheWJhY2tTZXNzaW9uSW50ZXJmYWNlQVZLaXQubW0K aW5kZXggYmQ2YmVjNzdlMTVhLi5iMjY4NTM5MWM1ZjYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJD b3JlL3BsYXRmb3JtL2lvcy9QbGF5YmFja1Nlc3Npb25JbnRlcmZhY2VBVktpdC5tbQorKysgYi9T b3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9pb3MvUGxheWJhY2tTZXNzaW9uSW50ZXJmYWNlQVZLaXQu bW0KQEAgLTEyNiw4ICsxMjYsOCBAQCB2b2lkIFBsYXliYWNrU2Vzc2lvbkludGVyZmFjZUFWS2l0 OjpidWZmZXJlZFRpbWVDaGFuZ2VkKGRvdWJsZSBidWZmZXJlZFRpbWUpCiAKIHZvaWQgUGxheWJh Y2tTZXNzaW9uSW50ZXJmYWNlQVZLaXQ6OnJhdGVDaGFuZ2VkKGJvb2wgaXNQbGF5aW5nLCBmbG9h dCBwbGF5YmFja1JhdGUsIGZsb2F0IGRlZmF1bHRQbGF5YmFja1JhdGUpCiB7Ci0gICAgW21fcGxh eWVyQ29udHJvbGxlciBzZXRSYXRlOmlzUGxheWluZyA/IHBsYXliYWNrUmF0ZSA6IDAuXTsKICAg ICBbbV9wbGF5ZXJDb250cm9sbGVyIHNldERlZmF1bHRQbGF5YmFja1JhdGU6ZGVmYXVsdFBsYXli YWNrUmF0ZV07CisgICAgW21fcGxheWVyQ29udHJvbGxlciBzZXRSYXRlOmlzUGxheWluZyA/IHBs YXliYWNrUmF0ZSA6IDAuXTsKIH0KIAogdm9pZCBQbGF5YmFja1Nlc3Npb25JbnRlcmZhY2VBVktp dDo6c2Vla2FibGVSYW5nZXNDaGFuZ2VkKGNvbnN0IFRpbWVSYW5nZXMmIHRpbWVSYW5nZXMsIGRv dWJsZSBsYXN0TW9kaWZpZWRUaW1lLCBkb3VibGUgbGl2ZVVwZGF0ZUludGVydmFsKQpkaWZmIC0t Z2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vaW9zL1dlYkFWUGxheWVyQ29udHJvbGxlci5t bSBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2lvcy9XZWJBVlBsYXllckNvbnRyb2xsZXIubW0K aW5kZXggYzYzZjE3M2JmYmIzLi44NjY1NDQ3MzRlZDggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJD b3JlL3BsYXRmb3JtL2lvcy9XZWJBVlBsYXllckNvbnRyb2xsZXIubW0KKysrIGIvU291cmNlL1dl YkNvcmUvcGxhdGZvcm0vaW9zL1dlYkFWUGxheWVyQ29udHJvbGxlci5tbQpAQCAtMTk2LDYgKzE5 NiwxMyBAQCAtICh2b2lkKXNldFJhdGU6KGRvdWJsZSlyYXRlCiAgICAgaWYgKCFfcmF0ZSkKICAg ICAgICAgcmV0dXJuOwogCisgICAgLy8gSW4gQVZLaXQsIHRoZSBgZGVmYXVsdFBsYXliYWNrUmF0 ZWAgaXMgdXNlZCB3aGVuIHBsYXliYWNrIHN0YXJ0cywgc3VjaCBhcyByZXN1bWluZyBhZnRlcgor ICAgIC8vIHBhdXNpbmcuIEluIFdlYktpdCwgaG93ZXZlciwgYGRlZmF1bHRQbGF5YmFja1JhdGVg IGlzIG9ubHkgdXNlZCB3aGVuIGZpcnN0IGxvYWRpbmcgYW5kIGFmdGVyCisgICAgLy8gZW5kaW5n IHNjYW5uaW5nLCB3aXRoIHRoZSBgcGxheWJhY2tSYXRlYCBiZWluZyB1c2VkIGluIGFsbCBvdGhl ciBjYXNlcywgaW5jbHVkaW5nIHdoZW4KKyAgICAvLyByZXN1bWluZyBhZnRlciBwYXVzaW5nLiBB cyBzdWNoLCBXZWJLaXQgc2hvdWxkIHJldHVybiB0aGUgYHBsYXliYWNrUmF0ZWAgaW5zdGVhZCBv ZiB0aGUKKyAgICAvLyBgZGVmYXVsdFBsYXliYWNrUmF0ZWAgaW4gdGhlc2UgY2FzZXMgd2hlbiBj b21tdW5pY2F0aW5nIHdpdGggQVZLaXQuCisgICAgW3NlbGYgc2V0RGVmYXVsdFBsYXliYWNrUmF0 ZTpfcmF0ZV07CisKICAgICBpZiAoc2VsZi5kZWxlZ2F0ZSAmJiBzZWxmLmRlbGVnYXRlLT5wbGF5 YmFja1JhdGUoKSAhPSBfcmF0ZSkKICAgICAgICAgc2VsZi5kZWxlZ2F0ZS0+c2V0UGxheWJhY2tS YXRlKF9yYXRlKTsKIH0K