225511 2021-05-07 05:53:43 -0700 [GStreamer][MediaStream] Emit black frames for disabled video tracks 2021-05-10 01:08:55 -0700 1 1 1 Unclassified WebKit Platform WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 pnormand pnormand calvaris eric.carlson ews-watchlist glenn hta jer.noble philipj sergio tommyw webkit-bug-importer oldest_to_newest 1757851 0 pnormand 2021-05-07 05:53:43 -0700 imported/w3c/web-platform-tests/mediacapture-streams/MediaStreamTrack-MediaElement-disabled-video-is-black.https.html fails. 1757853 1 427995 pnormand 2021-05-07 05:56:30 -0700 Created attachment 427995 Patch 1757871 2 427995 calvaris 2021-05-07 08:24:54 -0700 Comment on attachment 427995 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=427995&action=review > Source/WebCore/platform/mediastream/gstreamer/GStreamerMediaStreamSource.cpp:276 > + pushSample(blackSample.get()); Nit (maybe for other time): wouldn't it be nice pushSample was void pushSample(GRefPtr<GstSample>&&) ? 1757875 3 427995 pnormand 2021-05-07 08:39:13 -0700 Comment on attachment 427995 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=427995&action=review >> Source/WebCore/platform/mediastream/gstreamer/GStreamerMediaStreamSource.cpp:276 >> + pushSample(blackSample.get()); > > Nit (maybe for other time): wouldn't it be nice pushSample was void pushSample(GRefPtr<GstSample>&&) ? I don't think that's possible currently because when the track is enabled the sample being pushed is not owned by the observer, but by the track that generates it. And a track can have more than one observer. 1757878 4 pnormand 2021-05-07 08:52:22 -0700 Committed r277175 (237461@main): <https://commits.webkit.org/237461@main> 1757881 5 webkit-bug-importer 2021-05-07 08:53:32 -0700 <rdar://problem/77658069> 1758443 6 calvaris 2021-05-10 01:08:55 -0700 (In reply to Philippe Normand from comment #3) > Comment on attachment 427995 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=427995&action=review > > >> Source/WebCore/platform/mediastream/gstreamer/GStreamerMediaStreamSource.cpp:276 > >> + pushSample(blackSample.get()); > > > > Nit (maybe for other time): wouldn't it be nice pushSample was void pushSample(GRefPtr<GstSample>&&) ? > > I don't think that's possible currently because when the track is enabled > the sample being pushed is not owned by the observer, but by the track that > generates it. And a track can have more than one observer. It doesn't mean you can't create another GRefPtr<GstSample> by reffing the sampled owned by the track, right? 427995 2021-05-07 05:56:30 -0700 2021-05-07 08:24:54 -0700 Patch bug-225511-20210507055629.patch text/plain 5901 pnormand U3VidmVyc2lvbiBSZXZpc2lvbjogMjc3MTY3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggN2IwZjFhZTAzMGI0MTY2 OTViYzY0MDZmZmY0YmMwNzAwYjkzZmVkZi4uODFmNmMwOGRmNGI2MDc1MTIwZjllNzRjMzhjOWFi M2Y3M2RmNjUwNCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDIxLTA1LTA3ICBQaGls aXBwZSBOb3JtYW5kICA8cG5vcm1hbmRAaWdhbGlhLmNvbT4KKworICAgICAgICBbR1N0cmVhbWVy XVtNZWRpYVN0cmVhbV0gRW1pdCBibGFjayBmcmFtZXMgZm9yIGRpc2FibGVkIHZpZGVvIHRyYWNr cworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjI1NTEx CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgSW4gY2Fz ZSB0aGUgdmlkZW8gdHJhY2sgaXMgZGlzYWJsZWQsIGVtaXQgYSBibGFjayBJNDIwIGZyYW1lLiBG b3IgZGlzYWJsZWQgYXVkaW8gdHJhY2tzIHdlCisgICAgICAgIG1pZ2h0IG5lZWQgdG8gc2lsZW5j ZSB0aGUgY29ycmVzcG9uZGluZyBhdWRpbyBmcmFtZXMsIHRoaXMgd2lsbCBiZSBpbnZlc3RpZ2F0 ZWQgaW4gYQorICAgICAgICBmb2xsb3ctdXAgcGF0Y2guCisKKyAgICAgICAgKiBwbGF0Zm9ybS9t ZWRpYXN0cmVhbS9nc3RyZWFtZXIvR1N0cmVhbWVyTWVkaWFTdHJlYW1Tb3VyY2UuY3BwOgorCiAy MDIxLTA1LTA3ICBGcsOpZMOpcmljIFdhbmcgIDxmd2FuZ0BpZ2FsaWEuY29tPgogCiAgICAgICAg IENyYXNoIGluIEluc2VydFRleHRDb21tYW5kOjpwb3NpdGlvbkluc2lkZVRleHROb2RlCmRpZmYg LS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9tZWRpYXN0cmVhbS9nc3RyZWFtZXIvR1N0 cmVhbWVyTWVkaWFTdHJlYW1Tb3VyY2UuY3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbWVk aWFzdHJlYW0vZ3N0cmVhbWVyL0dTdHJlYW1lck1lZGlhU3RyZWFtU291cmNlLmNwcAppbmRleCBj NmQ0MWIxYTRiMzYwMGI1MzViYzNkNjg3YjA0YzQ3ZmYwZDhhNzk2Li5iNmEyMTUxZTgyMWY0NzZm OGRiYmY5MWJmNWM2NDk3MWZjNTE5YTMyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0 Zm9ybS9tZWRpYXN0cmVhbS9nc3RyZWFtZXIvR1N0cmVhbWVyTWVkaWFTdHJlYW1Tb3VyY2UuY3Bw CisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL21lZGlhc3RyZWFtL2dzdHJlYW1lci9HU3Ry ZWFtZXJNZWRpYVN0cmVhbVNvdXJjZS5jcHAKQEAgLTI0MCwyOCArMjQwLDQ2IEBAIHB1YmxpYzoK IAogICAgIHZvaWQgdHJhY2tTdGFydGVkKE1lZGlhU3RyZWFtVHJhY2tQcml2YXRlJikgZmluYWwg eyB9OwogICAgIHZvaWQgdHJhY2tFbmRlZChNZWRpYVN0cmVhbVRyYWNrUHJpdmF0ZSYpIGZpbmFs OwotCi0gICAgdm9pZCB0cmFja0VuYWJsZWRDaGFuZ2VkKE1lZGlhU3RyZWFtVHJhY2tQcml2YXRl JiB0cmFjaykgZmluYWwKLSAgICB7Ci0gICAgICAgIG1fZW5hYmxlZCA9IHRyYWNrLmVuYWJsZWQo KTsKLSAgICB9Ci0KKyAgICB2b2lkIHRyYWNrRW5hYmxlZENoYW5nZWQoTWVkaWFTdHJlYW1UcmFj a1ByaXZhdGUmKSBmaW5hbCB7IH07CiAgICAgdm9pZCB0cmFja011dGVkQ2hhbmdlZChNZWRpYVN0 cmVhbVRyYWNrUHJpdmF0ZSYpIGZpbmFsIHsgfTsKICAgICB2b2lkIHRyYWNrU2V0dGluZ3NDaGFu Z2VkKE1lZGlhU3RyZWFtVHJhY2tQcml2YXRlJikgZmluYWwgeyB9OwogICAgIHZvaWQgcmVhZHlT dGF0ZUNoYW5nZWQoTWVkaWFTdHJlYW1UcmFja1ByaXZhdGUmKSBmaW5hbCB7IH07CiAKICAgICB2 b2lkIHZpZGVvU2FtcGxlQXZhaWxhYmxlKE1lZGlhU2FtcGxlJiBzYW1wbGUpIGZpbmFsCiAgICAg ewotICAgICAgICBpZiAoIW1fZW5hYmxlZCB8fCAhbV9wYXJlbnQpCisgICAgICAgIGlmICghbV9w YXJlbnQpCiAgICAgICAgICAgICByZXR1cm47CiAKICAgICAgICAgYXV0byogZ3N0U2FtcGxlID0g c3RhdGljX2Nhc3Q8TWVkaWFTYW1wbGVHU3RyZWFtZXIqPigmc2FtcGxlKS0+cGxhdGZvcm1TYW1w bGUoKS5zYW1wbGUuZ3N0U2FtcGxlOwotICAgICAgICBwdXNoU2FtcGxlKGdzdFNhbXBsZSk7Cisg ICAgICAgIGlmIChtX3RyYWNrLmVuYWJsZWQoKSkgeworICAgICAgICAgICAgcHVzaFNhbXBsZShn c3RTYW1wbGUpOworICAgICAgICAgICAgcmV0dXJuOworICAgICAgICB9CisKKyAgICAgICAgLy8g SW4gY2FzZSB0aGUgdHJhY2sgaXMgZGlzYWJsZWQsIGVtaXQgYSBibGFjayBJNDIwIGZyYW1lLgor ICAgICAgICBhdXRvIGNhcHMgPSBhZG9wdEdSZWYoZ3N0X2NhcHNfY29weShnc3Rfc2FtcGxlX2dl dF9jYXBzKGdzdFNhbXBsZSkpKTsKKyAgICAgICAgZ3N0X2NhcHNfc2V0X3NpbXBsZShjYXBzLmdl dCgpLCAiZm9ybWF0IiwgR19UWVBFX1NUUklORywgIkk0MjAiLCBudWxscHRyKTsKKworICAgICAg ICBHc3RWaWRlb0luZm8gaW5mbzsKKyAgICAgICAgZ3N0X3ZpZGVvX2luZm9fZnJvbV9jYXBzKCZp bmZvLCBjYXBzLmdldCgpKTsKKworICAgICAgICBhdXRvIGJ1ZmZlciA9IGFkb3B0R1JlZihnc3Rf YnVmZmVyX25ld19hbGxvY2F0ZShudWxscHRyLCBHU1RfVklERU9fSU5GT19TSVpFKCZpbmZvKSwg bnVsbHB0cikpOworICAgICAgICB7CisgICAgICAgICAgICBHc3RNYXBwZWRCdWZmZXIgZGF0YShi dWZmZXIsIEdTVF9NQVBfV1JJVEUpOworICAgICAgICAgICAgYXV0byB5T2Zmc2V0ID0gR1NUX1ZJ REVPX0lORk9fUExBTkVfT0ZGU0VUKCZpbmZvLCAxKTsKKyAgICAgICAgICAgIGF1dG8gdU9mZnNl dCA9IEdTVF9WSURFT19JTkZPX1BMQU5FX09GRlNFVCgmaW5mbywgMik7CisgICAgICAgICAgICBt ZW1zZXQoZGF0YS5kYXRhKCksIDAsIHlPZmZzZXQpOworICAgICAgICAgICAgbWVtc2V0KGRhdGEu ZGF0YSgpICsgeU9mZnNldCwgMTI4LCB1T2Zmc2V0KTsKKyAgICAgICAgfQorICAgICAgICBnc3Rf YnVmZmVyX2FkZF92aWRlb19tZXRhX2Z1bGwoYnVmZmVyLmdldCgpLCBHU1RfVklERU9fRlJBTUVf RkxBR19OT05FLCBHU1RfVklERU9fRk9STUFUX0k0MjAsIEdTVF9WSURFT19JTkZPX1dJRFRIKCZp bmZvKSwgR1NUX1ZJREVPX0lORk9fSEVJR0hUKCZpbmZvKSwgMywgaW5mby5vZmZzZXQsIGluZm8u c3RyaWRlKTsKKyAgICAgICAgYXV0byBibGFja1NhbXBsZSA9IGFkb3B0R1JlZihnc3Rfc2FtcGxl X25ldyhidWZmZXIuZ2V0KCksIGNhcHMuZ2V0KCksIG51bGxwdHIsIG51bGxwdHIpKTsKKyAgICAg ICAgcHVzaFNhbXBsZShibGFja1NhbXBsZS5nZXQoKSk7CiAgICAgfQogCiAgICAgdm9pZCBhdWRp b1NhbXBsZXNBdmFpbGFibGUoY29uc3QgTWVkaWFUaW1lJiwgY29uc3QgUGxhdGZvcm1BdWRpb0Rh dGEmIGF1ZGlvRGF0YSwgY29uc3QgQXVkaW9TdHJlYW1EZXNjcmlwdGlvbiYsIHNpemVfdCkgZmlu YWwKICAgICB7Ci0gICAgICAgIGlmICghbV9lbmFibGVkIHx8ICFtX3BhcmVudCkKKyAgICAgICAg Ly8gVE9ETzogV2UgbGlrZWx5IG5lZWQgdG8gZW1pdCBzaWxlbnQgYXVkaW8gZnJhbWVzIGluIGNh c2UgdGhlIHRyYWNrIGlzIGRpc2FibGVkLgorICAgICAgICBpZiAoIW1fdHJhY2suZW5hYmxlZCgp IHx8ICFtX3BhcmVudCkKICAgICAgICAgICAgIHJldHVybjsKIAogICAgICAgICBjb25zdCBhdXRv JiBkYXRhID0gc3RhdGljX2Nhc3Q8Y29uc3QgR1N0cmVhbWVyQXVkaW9EYXRhJj4oYXVkaW9EYXRh KTsKQEAgLTI3Myw3ICsyOTEsNiBAQCBwcml2YXRlOgogICAgIEdzdEVsZW1lbnQqIG1fcGFyZW50 IHsgbnVsbHB0ciB9OwogICAgIE1lZGlhU3RyZWFtVHJhY2tQcml2YXRlJiBtX3RyYWNrOwogICAg IEdSZWZQdHI8R3N0RWxlbWVudD4gbV9zcmM7Ci0gICAgYm9vbCBtX2VuYWJsZWQgeyB0cnVlIH07 CiAgICAgR3N0Q2xvY2tUaW1lIG1fZmlyc3RCdWZmZXJQdHMgeyBHU1RfQ0xPQ0tfVElNRV9OT05F IH07CiAgICAgYm9vbCBtX2Vub3VnaERhdGEgeyBmYWxzZSB9OwogICAgIGJvb2wgbV9uZWVkc0Rp c2NvbnQgeyBmYWxzZSB9OwpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nIGIvTGF5 b3V0VGVzdHMvQ2hhbmdlTG9nCmluZGV4IGNkYWVhZjdmNmY1MDdmMTljYTRkYjZmNWI3MzkwZGQ4 NDUxZDVjMmQuLmRmNzA5ODM3NjFhOTAwNTM1MzhjNjM3OTgyOWU5YjY5ZGMyZWRkMWEgMTAwNjQ0 Ci0tLSBhL0xheW91dFRlc3RzL0NoYW5nZUxvZworKysgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cK QEAgLTEsMyArMSwxMiBAQAorMjAyMS0wNS0wNyAgUGhpbGlwcGUgTm9ybWFuZCAgPHBub3JtYW5k QGlnYWxpYS5jb20+CisKKyAgICAgICAgW0dTdHJlYW1lcl1bTWVkaWFTdHJlYW1dIEVtaXQgYmxh Y2sgZnJhbWVzIGZvciBkaXNhYmxlZCB2aWRlbyB0cmFja3MKKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIyNTUxMQorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogcGxhdGZvcm0vZ2xpYi9UZXN0RXhwZWN0YXRp b25zOiBVbmZsYWcgbWVkaWFzdHJlYW0gdGVzdCBub3cgcGFzc2luZy4KKwogMjAyMS0wNS0wNyAg RW5yaXF1ZSBPY2HDsWEgR29uesOhbGV6ICA8ZW9jYW5oYUBpZ2FsaWEuY29tPgogCiAgICAgICAg IFtHU3RyZWFtZXJdIExheW91dCB0ZXN0IG1lZGlhL3ZpZGVvLXBsYXlzaW5saW5lLmh0bWwgaXMg Zmxha3kKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL3BsYXRmb3JtL2dsaWIvVGVzdEV4cGVjdGF0 aW9ucyBiL0xheW91dFRlc3RzL3BsYXRmb3JtL2dsaWIvVGVzdEV4cGVjdGF0aW9ucwppbmRleCBk NjJhMjRmZDk3YjAzNTI0MTRjN2U3MzE4MjNmYWYyMzJkNDA1OGZiLi4yZmJiMTYxODIxOGQ3Mjdm NjdkNTQ0YTZlZTczYmJhN2IyYTU4NTJmIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9wbGF0Zm9y bS9nbGliL1Rlc3RFeHBlY3RhdGlvbnMKKysrIGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0vZ2xpYi9U ZXN0RXhwZWN0YXRpb25zCkBAIC0xMTU4LDcgKzExNTgsNiBAQCB3ZWJraXQub3JnL2IvMjIyNzk0 IHdlYnJ0Yy9tdWx0aS12aWRlby5odG1sIFsgRmFpbHVyZSBdCiB3ZWJraXQub3JnL2IvMjI0MDc0 IHdlYnJ0Yy9jb25jdXJyZW50VmlkZW9QbGF5YmFjay5odG1sIFsgVGltZW91dCBQYXNzIF0KIAog d2Via2l0Lm9yZy9iLzIwNjY1NiBpbXBvcnRlZC93M2Mvd2ViLXBsYXRmb3JtLXRlc3RzL21lZGlh Y2FwdHVyZS1zdHJlYW1zL01lZGlhU3RyZWFtLXJlbW92ZXRyYWNrLmh0dHBzLmh0bWwgWyBDcmFz aCBGYWlsdXJlIFRpbWVvdXQgXQotd2Via2l0Lm9yZy9iLzIwNjY1NiBpbXBvcnRlZC93M2Mvd2Vi LXBsYXRmb3JtLXRlc3RzL21lZGlhY2FwdHVyZS1zdHJlYW1zL01lZGlhU3RyZWFtVHJhY2stTWVk aWFFbGVtZW50LWRpc2FibGVkLXZpZGVvLWlzLWJsYWNrLmh0dHBzLmh0bWwgWyBGYWlsdXJlIF0K IHdlYmtpdC5vcmcvYi8yMDY2NTYgaW1wb3J0ZWQvdzNjL3dlYi1wbGF0Zm9ybS10ZXN0cy9tZWRp YWNhcHR1cmUtc3RyZWFtcy9NZWRpYVN0cmVhbS1NZWRpYUVsZW1lbnQtcHJlbG9hZC1ub25lLW1h bnVhbC5odHRwcy5odG1sIFsgQ3Jhc2ggRmFpbHVyZSBQYXNzIF0KIHdlYmtpdC5vcmcvYi8yMTAz ODUgaW1wb3J0ZWQvdzNjL3dlYi1wbGF0Zm9ybS10ZXN0cy9tZWRpYWNhcHR1cmUtc3RyZWFtcy9N ZWRpYVN0cmVhbS1NZWRpYUVsZW1lbnQtZmlyc3RmcmFtZS5odHRwcy5odG1sIFsgRmFpbHVyZSBD cmFzaCBQYXNzIF0KIHdlYmtpdC5vcmcvYi8yMjM1MDggaW1wb3J0ZWQvdzNjL3dlYi1wbGF0Zm9y bS10ZXN0cy9tZWRpYWNhcHR1cmUtc3RyZWFtcy9NZWRpYVN0cmVhbS1NZWRpYUVsZW1lbnQtc3Jj T2JqZWN0Lmh0dHBzLmh0bWwgWyBGYWlsdXJlIF0K