225501 2021-05-06 18:32:07 -0700 [WinCairo] Remove linker warning on ANGLE 2021-05-09 22:14:11 -0700 1 1 1 Unclassified WebKit Platform WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 basuke basuke basuke darin dino don.olmstead ews-watchlist graouts kondapallykalyan stephan.szabo webkit-bug-importer oldest_to_newest 1757770 0 basuke 2021-05-06 18:32:07 -0700 There're two warnings displayed when creating library lib64\libGLESv2.lib and object lib64\libGLESv2.exp: LINK : warning LNK4217: symbol 'ANGLEGetDisplayPlatform' defined in 'ANGLE.lib(Platform.obj)' is imported by 'proc_table_egl_autogen.obj' in function '"void __cdecl egl::`dynamic initializer for 'g_procTable''(void)" (??__Eg_procTable@egl@@YAXXZ)' [W:\WebKit\WebKitBuild\Release\Source\ThirdParty\ANGLE\GLESv2.vcxproj] LINK : warning LNK4217: symbol 'ANGLEResetDisplayPlatform' defined in 'ANGLE.lib(Platform.obj)' is imported by 'proc_table_egl_autogen.obj' in function '"void __cdecl egl::`dynamic initializer for 'g_procTable''(void)" (??__Eg_procTable@egl@@YAXXZ)' [W:\WebKit\WebKitBuild\Release\Source\ThirdParty\ANGLE\GLESv2.vcxproj] 1758016 1 basuke 2021-05-07 14:53:05 -0700 I'm still beginner of Windows build env, but my understanding of this warning is: - ANGLE is compiled as static library - That is linked to libGLESv2.dll - __declspec(dllimport) is not required in this case Is my understanding correct? 1758028 2 428039 basuke 2021-05-07 15:15:24 -0700 Created attachment 428039 PATCH 1758029 3 ews-watchlist 2021-05-07 15:16:21 -0700 Note that there are important steps to take when updating ANGLE. See https://trac.webkit.org/wiki/UpdatingANGLE 1758273 4 428039 darin 2021-05-08 21:07:30 -0700 Comment on attachment 428039 PATCH View in context: https://bugs.webkit.org/attachment.cgi?id=428039&action=review > Source/ThirdParty/ANGLE/ChangeLog:8 > + libANGLE is statically linked to libGLESv2.dll so that __declspec(dllimport) is not required here. is *now* statically linked; we changed that recently 1758283 5 ews-feeder 2021-05-08 21:31:50 -0700 Committed r277241 (237510@main): <https://commits.webkit.org/237510@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 428039. 1758284 6 webkit-bug-importer 2021-05-08 21:32:14 -0700 <rdar://problem/77704188> 1758428 7 basuke 2021-05-09 22:14:11 -0700 > is *now* statically linked; we changed that recently Make sense. Thanks! 428039 2021-05-07 15:15:24 -0700 2021-05-08 21:31:51 -0700 PATCH patch.diff text/plain 1572 basuke ZGlmZiAtLWdpdCBhL1NvdXJjZS9UaGlyZFBhcnR5L0FOR0xFL0NoYW5nZUxvZyBiL1NvdXJjZS9U aGlyZFBhcnR5L0FOR0xFL0NoYW5nZUxvZwppbmRleCBkMWI1MWY2NTE3M2YuLjQyOTVjZWM5ZDEz NyAxMDA2NDQKLS0tIGEvU291cmNlL1RoaXJkUGFydHkvQU5HTEUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9UaGlyZFBhcnR5L0FOR0xFL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDIxLTA1 LTA3ICBCYXN1a2UgU3V6dWtpICA8YmFzdWtlLnN1enVraUBzb255LmNvbT4KKworICAgICAgICBb V2luQ2Fpcm9dIFJlbW92ZSBsaW5rZXIgd2FybmluZyBvbiBBTkdMRQorICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjI1NTAxCisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgbGliQU5HTEUgaXMgc3RhdGljYWxseSBs aW5rZWQgdG8gbGliR0xFU3YyLmRsbCBzbyB0aGF0IF9fZGVjbHNwZWMoZGxsaW1wb3J0KSBpcyBu b3QgcmVxdWlyZWQgaGVyZS4KKworICAgICAgICAqIGluY2x1ZGUvcGxhdGZvcm0vUGxhdGZvcm1N ZXRob2RzLmg6CisKIDIwMjEtMDUtMDMgIEt5bGUgUGlkZGluZ3RvbiAgPGtwaWRkaW5ndG9uQGFw cGxlLmNvbT4KIAogICAgICAgICBbTWV0YWwgQU5HTEVdOiBGaXggY29udmVyc2lvbnMgdGVzdHMg YW5kIHJlbW92ZSBmYWlsaW5nIHRlc3QgZXhwZWN0YXRpb25zCmRpZmYgLS1naXQgYS9Tb3VyY2Uv VGhpcmRQYXJ0eS9BTkdMRS9pbmNsdWRlL3BsYXRmb3JtL1BsYXRmb3JtTWV0aG9kcy5oIGIvU291 cmNlL1RoaXJkUGFydHkvQU5HTEUvaW5jbHVkZS9wbGF0Zm9ybS9QbGF0Zm9ybU1ldGhvZHMuaApp bmRleCA0Njk3YTg3ZTQ1ODYuLjQ0YmVmMWZmMjBkNiAxMDA2NDQKLS0tIGEvU291cmNlL1RoaXJk UGFydHkvQU5HTEUvaW5jbHVkZS9wbGF0Zm9ybS9QbGF0Zm9ybU1ldGhvZHMuaAorKysgYi9Tb3Vy Y2UvVGhpcmRQYXJ0eS9BTkdMRS9pbmNsdWRlL3BsYXRmb3JtL1BsYXRmb3JtTWV0aG9kcy5oCkBA IC0xNiwxMyArMTYsNyBAQAogI2RlZmluZSBFR0xfUExBVEZPUk1fQU5HTEVfUExBVEZPUk1fTUVU SE9EU19BTkdMRVggMHgzNDgyCiAKICNpZiAhZGVmaW5lZChBTkdMRV9QTEFURk9STV9FWFBPUlQp Ci0jICAgIGlmIGRlZmluZWQoX1dJTjMyKQotIyAgICAgICAgaWYgIWRlZmluZWQoTElCQU5HTEVf SU1QTEVNRU5UQVRJT04pCi0jICAgICAgICAgICAgZGVmaW5lIEFOR0xFX1BMQVRGT1JNX0VYUE9S VCBfX2RlY2xzcGVjKGRsbGltcG9ydCkKLSMgICAgICAgIGVsc2UKLSMgICAgICAgICAgICBkZWZp bmUgQU5HTEVfUExBVEZPUk1fRVhQT1JUIF9fZGVjbHNwZWMoZGxsZXhwb3J0KQotIyAgICAgICAg ZW5kaWYKLSMgICAgZWxpZiBkZWZpbmVkKF9fR05VQ19fKSB8fCBkZWZpbmVkKF9fY2xhbmdfXykK KyMgICAgaWYgZGVmaW5lZChfX0dOVUNfXykgfHwgZGVmaW5lZChfX2NsYW5nX18pCiAjICAgICAg ICBkZWZpbmUgQU5HTEVfUExBVEZPUk1fRVhQT1JUIF9fYXR0cmlidXRlX18oKHZpc2liaWxpdHko ImRlZmF1bHQiKSkpCiAjICAgIGVuZGlmCiAjZW5kaWYK