<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>225494</bug_id>
          
          <creation_ts>2021-05-06 16:32:23 -0700</creation_ts>
          <short_desc>[macOS] Initialize HIToolbox library before entering sandbox</short_desc>
          <delta_ts>2022-02-10 16:28:18 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>WebKit Misc.</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>WONTFIX</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Brent Fulgham">bfulgham</reporter>
          <assigned_to name="Brent Fulgham">bfulgham</assigned_to>
          <cc>bfulgham</cc>
    
    <cc>darin</cc>
    
    <cc>pvollan</cc>
    
    <cc>webkit-bug-importer</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1757706</commentid>
    <comment_count>0</comment_count>
    <who name="Brent Fulgham">bfulgham</who>
    <bug_when>2021-05-06 16:32:23 -0700</bug_when>
    <thetext>AppKit calls into an older library (HLToolkit) to handle some menu operations. This library wants to know if its in a background application, and does so by communicating with LaunchServices. However, we close our connection to LaunchServices during WebContent process launch, which prevents these calls from working.

Although this failure is harmless on production systems (it fails as &apos;background process&apos;, which is what we want) it triggers assertions and logging on internal systems that masks useful logs and wastes power and cycles.

If we invoke HLTBIsCurrentProcessBackgroundOnly() at launch, we can complete our LaunchServices communications prior to cutting them off as we enter the sandbox. HLToolbox caches the result, so will perform properly for the rest of the WebContent process runtime.

&lt;rdar://problem/77171527&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1757713</commentid>
    <comment_count>1</comment_count>
      <attachid>427956</attachid>
    <who name="Brent Fulgham">bfulgham</who>
    <bug_when>2021-05-06 16:39:00 -0700</bug_when>
    <thetext>Created attachment 427956
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1757740</commentid>
    <comment_count>2</comment_count>
      <attachid>427956</attachid>
    <who name="Alexey Proskuryakov">ap</who>
    <bug_when>2021-05-06 17:30:38 -0700</bug_when>
    <thetext>Comment on attachment 427956
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=427956&amp;action=review

&gt; Source/WebKit/ChangeLog:3
&gt; +        [macOS] Initialize HLToolbox library before entering sandbox

Do we know if this will open any persistent XPC connections that we don&apos;t allow while sandboxed?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1757752</commentid>
    <comment_count>3</comment_count>
      <attachid>427967</attachid>
    <who name="Brent Fulgham">bfulgham</who>
    <bug_when>2021-05-06 17:48:49 -0700</bug_when>
    <thetext>Created attachment 427967
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1757802</commentid>
    <comment_count>4</comment_count>
      <attachid>427956</attachid>
    <who name="Brent Fulgham">bfulgham</who>
    <bug_when>2021-05-07 00:20:53 -0700</bug_when>
    <thetext>Comment on attachment 427956
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=427956&amp;action=review

&gt;&gt; Source/WebKit/ChangeLog:3
&gt;&gt; +        [macOS] Initialize HLToolbox library before entering sandbox
&gt; 
&gt; Do we know if this will open any persistent XPC connections that we don&apos;t allow while sandboxed?

The implementation of HLTBIsCurrentProcessBackgroundOnly is very simple. It calls a single LaunchServices command to read some process state and caches the result before returning the value. Subsequent calls do not call LaunchServices again.

I’m confirming we already hit this call before entering the sandbox before landing, but I don’t see a way to open further connections from this one call.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1758070</commentid>
    <comment_count>5</comment_count>
      <attachid>428054</attachid>
    <who name="Brent Fulgham">bfulgham</who>
    <bug_when>2021-05-07 16:10:24 -0700</bug_when>
    <thetext>Created attachment 428054
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1758222</commentid>
    <comment_count>6</comment_count>
      <attachid>428054</attachid>
    <who name="Darin Adler">darin</who>
    <bug_when>2021-05-08 16:43:34 -0700</bug_when>
    <thetext>Comment on attachment 428054
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=428054&amp;action=review

&gt; Source/WebKit/ChangeLog:18
&gt; +        If we invoke HLTBIsCurrentProcessBackgroundOnly() at launch, we can complete our LaunchServices communications prior
&gt; +        to cutting them off as we enter the sandbox. HLToolbox caches the result, so will perform properly for the rest of
&gt; +        the WebContent process runtime.

This comment does not clarify that calling GetGrayRgn does this.

&gt; Source/WebKit/WebProcess/cocoa/WebProcessCocoa.mm:689
&gt; +    // Cache background state for HLToolBox so AppKit doesn&apos;t try to talk to LaunchServices after we enter the sandbox

WebKit style caller for a period at the end of the sentence.

Change log comment calls this HLToolbox but this comment calls it HLToolBox.

Comment does not make it clear why calling GetGrayRgn accomplishes what the comment says is needed.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1758223</commentid>
    <comment_count>7</comment_count>
      <attachid>428054</attachid>
    <who name="Darin Adler">darin</who>
    <bug_when>2021-05-08 16:44:50 -0700</bug_when>
    <thetext>Comment on attachment 428054
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=428054&amp;action=review

&gt; Source/WebKit/ChangeLog:17
&gt; +        If we invoke HLTBIsCurrentProcessBackgroundOnly() at launch, we can complete our LaunchServices communications prior
&gt; +        to cutting them off as we enter the sandbox. HLToolbox caches the result, so will perform properly for the rest of

This makes it sound like this will slow down web process creation. What we’re describing here sounds like synchronous IPC.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1759422</commentid>
    <comment_count>8</comment_count>
    <who name="Brent Fulgham">bfulgham</who>
    <bug_when>2021-05-12 15:43:20 -0700</bug_when>
    <thetext>The HIToolbox team suggested we use &apos;HiliteMenu(0)&apos; instead, so I&apos;ll propose a patch for that.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1759424</commentid>
    <comment_count>9</comment_count>
      <attachid>428054</attachid>
    <who name="Brent Fulgham">bfulgham</who>
    <bug_when>2021-05-12 15:50:27 -0700</bug_when>
    <thetext>Comment on attachment 428054
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=428054&amp;action=review

&gt;&gt; Source/WebKit/WebProcess/cocoa/WebProcessCocoa.mm:689
&gt;&gt; +    // Cache background state for HLToolBox so AppKit doesn&apos;t try to talk to LaunchServices after we enter the sandbox
&gt; 
&gt; WebKit style caller for a period at the end of the sentence.
&gt; 
&gt; Change log comment calls this HLToolbox but this comment calls it HLToolBox.
&gt; 
&gt; Comment does not make it clear why calling GetGrayRgn accomplishes what the comment says is needed.

Will fix.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1759425</commentid>
    <comment_count>10</comment_count>
      <attachid>428422</attachid>
    <who name="Brent Fulgham">bfulgham</who>
    <bug_when>2021-05-12 15:51:04 -0700</bug_when>
    <thetext>Created attachment 428422
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1759431</commentid>
    <comment_count>11</comment_count>
      <attachid>428425</attachid>
    <who name="Brent Fulgham">bfulgham</who>
    <bug_when>2021-05-12 16:02:11 -0700</bug_when>
    <thetext>Created attachment 428425
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1759433</commentid>
    <comment_count>12</comment_count>
    <who name="Brent Fulgham">bfulgham</who>
    <bug_when>2021-05-12 16:06:02 -0700</bug_when>
    <thetext>I&apos;m also running an A/B test to see if this triggers any PLT regression.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1759469</commentid>
    <comment_count>13</comment_count>
      <attachid>428425</attachid>
    <who name="Darin Adler">darin</who>
    <bug_when>2021-05-12 17:13:36 -0700</bug_when>
    <thetext>Comment on attachment 428425
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=428425&amp;action=review

&gt; Source/WebKit/ChangeLog:18
&gt; +        If we invoke HiliteMenu(0) at launch, we can complete our LaunchServices communications prior
&gt; +        to cutting them off as we enter the sandbox. HLToolbox caches the result, so will perform properly for the rest of
&gt; +        the WebContent process runtime.

I never did see your take on whether doing this additional work at this point is OK from a performance point of view.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1762472</commentid>
    <comment_count>14</comment_count>
    <who name="Brent Fulgham">bfulgham</who>
    <bug_when>2021-05-21 10:23:10 -0700</bug_when>
    <thetext>(In reply to Darin Adler from comment #13)
&gt; Comment on attachment 428425 [details]
&gt; Patch
&gt; 
&gt; View in context:
&gt; https://bugs.webkit.org/attachment.cgi?id=428425&amp;action=review
&gt; 
&gt; &gt; Source/WebKit/ChangeLog:18
&gt; &gt; +        If we invoke HiliteMenu(0) at launch, we can complete our LaunchServices communications prior
&gt; &gt; +        to cutting them off as we enter the sandbox. HLToolbox caches the result, so will perform properly for the rest of
&gt; &gt; +        the WebContent process runtime.
&gt; 
&gt; I never did see your take on whether doing this additional work at this
&gt; point is OK from a performance point of view.

I&apos;ve got some A/B tests running in the Perf bots to see if we catch any regression. I&apos;ll discuss with Per Arne before we land.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1765798</commentid>
    <comment_count>15</comment_count>
    <who name="Brent Fulgham">bfulgham</who>
    <bug_when>2021-06-01 15:30:37 -0700</bug_when>
    <thetext>A/B tests completed on low-end and high-end hardware, and confirmed there was no regression.

Next I&apos;ll confirm this change doesn&apos;t introduce any new connections we didn&apos;t have prior to making this call.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1765820</commentid>
    <comment_count>16</comment_count>
    <who name="Brent Fulgham">bfulgham</who>
    <bug_when>2021-06-01 17:00:57 -0700</bug_when>
    <thetext>It looks like this change causes new connections to be opened to distnoted, logs, and diagnosticd, which we don&apos;t need for other reasons and would not be closed before entering the sandbox without modifying other frameworks.

Since this change was being done to avoid the equivalent of a debug assertion in internal systems, it&apos;s not worth making the change. Eventually, we will remove these frameworks from the WebContent process entirely, resolving the problem permanently.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>427956</attachid>
            <date>2021-05-06 16:39:00 -0700</date>
            <delta_ts>2021-05-06 17:49:22 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-225494-20210506163859.patch</filename>
            <type>text/plain</type>
            <size>2856</size>
            <attacher name="Brent Fulgham">bfulgham</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjc3MTA0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No
YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDdlNzkzOTc5OWY1ZDg2MDY4
Mjg4ZDYyYjI2NGJhZTM1NjE2MDNlNjAuLjc3MzMzMTgzNTMwMTNjNGU3NTFjZjU5MDBhOGY3Y2M1
ZDc3YTRkYmUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj
ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjUgQEAKKzIwMjEtMDUtMDYgIEJyZW50IEZ1
bGdoYW0gIDxiZnVsZ2hhbUBhcHBsZS5jb20+CisKKyAgICAgICAgW21hY09TXSBJbml0aWFsaXpl
IEhMVG9vbGJveCBsaWJyYXJ5IGJlZm9yZSBlbnRlcmluZyBzYW5kYm94CisgICAgICAgIGh0dHBz
Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMjU0OTQKKyAgICAgICAgPHJkYXI6
Ly9wcm9ibGVtLzc3MTcxNTI3PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp
LgorCisgICAgICAgIEFwcEtpdCBjYWxscyBpbnRvIGFuIG9sZGVyIGxpYnJhcnkgKEhMVG9vbGtp
dCkgdG8gaGFuZGxlIHNvbWUgbWVudSBvcGVyYXRpb25zLiBUaGlzIGxpYnJhcnkgd2FudHMgdG8g
a25vdyBpZiBpdHMKKyAgICAgICAgaW4gYSBiYWNrZ3JvdW5kIGFwcGxpY2F0aW9uLCBhbmQgZG9l
cyBzbyBieSBjb21tdW5pY2F0aW5nIHdpdGggTGF1bmNoU2VydmljZXMuIEhvd2V2ZXIsIHdlIGNs
b3NlIG91ciBjb25uZWN0aW9uCisgICAgICAgIHRvIExhdW5jaFNlcnZpY2VzIGR1cmluZyBXZWJD
b250ZW50IHByb2Nlc3MgbGF1bmNoLCB3aGljaCBwcmV2ZW50cyB0aGVzZSBjYWxscyBmcm9tIHdv
cmtpbmcuCisKKyAgICAgICAgQWx0aG91Z2ggdGhpcyBmYWlsdXJlIGlzIGhhcm1sZXNzIG9uIHBy
b2R1Y3Rpb24gc3lzdGVtcyAoaXQgZmFpbHMgYXMgJ2JhY2tncm91bmQgcHJvY2VzcycsIHdoaWNo
IGlzIHdoYXQgd2Ugd2FudCkKKyAgICAgICAgaXQgdHJpZ2dlcnMgYXNzZXJ0aW9ucyBhbmQgbG9n
Z2luZyBvbiBpbnRlcm5hbCBzeXN0ZW1zIHRoYXQgbWFza3MgdXNlZnVsIGxvZ3MgYW5kIHdhc3Rl
cyBwb3dlciBhbmQgY3ljbGVzLgorCisgICAgICAgIElmIHdlIGludm9rZSBITFRCSXNDdXJyZW50
UHJvY2Vzc0JhY2tncm91bmRPbmx5KCkgYXQgbGF1bmNoLCB3ZSBjYW4gY29tcGxldGUgb3VyIExh
dW5jaFNlcnZpY2VzIGNvbW11bmljYXRpb25zIHByaW9yCisgICAgICAgIHRvIGN1dHRpbmcgdGhl
bSBvZmYgYXMgd2UgZW50ZXIgdGhlIHNhbmRib3guIEhMVG9vbGJveCBjYWNoZXMgdGhlIHJlc3Vs
dCwgc28gd2lsbCBwZXJmb3JtIHByb3Blcmx5IGZvciB0aGUgcmVzdCBvZgorICAgICAgICB0aGUg
V2ViQ29udGVudCBwcm9jZXNzIHJ1bnRpbWUuCisKKyAgICAgICAgKiBXZWJQcm9jZXNzL2NvY29h
L1dlYlByb2Nlc3NDb2NvYS5tbToKKyAgICAgICAgKFdlYktpdDo6V2ViUHJvY2Vzczo6cGxhdGZv
cm1Jbml0aWFsaXplUHJvY2Vzcyk6CisKIDIwMjEtMDUtMDYgIFBlciBBcm5lIFZvbGxhbiAgPHB2
b2xsYW5AYXBwbGUuY29tPgogCiAgICAgICAgIEFkZCBzYW5kYm94IGV4dGVuc2lvbiBmbGFnIHRv
IHNwZWNpZnkgdGhhdCBwYXRoIGNvbnRhaW5zIG5vIHN5bWxpbmtzCmRpZmYgLS1naXQgYS9Tb3Vy
Y2UvV2ViS2l0L1dlYlByb2Nlc3MvY29jb2EvV2ViUHJvY2Vzc0NvY29hLm1tIGIvU291cmNlL1dl
YktpdC9XZWJQcm9jZXNzL2NvY29hL1dlYlByb2Nlc3NDb2NvYS5tbQppbmRleCBmNTcyM2NlMTU3
NDFiNDgzY2E3Yzk4OWY4ZjkwODM3MDg1Njk5MGFkLi5lMzI1ZjAxZmFhZGQ1Y2M2YmY5MzkwODYx
MGI0MmUyZmY5NzU3NTk5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L1dlYlByb2Nlc3MvY29j
b2EvV2ViUHJvY2Vzc0NvY29hLm1tCisrKyBiL1NvdXJjZS9XZWJLaXQvV2ViUHJvY2Vzcy9jb2Nv
YS9XZWJQcm9jZXNzQ29jb2EubW0KQEAgLTE2NSw2ICsxNjUsNyBAQCBTT0ZUX0xJTktfQ0xBU1Mo
Q29yZVNlcnZpY2VzLCBfTFNET3BlblNlcnZpY2UpCiAjaWYgUExBVEZPUk0oTUFDKQogU09GVF9M
SU5LX0ZSQU1FV09SS19JTl9VTUJSRUxMQShBcHBsaWNhdGlvblNlcnZpY2VzLCBISVNlcnZpY2Vz
KQogU09GVF9MSU5LX0ZVTkNUSU9OX01BWV9GQUlMX0ZPUl9TT1VSQ0UoV2ViS2l0LCBISVNlcnZp
Y2VzLCBfQVhTZXRBdWRpdFRva2VuSXNBdXRoZW50aWNhdGVkQ2FsbGJhY2ssIHZvaWQsIChBWEF1
ZGl0VG9rZW5Jc0F1dGhlbnRpY2F0ZWRDYWxsYmFjayBjYWxsYmFjayksIChjYWxsYmFjaykpCitl
eHRlcm4gQm9vbGVhbiBITFRCSXNDdXJyZW50UHJvY2Vzc0JhY2tncm91bmRPbmx5KHZvaWQpOwog
I2VuZGlmCiAKICNpZiBQTEFURk9STShJT1NfRkFNSUxZKQpAQCAtNjgyLDYgKzY4MywxMCBAQCB2
b2lkIFdlYlByb2Nlc3M6OnBsYXRmb3JtSW5pdGlhbGl6ZVByb2Nlc3MoY29uc3QgQXV4aWxpYXJ5
UHJvY2Vzc0luaXRpYWxpemF0aW9uUAogICAgIC8vIHdpdGggTGF1bmNoIFNlcnZpY2VzIGluIFdl
YlByb2Nlc3M6OnBsYXRmb3JtSW5pdGlhbGl6ZVdlYlByb2Nlc3Mgd2hlbiBjYWxsaW5nICtbTlNB
cHBsaWNhdGlvbiBfYWNjZXNzaWJpbGl0eUluaXRpYWxpemVdLgogICAgIF9DU0NoZWNrRml4RGlz
YWJsZSgpOwogI2VuZGlmCisjaWYgUExBVEZPUk0oTUFDKQorICAgIC8vIENhY2hlIGJhY2tncm91
bmQgc3RhdGUgZm9yIEhMVG9vbEJveCBzbyBBcHBLaXQgZG9lc24ndCB0cnkgdG8gdGFsayB0byBM
YXVuY2hTZXJ2aWNlcyBhZnRlciB3ZSBlbnRlciB0aGUgc2FuZGJveAorICAgICh2b2lkKUhMVEJJ
c0N1cnJlbnRQcm9jZXNzQmFja2dyb3VuZE9ubHkoKTsKKyNlbmRpZgogfQogCiAjaWYgVVNFKEFQ
UEtJVCkK
</data>
<flag name="commit-queue"
          id="448740"
          type_id="3"
          status="-"
          setter="ews-feeder"
    />
          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>427967</attachid>
            <date>2021-05-06 17:48:49 -0700</date>
            <delta_ts>2021-05-07 16:10:22 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-225494-20210506174849.patch</filename>
            <type>text/plain</type>
            <size>3047</size>
            <attacher name="Brent Fulgham">bfulgham</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjc3MTM4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No
YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGE0MzBiZWFlOTI5NmNhMDg3
MjRiMTg0NjVkZjJiMTZmNTU1MDI5ZTQuLjE3ZDU1NzI5MWZjNzVhZWE1Mjk0OGQyZjgxZjgxMmFm
NThlNTU5OTEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj
ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjUgQEAKKzIwMjEtMDUtMDYgIEJyZW50IEZ1
bGdoYW0gIDxiZnVsZ2hhbUBhcHBsZS5jb20+CisKKyAgICAgICAgW21hY09TXSBJbml0aWFsaXpl
IEhMVG9vbGJveCBsaWJyYXJ5IGJlZm9yZSBlbnRlcmluZyBzYW5kYm94CisgICAgICAgIGh0dHBz
Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMjU0OTQKKyAgICAgICAgPHJkYXI6
Ly9wcm9ibGVtLzc3MTcxNTI3PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp
LgorCisgICAgICAgIEFwcEtpdCBjYWxscyBpbnRvIGFuIG9sZGVyIGxpYnJhcnkgKEhMVG9vbGtp
dCkgdG8gaGFuZGxlIHNvbWUgbWVudSBvcGVyYXRpb25zLiBUaGlzIGxpYnJhcnkgd2FudHMgdG8g
a25vdyBpZiBpdHMKKyAgICAgICAgaW4gYSBiYWNrZ3JvdW5kIGFwcGxpY2F0aW9uLCBhbmQgZG9l
cyBzbyBieSBjb21tdW5pY2F0aW5nIHdpdGggTGF1bmNoU2VydmljZXMuIEhvd2V2ZXIsIHdlIGNs
b3NlIG91ciBjb25uZWN0aW9uCisgICAgICAgIHRvIExhdW5jaFNlcnZpY2VzIGR1cmluZyBXZWJD
b250ZW50IHByb2Nlc3MgbGF1bmNoLCB3aGljaCBwcmV2ZW50cyB0aGVzZSBjYWxscyBmcm9tIHdv
cmtpbmcuCisKKyAgICAgICAgQWx0aG91Z2ggdGhpcyBmYWlsdXJlIGlzIGhhcm1sZXNzIG9uIHBy
b2R1Y3Rpb24gc3lzdGVtcyAoaXQgZmFpbHMgYXMgJ2JhY2tncm91bmQgcHJvY2VzcycsIHdoaWNo
IGlzIHdoYXQgd2Ugd2FudCkKKyAgICAgICAgaXQgdHJpZ2dlcnMgYXNzZXJ0aW9ucyBhbmQgbG9n
Z2luZyBvbiBpbnRlcm5hbCBzeXN0ZW1zIHRoYXQgbWFza3MgdXNlZnVsIGxvZ3MgYW5kIHdhc3Rl
cyBwb3dlciBhbmQgY3ljbGVzLgorCisgICAgICAgIElmIHdlIGludm9rZSBITFRCSXNDdXJyZW50
UHJvY2Vzc0JhY2tncm91bmRPbmx5KCkgYXQgbGF1bmNoLCB3ZSBjYW4gY29tcGxldGUgb3VyIExh
dW5jaFNlcnZpY2VzIGNvbW11bmljYXRpb25zIHByaW9yCisgICAgICAgIHRvIGN1dHRpbmcgdGhl
bSBvZmYgYXMgd2UgZW50ZXIgdGhlIHNhbmRib3guIEhMVG9vbGJveCBjYWNoZXMgdGhlIHJlc3Vs
dCwgc28gd2lsbCBwZXJmb3JtIHByb3Blcmx5IGZvciB0aGUgcmVzdCBvZgorICAgICAgICB0aGUg
V2ViQ29udGVudCBwcm9jZXNzIHJ1bnRpbWUuCisKKyAgICAgICAgKiBXZWJQcm9jZXNzL2NvY29h
L1dlYlByb2Nlc3NDb2NvYS5tbToKKyAgICAgICAgKFdlYktpdDo6V2ViUHJvY2Vzczo6cGxhdGZv
cm1Jbml0aWFsaXplUHJvY2Vzcyk6CisKIDIwMjEtMDUtMDYgIEVyaWMgQ2FybHNvbiAgPGVyaWMu
Y2FybHNvbkBhcHBsZS5jb20+CiAKICAgICAgICAgW0dQVVBdIFJlZHVjZSBNZWRpYVBsYXllciBw
b2xsaW5nIGZyZXF1ZW5jeSB3aGVuIHBvc3NpYmxlCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0
L1dlYlByb2Nlc3MvY29jb2EvV2ViUHJvY2Vzc0NvY29hLm1tIGIvU291cmNlL1dlYktpdC9XZWJQ
cm9jZXNzL2NvY29hL1dlYlByb2Nlc3NDb2NvYS5tbQppbmRleCBmNTcyM2NlMTU3NDFiNDgzY2E3
Yzk4OWY4ZjkwODM3MDg1Njk5MGFkLi43OTEzZGI2OThkMTNjZDFjMGVlZjE4NmUyYTQ1OTUzMTJi
MmYwYjc5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L1dlYlByb2Nlc3MvY29jb2EvV2ViUHJv
Y2Vzc0NvY29hLm1tCisrKyBiL1NvdXJjZS9XZWJLaXQvV2ViUHJvY2Vzcy9jb2NvYS9XZWJQcm9j
ZXNzQ29jb2EubW0KQEAgLTE2NSw2ICsxNjUsOSBAQCBTT0ZUX0xJTktfQ0xBU1MoQ29yZVNlcnZp
Y2VzLCBfTFNET3BlblNlcnZpY2UpCiAjaWYgUExBVEZPUk0oTUFDKQogU09GVF9MSU5LX0ZSQU1F
V09SS19JTl9VTUJSRUxMQShBcHBsaWNhdGlvblNlcnZpY2VzLCBISVNlcnZpY2VzKQogU09GVF9M
SU5LX0ZVTkNUSU9OX01BWV9GQUlMX0ZPUl9TT1VSQ0UoV2ViS2l0LCBISVNlcnZpY2VzLCBfQVhT
ZXRBdWRpdFRva2VuSXNBdXRoZW50aWNhdGVkQ2FsbGJhY2ssIHZvaWQsIChBWEF1ZGl0VG9rZW5J
c0F1dGhlbnRpY2F0ZWRDYWxsYmFjayBjYWxsYmFjayksIChjYWxsYmFjaykpCisKK1NPRlRfTElO
S19GUkFNRVdPUktfSU5fVU1CUkVMTEEoQ2FyYm9uLCBISVRvb2xib3gpCitTT0ZUX0xJTktfRlVO
Q1RJT05fTUFZX0ZBSUxfRk9SX1NPVVJDRShXZWJLaXQsIEhJVG9vbGJveCwgSExUQklzQ3VycmVu
dFByb2Nlc3NCYWNrZ3JvdW5kT25seSwgQm9vbGVhbiwgKHZvaWQpLCAoKSkKICNlbmRpZgogCiAj
aWYgUExBVEZPUk0oSU9TX0ZBTUlMWSkKQEAgLTY4Miw2ICs2ODUsMTEgQEAgdm9pZCBXZWJQcm9j
ZXNzOjpwbGF0Zm9ybUluaXRpYWxpemVQcm9jZXNzKGNvbnN0IEF1eGlsaWFyeVByb2Nlc3NJbml0
aWFsaXphdGlvblAKICAgICAvLyB3aXRoIExhdW5jaCBTZXJ2aWNlcyBpbiBXZWJQcm9jZXNzOjpw
bGF0Zm9ybUluaXRpYWxpemVXZWJQcm9jZXNzIHdoZW4gY2FsbGluZyArW05TQXBwbGljYXRpb24g
X2FjY2Vzc2liaWxpdHlJbml0aWFsaXplXS4KICAgICBfQ1NDaGVja0ZpeERpc2FibGUoKTsKICNl
bmRpZgorI2lmIFBMQVRGT1JNKE1BQykKKyAgICAvLyBDYWNoZSBiYWNrZ3JvdW5kIHN0YXRlIGZv
ciBITFRvb2xCb3ggc28gQXBwS2l0IGRvZXNuJ3QgdHJ5IHRvIHRhbGsgdG8gTGF1bmNoU2Vydmlj
ZXMgYWZ0ZXIgd2UgZW50ZXIgdGhlIHNhbmRib3gKKyAgICBpZiAoY2FuTG9hZF9ISVRvb2xib3hf
SExUQklzQ3VycmVudFByb2Nlc3NCYWNrZ3JvdW5kT25seSgpKQorICAgICAgICAodm9pZClzb2Z0
TGlua19ISVRvb2xib3hfSExUQklzQ3VycmVudFByb2Nlc3NCYWNrZ3JvdW5kT25seSgpOworI2Vu
ZGlmCiB9CiAKICNpZiBVU0UoQVBQS0lUKQo=
</data>

          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>428054</attachid>
            <date>2021-05-07 16:10:24 -0700</date>
            <delta_ts>2021-05-12 15:51:03 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-225494-20210507161023.patch</filename>
            <type>text/plain</type>
            <size>2982</size>
            <attacher name="Brent Fulgham">bfulgham</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjc3MTc4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No
YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDdmYWYxZTZkMTI3NzEwNmM3
YmJmZTFjMjk3ZmJhNDA0YmRiNzMxZTUuLmJhZDNiMjIwY2Y0ZjlmYmFjMTY0M2M4NmNjOGFmYmRl
NjZiYTIwYzggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj
ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjUgQEAKKzIwMjEtMDUtMDcgIEJyZW50IEZ1
bGdoYW0gIDxiZnVsZ2hhbUBhcHBsZS5jb20+CisKKyAgICAgICAgW21hY09TXSBJbml0aWFsaXpl
IEhMVG9vbGJveCBsaWJyYXJ5IGJlZm9yZSBlbnRlcmluZyBzYW5kYm94CisgICAgICAgIGh0dHBz
Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMjU0OTQKKyAgICAgICAgPHJkYXI6
Ly9wcm9ibGVtLzc3MTcxNTI3PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp
LgorCisgICAgICAgIEFwcEtpdCBjYWxscyBpbnRvIGFuIG9sZGVyIGxpYnJhcnkgKEhMVG9vbGtp
dCkgdG8gaGFuZGxlIHNvbWUgbWVudSBvcGVyYXRpb25zLiBUaGlzIGxpYnJhcnkgd2FudHMgdG8g
a25vdyBpZiBpdHMKKyAgICAgICAgaW4gYSBiYWNrZ3JvdW5kIGFwcGxpY2F0aW9uLCBhbmQgZG9l
cyBzbyBieSBjb21tdW5pY2F0aW5nIHdpdGggTGF1bmNoU2VydmljZXMuIEhvd2V2ZXIsIHdlIGNs
b3NlIG91ciBjb25uZWN0aW9uCisgICAgICAgIHRvIExhdW5jaFNlcnZpY2VzIGR1cmluZyBXZWJD
b250ZW50IHByb2Nlc3MgbGF1bmNoLCB3aGljaCBwcmV2ZW50cyB0aGVzZSBjYWxscyBmcm9tIHdv
cmtpbmcuCisKKyAgICAgICAgQWx0aG91Z2ggdGhpcyBmYWlsdXJlIGlzIGhhcm1sZXNzIG9uIHBy
b2R1Y3Rpb24gc3lzdGVtcyAoaXQgZmFpbHMgYXMgJ2JhY2tncm91bmQgcHJvY2VzcycsIHdoaWNo
IGlzIHdoYXQgd2Ugd2FudCkKKyAgICAgICAgaXQgdHJpZ2dlcnMgYXNzZXJ0aW9ucyBhbmQgbG9n
Z2luZyBvbiBpbnRlcm5hbCBzeXN0ZW1zIHRoYXQgbWFza3MgdXNlZnVsIGxvZ3MgYW5kIHdhc3Rl
cyBwb3dlciBhbmQgY3ljbGVzLgorCisgICAgICAgIElmIHdlIGludm9rZSBITFRCSXNDdXJyZW50
UHJvY2Vzc0JhY2tncm91bmRPbmx5KCkgYXQgbGF1bmNoLCB3ZSBjYW4gY29tcGxldGUgb3VyIExh
dW5jaFNlcnZpY2VzIGNvbW11bmljYXRpb25zIHByaW9yCisgICAgICAgIHRvIGN1dHRpbmcgdGhl
bSBvZmYgYXMgd2UgZW50ZXIgdGhlIHNhbmRib3guIEhMVG9vbGJveCBjYWNoZXMgdGhlIHJlc3Vs
dCwgc28gd2lsbCBwZXJmb3JtIHByb3Blcmx5IGZvciB0aGUgcmVzdCBvZgorICAgICAgICB0aGUg
V2ViQ29udGVudCBwcm9jZXNzIHJ1bnRpbWUuCisKKyAgICAgICAgKiBXZWJQcm9jZXNzL2NvY29h
L1dlYlByb2Nlc3NDb2NvYS5tbToKKyAgICAgICAgKFdlYktpdDo6V2ViUHJvY2Vzczo6cGxhdGZv
cm1Jbml0aWFsaXplUHJvY2Vzcyk6CisKIDIwMjEtMDUtMDcgIENhcmxvcyBHYXJuYWNobyAgPGNh
cmxvc2dAZ25vbWUub3JnPgogCiAgICAgICAgIFtHVEs0XSBSZXdyaXRlIEdUSyBnZXN0dXJlIHN1
cHBvcnQgdG8gd29yayBmb3IgYm90aCAzLnggYW5kIDQueC4KZGlmZiAtLWdpdCBhL1NvdXJjZS9X
ZWJLaXQvV2ViUHJvY2Vzcy9jb2NvYS9XZWJQcm9jZXNzQ29jb2EubW0gYi9Tb3VyY2UvV2ViS2l0
L1dlYlByb2Nlc3MvY29jb2EvV2ViUHJvY2Vzc0NvY29hLm1tCmluZGV4IGY1NzIzY2UxNTc0MWI0
ODNjYTdjOTg5ZjhmOTA4MzcwODU2OTkwYWQuLjYyNDdiNjI4NGZmN2I4ZTNlM2M1M2E0NmM1ODVj
ODdkZjZkZjhjYTEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvV2ViUHJvY2Vzcy9jb2NvYS9X
ZWJQcm9jZXNzQ29jb2EubW0KKysrIGIvU291cmNlL1dlYktpdC9XZWJQcm9jZXNzL2NvY29hL1dl
YlByb2Nlc3NDb2NvYS5tbQpAQCAtMTY1LDYgKzE2NSw5IEBAIFNPRlRfTElOS19DTEFTUyhDb3Jl
U2VydmljZXMsIF9MU0RPcGVuU2VydmljZSkKICNpZiBQTEFURk9STShNQUMpCiBTT0ZUX0xJTktf
RlJBTUVXT1JLX0lOX1VNQlJFTExBKEFwcGxpY2F0aW9uU2VydmljZXMsIEhJU2VydmljZXMpCiBT
T0ZUX0xJTktfRlVOQ1RJT05fTUFZX0ZBSUxfRk9SX1NPVVJDRShXZWJLaXQsIEhJU2VydmljZXMs
IF9BWFNldEF1ZGl0VG9rZW5Jc0F1dGhlbnRpY2F0ZWRDYWxsYmFjaywgdm9pZCwgKEFYQXVkaXRU
b2tlbklzQXV0aGVudGljYXRlZENhbGxiYWNrIGNhbGxiYWNrKSwgKGNhbGxiYWNrKSkKKworU09G
VF9MSU5LX0ZSQU1FV09SS19JTl9VTUJSRUxMQShDYXJib24sIEhJVG9vbGJveCkKK1NPRlRfTElO
S19GVU5DVElPTl9NQVlfRkFJTF9GT1JfU09VUkNFKFdlYktpdCwgSElUb29sYm94LCBHZXRHcmF5
UmduLCBSZ25IYW5kbGUsICh2b2lkKSwgKCkpCiAjZW5kaWYKIAogI2lmIFBMQVRGT1JNKElPU19G
QU1JTFkpCkBAIC02ODIsNiArNjg1LDExIEBAIHZvaWQgV2ViUHJvY2Vzczo6cGxhdGZvcm1Jbml0
aWFsaXplUHJvY2Vzcyhjb25zdCBBdXhpbGlhcnlQcm9jZXNzSW5pdGlhbGl6YXRpb25QCiAgICAg
Ly8gd2l0aCBMYXVuY2ggU2VydmljZXMgaW4gV2ViUHJvY2Vzczo6cGxhdGZvcm1Jbml0aWFsaXpl
V2ViUHJvY2VzcyB3aGVuIGNhbGxpbmcgK1tOU0FwcGxpY2F0aW9uIF9hY2Nlc3NpYmlsaXR5SW5p
dGlhbGl6ZV0uCiAgICAgX0NTQ2hlY2tGaXhEaXNhYmxlKCk7CiAjZW5kaWYKKyNpZiBQTEFURk9S
TShNQUMpCisgICAgLy8gQ2FjaGUgYmFja2dyb3VuZCBzdGF0ZSBmb3IgSExUb29sQm94IHNvIEFw
cEtpdCBkb2Vzbid0IHRyeSB0byB0YWxrIHRvIExhdW5jaFNlcnZpY2VzIGFmdGVyIHdlIGVudGVy
IHRoZSBzYW5kYm94CisgICAgaWYgKGNhbkxvYWRfSElUb29sYm94X0dldEdyYXlSZ24oKSkKKyAg
ICAgICAgKHZvaWQpc29mdExpbmtfSElUb29sYm94X0dldEdyYXlSZ24oKTsKKyNlbmRpZgogfQog
CiAjaWYgVVNFKEFQUEtJVCkK
</data>

          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>428422</attachid>
            <date>2021-05-12 15:51:04 -0700</date>
            <delta_ts>2021-05-12 16:10:50 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-225494-20210512155103.patch</filename>
            <type>text/plain</type>
            <size>3067</size>
            <attacher name="Brent Fulgham">bfulgham</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjc3Mzk1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No
YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGZjNTE3MWRhN2Q4YjQ2ZmNm
NjYzZjJiOTRiYzNmMjIxZGExZGE2N2QuLjE5YzdiN2M0YWY4OTAwNGNkZGYxYzgyZjc3NzQyMGZl
Y2FiNDljZjggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj
ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjUgQEAKKzIwMjEtMDUtMTIgIEJyZW50IEZ1
bGdoYW0gIDxiZnVsZ2hhbUBhcHBsZS5jb20+CisKKyAgICAgICAgW21hY09TXSBJbml0aWFsaXpl
IEhMVG9vbGJveCBsaWJyYXJ5IGJlZm9yZSBlbnRlcmluZyBzYW5kYm94CisgICAgICAgIGh0dHBz
Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMjU0OTQKKyAgICAgICAgPHJkYXI6
Ly9wcm9ibGVtLzc3MTcxNTI3PgorCisgICAgICAgIFJldmlld2VkIGJ5IERhcmluIEFkbGVyLgor
CisgICAgICAgIEFwcEtpdCBjYWxscyBpbnRvIGFuIG9sZGVyIGxpYnJhcnkgKEhMVG9vbGtpdCkg
dG8gaGFuZGxlIHNvbWUgbWVudSBvcGVyYXRpb25zLiBUaGlzIGxpYnJhcnkgd2FudHMgdG8ga25v
dyBpZiBpdHMKKyAgICAgICAgaW4gYSBiYWNrZ3JvdW5kIGFwcGxpY2F0aW9uLCBhbmQgZG9lcyBz
byBieSBjb21tdW5pY2F0aW5nIHdpdGggTGF1bmNoU2VydmljZXMuIEhvd2V2ZXIsIHdlIGNsb3Nl
IG91ciBjb25uZWN0aW9uCisgICAgICAgIHRvIExhdW5jaFNlcnZpY2VzIGR1cmluZyBXZWJDb250
ZW50IHByb2Nlc3MgbGF1bmNoLCB3aGljaCBwcmV2ZW50cyB0aGVzZSBjYWxscyBmcm9tIHdvcmtp
bmcuCisKKyAgICAgICAgQWx0aG91Z2ggdGhpcyBmYWlsdXJlIGlzIGhhcm1sZXNzIG9uIHByb2R1
Y3Rpb24gc3lzdGVtcyAoaXQgZmFpbHMgYXMgJ2JhY2tncm91bmQgcHJvY2VzcycsIHdoaWNoIGlz
IHdoYXQgd2Ugd2FudCkKKyAgICAgICAgaXQgdHJpZ2dlcnMgYXNzZXJ0aW9ucyBhbmQgbG9nZ2lu
ZyBvbiBpbnRlcm5hbCBzeXN0ZW1zIHRoYXQgbWFza3MgdXNlZnVsIGxvZ3MgYW5kIHdhc3RlcyBw
b3dlciBhbmQgY3ljbGVzLgorCisgICAgICAgIElmIHdlIGludm9rZSBIaWxpdGVNZW51KDApIGF0
IGxhdW5jaCwgd2UgY2FuIGNvbXBsZXRlIG91ciBMYXVuY2hTZXJ2aWNlcyBjb21tdW5pY2F0aW9u
cyBwcmlvcgorICAgICAgICB0byBjdXR0aW5nIHRoZW0gb2ZmIGFzIHdlIGVudGVyIHRoZSBzYW5k
Ym94LiBITFRvb2xib3ggY2FjaGVzIHRoZSByZXN1bHQsIHNvIHdpbGwgcGVyZm9ybSBwcm9wZXJs
eSBmb3IgdGhlIHJlc3Qgb2YKKyAgICAgICAgdGhlIFdlYkNvbnRlbnQgcHJvY2VzcyBydW50aW1l
LgorCisgICAgICAgICogV2ViUHJvY2Vzcy9jb2NvYS9XZWJQcm9jZXNzQ29jb2EubW06CisgICAg
ICAgIChXZWJLaXQ6OldlYlByb2Nlc3M6OnBsYXRmb3JtSW5pdGlhbGl6ZVByb2Nlc3MpOgorCiAy
MDIxLTA1LTEyICBXZW5zb24gSHNpZWggIDx3ZW5zb25faHNpZWhAYXBwbGUuY29tPgogCiAgICAg
ICAgIFBsdW1iIHNvbWUgbW9yZSBtZXRhZGF0YSB0byBRdWlja0xvb2sgd2hlbiByZXZlYWxpbmcg
aW1hZ2VzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L1dlYlByb2Nlc3MvY29jb2EvV2ViUHJv
Y2Vzc0NvY29hLm1tIGIvU291cmNlL1dlYktpdC9XZWJQcm9jZXNzL2NvY29hL1dlYlByb2Nlc3ND
b2NvYS5tbQppbmRleCAyYjhiMDQyMzJlM2E2OGYwN2ZmMjYyOGQwMGE5NGJmZjUwODljNWU5Li5h
ZWQyMmQzOTBjNDNhNTZiZDdlOGU2MDdkOTYyN2UwZWMxMjZhMzcxIDEwMDY0NAotLS0gYS9Tb3Vy
Y2UvV2ViS2l0L1dlYlByb2Nlc3MvY29jb2EvV2ViUHJvY2Vzc0NvY29hLm1tCisrKyBiL1NvdXJj
ZS9XZWJLaXQvV2ViUHJvY2Vzcy9jb2NvYS9XZWJQcm9jZXNzQ29jb2EubW0KQEAgLTE2NSw2ICsx
NjUsMTAgQEAgU09GVF9MSU5LX0NMQVNTKENvcmVTZXJ2aWNlcywgX0xTRE9wZW5TZXJ2aWNlKQog
I2lmIFBMQVRGT1JNKE1BQykKIFNPRlRfTElOS19GUkFNRVdPUktfSU5fVU1CUkVMTEEoQXBwbGlj
YXRpb25TZXJ2aWNlcywgSElTZXJ2aWNlcykKIFNPRlRfTElOS19GVU5DVElPTl9NQVlfRkFJTF9G
T1JfU09VUkNFKFdlYktpdCwgSElTZXJ2aWNlcywgX0FYU2V0QXVkaXRUb2tlbklzQXV0aGVudGlj
YXRlZENhbGxiYWNrLCB2b2lkLCAoQVhBdWRpdFRva2VuSXNBdXRoZW50aWNhdGVkQ2FsbGJhY2sg
Y2FsbGJhY2spLCAoY2FsbGJhY2spKQorCitTT0ZUX0xJTktfRlJBTUVXT1JLX0lOX1VNQlJFTExB
KENhcmJvbiwgSElUb29sYm94KQorU09GVF9MSU5LX0ZVTkNUSU9OX01BWV9GQUlMX0ZPUl9TT1VS
Q0UoV2ViS2l0LCBISVRvb2xib3gsIEhpbGl0ZU1lbnUsIHZvaWQsIChNZW51SUQgbWVudUlEKSwg
KG1lbnVJRCkpCisKICNlbmRpZgogCiAjaWYgUExBVEZPUk0oSU9TX0ZBTUlMWSkKQEAgLTY3OCw2
ICs2ODIsMTIgQEAgdm9pZCBXZWJQcm9jZXNzOjpwbGF0Zm9ybUluaXRpYWxpemVQcm9jZXNzKGNv
bnN0IEF1eGlsaWFyeVByb2Nlc3NJbml0aWFsaXphdGlvblAKICAgICAvLyB3aXRoIExhdW5jaCBT
ZXJ2aWNlcyBpbiBXZWJQcm9jZXNzOjpwbGF0Zm9ybUluaXRpYWxpemVXZWJQcm9jZXNzIHdoZW4g
Y2FsbGluZyArW05TQXBwbGljYXRpb24gX2FjY2Vzc2liaWxpdHlJbml0aWFsaXplXS4KICAgICBf
Q1NDaGVja0ZpeERpc2FibGUoKTsKICNlbmRpZgorI2lmIFBMQVRGT1JNKE1BQykKKyAgICAvLyBD
YWNoZSBiYWNrZ3JvdW5kIHN0YXRlIGZvciBISVRvb2xCb3ggc28gQXBwS2l0IGRvZXNuJ3QgdHJ5
IHRvIHRhbGsgdG8gTGF1bmNoU2VydmljZXMgYWZ0ZXIgd2UgZW50ZXIgdGhlIHNhbmRib3guCisg
ICAgLy8gUGVyIHRoZSBISVRvb2xib3ggdGVhbSwgSGlsaXRlTWVudSgwKSBjYXVzZXMgdGhpcyBp
bml0aWFsaXphdGlvbiB3aXRob3V0IHRyaWdnZXJpbmcgVUkgYWN0aXZpdHkuCisgICAgaWYgKGNh
bkxvYWRfSElUb29sYm94X0hpbGl0ZU1lbnUoKSkKKyAgICAgICAgc29mdExpbmtfSElUb29sYm94
X0hpbGl0ZU1lbnUoMCk7CisjZW5kaWYKIH0KIAogI2lmIFVTRShBUFBLSVQpCg==
</data>
<flag name="commit-queue"
          id="449342"
          type_id="3"
          status="-"
          setter="ews-feeder"
    />
          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>428425</attachid>
            <date>2021-05-12 16:02:11 -0700</date>
            <delta_ts>2022-02-10 16:28:18 -0800</delta_ts>
            <desc>Patch</desc>
            <filename>bug-225494-20210512160210.patch</filename>
            <type>text/plain</type>
            <size>3089</size>
            <attacher name="Brent Fulgham">bfulgham</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjc3Mzk1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No
YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGZjNTE3MWRhN2Q4YjQ2ZmNm
NjYzZjJiOTRiYzNmMjIxZGExZGE2N2QuLjE5YzdiN2M0YWY4OTAwNGNkZGYxYzgyZjc3NzQyMGZl
Y2FiNDljZjggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj
ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjUgQEAKKzIwMjEtMDUtMTIgIEJyZW50IEZ1
bGdoYW0gIDxiZnVsZ2hhbUBhcHBsZS5jb20+CisKKyAgICAgICAgW21hY09TXSBJbml0aWFsaXpl
IEhMVG9vbGJveCBsaWJyYXJ5IGJlZm9yZSBlbnRlcmluZyBzYW5kYm94CisgICAgICAgIGh0dHBz
Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMjU0OTQKKyAgICAgICAgPHJkYXI6
Ly9wcm9ibGVtLzc3MTcxNTI3PgorCisgICAgICAgIFJldmlld2VkIGJ5IERhcmluIEFkbGVyLgor
CisgICAgICAgIEFwcEtpdCBjYWxscyBpbnRvIGFuIG9sZGVyIGxpYnJhcnkgKEhMVG9vbGtpdCkg
dG8gaGFuZGxlIHNvbWUgbWVudSBvcGVyYXRpb25zLiBUaGlzIGxpYnJhcnkgd2FudHMgdG8ga25v
dyBpZiBpdHMKKyAgICAgICAgaW4gYSBiYWNrZ3JvdW5kIGFwcGxpY2F0aW9uLCBhbmQgZG9lcyBz
byBieSBjb21tdW5pY2F0aW5nIHdpdGggTGF1bmNoU2VydmljZXMuIEhvd2V2ZXIsIHdlIGNsb3Nl
IG91ciBjb25uZWN0aW9uCisgICAgICAgIHRvIExhdW5jaFNlcnZpY2VzIGR1cmluZyBXZWJDb250
ZW50IHByb2Nlc3MgbGF1bmNoLCB3aGljaCBwcmV2ZW50cyB0aGVzZSBjYWxscyBmcm9tIHdvcmtp
bmcuCisKKyAgICAgICAgQWx0aG91Z2ggdGhpcyBmYWlsdXJlIGlzIGhhcm1sZXNzIG9uIHByb2R1
Y3Rpb24gc3lzdGVtcyAoaXQgZmFpbHMgYXMgJ2JhY2tncm91bmQgcHJvY2VzcycsIHdoaWNoIGlz
IHdoYXQgd2Ugd2FudCkKKyAgICAgICAgaXQgdHJpZ2dlcnMgYXNzZXJ0aW9ucyBhbmQgbG9nZ2lu
ZyBvbiBpbnRlcm5hbCBzeXN0ZW1zIHRoYXQgbWFza3MgdXNlZnVsIGxvZ3MgYW5kIHdhc3RlcyBw
b3dlciBhbmQgY3ljbGVzLgorCisgICAgICAgIElmIHdlIGludm9rZSBIaWxpdGVNZW51KDApIGF0
IGxhdW5jaCwgd2UgY2FuIGNvbXBsZXRlIG91ciBMYXVuY2hTZXJ2aWNlcyBjb21tdW5pY2F0aW9u
cyBwcmlvcgorICAgICAgICB0byBjdXR0aW5nIHRoZW0gb2ZmIGFzIHdlIGVudGVyIHRoZSBzYW5k
Ym94LiBITFRvb2xib3ggY2FjaGVzIHRoZSByZXN1bHQsIHNvIHdpbGwgcGVyZm9ybSBwcm9wZXJs
eSBmb3IgdGhlIHJlc3Qgb2YKKyAgICAgICAgdGhlIFdlYkNvbnRlbnQgcHJvY2VzcyBydW50aW1l
LgorCisgICAgICAgICogV2ViUHJvY2Vzcy9jb2NvYS9XZWJQcm9jZXNzQ29jb2EubW06CisgICAg
ICAgIChXZWJLaXQ6OldlYlByb2Nlc3M6OnBsYXRmb3JtSW5pdGlhbGl6ZVByb2Nlc3MpOgorCiAy
MDIxLTA1LTEyICBXZW5zb24gSHNpZWggIDx3ZW5zb25faHNpZWhAYXBwbGUuY29tPgogCiAgICAg
ICAgIFBsdW1iIHNvbWUgbW9yZSBtZXRhZGF0YSB0byBRdWlja0xvb2sgd2hlbiByZXZlYWxpbmcg
aW1hZ2VzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L1dlYlByb2Nlc3MvY29jb2EvV2ViUHJv
Y2Vzc0NvY29hLm1tIGIvU291cmNlL1dlYktpdC9XZWJQcm9jZXNzL2NvY29hL1dlYlByb2Nlc3ND
b2NvYS5tbQppbmRleCAyYjhiMDQyMzJlM2E2OGYwN2ZmMjYyOGQwMGE5NGJmZjUwODljNWU5Li4y
N2VjMGUxNWQ5MTJlMTMxYmI5M2Y1MzYwYmUwODk4YTZmNzE0OGZhIDEwMDY0NAotLS0gYS9Tb3Vy
Y2UvV2ViS2l0L1dlYlByb2Nlc3MvY29jb2EvV2ViUHJvY2Vzc0NvY29hLm1tCisrKyBiL1NvdXJj
ZS9XZWJLaXQvV2ViUHJvY2Vzcy9jb2NvYS9XZWJQcm9jZXNzQ29jb2EubW0KQEAgLTE2NSw2ICsx
NjUsMTAgQEAgU09GVF9MSU5LX0NMQVNTKENvcmVTZXJ2aWNlcywgX0xTRE9wZW5TZXJ2aWNlKQog
I2lmIFBMQVRGT1JNKE1BQykKIFNPRlRfTElOS19GUkFNRVdPUktfSU5fVU1CUkVMTEEoQXBwbGlj
YXRpb25TZXJ2aWNlcywgSElTZXJ2aWNlcykKIFNPRlRfTElOS19GVU5DVElPTl9NQVlfRkFJTF9G
T1JfU09VUkNFKFdlYktpdCwgSElTZXJ2aWNlcywgX0FYU2V0QXVkaXRUb2tlbklzQXV0aGVudGlj
YXRlZENhbGxiYWNrLCB2b2lkLCAoQVhBdWRpdFRva2VuSXNBdXRoZW50aWNhdGVkQ2FsbGJhY2sg
Y2FsbGJhY2spLCAoY2FsbGJhY2spKQorCit0eXBlZGVmIFNJbnQxNiBNZW51SUQ7CitTT0ZUX0xJ
TktfRlJBTUVXT1JLX0lOX1VNQlJFTExBKENhcmJvbiwgSElUb29sYm94KQorU09GVF9MSU5LX0ZV
TkNUSU9OX01BWV9GQUlMX0ZPUl9TT1VSQ0UoV2ViS2l0LCBISVRvb2xib3gsIEhpbGl0ZU1lbnUs
IHZvaWQsIChNZW51SUQgbWVudUlEKSwgKG1lbnVJRCkpCiAjZW5kaWYKIAogI2lmIFBMQVRGT1JN
KElPU19GQU1JTFkpCkBAIC02NzgsNiArNjgyLDEyIEBAIHZvaWQgV2ViUHJvY2Vzczo6cGxhdGZv
cm1Jbml0aWFsaXplUHJvY2Vzcyhjb25zdCBBdXhpbGlhcnlQcm9jZXNzSW5pdGlhbGl6YXRpb25Q
CiAgICAgLy8gd2l0aCBMYXVuY2ggU2VydmljZXMgaW4gV2ViUHJvY2Vzczo6cGxhdGZvcm1Jbml0
aWFsaXplV2ViUHJvY2VzcyB3aGVuIGNhbGxpbmcgK1tOU0FwcGxpY2F0aW9uIF9hY2Nlc3NpYmls
aXR5SW5pdGlhbGl6ZV0uCiAgICAgX0NTQ2hlY2tGaXhEaXNhYmxlKCk7CiAjZW5kaWYKKyNpZiBQ
TEFURk9STShNQUMpCisgICAgLy8gQ2FjaGUgYmFja2dyb3VuZCBzdGF0ZSBmb3IgSElUb29sQm94
IHNvIEFwcEtpdCBkb2Vzbid0IHRyeSB0byB0YWxrIHRvIExhdW5jaFNlcnZpY2VzIGFmdGVyIHdl
IGVudGVyIHRoZSBzYW5kYm94LgorICAgIC8vIFBlciB0aGUgSElUb29sYm94IHRlYW0sIEhpbGl0
ZU1lbnUoMCkgY2F1c2VzIHRoaXMgaW5pdGlhbGl6YXRpb24gd2l0aG91dCB0cmlnZ2VyaW5nIFVJ
IGFjdGl2aXR5LgorICAgIGlmIChjYW5Mb2FkX0hJVG9vbGJveF9IaWxpdGVNZW51KCkpCisgICAg
ICAgIHNvZnRMaW5rX0hJVG9vbGJveF9IaWxpdGVNZW51KDApOworI2VuZGlmCiB9CiAKICNpZiBV
U0UoQVBQS0lUKQo=
</data>

          </attachment>
      

    </bug>

</bugzilla>