225493 2021-05-06 16:30:14 -0700 css-display-none actions from WKContentRuleList should apply to pages loaded with loadData and loadHTMLString 2021-05-10 09:56:28 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 achristensen achristensen cdumez darin ews-watchlist japhet webkit-bug-importer oldest_to_newest 1757703 0 achristensen 2021-05-06 16:30:14 -0700 css-display-none actions from WKContentRuleList should apply to pages loaded with loadData and loadHTMLString 1757704 1 427952 achristensen 2021-05-06 16:32:05 -0700 Created attachment 427952 Patch 1757705 2 achristensen 2021-05-06 16:32:08 -0700 <rdar://problem/77331789> 1758291 3 427952 darin 2021-05-08 22:00:58 -0700 Comment on attachment 427952 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=427952&action=review > Source/WebCore/loader/DocumentLoader.cpp:528 > + // We want the CSS but not the blocking or upgrading for substitute data. Based on your change log comment I would write something more like: "We want the CSS to be loaded for us, but we ignore any attempt to block or upgrade the connection since there is no connection." Not sure my sentence was accurate, but I think it’s easier to understand than "[don’t want] the blocking or upgrading" and instead of saying "for substitute data" which is already said by the name of the function we are in, we can point out *why* we ignore attempts to block or upgrade. 1758527 4 achristensen 2021-05-10 09:56:28 -0700 That's a great comment suggestion. Taken. r277268 427952 2021-05-06 16:32:05 -0700 2021-05-08 22:00:58 -0700 Patch bug-225493-20210506163204.patch text/plain 6628 achristensen U3VidmVyc2lvbiBSZXZpc2lvbjogMjc3MDk5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMmY1N2Q1ZTRmYjNhNzg5 NDE1OWVhMmFiMTcyOTNiYmRhZGQ1NjI2MS4uYTRhYmY5NjFiODYyMTMwZjM2MDdlODkzZjQwNDdi ZjM3ODNiM2EwOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDIxLTA1LTA2ICBBbGV4 IENocmlzdGVuc2VuICA8YWNocmlzdGVuc2VuQHdlYmtpdC5vcmc+CisKKyAgICAgICAgY3NzLWRp c3BsYXktbm9uZSBhY3Rpb25zIGZyb20gV0tDb250ZW50UnVsZUxpc3Qgc2hvdWxkIGFwcGx5IHRv IHBhZ2VzIGxvYWRlZCB3aXRoIGxvYWREYXRhIGFuZCBsb2FkSFRNTFN0cmluZworICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjI1NDkzCisgICAgICAgIDxy ZGFyOi8vNzczMzE3ODk+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgQmxvY2tpbmcgYW5kIGh0dHBzIHVwZ3JhZGUgZG9uJ3QgcmVhbGx5IG1ha2Ugc2Vu c2Ugb24gdGhlIHVybCBmcm9tIGxvYWREYXRhIGFuZCBsb2FkSFRNTFN0cmluZyBiZWNhdXNlIGJs b2NraW5nIHdvdWxkIGJlCisgICAgICAgIGluY29tcGF0aWJsZSB3aXRoIGV4aXN0aW5nIGFwcHMg YW5kIGJlY2F1c2UgeW91J3JlIG5vdCByZWFsbHkgY29ubmVjdGluZyB0byBhIHNlcnZlciwgeW91 J3JlIGp1c3QgcHJldGVuZGluZyB5b3UgZGlkLgorCisgICAgICAgICogbG9hZGVyL0RvY3VtZW50 TG9hZGVyLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkRvY3VtZW50TG9hZGVyOjpoYW5kbGVTdWJz dGl0dXRlRGF0YUxvYWROb3cpOgorCiAyMDIxLTA1LTA2ICBEZWFuIEphY2tzb24gIDxkaW5vQGFw cGxlLmNvbT4KIAogICAgICAgICBbV2ViWFJdIEFkZCBJT1N1cmZhY2UgdG8gRnJhbWVEYXRhOjpM YXllckRhdGEKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2xvYWRlci9Eb2N1bWVudExvYWRl ci5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9sb2FkZXIvRG9jdW1lbnRMb2FkZXIuY3BwCmluZGV4IDk2 ZTEzMDA3ZTYwNTBjMTYyZTYwODU3ZjgwM2Q1MDhhNzY3MTQzOWIuLmU1ZGRlNDVmN2IyMWY3NzVk ZDdjODI0YzkwMDVmYzJiNWUyYjRhOGUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2xvYWRl ci9Eb2N1bWVudExvYWRlci5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvbG9hZGVyL0RvY3VtZW50 TG9hZGVyLmNwcApAQCAtMzcsNiArMzcsNyBAQAogI2luY2x1ZGUgIkNhY2hlZFJhd1Jlc291cmNl LmgiCiAjaW5jbHVkZSAiQ2FjaGVkUmVzb3VyY2VMb2FkZXIuaCIKICNpbmNsdWRlICJDb250ZW50 RXh0ZW5zaW9uRXJyb3IuaCIKKyNpbmNsdWRlICJDb250ZW50UnVsZUxpc3RSZXN1bHRzLmgiCiAj aW5jbHVkZSAiQ29udGVudFNlY3VyaXR5UG9saWN5LmgiCiAjaW5jbHVkZSAiQ3VzdG9tSGVhZGVy RmllbGRzLmgiCiAjaW5jbHVkZSAiRE9NV2luZG93LmgiCkBAIC04OCw2ICs4OSw3IEBACiAjaW5j bHVkZSAiU2V0dGluZ3MuaCIKICNpbmNsdWRlICJTdWJyZXNvdXJjZUxvYWRlci5oIgogI2luY2x1 ZGUgIlRleHRSZXNvdXJjZURlY29kZXIuaCIKKyNpbmNsdWRlICJVc2VyQ29udGVudFByb3ZpZGVy LmgiCiAjaW5jbHVkZSA8d3RmL0Fzc2VydGlvbnMuaD4KICNpbmNsdWRlIDx3dGYvQ29tcGxldGlv bkhhbmRsZXIuaD4KICNpbmNsdWRlIDx3dGYvTmV2ZXJEZXN0cm95ZWQuaD4KQEAgLTUyMCw2ICs1 MjIsMTQgQEAgdm9pZCBEb2N1bWVudExvYWRlcjo6aGFuZGxlU3Vic3RpdHV0ZURhdGFMb2FkTm93 KCkKICAgICBpZiAocmVzcG9uc2UudXJsKCkuaXNFbXB0eSgpKQogICAgICAgICByZXNwb25zZSA9 IFJlc291cmNlUmVzcG9uc2UobV9yZXF1ZXN0LnVybCgpLCBtX3N1YnN0aXR1dGVEYXRhLm1pbWVU eXBlKCksIG1fc3Vic3RpdHV0ZURhdGEuY29udGVudCgpLT5zaXplKCksIG1fc3Vic3RpdHV0ZURh dGEudGV4dEVuY29kaW5nKCkpOwogCisjaWYgRU5BQkxFKENPTlRFTlRfRVhURU5TSU9OUykKKyAg ICBpZiAoYXV0byogcGFnZSA9IG1fZnJhbWUgPyBtX2ZyYW1lLT5wYWdlKCkgOiBudWxscHRyKSB7 CisgICAgICAgIC8vIFdlIGludGVudGlvbmFsbHkgZG8gbm90aGluZyB3aXRoIHRoZSByZXN1bHRz IG9mIHRoaXMgY2FsbC4KKyAgICAgICAgLy8gV2Ugd2FudCB0aGUgQ1NTIGJ1dCBub3QgdGhlIGJs b2NraW5nIG9yIHVwZ3JhZGluZyBmb3Igc3Vic3RpdHV0ZSBkYXRhLgorICAgICAgICBwYWdlLT51 c2VyQ29udGVudFByb3ZpZGVyKCkucHJvY2Vzc0NvbnRlbnRSdWxlTGlzdHNGb3JMb2FkKCpwYWdl LCByZXNwb25zZS51cmwoKSwgQ29udGVudEV4dGVuc2lvbnM6OlJlc291cmNlVHlwZTo6RG9jdW1l bnQsICp0aGlzKTsKKyAgICB9CisjZW5kaWYKKwogICAgIHJlc3BvbnNlUmVjZWl2ZWQocmVzcG9u c2UsIG51bGxwdHIpOwogfQogCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cgYi9Ub29scy9D aGFuZ2VMb2cKaW5kZXggOTJjOGU0ZWE0ZjA2OTMzMzczMTZmZDMwN2U0NjNmN2JmMzI5MzM4MC4u NGI2OGFjMTQ5ODg4MzQ0NTlkODZmOTg0MTJlYzEyZDQzNTc2OWE4YiAxMDA2NDQKLS0tIGEvVG9v bHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDIx LTA1LTA2ICBBbGV4IENocmlzdGVuc2VuICA8YWNocmlzdGVuc2VuQHdlYmtpdC5vcmc+CisKKyAg ICAgICAgY3NzLWRpc3BsYXktbm9uZSBhY3Rpb25zIGZyb20gV0tDb250ZW50UnVsZUxpc3Qgc2hv dWxkIGFwcGx5IHRvIHBhZ2VzIGxvYWRlZCB3aXRoIGxvYWREYXRhIGFuZCBsb2FkSFRNTFN0cmlu ZworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjI1NDkz CisgICAgICAgIDxyZGFyOi8vNzczMzE3ODk+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgKiBUZXN0V2ViS2l0QVBJL1Rlc3RzL1dlYktpdENvY29hL0Nv bnRlbnRSdWxlTGlzdE5vdGlmaWNhdGlvbi5tbToKKyAgICAgICAgKFRFU1QpOgorCiAyMDIxLTA1 LTA2ICBTYW0gU25lZGRvbiAgPGdzbmVkZGVyc0BhcHBsZS5jb20+CiAKICAgICAgICAgbWFyayBh bGwgU0NNIHRlc3RzIHVzaW5nIFNWTiBhcyBzbG93LCBhIGNvdXBsZSBhcyB4ZmFpbDsgZW5hYmxl IFNDTQpkaWZmIC0tZ2l0IGEvVG9vbHMvVGVzdFdlYktpdEFQSS9UZXN0cy9XZWJLaXRDb2NvYS9D b250ZW50UnVsZUxpc3ROb3RpZmljYXRpb24ubW0gYi9Ub29scy9UZXN0V2ViS2l0QVBJL1Rlc3Rz L1dlYktpdENvY29hL0NvbnRlbnRSdWxlTGlzdE5vdGlmaWNhdGlvbi5tbQppbmRleCA3NmY4NThi MGU0MDMwYjczNmY4ZDBmZjQ0Yzg2MDdkZDZhY2E0NjE2Li5kODY3MTkyZWEwYzA4MjYzYjZlY2Y0 OTE2YWJhYTI3N2E2OGM0MTUxIDEwMDY0NAotLS0gYS9Ub29scy9UZXN0V2ViS2l0QVBJL1Rlc3Rz L1dlYktpdENvY29hL0NvbnRlbnRSdWxlTGlzdE5vdGlmaWNhdGlvbi5tbQorKysgYi9Ub29scy9U ZXN0V2ViS2l0QVBJL1Rlc3RzL1dlYktpdENvY29hL0NvbnRlbnRSdWxlTGlzdE5vdGlmaWNhdGlv bi5tbQpAQCAtMzIsNiArMzIsNyBAQAogI2ltcG9ydCAiVGVzdE5hdmlnYXRpb25EZWxlZ2F0ZS5o IgogI2ltcG9ydCAiVGVzdFVJRGVsZWdhdGUuaCIKICNpbXBvcnQgIlRlc3RVUkxTY2hlbWVIYW5k bGVyLmgiCisjaW1wb3J0ICJUZXN0V0tXZWJWaWV3LmgiCiAjaW1wb3J0IDxXZWJLaXQvV0tDb250 ZW50UnVsZUxpc3RQcml2YXRlLmg+CiAjaW1wb3J0IDxXZWJLaXQvV0tDb250ZW50UnVsZUxpc3RT dG9yZVByaXZhdGUuaD4KICNpbXBvcnQgPFdlYktpdC9XS05hdmlnYXRpb25EZWxlZ2F0ZVByaXZh dGUuaD4KQEAgLTE1Nyw2ICsxNTgsNDUgQEAgVEVTVChDb250ZW50UnVsZUxpc3QsIE5vdGlmaWNh dGlvblN1YnJlc291cmNlKQogICAgIEVYUEVDVF9TVFJFUShbbm90aWZpY2F0aW9uSWRlbnRpZmll ciBVVEY4U3RyaW5nXSwgInRlc3RpZGVudGlmaWVyIik7CiB9CiAKK1RFU1QoQ29udGVudFJ1bGVM aXN0LCBMb2FkSFRNTFN0cmluZ0Rpc3BsYXlOb25lKQoreworICAgIE5TU3RyaW5nICpodG1sID0g QCI8YSBocmVmPSdodHRwczovL3d3dy5hcHBsZS5jb20vJz5saW5rIHRvIEFwcGxlPC9hPiI7CisK KyAgICBOU1N0cmluZyAqZ2V0TGlua0Rpc3BsYXkgPSBAIndpbmRvdy5nZXRDb21wdXRlZFN0eWxl KGRvY3VtZW50LnF1ZXJ5U2VsZWN0b3IoJ2EnKSkuZ2V0UHJvcGVydHlWYWx1ZSgnZGlzcGxheScp IjsKKworICAgIGF1dG8gbGlzdCA9IG1ha2VDb250ZW50UnVsZUxpc3QoQCJbIgorICAgICAgICAi eyBcImFjdGlvblwiOiB7IFwidHlwZVwiIDogXCJjc3MtZGlzcGxheS1ub25lXCIsIFwic2VsZWN0 b3JcIjogXCJhW2hyZWYqPSdhcHBsZS5jb20nXVwiIH0sIFwidHJpZ2dlclwiOiB7IFwidXJsLWZp bHRlclwiOiBcIi4qXCIgfX0sIgorICAgICAgICAieyBcImFjdGlvblwiOiB7IFwidHlwZVwiIDog XCJibG9ja1wiIH0sIFwidHJpZ2dlclwiOiB7IFwidXJsLWZpbHRlclwiOiBcIndlYmtpdC5vcmdc IiB9fSwiCisgICAgICAgICJ7IFwiYWN0aW9uXCI6IHsgXCJ0eXBlXCIgOiBcImlnbm9yZS1wcmV2 aW91cy1ydWxlc1wiIH0sIFwidHJpZ2dlclwiOiB7IFwidXJsLWZpbHRlclwiOiBcImV4YW1wbGUu Y29tXCIgfX0iCisgICAgIl0iKTsKKworICAgIGF1dG8gY29uZmlndXJhdGlvbiA9IGFkb3B0TlMo W1dLV2ViVmlld0NvbmZpZ3VyYXRpb24gbmV3XSk7CisgICAgW1tjb25maWd1cmF0aW9uIHVzZXJD b250ZW50Q29udHJvbGxlcl0gYWRkQ29udGVudFJ1bGVMaXN0Omxpc3QuZ2V0KCldOworICAgIGF1 dG8gd2ViVmlldyA9IGFkb3B0TlMoW1tUZXN0V0tXZWJWaWV3IGFsbG9jXSBpbml0V2l0aEZyYW1l Ok5TTWFrZVJlY3QoMCwgMCwgODAwLCA2MDApIGNvbmZpZ3VyYXRpb246Y29uZmlndXJhdGlvbi5n ZXQoKV0pOworCisgICAgW3dlYlZpZXcgc3luY2hyb25vdXNseUxvYWRIVE1MU3RyaW5nOmh0bWxd OworICAgIEVYUEVDVF9XS19TVFJFUShbd2ViVmlldyBvYmplY3RCeUV2YWx1YXRpbmdKYXZhU2Ny aXB0OmdldExpbmtEaXNwbGF5XSwgIm5vbmUiKTsKKworICAgIFt3ZWJWaWV3IHN5bmNocm9ub3Vz bHlMb2FkSFRNTFN0cmluZzpodG1sIGJhc2VVUkw6W05TVVJMIFVSTFdpdGhTdHJpbmc6QCJodHRw czovL3dlYmtpdC5vcmcvIl1dOworICAgIEVYUEVDVF9XS19TVFJFUShbd2ViVmlldyBvYmplY3RC eUV2YWx1YXRpbmdKYXZhU2NyaXB0OmdldExpbmtEaXNwbGF5XSwgIm5vbmUiKTsKKworICAgIFt3 ZWJWaWV3IHN5bmNocm9ub3VzbHlMb2FkSFRNTFN0cmluZzpodG1sIGJhc2VVUkw6W05TVVJMIFVS TFdpdGhTdHJpbmc6QCJodHRwczovL2V4YW1wbGUuY29tLyJdXTsKKyAgICBFWFBFQ1RfV0tfU1RS RVEoW3dlYlZpZXcgb2JqZWN0QnlFdmFsdWF0aW5nSmF2YVNjcmlwdDpnZXRMaW5rRGlzcGxheV0s ICJpbmxpbmUiKTsKKworICAgIGF1dG8gbGlzdDIgPSBtYWtlQ29udGVudFJ1bGVMaXN0KEAiWyIK KyAgICAgICAgInsgXCJhY3Rpb25cIjogeyBcInR5cGVcIiA6IFwiY3NzLWRpc3BsYXktbm9uZVwi LCBcInNlbGVjdG9yXCI6IFwiYVtocmVmKj0nYXBwbGUuY29tJ11cIiB9LCBcInRyaWdnZXJcIjog eyBcInVybC1maWx0ZXJcIjogXCJ3ZWJraXQub3JnXCIgfX0iCisgICAgIl0iLCBAIm90aGVyIGV4 dGVuc2lvbiIpOworICAgIGF1dG8gY29uZmlndXJhdGlvbjIgPSBhZG9wdE5TKFtXS1dlYlZpZXdD b25maWd1cmF0aW9uIG5ld10pOworICAgIFtbY29uZmlndXJhdGlvbjIgdXNlckNvbnRlbnRDb250 cm9sbGVyXSBhZGRDb250ZW50UnVsZUxpc3Q6bGlzdDIuZ2V0KCldOworICAgIGF1dG8gd2ViVmll dzIgPSBhZG9wdE5TKFtbVGVzdFdLV2ViVmlldyBhbGxvY10gaW5pdFdpdGhGcmFtZTpOU01ha2VS ZWN0KDAsIDAsIDgwMCwgNjAwKSBjb25maWd1cmF0aW9uOmNvbmZpZ3VyYXRpb24yLmdldCgpXSk7 CisKKyAgICBbd2ViVmlldzIgc3luY2hyb25vdXNseUxvYWRIVE1MU3RyaW5nOmh0bWwgYmFzZVVS TDpbTlNVUkwgVVJMV2l0aFN0cmluZzpAImh0dHBzOi8vd2Via2l0Lm9yZy8iXV07CisgICAgRVhQ RUNUX1dLX1NUUkVRKFt3ZWJWaWV3MiBvYmplY3RCeUV2YWx1YXRpbmdKYXZhU2NyaXB0OmdldExp bmtEaXNwbGF5XSwgIm5vbmUiKTsKKworICAgIFt3ZWJWaWV3MiBzeW5jaHJvbm91c2x5TG9hZEhU TUxTdHJpbmc6aHRtbCBiYXNlVVJMOltOU1VSTCBVUkxXaXRoU3RyaW5nOkAiaHR0cHM6Ly9leGFt cGxlLmNvbS8iXV07CisgICAgRVhQRUNUX1dLX1NUUkVRKFt3ZWJWaWV3MiBvYmplY3RCeUV2YWx1 YXRpbmdKYXZhU2NyaXB0OmdldExpbmtEaXNwbGF5XSwgImlubGluZSIpOworfQorCiBURVNUKENv bnRlbnRSdWxlTGlzdCwgUGVyZm9ybWVkQWN0aW9uRm9yVVJMKQogewogICAgIE5TU3RyaW5nICpm aXJzdExpc3QgPSBAIlt7XCJhY3Rpb25cIjp7XCJ0eXBlXCI6XCJub3RpZnlcIixcIm5vdGlmaWNh dGlvblwiOlwidGVzdG5vdGlmaWNhdGlvblwifSxcInRyaWdnZXJcIjp7XCJ1cmwtZmlsdGVyXCI6 XCJub3RpZnlcIn19XSI7Cg==