225486 2021-05-06 15:02:23 -0700 Retry asynchronously in WebProcessPool::getGPUProcessConnection() in case of failure 2021-05-06 18:50:16 -0700 1 1 1 Unclassified WebKit WebKit2 WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=225478 https://bugs.webkit.org/show_bug.cgi?id=224017 InRadar P2 Normal --- 1 cdumez cdumez achristensen kkinnunen webkit-bug-importer oldest_to_newest 1757661 0 cdumez 2021-05-06 15:02:23 -0700 Retry asynchronously in WebProcessPool::getGPUProcessConnection(), similarly to what we do in WebsiteDataStore::getNetworkProcessConnection(). As a result, we no longer need to ref the WebProcessPool in the lambda and we avoid retrying unnecessarily when the WebProcessPool is getting destroyed. 1757662 1 427939 cdumez 2021-05-06 15:04:18 -0700 Created attachment 427939 Patch 1757721 2 427959 cdumez 2021-05-06 16:52:05 -0700 Created attachment 427959 Patch 1757771 3 ews-feeder 2021-05-06 18:49:01 -0700 Committed r277151 (237438@main): <https://commits.webkit.org/237438@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 427959. 1757772 4 webkit-bug-importer 2021-05-06 18:50:16 -0700 <rdar://problem/77636072> 427939 2021-05-06 15:04:18 -0700 2021-05-06 16:52:04 -0700 Patch bug-225486-20210506150417.patch text/plain 3209 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjc3MTI1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGE0MzBiZWFlOTI5NmNhMDg3 MjRiMTg0NjVkZjJiMTZmNTU1MDI5ZTQuLjJjZDQxMjY1MjU2ZTY0ZTkzOTU2MzJiZTQxMjMyODVi MDBhZjcyNzkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTggQEAKKzIwMjEtMDUtMDYgIENocmlzIER1 bWV6ICA8Y2R1bWV6QGFwcGxlLmNvbT4KKworICAgICAgICBSZXRyeSBhc3luY2hyb25vdXNseSBp biBXZWJQcm9jZXNzUG9vbDo6Z2V0R1BVUHJvY2Vzc0Nvbm5lY3Rpb24oKSBpbiBjYXNlIG9mIGZh aWx1cmUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIy NTQ4NgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFJl dHJ5IGFzeW5jaHJvbm91c2x5IGluIFdlYlByb2Nlc3NQb29sOjpnZXRHUFVQcm9jZXNzQ29ubmVj dGlvbigpLCBzaW1pbGFybHkgdG8gd2hhdAorICAgICAgICB3ZSBkbyBpbiBXZWJzaXRlRGF0YVN0 b3JlOjpnZXROZXR3b3JrUHJvY2Vzc0Nvbm5lY3Rpb24oKS4gQXMgYSByZXN1bHQsIHdlIG5vIGxv bmdlcgorICAgICAgICBuZWVkIHRvIHJlZiB0aGUgV2ViUHJvY2Vzc1Bvb2wgaW4gdGhlIGxhbWJk YSBhbmQgd2UgYXZvaWQgcmV0cnlpbmcgdW5uZWNlc3NhcmlseQorICAgICAgICB3aGVuIHRoZSBX ZWJQcm9jZXNzUG9vbCBpcyBnZXR0aW5nIGRlc3Ryb3llZC4KKworICAgICAgICAqIFVJUHJvY2Vz cy9XZWJQcm9jZXNzUG9vbC5jcHA6CisgICAgICAgIChXZWJLaXQ6OldlYlByb2Nlc3NQb29sOjpn ZXRHUFVQcm9jZXNzQ29ubmVjdGlvbik6CisKIDIwMjEtMDUtMDYgIEVyaWMgQ2FybHNvbiAgPGVy aWMuY2FybHNvbkBhcHBsZS5jb20+CiAKICAgICAgICAgW0dQVVBdIFJlZHVjZSBNZWRpYVBsYXll ciBwb2xsaW5nIGZyZXF1ZW5jeSB3aGVuIHBvc3NpYmxlCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi S2l0L1VJUHJvY2Vzcy9XZWJQcm9jZXNzUG9vbC5jcHAgYi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vz cy9XZWJQcm9jZXNzUG9vbC5jcHAKaW5kZXggYmFlM2Y4NTRhOTU4YTQ3NGI4MjYzZThlODFlNmQ0 YTQyNzYzY2FmNy4uNzQxMzFlMjc0ODcyYmZjNWQ2NmI4OGQ0OGJiZTQ4YWY1N2EyYTZkYyAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvV2ViUHJvY2Vzc1Bvb2wuY3BwCisrKyBi L1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL1dlYlByb2Nlc3NQb29sLmNwcApAQCAtNTI3LDExICs1 MjcsMTYgQEAgdm9pZCBXZWJQcm9jZXNzUG9vbDo6Z2V0R1BVUHJvY2Vzc0Nvbm5lY3Rpb24oV2Vi UHJvY2Vzc1Byb3h5JiB3ZWJQcm9jZXNzUHJveHksIEcKICNpZiBFTkFCTEUoSVBDX1RFU1RJTkdf QVBJKQogICAgIHBhcmFtZXRlcnMuaWdub3JlSW52YWxpZE1lc3NhZ2VGb3JUZXN0aW5nID0gd2Vi UHJvY2Vzc1Byb3h5Lmlnbm9yZUludmFsaWRNZXNzYWdlRm9yVGVzdGluZygpOwogI2VuZGlmCi0g ICAgZW5zdXJlR1BVUHJvY2VzcygpLmdldEdQVVByb2Nlc3NDb25uZWN0aW9uKHdlYlByb2Nlc3NQ cm94eSwgcGFyYW1ldGVycywgW3RoaXMsIHByb3RlY3RlZFRoaXMgPSBtYWtlUmVmKCp0aGlzKSwg cGFyYW1ldGVycywgd2ViUHJvY2Vzc1Byb3h5ID0gbWFrZVdlYWtQdHIod2ViUHJvY2Vzc1Byb3h5 KSwgcmVwbHkgPSBXVEZNb3ZlKHJlcGx5KV0gKGF1dG8mIGNvbm5lY3Rpb25JbmZvKSBtdXRhYmxl IHsKLSAgICAgICAgaWYgKFVOTElLRUxZKCFJUEM6OkNvbm5lY3Rpb246OmlkZW50aWZpZXJJc1Zh bGlkKGNvbm5lY3Rpb25JbmZvLmlkZW50aWZpZXIoKSkgJiYgd2ViUHJvY2Vzc1Byb3h5KSkgewot ICAgICAgICAgICAgV0VCUFJPQ0VTU1BPT0xfUkVMRUFTRV9MT0dfRVJST1IoUHJvY2VzcywgImdl dEdQVVByb2Nlc3NDb25uZWN0aW9uOiBGYWlsZWQgZmlyc3QgYXR0ZW1wdCwgcmV0cnlpbmciKTsK LSAgICAgICAgICAgIGVuc3VyZUdQVVByb2Nlc3MoKS5nZXRHUFVQcm9jZXNzQ29ubmVjdGlvbigq d2ViUHJvY2Vzc1Byb3h5LCBwYXJhbWV0ZXJzLCBXVEZNb3ZlKHJlcGx5KSk7Ci0gICAgICAgICAg ICByZXR1cm47CisgICAgZW5zdXJlR1BVUHJvY2VzcygpLmdldEdQVVByb2Nlc3NDb25uZWN0aW9u KHdlYlByb2Nlc3NQcm94eSwgcGFyYW1ldGVycywgW3RoaXMsIHdlYWtUaGlzID0gbWFrZVdlYWtQ dHIoKnRoaXMpLCBwYXJhbWV0ZXJzLCB3ZWJQcm9jZXNzUHJveHkgPSBtYWtlV2Vha1B0cih3ZWJQ cm9jZXNzUHJveHkpLCByZXBseSA9IFdURk1vdmUocmVwbHkpXSAoYXV0byYgY29ubmVjdGlvbklu Zm8pIG11dGFibGUgeworICAgICAgICBpZiAoVU5MSUtFTFkoIUlQQzo6Q29ubmVjdGlvbjo6aWRl bnRpZmllcklzVmFsaWQoY29ubmVjdGlvbkluZm8uaWRlbnRpZmllcigpKSkpIHsKKyAgICAgICAg ICAgIC8vIFJldHJ5IG9uIHRoZSBuZXh0IFJ1bkxvb3AgaXRlcmF0aW9uIGJlY2F1c2Ugd2UgbWF5 IGJlIGluc2lkZSB0aGUgV2ViUHJvY2Vzc1Bvb2wgZGVzdHJ1Y3Rvci4KKyAgICAgICAgICAgIFJ1 bkxvb3A6Om1haW4oKS5kaXNwYXRjaChbdGhpcywgd2Vha1RoaXMgPSBXVEZNb3ZlKHdlYWtUaGlz KSwgd2ViUHJvY2Vzc1Byb3h5ID0gV1RGTW92ZSh3ZWJQcm9jZXNzUHJveHkpLCBwYXJhbWV0ZXJz ID0gV1RGTW92ZShwYXJhbWV0ZXJzKSwgcmVwbHkgPSBXVEZNb3ZlKHJlcGx5KV0gKCkgbXV0YWJs ZSB7CisgICAgICAgICAgICAgICAgaWYgKHdlYWtUaGlzICYmIHdlYlByb2Nlc3NQcm94eSkgewor ICAgICAgICAgICAgICAgICAgICBXRUJQUk9DRVNTUE9PTF9SRUxFQVNFX0xPR19FUlJPUihQcm9j ZXNzLCAiZ2V0R1BVUHJvY2Vzc0Nvbm5lY3Rpb246IEZhaWxlZCBmaXJzdCBhdHRlbXB0LCByZXRy eWluZyIpOworICAgICAgICAgICAgICAgICAgICBlbnN1cmVHUFVQcm9jZXNzKCkuZ2V0R1BVUHJv Y2Vzc0Nvbm5lY3Rpb24oKndlYlByb2Nlc3NQcm94eSwgcGFyYW1ldGVycywgV1RGTW92ZShyZXBs eSkpOworICAgICAgICAgICAgICAgIH0gZWxzZQorICAgICAgICAgICAgICAgICAgICByZXBseSh7 IH0pOworICAgICAgICAgICAgfSk7CiAgICAgICAgIH0KICAgICAgICAgcmVwbHkoY29ubmVjdGlv bkluZm8pOwogICAgIH0pOwo= 427959 2021-05-06 16:52:05 -0700 2021-05-06 18:49:02 -0700 Patch bug-225486-20210506165204.patch text/plain 3202 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjc3MTM4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGE0MzBiZWFlOTI5NmNhMDg3 MjRiMTg0NjVkZjJiMTZmNTU1MDI5ZTQuLmNlYWQyMmI5ZGJlMTM3NjljNjMzMzdiMzQ2ZDZmMjg0 MjUwMmEyNmIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTggQEAKKzIwMjEtMDUtMDYgIENocmlzIER1 bWV6ICA8Y2R1bWV6QGFwcGxlLmNvbT4KKworICAgICAgICBSZXRyeSBhc3luY2hyb25vdXNseSBp biBXZWJQcm9jZXNzUG9vbDo6Z2V0R1BVUHJvY2Vzc0Nvbm5lY3Rpb24oKSBpbiBjYXNlIG9mIGZh aWx1cmUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIy NTQ4NgorCisgICAgICAgIFJldmlld2VkIGJ5IEFsZXggQ2hyaXN0ZW5zZW4uCisKKyAgICAgICAg UmV0cnkgYXN5bmNocm9ub3VzbHkgaW4gV2ViUHJvY2Vzc1Bvb2w6OmdldEdQVVByb2Nlc3NDb25u ZWN0aW9uKCksIHNpbWlsYXJseSB0byB3aGF0CisgICAgICAgIHdlIGRvIGluIFdlYnNpdGVEYXRh U3RvcmU6OmdldE5ldHdvcmtQcm9jZXNzQ29ubmVjdGlvbigpLiBBcyBhIHJlc3VsdCwgd2Ugbm8g bG9uZ2VyCisgICAgICAgIG5lZWQgdG8gcmVmIHRoZSBXZWJQcm9jZXNzUG9vbCBpbiB0aGUgbGFt YmRhIGFuZCB3ZSBhdm9pZCByZXRyeWluZyB1bm5lY2Vzc2FyaWx5CisgICAgICAgIHdoZW4gdGhl IFdlYlByb2Nlc3NQb29sIGlzIGdldHRpbmcgZGVzdHJveWVkLgorCisgICAgICAgICogVUlQcm9j ZXNzL1dlYlByb2Nlc3NQb29sLmNwcDoKKyAgICAgICAgKFdlYktpdDo6V2ViUHJvY2Vzc1Bvb2w6 OmdldEdQVVByb2Nlc3NDb25uZWN0aW9uKToKKwogMjAyMS0wNS0wNiAgRXJpYyBDYXJsc29uICA8 ZXJpYy5jYXJsc29uQGFwcGxlLmNvbT4KIAogICAgICAgICBbR1BVUF0gUmVkdWNlIE1lZGlhUGxh eWVyIHBvbGxpbmcgZnJlcXVlbmN5IHdoZW4gcG9zc2libGUKZGlmZiAtLWdpdCBhL1NvdXJjZS9X ZWJLaXQvVUlQcm9jZXNzL1dlYlByb2Nlc3NQb29sLmNwcCBiL1NvdXJjZS9XZWJLaXQvVUlQcm9j ZXNzL1dlYlByb2Nlc3NQb29sLmNwcAppbmRleCBiYWUzZjg1NGE5NThhNDc0YjgyNjNlOGU4MWU2 ZDRhNDI3NjNjYWY3Li4zNDIwMGNjNTY2Y2Q5NmQwMzQxZTI4ZGI0NjY4NGVlMDhkMDU3ZDQzIDEw MDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9XZWJQcm9jZXNzUG9vbC5jcHAKKysr IGIvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvV2ViUHJvY2Vzc1Bvb2wuY3BwCkBAIC01MjcsMTAg KzUyNywxNiBAQCB2b2lkIFdlYlByb2Nlc3NQb29sOjpnZXRHUFVQcm9jZXNzQ29ubmVjdGlvbihX ZWJQcm9jZXNzUHJveHkmIHdlYlByb2Nlc3NQcm94eSwgRwogI2lmIEVOQUJMRShJUENfVEVTVElO R19BUEkpCiAgICAgcGFyYW1ldGVycy5pZ25vcmVJbnZhbGlkTWVzc2FnZUZvclRlc3RpbmcgPSB3 ZWJQcm9jZXNzUHJveHkuaWdub3JlSW52YWxpZE1lc3NhZ2VGb3JUZXN0aW5nKCk7CiAjZW5kaWYK LSAgICBlbnN1cmVHUFVQcm9jZXNzKCkuZ2V0R1BVUHJvY2Vzc0Nvbm5lY3Rpb24od2ViUHJvY2Vz c1Byb3h5LCBwYXJhbWV0ZXJzLCBbdGhpcywgcHJvdGVjdGVkVGhpcyA9IG1ha2VSZWYoKnRoaXMp LCBwYXJhbWV0ZXJzLCB3ZWJQcm9jZXNzUHJveHkgPSBtYWtlV2Vha1B0cih3ZWJQcm9jZXNzUHJv eHkpLCByZXBseSA9IFdURk1vdmUocmVwbHkpXSAoYXV0byYgY29ubmVjdGlvbkluZm8pIG11dGFi bGUgewotICAgICAgICBpZiAoVU5MSUtFTFkoIUlQQzo6Q29ubmVjdGlvbjo6aWRlbnRpZmllcklz VmFsaWQoY29ubmVjdGlvbkluZm8uaWRlbnRpZmllcigpKSAmJiB3ZWJQcm9jZXNzUHJveHkpKSB7 Ci0gICAgICAgICAgICBXRUJQUk9DRVNTUE9PTF9SRUxFQVNFX0xPR19FUlJPUihQcm9jZXNzLCAi Z2V0R1BVUHJvY2Vzc0Nvbm5lY3Rpb246IEZhaWxlZCBmaXJzdCBhdHRlbXB0LCByZXRyeWluZyIp OwotICAgICAgICAgICAgZW5zdXJlR1BVUHJvY2VzcygpLmdldEdQVVByb2Nlc3NDb25uZWN0aW9u KCp3ZWJQcm9jZXNzUHJveHksIHBhcmFtZXRlcnMsIFdURk1vdmUocmVwbHkpKTsKKyAgICBlbnN1 cmVHUFVQcm9jZXNzKCkuZ2V0R1BVUHJvY2Vzc0Nvbm5lY3Rpb24od2ViUHJvY2Vzc1Byb3h5LCBw YXJhbWV0ZXJzLCBbdGhpcywgd2Vha1RoaXMgPSBtYWtlV2Vha1B0cigqdGhpcyksIHBhcmFtZXRl cnMsIHdlYlByb2Nlc3NQcm94eSA9IG1ha2VXZWFrUHRyKHdlYlByb2Nlc3NQcm94eSksIHJlcGx5 ID0gV1RGTW92ZShyZXBseSldIChhdXRvJiBjb25uZWN0aW9uSW5mbykgbXV0YWJsZSB7CisgICAg ICAgIGlmIChVTkxJS0VMWSghSVBDOjpDb25uZWN0aW9uOjppZGVudGlmaWVySXNWYWxpZChjb25u ZWN0aW9uSW5mby5pZGVudGlmaWVyKCkpKSkgeworICAgICAgICAgICAgLy8gUmV0cnkgb24gdGhl IG5leHQgUnVuTG9vcCBpdGVyYXRpb24gYmVjYXVzZSB3ZSBtYXkgYmUgaW5zaWRlIHRoZSBXZWJQ cm9jZXNzUG9vbCBkZXN0cnVjdG9yLgorICAgICAgICAgICAgUnVuTG9vcDo6bWFpbigpLmRpc3Bh dGNoKFt0aGlzLCB3ZWFrVGhpcyA9IFdURk1vdmUod2Vha1RoaXMpLCB3ZWJQcm9jZXNzUHJveHkg PSBXVEZNb3ZlKHdlYlByb2Nlc3NQcm94eSksIHBhcmFtZXRlcnMgPSBXVEZNb3ZlKHBhcmFtZXRl cnMpLCByZXBseSA9IFdURk1vdmUocmVwbHkpXSAoKSBtdXRhYmxlIHsKKyAgICAgICAgICAgICAg ICBpZiAod2Vha1RoaXMgJiYgd2ViUHJvY2Vzc1Byb3h5KSB7CisgICAgICAgICAgICAgICAgICAg IFdFQlBST0NFU1NQT09MX1JFTEVBU0VfTE9HX0VSUk9SKFByb2Nlc3MsICJnZXRHUFVQcm9jZXNz Q29ubmVjdGlvbjogRmFpbGVkIGZpcnN0IGF0dGVtcHQsIHJldHJ5aW5nIik7CisgICAgICAgICAg ICAgICAgICAgIGVuc3VyZUdQVVByb2Nlc3MoKS5nZXRHUFVQcm9jZXNzQ29ubmVjdGlvbigqd2Vi UHJvY2Vzc1Byb3h5LCBwYXJhbWV0ZXJzLCBXVEZNb3ZlKHJlcGx5KSk7CisgICAgICAgICAgICAg ICAgfSBlbHNlCisgICAgICAgICAgICAgICAgICAgIHJlcGx5KHsgfSk7CisgICAgICAgICAgICB9 KTsKICAgICAgICAgICAgIHJldHVybjsKICAgICAgICAgfQogICAgICAgICByZXBseShjb25uZWN0 aW9uSW5mbyk7Cg==