225485 2021-05-06 14:40:43 -0700 [GPUP-MSE] Implement time changed callback 2021-05-10 10:46:49 -0700 1 1 1 Unclassified WebKit Media WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 eric.carlson eric.carlson ews-watchlist glenn jer.noble peng.liu6 philipj sergio webkit-bug-importer oldest_to_newest 1757656 0 eric.carlson 2021-05-06 14:40:43 -0700 Implement MediaPlayerPrivateMediaSourceAVFObjC::setCurrentTimeDidChangeCallback so we won't have to poll currentTime 1757657 1 webkit-bug-importer 2021-05-06 14:40:56 -0700 <rdar://problem/77625992> 1757663 2 427940 eric.carlson 2021-05-06 15:08:02 -0700 Created attachment 427940 Patch 1757675 3 427940 peng.liu6 2021-05-06 15:44:47 -0700 Comment on attachment 427940 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=427940&action=review > Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm:427 > + Nit. This empty line can be removed. 1758541 4 ews-feeder 2021-05-10 10:46:47 -0700 Committed r277272 (237539@main): <https://commits.webkit.org/237539@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 427940. 427940 2021-05-06 15:08:02 -0700 2021-05-10 10:46:48 -0700 Patch bug-225485-20210506150802.patch text/plain 4884 eric.carlson U3VidmVyc2lvbiBSZXZpc2lvbjogMjc3MTI1CjIwMjEtMDUtMDZUMTQ6NTg6MjgsNjA3OiBbMHgx MTIwN2JlMDBdIHdoaWxlIGNvbXB1dGluZyBzb2NrbmFtZTogZmFpbGVkIHRvIGNyZWF0ZSAvdXNy L2xvY2FsL3Zhci9ydW4vd2F0Y2htYW4vZXJpYy1zdGF0ZTogTm8gc3VjaCBmaWxlIG9yIGRpcmVj dG9yeQpXYXRjaG1hbjogY29tbWFuZCByZXR1cm5lZCBubyBvdXRwdXQuCkZhbGxpbmcgYmFjayB0 byBzY2FubmluZy4uLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCmluZGV4IDA2NjZiMzIwZWJiMjQ3ZGRiYWFhNWVlZjVjOWM4 OTJjMGY3YjQwMjAuLjYyNjZhMGYyOTA3YTFlYTFiODNkMWY5Nzc0MDFmMjQ4OGNmZTIwMjEgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cKQEAgLTEsMyArMSwyMiBAQAorMjAyMS0wNS0wNiAgRXJpYyBDYXJsc29uICA8ZXJp Yy5jYXJsc29uQGFwcGxlLmNvbT4KKworICAgICAgICBbR1BVUC1NU0VdIEltcGxlbWVudCB0aW1l IGNoYW5nZWQgY2FsbGJhY2sKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTIyNTQ4NQorICAgICAgICA8cmRhcjovL3Byb2JsZW0vNzc2MjU5OTI+CisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgSW1wbGVtZW50IE1l ZGlhUGxheWVyUHJpdmF0ZU1lZGlhU291cmNlQVZGT2JqQzo6c2V0Q3VycmVudFRpbWVEaWRDaGFu Z2VDYWxsYmFjayBzbworICAgICAgICB0aGUgR1BVIHByb2Nlc3MgZG9lc24ndCBoYXZlIHRvIHBv bGwgY3VycmVudFRpbWUuCisKKyAgICAgICAgTm8gY2hhbmdlIGluIGZ1bmN0aW9uYWxpdHkuCisK KyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9hdmZvdW5kYXRpb24vb2JqYy9NZWRpYVBsYXll clByaXZhdGVNZWRpYVNvdXJjZUFWRk9iakMuaDoKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGlj cy9hdmZvdW5kYXRpb24vb2JqYy9NZWRpYVBsYXllclByaXZhdGVNZWRpYVNvdXJjZUFWRk9iakMu bW06CisgICAgICAgIChXZWJDb3JlOjpNZWRpYVBsYXllclByaXZhdGVNZWRpYVNvdXJjZUFWRk9i akM6Ok1lZGlhUGxheWVyUHJpdmF0ZU1lZGlhU291cmNlQVZGT2JqQyk6CisgICAgICAgIChXZWJD b3JlOjpNZWRpYVBsYXllclByaXZhdGVNZWRpYVNvdXJjZUFWRk9iakM6On5NZWRpYVBsYXllclBy aXZhdGVNZWRpYVNvdXJjZUFWRk9iakMpOgorICAgICAgICAoV2ViQ29yZTo6TWVkaWFQbGF5ZXJQ cml2YXRlTWVkaWFTb3VyY2VBVkZPYmpDOjpzZXRDdXJyZW50VGltZURpZENoYW5nZUNhbGxiYWNr KToKKwogMjAyMS0wNS0wNiAgRGV2aW4gUm91c3NvICA8ZHJvdXNzb0BhcHBsZS5jb20+CiAKICAg ICAgICAgU2FtcGxlZCBQYWdlIFRvcCBDb2xvcjogbWFrZSBoaXQgdGVzdHMgY29uc2lkZXIgZWxl bWVudHMgd2l0aCBgcG9pbnRlci1ldmVudHM6IG5vbmVgCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi Q29yZS9wbGF0Zm9ybS9ncmFwaGljcy9hdmZvdW5kYXRpb24vb2JqYy9NZWRpYVBsYXllclByaXZh dGVNZWRpYVNvdXJjZUFWRk9iakMuaCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNz L2F2Zm91bmRhdGlvbi9vYmpjL01lZGlhUGxheWVyUHJpdmF0ZU1lZGlhU291cmNlQVZGT2JqQy5o CmluZGV4IDljODJmMjhhMTU1YjIwNDFlMjg5ODBhYzZjMTZiMGI1NTAxN2FhOWEuLjJlOGI2ODU0 NDNlMDYzN2M1ODQ2MmIzN2JkYWI2MmRhY2RhODMxODcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJD b3JlL3BsYXRmb3JtL2dyYXBoaWNzL2F2Zm91bmRhdGlvbi9vYmpjL01lZGlhUGxheWVyUHJpdmF0 ZU1lZGlhU291cmNlQVZGT2JqQy5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBo aWNzL2F2Zm91bmRhdGlvbi9vYmpjL01lZGlhUGxheWVyUHJpdmF0ZU1lZGlhU291cmNlQVZGT2Jq Qy5oCkBAIC0yNjMsNiArMjYzLDggQEAgcHJpdmF0ZToKIAogICAgIGJvb2wgaXNWaWRlb091dHB1 dEF2YWlsYWJsZSgpIGNvbnN0OwogCisgICAgYm9vbCBzZXRDdXJyZW50VGltZURpZENoYW5nZUNh bGxiYWNrKE1lZGlhUGxheWVyOjpDdXJyZW50VGltZURpZENoYW5nZUNhbGxiYWNrJiYpIGZpbmFs OworCiAgICAgZnJpZW5kIGNsYXNzIE1lZGlhU291cmNlUHJpdmF0ZUFWRk9iakM7CiAKICAgICBz dHJ1Y3QgUGVuZGluZ1NlZWsgewpAQCAtMjk1LDYgKzI5Nyw4IEBAIHByaXZhdGU6CiAgICAgSGFz aE1hcDxSZXRhaW5QdHI8Q0ZUeXBlUmVmPiwgQXVkaW9SZW5kZXJlclByb3BlcnRpZXM+IG1fc2Ft cGxlQnVmZmVyQXVkaW9SZW5kZXJlck1hcDsKICAgICBSZXRhaW5QdHI8QVZTYW1wbGVCdWZmZXJS ZW5kZXJTeW5jaHJvbml6ZXI+IG1fc3luY2hyb25pemVyOwogICAgIEFMTE9XX05FV19BUElfV0lU SE9VVF9HVUFSRFNfRU5ECisgICAgbXV0YWJsZSBNZWRpYVBsYXllcjo6Q3VycmVudFRpbWVEaWRD aGFuZ2VDYWxsYmFjayBtX2N1cnJlbnRUaW1lRGlkQ2hhbmdlQ2FsbGJhY2s7CisgICAgUmV0YWlu UHRyPGlkPiBtX3RpbWVDaGFuZ2VkT2JzZXJ2ZXI7CiAgICAgUmV0YWluUHRyPGlkPiBtX3RpbWVK dW1wZWRPYnNlcnZlcjsKICAgICBSZXRhaW5QdHI8aWQ+IG1fZHVyYXRpb25PYnNlcnZlcjsKICAg ICBSZXRhaW5QdHI8aWQ+IG1fcGVyZm9ybVRhc2tPYnNlcnZlcjsKZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2F2Zm91bmRhdGlvbi9vYmpjL01lZGlhUGxheWVy UHJpdmF0ZU1lZGlhU291cmNlQVZGT2JqQy5tbSBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dy YXBoaWNzL2F2Zm91bmRhdGlvbi9vYmpjL01lZGlhUGxheWVyUHJpdmF0ZU1lZGlhU291cmNlQVZG T2JqQy5tbQppbmRleCAwNDkyY2EzOTIyNjU1MWY0ZThiNTYwZDc3ZDdmYjY1NWMzYmU4OGUxLi42 ZWIwMGE0ZWYwOGM0M2MwOTdjYTBmOGJiNTQyZGY2ZDFkMzI1YjJmIDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9hdmZvdW5kYXRpb24vb2JqYy9NZWRpYVBsYXll clByaXZhdGVNZWRpYVNvdXJjZUFWRk9iakMubW0KKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZv cm0vZ3JhcGhpY3MvYXZmb3VuZGF0aW9uL29iamMvTWVkaWFQbGF5ZXJQcml2YXRlTWVkaWFTb3Vy Y2VBVkZPYmpDLm1tCkBAIC0xNjksNiArMTY5LDkgQEAgTWVkaWFQbGF5ZXJQcml2YXRlTWVkaWFT b3VyY2VBVkZPYmpDOjpNZWRpYVBsYXllclByaXZhdGVNZWRpYVNvdXJjZUFWRk9iakMoTWVkaWEK IAogICAgICAgICBpZiAobV9wZW5kaW5nU2VlaykKICAgICAgICAgICAgIHNlZWtJbnRlcm5hbCgp OworCisgICAgICAgIGlmIChtX2N1cnJlbnRUaW1lRGlkQ2hhbmdlQ2FsbGJhY2spCisgICAgICAg ICAgICBtX2N1cnJlbnRUaW1lRGlkQ2hhbmdlQ2FsbGJhY2soQ01USU1FX0lTX05VTUVSSUModGlt ZSkgPyBQQUw6OnRvTWVkaWFUaW1lKHRpbWUpIDogTWVkaWFUaW1lOjp6ZXJvVGltZSgpKTsKICAg ICB9XTsKIH0KIApAQCAtMTgwLDYgKzE4Myw4IEBAIE1lZGlhUGxheWVyUHJpdmF0ZU1lZGlhU291 cmNlQVZGT2JqQzo6fk1lZGlhUGxheWVyUHJpdmF0ZU1lZGlhU291cmNlQVZGT2JqQygpCiAKICAg ICBpZiAobV90aW1lSnVtcGVkT2JzZXJ2ZXIpCiAgICAgICAgIFttX3N5bmNocm9uaXplciByZW1v dmVUaW1lT2JzZXJ2ZXI6bV90aW1lSnVtcGVkT2JzZXJ2ZXIuZ2V0KCldOworICAgIGlmIChtX3Rp bWVDaGFuZ2VkT2JzZXJ2ZXIpCisgICAgICAgIFttX3N5bmNocm9uaXplciByZW1vdmVUaW1lT2Jz ZXJ2ZXI6bV90aW1lQ2hhbmdlZE9ic2VydmVyLmdldCgpXTsKICAgICBpZiAobV9kdXJhdGlvbk9i c2VydmVyKQogICAgICAgICBbbV9zeW5jaHJvbml6ZXIgcmVtb3ZlVGltZU9ic2VydmVyOm1fZHVy YXRpb25PYnNlcnZlci5nZXQoKV07CiAgICAgZmx1c2hQZW5kaW5nU2l6ZUNoYW5nZXMoKTsKQEAg LTQxMCw2ICs0MTUsMjIgQEAgTWVkaWFUaW1lIE1lZGlhUGxheWVyUHJpdmF0ZU1lZGlhU291cmNl QVZGT2JqQzo6Y3VycmVudE1lZGlhVGltZSgpIGNvbnN0CiAgICAgcmV0dXJuIHN5bmNocm9uaXpl clRpbWU7CiB9CiAKK2Jvb2wgTWVkaWFQbGF5ZXJQcml2YXRlTWVkaWFTb3VyY2VBVkZPYmpDOjpz ZXRDdXJyZW50VGltZURpZENoYW5nZUNhbGxiYWNrKE1lZGlhUGxheWVyOjpDdXJyZW50VGltZURp ZENoYW5nZUNhbGxiYWNrJiYgY2FsbGJhY2spCit7CisgICAgbV9jdXJyZW50VGltZURpZENoYW5n ZUNhbGxiYWNrID0gV1RGTW92ZShjYWxsYmFjayk7CisKKyAgICBpZiAobV9jdXJyZW50VGltZURp ZENoYW5nZUNhbGxiYWNrKSB7CisgICAgICAgIG1fdGltZUNoYW5nZWRPYnNlcnZlciA9IFttX3N5 bmNocm9uaXplciBhZGRQZXJpb2RpY1RpbWVPYnNlcnZlckZvckludGVydmFsOkNNVGltZU1ha2Uo MSwgMTApIHF1ZXVlOmRpc3BhdGNoX2dldF9tYWluX3F1ZXVlKCkgdXNpbmdCbG9jazpeKENNVGlt ZSB0aW1lKSB7CisgICAgICAgICAgICBpZiAobV9jdXJyZW50VGltZURpZENoYW5nZUNhbGxiYWNr KQorICAgICAgICAgICAgICAgIG1fY3VycmVudFRpbWVEaWRDaGFuZ2VDYWxsYmFjayhDTVRJTUVf SVNfTlVNRVJJQyh0aW1lKSA/IFBBTDo6dG9NZWRpYVRpbWUodGltZSkgOiBNZWRpYVRpbWU6Onpl cm9UaW1lKCkpOworICAgICAgICB9XTsKKworICAgIH0gZWxzZQorICAgICAgICBtX3RpbWVDaGFu Z2VkT2JzZXJ2ZXIgPSBudWxscHRyOworCisgICAgcmV0dXJuIHRydWU7Cit9CisKIE1lZGlhVGlt ZSBNZWRpYVBsYXllclByaXZhdGVNZWRpYVNvdXJjZUFWRk9iakM6OnN0YXJ0VGltZSgpIGNvbnN0 CiB7CiAgICAgcmV0dXJuIE1lZGlhVGltZTo6emVyb1RpbWUoKTsK