<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>225473</bug_id>
          
          <creation_ts>2021-05-06 11:40:22 -0700</creation_ts>
          <short_desc>Make it easy to pass __XPC variables to run-benchmark</short_desc>
          <delta_ts>2021-05-06 11:59:18 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Tools / Tests</component>
          <version>Other</version>
          <rep_platform>All</rep_platform>
          <op_sys>All</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Filip Pizlo">fpizlo</reporter>
          <assigned_to name="Filip Pizlo">fpizlo</assigned_to>
          <cc>ews-watchlist</cc>
    
    <cc>glenn</cc>
    
    <cc>jbedard</cc>
    
    <cc>simon.fraser</cc>
    
    <cc>slewis</cc>
    
    <cc>webkit-bug-importer</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1757542</commentid>
    <comment_count>0</comment_count>
    <who name="Filip Pizlo">fpizlo</who>
    <bug_when>2021-05-06 11:40:22 -0700</bug_when>
    <thetext>...</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1757543</commentid>
    <comment_count>1</comment_count>
      <attachid>427914</attachid>
    <who name="Filip Pizlo">fpizlo</who>
    <bug_when>2021-05-06 11:41:11 -0700</bug_when>
    <thetext>Created attachment 427914
the patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1757549</commentid>
    <comment_count>2</comment_count>
      <attachid>427914</attachid>
    <who name="Simon Fraser (smfr)">simon.fraser</who>
    <bug_when>2021-05-06 11:52:12 -0700</bug_when>
    <thetext>Comment on attachment 427914
the patch

Could you fix the help to show how to do this too please?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1757550</commentid>
    <comment_count>3</comment_count>
    <who name="Filip Pizlo">fpizlo</who>
    <bug_when>2021-05-06 11:53:07 -0700</bug_when>
    <thetext>(In reply to Simon Fraser (smfr) from comment #2)
&gt; Comment on attachment 427914 [details]
&gt; the patch
&gt; 
&gt; Could you fix the help to show how to do this too please?

Sure!</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1757551</commentid>
    <comment_count>4</comment_count>
      <attachid>427914</attachid>
    <who name="Filip Pizlo">fpizlo</who>
    <bug_when>2021-05-06 11:53:53 -0700</bug_when>
    <thetext>Comment on attachment 427914
the patch

Going to land a different patch, that includes changes to the help text.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1757553</commentid>
    <comment_count>5</comment_count>
    <who name="Filip Pizlo">fpizlo</who>
    <bug_when>2021-05-06 11:58:56 -0700</bug_when>
    <thetext>Landed in https://trac.webkit.org/changeset/277105/webkit</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1757554</commentid>
    <comment_count>6</comment_count>
    <who name="Radar WebKit Bug Importer">webkit-bug-importer</who>
    <bug_when>2021-05-06 11:59:18 -0700</bug_when>
    <thetext>&lt;rdar://problem/77618796&gt;</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>427914</attachid>
            <date>2021-05-06 11:41:11 -0700</date>
            <delta_ts>2021-05-06 11:53:53 -0700</delta_ts>
            <desc>the patch</desc>
            <filename>envrunbench.patch</filename>
            <type>text/plain</type>
            <size>2369</size>
            <attacher name="Filip Pizlo">fpizlo</attacher>
            
              <data encoding="base64">SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl
dmlzaW9uIDI3NzA5NikKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSww
ICsxLDEwIEBACisyMDIxLTA1LTA2ICBGaWxpcCBQaXpsbyAgPGZwaXpsb0BhcHBsZS5jb20+CisK
KyAgICAgICAgTWFrZSBpdCBlYXN5IHRvIHBhc3MgX19YUEMgdmFyaWFibGVzIHRvIHJ1bi1iZW5j
aG1hcmsKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIy
NTQ3MworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICog
U2NyaXB0cy93ZWJraXRweS9iZW5jaG1hcmtfcnVubmVyL2Jyb3dzZXJfZHJpdmVyL29zeF9zYWZh
cmlfZHJpdmVyLnB5OgorICAgICAgICAoT1NYU2FmYXJpRHJpdmVyLmxhdW5jaF91cmwpOgorCklu
ZGV4OiBUb29scy9TY3JpcHRzL3dlYmtpdHB5L2JlbmNobWFya19ydW5uZXIvYnJvd3Nlcl9kcml2
ZXIvb3N4X3NhZmFyaV9kcml2ZXIucHkKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gVG9vbHMvU2NyaXB0cy93ZWJr
aXRweS9iZW5jaG1hcmtfcnVubmVyL2Jyb3dzZXJfZHJpdmVyL29zeF9zYWZhcmlfZHJpdmVyLnB5
CShyZXZpc2lvbiAyNzY4NTcpCisrKyBUb29scy9TY3JpcHRzL3dlYmtpdHB5L2JlbmNobWFya19y
dW5uZXIvYnJvd3Nlcl9kcml2ZXIvb3N4X3NhZmFyaV9kcml2ZXIucHkJKHdvcmtpbmcgY29weSkK
QEAgLTIsNiArMiw3IEBACiAKIGltcG9ydCBsb2dnaW5nCiBpbXBvcnQgb3MKK2ltcG9ydCByZQog
aW1wb3J0IHN1YnByb2Nlc3MKIGltcG9ydCB0aW1lCiAKQEAgLTI2LDYgKzI3LDkgQEAgY2xhc3Mg
T1NYU2FmYXJpRHJpdmVyKE9TWEJyb3dzZXJEcml2ZXIpOgogICAgIGRlZiBsYXVuY2hfdXJsKHNl
bGYsIHVybCwgb3B0aW9ucywgYnJvd3Nlcl9idWlsZF9wYXRoLCBicm93c2VyX3BhdGgpOgogICAg
ICAgICBhcmdzID0gWycvQXBwbGljYXRpb25zL1NhZmFyaS5hcHAvQ29udGVudHMvTWFjT1MvU2Fm
YXJpJ10KICAgICAgICAgZW52ID0ge30KKyAgICAgICAgZm9yIGtleSwgdmFsdWUgaW4gb3MuZW52
aXJvbi5pdGVtcygpOgorICAgICAgICAgICAgaWYgcmUubWF0Y2gociJeX19YUENfIiwga2V5KToK
KyAgICAgICAgICAgICAgICBlbnZba2V5XSA9IHZhbHVlCiAgICAgICAgIGlmIGJyb3dzZXJfYnVp
bGRfcGF0aDoKICAgICAgICAgICAgIGJyb3dzZXJfYnVpbGRfYWJzb2x1dGVfcGF0aCA9IG9zLnBh
dGguYWJzcGF0aChicm93c2VyX2J1aWxkX3BhdGgpCiAgICAgICAgICAgICBzYWZhcmlfYXBwX2lu
X2J1aWxkX3BhdGggPSBvcy5wYXRoLmpvaW4oYnJvd3Nlcl9idWlsZF9hYnNvbHV0ZV9wYXRoLCAn
U2FmYXJpLmFwcC9Db250ZW50cy9NYWNPUy9TYWZhcmknKQpAQCAtMzcsOCArNDEsMTAgQEAgY2xh
c3MgT1NYU2FmYXJpRHJpdmVyKE9TWEJyb3dzZXJEcml2ZXIpOgogICAgICAgICAgICAgICAgIGFy
Z3MgPSBbc2FmYXJpX2FwcF9pbl9idWlsZF9wYXRoXQogCiAgICAgICAgICAgICBpZiBjb250YWlu
c19mcmFtZXdvcmtzOgotICAgICAgICAgICAgICAgIGVudiA9IHsnRFlMRF9GUkFNRVdPUktfUEFU
SCc6IGJyb3dzZXJfYnVpbGRfYWJzb2x1dGVfcGF0aCwgJ0RZTERfTElCUkFSWV9QQVRIJzogYnJv
d3Nlcl9idWlsZF9hYnNvbHV0ZV9wYXRoLAotICAgICAgICAgICAgICAgICAgICAnX19YUENfRFlM
RF9GUkFNRVdPUktfUEFUSCc6IGJyb3dzZXJfYnVpbGRfYWJzb2x1dGVfcGF0aCwgJ19fWFBDX0RZ
TERfTElCUkFSWV9QQVRIJzogYnJvd3Nlcl9idWlsZF9hYnNvbHV0ZV9wYXRofQorICAgICAgICAg
ICAgICAgIGVudlsnRFlMRF9GUkFNRVdPUktfUEFUSCddID0gYnJvd3Nlcl9idWlsZF9hYnNvbHV0
ZV9wYXRoCisgICAgICAgICAgICAgICAgZW52WydEWUxEX0xJQlJBUllfUEFUSCddID0gYnJvd3Nl
cl9idWlsZF9hYnNvbHV0ZV9wYXRoCisgICAgICAgICAgICAgICAgZW52WydfX1hQQ19EWUxEX0ZS
QU1FV09SS19QQVRIJ10gPSBicm93c2VyX2J1aWxkX2Fic29sdXRlX3BhdGgKKyAgICAgICAgICAg
ICAgICBlbnZbJ19fWFBDX0RZTERfTElCUkFSWV9QQVRIJ10gPSBicm93c2VyX2J1aWxkX2Fic29s
dXRlX3BhdGgKICAgICAgICAgICAgIGVsaWYgbm90IGhhc19zYWZhcmlfYXBwOgogICAgICAgICAg
ICAgICAgIHJhaXNlIEV4Y2VwdGlvbignQ291bGQgbm90IGZpbmQgYW55IGZyYW1ld29yayAie30i
Jy5mb3JtYXQoYnJvd3Nlcl9idWlsZF9wYXRoKSkKIAo=
</data>
<flag name="review"
          id="448678"
          type_id="1"
          status="+"
          setter="slewis"
    />
    <flag name="commit-queue"
          id="448679"
          type_id="3"
          status="-"
          setter="fpizlo"
    />
          </attachment>
      

    </bug>

</bugzilla>