<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>225472</bug_id>
          
          <creation_ts>2021-05-06 11:38:30 -0700</creation_ts>
          <short_desc>Make some things easier to dataLog in wasm</short_desc>
          <delta_ts>2021-05-06 13:57:14 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>JavaScriptCore</component>
          <version>Other</version>
          <rep_platform>All</rep_platform>
          <op_sys>All</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Filip Pizlo">fpizlo</reporter>
          <assigned_to name="Filip Pizlo">fpizlo</assigned_to>
          <cc>ews-watchlist</cc>
    
    <cc>keith_miller</cc>
    
    <cc>mark.lam</cc>
    
    <cc>msaboff</cc>
    
    <cc>saam</cc>
    
    <cc>tzagallo</cc>
    
    <cc>webkit-bug-importer</cc>
    
    <cc>ysuzuki</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1757537</commentid>
    <comment_count>0</comment_count>
    <who name="Filip Pizlo">fpizlo</who>
    <bug_when>2021-05-06 11:38:30 -0700</bug_when>
    <thetext>...</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1757538</commentid>
    <comment_count>1</comment_count>
      <attachid>427913</attachid>
    <who name="Filip Pizlo">fpizlo</who>
    <bug_when>2021-05-06 11:39:47 -0700</bug_when>
    <thetext>Created attachment 427913
da patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1757576</commentid>
    <comment_count>2</comment_count>
      <attachid>427913</attachid>
    <who name="Yusuke Suzuki">ysuzuki</who>
    <bug_when>2021-05-06 12:47:29 -0700</bug_when>
    <thetext>Comment on attachment 427913
da patch

r=me</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1757617</commentid>
    <comment_count>3</comment_count>
    <who name="EWS">ews-feeder</who>
    <bug_when>2021-05-06 13:43:26 -0700</bug_when>
    <thetext>Creating invalid ChangeLogEntry:

Traceback (most recent call last):
  File &quot;Tools/Scripts/webkit-patch&quot;, line 80, in &lt;module&gt;
    main()
  File &quot;Tools/Scripts/webkit-patch&quot;, line 75, in main
    WebKitPatch(os.path.abspath(__file__)).main()
  File &quot;/Volumes/Data/worker/Commit-Queue/build/Tools/Scripts/webkitpy/tool/multicommandtool.py&quot;, line 305, in main
    result = command.check_arguments_and_execute(options, args, self)
  File &quot;/Volumes/Data/worker/Commit-Queue/build/Tools/Scripts/webkitpy/tool/multicommandtool.py&quot;, line 123, in check_arguments_and_execute
    return self.execute(options, args, tool) or 0
  File &quot;/Volumes/Data/worker/Commit-Queue/build/Tools/Scripts/webkitpy/tool/commands/abstractsequencedcommand.py&quot;, line 55, in execute
    self._sequence.run_and_handle_errors(tool, options, state)
  File &quot;/Volumes/Data/worker/Commit-Queue/build/Tools/Scripts/webkitpy/tool/commands/stepsequence.py&quot;, line 73, in run_and_handle_errors
    self._run(tool, options, state)
  File &quot;/Volumes/Data/worker/Commit-Queue/build/Tools/Scripts/webkitpy/tool/commands/stepsequence.py&quot;, line 67, in _run
    step(tool, options).run(state)
  File &quot;/Volumes/Data/worker/Commit-Queue/build/Tools/Scripts/webkitpy/tool/steps/validatereviewer.py&quot;, line 52, in run
    changelog_entry = ChangeLog(changelog_path).latest_entry()
  File &quot;/Volumes/Data/worker/Commit-Queue/build/Tools/Scripts/webkitpy/common/checkout/changelog.py&quot;, line 377, in latest_entry
    return self.parse_latest_entry_from_file(changelog_file)
  File &quot;/Volumes/Data/worker/Commit-Queue/build/Tools/Scripts/webkitpy/common/checkout/changelog.py&quot;, line 323, in parse_latest_entry_from_file
    return next(cls.parse_entries_from_file(changelog_file))
  File &quot;/Volumes/Data/worker/Commit-Queue/build/Tools/Scripts/webkitpy/common/checkout/changelog.py&quot;, line 362, in parse_entries_from_file
    yield ChangeLogEntry(&apos;&apos;.join(entry_lines[:-1]), revision=most_probable_revision)
  File &quot;/Volumes/Data/worker/Commit-Queue/build/Tools/Scripts/webkitpy/common/checkout/changelog.py&quot;, line 112, in __init__
    self._parse_entry()
  File &quot;/Volumes/Data/worker/Commit-Queue/build/Tools/Scripts/webkitpy/common/checkout/changelog.py&quot;, line 220, in _parse_entry
    self._date_line = match.group()
AttributeError: &apos;NoneType&apos; object has no attribute &apos;group&apos;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1757627</commentid>
    <comment_count>4</comment_count>
    <who name="Filip Pizlo">fpizlo</who>
    <bug_when>2021-05-06 13:56:15 -0700</bug_when>
    <thetext>Landed in https://trac.webkit.org/changeset/277118/webkit</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1757629</commentid>
    <comment_count>5</comment_count>
    <who name="Radar WebKit Bug Importer">webkit-bug-importer</who>
    <bug_when>2021-05-06 13:57:14 -0700</bug_when>
    <thetext>&lt;rdar://problem/77623806&gt;</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>427913</attachid>
            <date>2021-05-06 11:39:47 -0700</date>
            <delta_ts>2021-05-06 13:43:27 -0700</delta_ts>
            <desc>da patch</desc>
            <filename>memorymodedump.patch</filename>
            <type>text/plain</type>
            <size>4431</size>
            <attacher name="Filip Pizlo">fpizlo</attacher>
            
              <data encoding="base64">SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291
cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMjc2ODU4KQorKysgU291cmNl
L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwwICsxLDE0IEBA
CisyMDIxLTA1LTA2ICBGaWxpcCBQaXpsbyAgPGZwaXpsb0BhcHBsZS5jb20+CisKKyAgICAgICAg
TWFrZSBzb21lIHRoaW5ncyBlYXNpZXIgdG8gZGF0YUxvZyBpbiB3YXNtCisgICAgICAgIGh0dHBz
Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMjU0NzIKKworICAgICAgICBSZXZp
ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIHdhc20vV2FzbU1lbW9yeU1vZGUu
Y3BwOgorICAgICAgICAoV1RGOjpwcmludEludGVybmFsKToKKyAgICAgICAgKiB3YXNtL1dhc21N
ZW1vcnlNb2RlLmg6CisgICAgICAgICogd2FzbS9XYXNtV29ya2xpc3QuY3BwOgorICAgICAgICAo
SlNDOjpXYXNtOjpXb3JrbGlzdDo6ZHVtcCBjb25zdCk6CisgICAgICAgICogd2FzbS9XYXNtV29y
a2xpc3QuaDoKKwpJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL3dhc20vV2FzbU1lbW9yeU1v
ZGUuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS93YXNtL1dhc21NZW1v
cnlNb2RlLmNwcAkocmV2aXNpb24gMjc2ODU3KQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL3dh
c20vV2FzbU1lbW9yeU1vZGUuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0xLDUgKzEsNSBAQAogLyoK
LSAqIENvcHlyaWdodCAoQykgMjAxNi0yMDE3IEFwcGxlIEluYy4gQWxsIHJpZ2h0cyByZXNlcnZl
ZC4KKyAqIENvcHlyaWdodCAoQykgMjAxNi0yMDIxIEFwcGxlIEluYy4gQWxsIHJpZ2h0cyByZXNl
cnZlZC4KICAqCiAgKiBSZWRpc3RyaWJ1dGlvbiBhbmQgdXNlIGluIHNvdXJjZSBhbmQgYmluYXJ5
IGZvcm1zLCB3aXRoIG9yIHdpdGhvdXQKICAqIG1vZGlmaWNhdGlvbiwgYXJlIHBlcm1pdHRlZCBw
cm92aWRlZCB0aGF0IHRoZSBmb2xsb3dpbmcgY29uZGl0aW9ucwpAQCAtMjksNiArMjksNyBAQAog
I2lmIEVOQUJMRShXRUJBU1NFTUJMWSkKIAogI2luY2x1ZGUgPHd0Zi9Bc3NlcnRpb25zLmg+Cisj
aW5jbHVkZSA8d3RmL1ByaW50U3RyZWFtLmg+CiAKIG5hbWVzcGFjZSBKU0MgeyBuYW1lc3BhY2Ug
V2FzbSB7CiAKQEAgLTU0LDQgKzU1LDE4IEBAIGNvbnN0IGNoYXIqIG1ha2VTdHJpbmcoTWVtb3J5
U2hhcmluZ01vZGUKIAogfSB9IC8vIG5hbWVzcGFjZSBKU0M6Oldhc20KIAorbmFtZXNwYWNlIFdU
RiB7CisKK3ZvaWQgcHJpbnRJbnRlcm5hbChQcmludFN0cmVhbSYgb3V0LCBKU0M6Oldhc206Ok1l
bW9yeU1vZGUgbW9kZSkKK3sKKyAgICBvdXQucHJpbnQoSlNDOjpXYXNtOjptYWtlU3RyaW5nKG1v
ZGUpKTsKK30KKwordm9pZCBwcmludEludGVybmFsKFByaW50U3RyZWFtJiBvdXQsIEpTQzo6V2Fz
bTo6TWVtb3J5U2hhcmluZ01vZGUgbW9kZSkKK3sKKyAgICBvdXQucHJpbnQoSlNDOjpXYXNtOjpt
YWtlU3RyaW5nKG1vZGUpKTsKK30KKworfSAvLyBuYW1lc3BhY2UgV1RGCisKICNlbmRpZiAvLyBF
TkFCTEUoV0VCQVNTRU1CTFkpCkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvd2FzbS9XYXNt
TWVtb3J5TW9kZS5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS93YXNtL1dh
c21NZW1vcnlNb2RlLmgJKHJldmlzaW9uIDI3Njg1NykKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29y
ZS93YXNtL1dhc21NZW1vcnlNb2RlLmgJKHdvcmtpbmcgY29weSkKQEAgLTEsNSArMSw1IEBACiAv
KgotICogQ29weXJpZ2h0IChDKSAyMDE3IEFwcGxlIEluYy4gQWxsIHJpZ2h0cyByZXNlcnZlZC4K
KyAqIENvcHlyaWdodCAoQykgMjAxNy0yMDIxIEFwcGxlIEluYy4gQWxsIHJpZ2h0cyByZXNlcnZl
ZC4KICAqCiAgKiBSZWRpc3RyaWJ1dGlvbiBhbmQgdXNlIGluIHNvdXJjZSBhbmQgYmluYXJ5IGZv
cm1zLCB3aXRoIG9yIHdpdGhvdXQKICAqIG1vZGlmaWNhdGlvbiwgYXJlIHBlcm1pdHRlZCBwcm92
aWRlZCB0aGF0IHRoZSBmb2xsb3dpbmcgY29uZGl0aW9ucwpAQCAtNDksNCArNDksMTIgQEAgSlNf
RVhQT1JUX1BSSVZBVEUgY29uc3QgY2hhciogbWFrZVN0cmluZwogCiB9IH0gLy8gbmFtZXNwYWNl
IEpTQzo6V2FzbQogCituYW1lc3BhY2UgV1RGIHsKKworY2xhc3MgUHJpbnRTdHJlYW07Cit2b2lk
IHByaW50SW50ZXJuYWwoUHJpbnRTdHJlYW0mLCBKU0M6Oldhc206Ok1lbW9yeU1vZGUpOwordm9p
ZCBwcmludEludGVybmFsKFByaW50U3RyZWFtJiwgSlNDOjpXYXNtOjpNZW1vcnlTaGFyaW5nTW9k
ZSk7CisKK30gLy8gbmFtZXNwYWNlIFdURgorCiAjZW5kaWYgLy8gRU5BQkxFKFdFQkFTU0VNQkxZ
KQpJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL3dhc20vV2FzbVdvcmtsaXN0LmNwcAo9PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvd2FzbS9XYXNtV29ya2xpc3QuY3BwCShy
ZXZpc2lvbiAyNzY4NTcpCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvd2FzbS9XYXNtV29ya2xp
c3QuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0xLDUgKzEsNSBAQAogLyoKLSAqIENvcHlyaWdodCAo
QykgMjAxNy0yMDE5IEFwcGxlIEluYy4gQWxsIHJpZ2h0cyByZXNlcnZlZC4KKyAqIENvcHlyaWdo
dCAoQykgMjAxNy0yMDIxIEFwcGxlIEluYy4gQWxsIHJpZ2h0cyByZXNlcnZlZC4KICAqCiAgKiBS
ZWRpc3RyaWJ1dGlvbiBhbmQgdXNlIGluIHNvdXJjZSBhbmQgYmluYXJ5IGZvcm1zLCB3aXRoIG9y
IHdpdGhvdXQKICAqIG1vZGlmaWNhdGlvbiwgYXJlIHBlcm1pdHRlZCBwcm92aWRlZCB0aGF0IHRo
ZSBmb2xsb3dpbmcgY29uZGl0aW9ucwpAQCAtNDksNiArNDksMTEgQEAgY29uc3QgY2hhciogV29y
a2xpc3Q6OnByaW9yaXR5U3RyaW5nKFByaQogICAgIFJFTEVBU0VfQVNTRVJUX05PVF9SRUFDSEVE
KCk7CiB9CiAKK3ZvaWQgV29ya2xpc3Q6OmR1bXAoUHJpbnRTdHJlYW0mIG91dCkgY29uc3QKK3sK
KyAgICBvdXQucHJpbnQoIlF1ZXVlIFNpemUgPSAiLCBtX3F1ZXVlLnNpemUoKSk7Cit9CisKIC8v
IFRoZSBUaHJlYWQgY2xhc3MgaXMgZGVzaWduZWQgdG8gcHJldmVudCB0aHJlYWRzIGZyb20gYmxv
Y2tpbmcgd2hlbiB0aGVyZSBpcyBzdGlsbCB3b3JrCiAvLyBpbiB0aGUgcXVldWUuIFdhc20ncyBQ
bGFucyBoYXZlIHNvbWUgcGhhc2VzLCBWYWxpZGlhdGlvbiwgUHJlcGFyYXRpb24sIGFuZCBDb21w
bGV0aW9uLAogLy8gdGhhdCBjYW4gb25seSBiZSBkb25lIGJ5IG9uZSB0aHJlYWQsIGFuZCBhbm90
aGVyIHBoYXNlLCBDb21waWxhdGlvbiwgdGhhdCBjYW4gYmUgZG9uZQpJbmRleDogU291cmNlL0ph
dmFTY3JpcHRDb3JlL3dhc20vV2FzbVdvcmtsaXN0LmgKPT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0ph
dmFTY3JpcHRDb3JlL3dhc20vV2FzbVdvcmtsaXN0LmgJKHJldmlzaW9uIDI3Njg1NykKKysrIFNv
dXJjZS9KYXZhU2NyaXB0Q29yZS93YXNtL1dhc21Xb3JrbGlzdC5oCSh3b3JraW5nIGNvcHkpCkBA
IC0xLDUgKzEsNSBAQAogLyoKLSAqIENvcHlyaWdodCAoQykgMjAxNyBBcHBsZSBJbmMuIEFsbCBy
aWdodHMgcmVzZXJ2ZWQuCisgKiBDb3B5cmlnaHQgKEMpIDIwMTctMjAyMSBBcHBsZSBJbmMuIEFs
bCByaWdodHMgcmVzZXJ2ZWQuCiAgKgogICogUmVkaXN0cmlidXRpb24gYW5kIHVzZSBpbiBzb3Vy
Y2UgYW5kIGJpbmFyeSBmb3Jtcywgd2l0aCBvciB3aXRob3V0CiAgKiBtb2RpZmljYXRpb24sIGFy
ZSBwZXJtaXR0ZWQgcHJvdmlkZWQgdGhhdCB0aGUgZm9sbG93aW5nIGNvbmRpdGlvbnMKQEAgLTMw
LDYgKzMwLDcgQEAKICNpbmNsdWRlIDxxdWV1ZT4KIAogI2luY2x1ZGUgPHd0Zi9BdXRvbWF0aWNU
aHJlYWQuaD4KKyNpbmNsdWRlIDx3dGYvUHJpbnRTdHJlYW0uaD4KICNpbmNsdWRlIDx3dGYvUHJp
b3JpdHlRdWV1ZS5oPgogI2luY2x1ZGUgPHd0Zi9WZWN0b3IuaD4KIApAQCAtNTksNiArNjAsOCBA
QCBwdWJsaWM6CiAgICAgfTsKICAgICBjb25zdCBjaGFyKiBwcmlvcml0eVN0cmluZyhQcmlvcml0
eSk7CiAKKyAgICB2b2lkIGR1bXAoUHJpbnRTdHJlYW0mKSBjb25zdDsKKwogcHJpdmF0ZToKICAg
ICBjbGFzcyBUaHJlYWQ7CiAgICAgZnJpZW5kIGNsYXNzIFRocmVhZDsK
</data>
<flag name="review"
          id="448676"
          type_id="1"
          status="+"
          setter="ysuzuki"
    />
    <flag name="commit-queue"
          id="448677"
          type_id="3"
          status="-"
          setter="ews-feeder"
    />
          </attachment>
      

    </bug>

</bugzilla>