225467 2021-05-06 09:59:29 -0700 REGRESSION (Safari 14): Submenus on https://codelearn.cat don't show 2021-06-22 11:33:35 -0700 1 1 1 Unclassified WebKit Layout and Rendering Safari Technology Preview Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 simon.fraser simon.fraser bfulgham changseok esprehn+autocc ews-watchlist glenn kondapallykalyan ntim pdr simon.fraser webkit-bug-importer zalan zimmermann oldest_to_newest 1757476 0 simon.fraser 2021-05-06 09:59:29 -0700 Hover the menus on https://codelearn.cat: hover "Centres" then "Barcelona" and the hover menus fail to appear. To reproduce, your window needs to be short enough for the longer menus to scroll. 1757477 1 webkit-bug-importer 2021-05-06 10:00:21 -0700 <rdar://problem/77612276> 1757478 2 simon.fraser 2021-05-06 10:00:32 -0700 Probably related to async overflow scroll and compositing. 1767905 3 simon.fraser 2021-06-08 14:20:37 -0700 This might be fallout from the RenderLayer/ScrollableArea split. There's a composited layer with overflow:scroll, and overflow is being toggled to 'visible'. We fail to remove the compositing clipping layer, so the content remains clipped. This is happening because RenderBox::requiresLayerWithScrollableArea() is called from RenderLayer::styleChanged() (i.e. before layout) but it consults hasHorizontalOverflow() || hasVerticalOverflow() which depend on layout. 1767906 4 simon.fraser 2021-06-08 14:21:03 -0700 We also never remove the RenderLayerScrollableArea and it seems like we should. 1768238 5 430979 simon.fraser 2021-06-09 10:55:29 -0700 Created attachment 430979 Patch 1771731 6 ews-feeder 2021-06-22 11:33:32 -0700 Committed r279130 (239044@main): <https://commits.webkit.org/239044@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 430979. 430979 2021-06-09 10:55:29 -0700 2021-06-22 11:33:33 -0700 Patch bug-225467-20210609105528.patch text/plain 6138 simon.fraser U3VidmVyc2lvbiBSZXZpc2lvbjogMjc4NjY0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOTE4ZjQ1NDkzYWYyOWU4 ZjdjNzAzOWRiMzNjMWU4MTM0MDJmOTI5OC4uNTc1M2FiZDNhNDM3YTNkOTg2ODFhMzIxZjk4M2Fi MzMxMzdlMmY0ZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI4IEBACisyMDIxLTA2LTA5ICBTaW1v biBGcmFzZXIgIDxzaW1vbi5mcmFzZXJAYXBwbGUuY29tPgorCisgICAgICAgIFJFR1JFU1NJT04g KFNhZmFyaSAxNCk6IFN1Ym1lbnVzIG9uIGh0dHBzOi8vY29kZWxlYXJuLmNhdCBkb24ndCBzaG93 CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMjU0NjcK KyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzc3NjEyMjc2PgorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorICAgICAgICAKKyAgICAgICAgUmVuZGVyQm94OjpyZXF1aXJlc0xh eWVyV2l0aFNjcm9sbGFibGVBcmVhKCkgaXMgY2FsbGVkIHZpYSBSZW5kZXJMYXllcjo6c3R5bGVD aGFuZ2VkKCkKKyAgICAgICAgd2hpY2ggaXMgYmVmb3JlIGxheW91dCwgeWV0IHJlcXVpcmVzTGF5 ZXJXaXRoU2Nyb2xsYWJsZUFyZWEoKSB3YXMgY29uc3VsdGluZyBsYXlvdXQtZGVwZW5kZW50Cisg ICAgICAgIHN0YXRlIHVuZGVyIGhhc0hvcml6b250YWxPdmVyZmxvdygpIHx8IGhhc1ZlcnRpY2Fs T3ZlcmZsb3coKS4gVGhpcyByZXN1bHRlZCBpbiBjb21wb3NpdGVkCisgICAgICAgIHNjcm9sbGlu ZyBsYXllcnMgc3RpY2tpbmcgYXJvdW5kIGFmdGVyIG92ZXJmbG93IHN0eWxlIGNoYW5nZWQgZnJv bSBgc2Nyb2xsYCB0byBgdmlzaWJsZWAuCisKKyAgICAgICAgRml4IGJ5IGp1c3QgcmVtb3Zpbmcg dGhlICJoYXMgb3ZlcmZsb3ciIGNoZWNrczsgd2UgbWFrZSBSZW5kZXJMYXllclNjcm9sbGFibGVB cmVhCisgICAgICAgIGZvciBhbnkgbm9uLXZpc2libGUgb3ZlcmZsb3cgYW55d2F5LiBzY3JvbGxz T3ZlcmZsb3coKSBjaGVja3MgaGFzT3ZlcmZsb3dDbGlwKCksCisgICAgICAgIHNvIGFsbCB3ZSBu ZWVkIGlzIGEgaGFzT3ZlcmZsb3dDbGlwKCkgY2hlY2suCisKKyAgICAgICAgUmVtb3ZlIHNvbWUg cmVkdW5kYW50IGNvbW1lbnRzIGFuZCBhZGQgYSBGSVhNRSBhYm91dCBsYXllcnMgd2hpY2ggZ2V0 IFJlbmRlckxheWVyU2Nyb2xsYWJsZUFyZWFzCisgICAgICAgIGJ1dCBkb24ndCBuZWVkIHRoZW0u CisKKyAgICAgICAgVGVzdDogY29tcG9zaXRpbmcvb3ZlcmZsb3cvb3ZlcmZsb3ctc2Nyb2xsLXRv LXZpc2libGUuaHRtbAorCisgICAgICAgICogcmVuZGVyaW5nL1JlbmRlckJveC5jcHA6CisgICAg ICAgIChXZWJDb3JlOjpSZW5kZXJCb3g6OnJlcXVpcmVzTGF5ZXJXaXRoU2Nyb2xsYWJsZUFyZWEg Y29uc3QpOgorCiAyMDIxLTA2LTA5ICBTaW1vbiBGcmFzZXIgIDxzaW1vbi5mcmFzZXJAYXBwbGUu Y29tPgogCiAgICAgICAgIFVucmV2aWV3ZWQgV2luZG93cyBidWlsZCBmaXguCmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyQm94LmNwcCBiL1NvdXJjZS9XZWJDb3Jl L3JlbmRlcmluZy9SZW5kZXJCb3guY3BwCmluZGV4IDI1MDJmNzNkY2IyYzE2MjMyNTIyYmRhMTUy ZWIxNDYwNDEwNzRlZjAuLmEyYjYxMDA5OTBkZWQ1MjNmMTcxZjYyOTJlYmIxNmRhZWY4NDJjMWIg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJCb3guY3BwCisrKyBi L1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJCb3guY3BwCkBAIC05NTksMTkgKzk1OSwx NiBAQCBib29sIFJlbmRlckJveDo6aXNTY3JvbGxhYmxlT3JSdWJiZXJiYW5kYWJsZUJveCgpIGNv bnN0CiAKIGJvb2wgUmVuZGVyQm94OjpyZXF1aXJlc0xheWVyV2l0aFNjcm9sbGFibGVBcmVhKCkg Y29uc3QKIHsKLSAgICAvLyBUaGUgUmVuZGVyVmlldyBpcyBhbHdheXMgZXhwZWN0ZWQgdG8gYmUg cG90ZW50aWFsbHkgc2Nyb2xsYWJsZS4KKyAgICAvLyBGSVhNRTogVGhpcyBpcyB3cm9uZzsgdGhl c2UgYm94ZXMnIGxheWVycyBzaG91bGQgbm90IG5lZWQgU2Nyb2xsYWJsZUFyZWFzIHZpYSBSZW5k ZXJMYXllci4KICAgICBpZiAoaXNSZW5kZXJWaWV3KCkgfHwgaXNEb2N1bWVudEVsZW1lbnRSZW5k ZXJlcigpKQogICAgICAgICByZXR1cm4gdHJ1ZTsKIAotICAgIC8vIE92ZXJmbG93IGhhbmRsaW5n IG5lZWRzIFJlbmRlckxheWVyU2Nyb2xsYWJsZUFyZWEuCi0gICAgaWYgKHNjcm9sbHNPdmVyZmxv dygpIHx8IGhhc092ZXJmbG93Q2xpcCgpIHx8IGhhc0hvcml6b250YWxPdmVyZmxvdygpIHx8IGhh c1ZlcnRpY2FsT3ZlcmZsb3coKSkKKyAgICBpZiAoaGFzT3ZlcmZsb3dDbGlwKCkpCiAgICAgICAg IHJldHVybiB0cnVlOwogCi0gICAgLy8gUmVzaXplIGhhbmRsaW5nIG5lZWRzIFJlbmRlckxheWVy U2Nyb2xsYWJsZUFyZWEuCiAgICAgaWYgKHN0eWxlKCkucmVzaXplKCkgIT0gUmVzaXplOjpOb25l KQogICAgICAgICByZXR1cm4gdHJ1ZTsKIAotICAgIC8vIE1hcnF1ZWUgaGFuZGxpbmcgbmVlZHMg UmVuZGVyTGF5ZXJTY3JvbGxhYmxlQXJlYS4KICAgICBpZiAoaXNIVE1MTWFycXVlZSgpICYmIHN0 eWxlKCkubWFycXVlZUJlaGF2aW9yKCkgIT0gTWFycXVlZUJlaGF2aW9yOjpOb25lKQogICAgICAg ICByZXR1cm4gdHJ1ZTsKIApkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nIGIvTGF5 b3V0VGVzdHMvQ2hhbmdlTG9nCmluZGV4IGFiY2MyNTQ1M2I0OWU1OTI2OWI2Y2NhYjY5M2FlYWI5 MjEwY2YxNjQuLmIzNGE1NGEwZmNkMWI1NjViMWFlN2E1MGM3OTMyNWVkNjBjOWIxMWUgMTAwNjQ0 Ci0tLSBhL0xheW91dFRlc3RzL0NoYW5nZUxvZworKysgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cK QEAgLTEsMyArMSwxNCBAQAorMjAyMS0wNi0wOSAgU2ltb24gRnJhc2VyICA8c2ltb24uZnJhc2Vy QGFwcGxlLmNvbT4KKworICAgICAgICBSRUdSRVNTSU9OIChTYWZhcmkgMTQpOiBTdWJtZW51cyBv biBodHRwczovL2NvZGVsZWFybi5jYXQgZG9uJ3Qgc2hvdworICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjI1NDY3CisgICAgICAgIDxyZGFyOi8vcHJvYmxl bS83NzYxMjI3Nj4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICAqIGNvbXBvc2l0aW5nL292ZXJmbG93L292ZXJmbG93LXNjcm9sbC10by12aXNpYmxlLWV4 cGVjdGVkLmh0bWw6IEFkZGVkLgorICAgICAgICAqIGNvbXBvc2l0aW5nL292ZXJmbG93L292ZXJm bG93LXNjcm9sbC10by12aXNpYmxlLmh0bWw6IEFkZGVkLgorCiAyMDIxLTA2LTA5ICBBbGFuIEJ1 anRhcyAgPHphbGFuQGFwcGxlLmNvbT4KIAogICAgICAgICBbRmxleGJveF0gRmxleEl0ZW0gc3Rh eXMgaW52aXNpYmxlIGFmdGVyIGluaXRpYWwgbGF5b3V0CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0 cy9jb21wb3NpdGluZy9vdmVyZmxvdy9vdmVyZmxvdy1zY3JvbGwtdG8tdmlzaWJsZS1leHBlY3Rl ZC5odG1sIGIvTGF5b3V0VGVzdHMvY29tcG9zaXRpbmcvb3ZlcmZsb3cvb3ZlcmZsb3ctc2Nyb2xs LXRvLXZpc2libGUtZXhwZWN0ZWQuaHRtbApuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwLi42N2ZlMGU1YzJiMzdmODIyMDk0 MmQ5MWUwYzE2N2Y2ZDZmMTEwNDQ1Ci0tLSAvZGV2L251bGwKKysrIGIvTGF5b3V0VGVzdHMvY29t cG9zaXRpbmcvb3ZlcmZsb3cvb3ZlcmZsb3ctc2Nyb2xsLXRvLXZpc2libGUtZXhwZWN0ZWQuaHRt bApAQCAtMCwwICsxLDI5IEBACis8IURPQ1RZUEUgaHRtbD4gPCEtLSB3ZWJraXQtdGVzdC1ydW5u ZXIgWyBBc3luY092ZXJmbG93U2Nyb2xsaW5nRW5hYmxlZD10cnVlIF0gLS0+Cis8aHRtbD4KKzxo ZWFkPgorICAgIDxzdHlsZT4KKyAgICAgICAgLnNjcm9sbGVyIHsKKyAgICAgICAgICAgIGJvcmRl cjogMXB4IHNvbGlkIGJsYWNrOworICAgICAgICAgICAgbWFyZ2luOiAxMHB4OworICAgICAgICAg ICAgcGFkZGluZzogMTBweDsKKyAgICAgICAgICAgIG92ZXJmbG93OiB2aXNpYmxlOworICAgICAg ICAgICAgdHJhbnNmb3JtOiB0cmFuc2xhdGVaKDBweCk7CisgICAgICAgIH0KKyAgICAgICAgCisg ICAgICAgIC5ib3ggeworICAgICAgICAgICAgcG9zaXRpb246IGFic29sdXRlOworICAgICAgICAg ICAgd2lkdGg6IDEwMHB4OworICAgICAgICAgICAgaGVpZ2h0OiAxMDBweDsKKyAgICAgICAgICAg IGJvcmRlcjogMnB4IHNvbGlkIGJsdWU7CisgICAgICAgICAgICBiYWNrZ3JvdW5kLWNvbG9yOiBn cmVlbjsKKyAgICAgICAgICAgIHBhZGRpbmc6IDEwcHg7CisgICAgICAgIH0KKyAgICA8L3N0eWxl PgorPC9oZWFkPgorPGJvZHk+CisgICAgPGRpdiBjbGFzcz0ic2Nyb2xsZXIiPgorICAgICAgICBZ b3Ugc2hvdWxkIHNlZSB0aGUgZW50aXJlIGdyZWVuIGJveCBiZWxvdworICAgICAgICA8ZGl2IGNs YXNzPSJib3giPjwvZGl2PgorICAgIDwvZGl2PgorPC9ib2R5PgorPC9odG1sPgpkaWZmIC0tZ2l0 IGEvTGF5b3V0VGVzdHMvY29tcG9zaXRpbmcvb3ZlcmZsb3cvb3ZlcmZsb3ctc2Nyb2xsLXRvLXZp c2libGUuaHRtbCBiL0xheW91dFRlc3RzL2NvbXBvc2l0aW5nL292ZXJmbG93L292ZXJmbG93LXNj cm9sbC10by12aXNpYmxlLmh0bWwKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMC4uOGFmNTdlZmJlMzRmYzk4YjA5YjY4Yzdl OWEzZmI0MmIwZDk0YmMyMQotLS0gL2Rldi9udWxsCisrKyBiL0xheW91dFRlc3RzL2NvbXBvc2l0 aW5nL292ZXJmbG93L292ZXJmbG93LXNjcm9sbC10by12aXNpYmxlLmh0bWwKQEAgLTAsMCArMSw0 NSBAQAorPCFET0NUWVBFIGh0bWw+IDwhLS0gd2Via2l0LXRlc3QtcnVubmVyIFsgQXN5bmNPdmVy Zmxvd1Njcm9sbGluZ0VuYWJsZWQ9dHJ1ZSBdIC0tPgorPGh0bWw+Cis8aGVhZD4KKyAgICA8c3R5 bGU+CisgICAgICAgIC5zY3JvbGxlciB7CisgICAgICAgICAgICBib3JkZXI6IDFweCBzb2xpZCBi bGFjazsKKyAgICAgICAgICAgIG1hcmdpbjogMTBweDsKKyAgICAgICAgICAgIHBhZGRpbmc6IDEw cHg7CisgICAgICAgICAgICBvdmVyZmxvdzogc2Nyb2xsOworICAgICAgICAgICAgdHJhbnNmb3Jt OiB0cmFuc2xhdGVaKDBweCk7CisgICAgICAgIH0KKyAgICAgICAgCisgICAgICAgIC5ib3ggewor ICAgICAgICAgICAgcG9zaXRpb246IGFic29sdXRlOworICAgICAgICAgICAgd2lkdGg6IDEwMHB4 OworICAgICAgICAgICAgaGVpZ2h0OiAxMDBweDsKKyAgICAgICAgICAgIGJvcmRlcjogMnB4IHNv bGlkIGJsdWU7CisgICAgICAgICAgICBiYWNrZ3JvdW5kLWNvbG9yOiBncmVlbjsKKyAgICAgICAg ICAgIHBhZGRpbmc6IDEwcHg7CisgICAgICAgIH0KKyAgICAgICAgCisgICAgICAgIGJvZHkuY2hh bmdlZCAuc2Nyb2xsZXIgeworICAgICAgICAgICAgb3ZlcmZsb3c6IHZpc2libGU7CisgICAgICAg IH0KKyAgICA8L3N0eWxlPgorICAgIDxzY3JpcHQ+CisgICAgICAgIGlmICh3aW5kb3cudGVzdFJ1 bm5lcikKKyAgICAgICAgICAgIHRlc3RSdW5uZXIud2FpdFVudGlsRG9uZSgpOworCisgICAgICAg IHdpbmRvdy5hZGRFdmVudExpc3RlbmVyKCdsb2FkJywgKCkgPT4geworICAgICAgICAgICAgcmVx dWVzdEFuaW1hdGlvbkZyYW1lKCgpID0+IHsKKyAgICAgICAgICAgICAgICBkb2N1bWVudC5ib2R5 LmNsYXNzTGlzdC5hZGQoJ2NoYW5nZWQnKTsKKyAgICAgICAgICAgICAgICBpZiAod2luZG93LnRl c3RSdW5uZXIpCisgICAgICAgICAgICAgICAgICAgIHRlc3RSdW5uZXIubm90aWZ5RG9uZSgpOwor ICAgICAgICAgICAgfSk7CisgICAgICAgIH0sIGZhbHNlKTsKKyAgICA8L3NjcmlwdD4KKzwvaGVh ZD4KKzxib2R5PgorICAgIDxkaXYgY2xhc3M9InNjcm9sbGVyIj4KKyAgICAgICAgWW91IHNob3Vs ZCBzZWUgdGhlIGVudGlyZSBncmVlbiBib3ggYmVsb3cKKyAgICAgICAgPGRpdiBjbGFzcz0iYm94 Ij48L2Rpdj4KKyAgICA8L2Rpdj4KKzwvYm9keT4KKzwvaHRtbD4K