225454 2021-05-06 06:41:38 -0700 [GStreamer] Fallback to texture mapper video orientation handling when glvideoflip is not available 2021-05-06 08:39:11 -0700 1 1 1 Unclassified WebKit Platform WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=225456 InRadar P2 Normal --- 1 pnormand pnormand aperez calvaris cgarcia eric.carlson ews-watchlist glenn gustavo jer.noble menard nina philipj sergio vjaquez webkit-bug-importer oldest_to_newest 1757386 0 pnormand 2021-05-06 06:41:38 -0700 . 1757392 1 427882 pnormand 2021-05-06 07:06:52 -0700 Created attachment 427882 Patch 1757395 2 nina 2021-05-06 07:28:49 -0700 confirmed working here 1757401 3 aperez 2021-05-06 07:50:47 -0700 Patch looked reasonable to me, so it's great that someone with more multimedia experience like Xabier r+'d this (thanks!) — I will get this backported to the 2.32 release branch as soon as it lands on trunk :) 1757406 4 ews-feeder 2021-05-06 08:04:27 -0700 Committed r277088 (237391@main): <https://commits.webkit.org/237391@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 427882. 1757407 5 webkit-bug-importer 2021-05-06 08:05:19 -0700 <rdar://problem/77606997> 1757410 6 calvaris 2021-05-06 08:15:22 -0700 (In reply to Adrian Perez from comment #3) > Patch looked reasonable to me, so it's great that someone with more > multimedia experience like Xabier r+'d this (thanks!) — I will get > this backported to the 2.32 release branch as soon as it lands on > trunk :) I'm as "fast finger". 1757418 7 aperez 2021-05-06 08:39:11 -0700 (In reply to Xabier Rodríguez Calvar from comment #6) > (In reply to Adrian Perez from comment #3) > > Patch looked reasonable to me, so it's great that someone with more > > multimedia experience like Xabier r+'d this (thanks!) — I will get > > this backported to the 2.32 release branch as soon as it lands on > > trunk :) > > I'm as "fast finger". …aaand this is now in the 2.32 release branch as r277090 =) 427882 2021-05-06 07:06:52 -0700 2021-05-06 08:04:29 -0700 Patch bug-225454-20210506070651.patch text/plain 5859 pnormand U3VidmVyc2lvbiBSZXZpc2lvbjogMjc3MDgwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZDc0ZTQ0ZTNkOThlOWY3 ZTFiZmY0MzFiYzA3MmY2ZTFlMzEzYmU0My4uOGQ3NDgwMjhiMGYzMDRiM2E3YmUzY2ZmZGE0ZmQ0 ZWI5ZTk5NzcxMCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIzIEBACisyMDIxLTA1LTA2ICBQaGls aXBwZSBOb3JtYW5kICA8cG5vcm1hbmRAaWdhbGlhLmNvbT4KKworICAgICAgICBbR1N0cmVhbWVy XSBGYWxsYmFjayB0byB0ZXh0dXJlIG1hcHBlciB2aWRlbyBvcmllbnRhdGlvbiBoYW5kbGluZyB3 aGVuIGdsdmlkZW9mbGlwIGlzIG5vdCBhdmFpbGFibGUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIyNTQ1NAorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgIHIyNzU0MTIgaW50cm9kdWNlZCBhIG5ldyBydW50aW1l IGRlcGVuZGVuY3kgb24gZ3N0LXBsdWdpbnMtZ29vZCdzIGdsdmlkZW9mbGlwIGVsZW1lbnQsIHdo aWNoCisgICAgICAgIGlzIG5vdCBkZXNpcmFibGUgZm9yIHRoZSAyLjMyIGJyYW5jaC4gVGhpcyBw YXRjaCBsZXQncyB0aGUgcGxheWVyIGhhbmRsZSByb3RhdGlvbiB0YWdzIGlmCisgICAgICAgIHRo ZSBnbHZpZGVvZmxpcCBlbGVtZW50IHdhc24ndCBmb3VuZCBhdCBydW50aW1lLiBJZGVhbGx5IHdl IHNob3VsZCBwcm9iYWJseSBub3QgcmVseSBvbgorICAgICAgICBnbHZpZGVvZmxpcCBpbiB0aGUg Zmlyc3QgcGxhY2UgYXMgaXQgbWlnaHQgaW5kdWNlIGEgcGVyZm9ybWFuY2UgaW1wYWN0LCB0byBi ZSBoYW5kbGVkIGluIGEKKyAgICAgICAgZm9sbG93LXVwIHBhdGNoLgorCisgICAgICAgICogcGxh dGZvcm0vZ3JhcGhpY3MvZ3N0cmVhbWVyL0dMVmlkZW9TaW5rR1N0cmVhbWVyLmNwcDoKKyAgICAg ICAgKHdlYktpdEdMVmlkZW9TaW5rQ29uc3RydWN0ZWQpOgorICAgICAgICAod2ViS2l0R0xWaWRl b1NpbmtHZXRQcm9wZXJ0eSk6CisgICAgICAgICh3ZWJraXRfZ2xfdmlkZW9fc2lua19jbGFzc19p bml0KToKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9nc3RyZWFtZXIvTWVkaWFQbGF5ZXJQ cml2YXRlR1N0cmVhbWVyLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6Ok1lZGlhUGxheWVyUHJpdmF0 ZUdTdHJlYW1lcjo6Y3JlYXRlVmlkZW9TaW5rR0wpOgorCiAyMDIxLTA1LTA2ICBQaGlsaXBwZSBO b3JtYW5kICA8cG5vcm1hbmRAaWdhbGlhLmNvbT4KIAogICAgICAgICBSRUdSRVNTSU9OKHIyNzEz NDEpOiBtZWRpYS9tZWRpYS1mdWxsc2NyZWVuLWlubGluZS5odG1sIHRpbWVzIG91dCBvbiBHVEsK ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2dzdHJlYW1lci9H TFZpZGVvU2lua0dTdHJlYW1lci5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGlj cy9nc3RyZWFtZXIvR0xWaWRlb1NpbmtHU3RyZWFtZXIuY3BwCmluZGV4IGQ1MGM3OGE2ZjBhNGJl ZjYxNTg1MjUyNDM5Y2ZlM2VjODFjNmYzMWYuLmZmNjhiYTQ5ZTQ3MDJkYTllODE5MTgzNDk1MmVh NWRkODhhNzU3ZTAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNz L2dzdHJlYW1lci9HTFZpZGVvU2lua0dTdHJlYW1lci5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUv cGxhdGZvcm0vZ3JhcGhpY3MvZ3N0cmVhbWVyL0dMVmlkZW9TaW5rR1N0cmVhbWVyLmNwcApAQCAt NDAsMTIgKzQwLDE0IEBAIHVzaW5nIG5hbWVzcGFjZSBXZWJDb3JlOwogZW51bSB7CiAgICAgUFJP UF8wLAogICAgIFBST1BfU1RBVFMsCisgICAgUFJPUF9IQU5ETEVTX1JPVEFUSU9OX1RBR1MsCiAg ICAgUFJPUF9MQVNUCiB9OwogCiBzdHJ1Y3QgX1dlYktpdEdMVmlkZW9TaW5rUHJpdmF0ZSB7CiAg ICAgR1JlZlB0cjxHc3RFbGVtZW50PiBhcHBTaW5rOwogICAgIE1lZGlhUGxheWVyUHJpdmF0ZUdT dHJlYW1lciogbWVkaWFQbGF5ZXJQcml2YXRlOworICAgIGJvb2wgaGFuZGxlc1JvdGF0aW9uVGFn czsKIH07CiAKIEdTVF9ERUJVR19DQVRFR09SWV9TVEFUSUMod2Via2l0X2dsX3ZpZGVvX3Npbmtf ZGVidWcpOwpAQCAtODEsMTMgKzgzLDE4IEBAIHN0YXRpYyB2b2lkIHdlYktpdEdMVmlkZW9TaW5r Q29uc3RydWN0ZWQoR09iamVjdCogb2JqZWN0KQogCiAgICAgR3N0RWxlbWVudCogdXBsb2FkID0g Z3N0X2VsZW1lbnRfZmFjdG9yeV9tYWtlKCJnbHVwbG9hZCIsIG51bGxwdHIpOwogICAgIEdzdEVs ZW1lbnQqIGNvbG9yY29udmVydCA9IGdzdF9lbGVtZW50X2ZhY3RvcnlfbWFrZSgiZ2xjb2xvcmNv bnZlcnQiLCBudWxscHRyKTsKKwogICAgIEdzdEVsZW1lbnQqIHZpZGVvRmxpcCA9IGdzdF9lbGVt ZW50X2ZhY3RvcnlfbWFrZSgiZ2x2aWRlb2ZsaXAiLCBudWxscHRyKTsKLSAgICBnc3RfdXRpbF9z ZXRfb2JqZWN0X2FyZyhHX09CSkVDVCh2aWRlb0ZsaXApLCAibWV0aG9kIiwgImF1dG9tYXRpYyIp OworICAgIHNpbmstPnByaXYtPmhhbmRsZXNSb3RhdGlvblRhZ3MgPSB2aWRlb0ZsaXA7CisKKyAg ICBpZiAodmlkZW9GbGlwKSB7CisgICAgICAgIGdzdF91dGlsX3NldF9vYmplY3RfYXJnKEdfT0JK RUNUKHZpZGVvRmxpcCksICJtZXRob2QiLCAiYXV0b21hdGljIik7CisgICAgICAgIGdzdF9iaW5f YWRkKEdTVF9CSU5fQ0FTVChzaW5rKSwgdmlkZW9GbGlwKTsKKyAgICB9CiAKICAgICBBU1NFUlQo dXBsb2FkKTsKICAgICBBU1NFUlQoY29sb3Jjb252ZXJ0KTsKLSAgICBBU1NFUlQodmlkZW9GbGlw KTsKLSAgICBnc3RfYmluX2FkZF9tYW55KEdTVF9CSU5fQ0FTVChzaW5rKSwgdXBsb2FkLCBjb2xv cmNvbnZlcnQsIHZpZGVvRmxpcCwgc2luay0+cHJpdi0+YXBwU2luay5nZXQoKSwgbnVsbHB0cik7 CisgICAgZ3N0X2Jpbl9hZGRfbWFueShHU1RfQklOX0NBU1Qoc2luayksIHVwbG9hZCwgY29sb3Jj b252ZXJ0LCBzaW5rLT5wcml2LT5hcHBTaW5rLmdldCgpLCBudWxscHRyKTsKIAogICAgIC8vIFdv cmthcm91bmQgdW50aWwgd2UgY2FuIGRlcGVuZCBvbiBHU3RyZWFtZXIgMS4xNi4yLgogICAgIC8v IGh0dHBzOi8vZ2l0bGFiLmZyZWVkZXNrdG9wLm9yZy9nc3RyZWFtZXIvZ3N0LXBsdWdpbnMtYmFz ZS9jb21taXQvOGQzMmRlMDkwNTU0Y2YyOWZlMzU5ZjgzYWE0NjAwMGJhNjU4YTY5MwpAQCAtMTEz LDcgKzEyMCwxMiBAQCBzdGF0aWMgdm9pZCB3ZWJLaXRHTFZpZGVvU2lua0NvbnN0cnVjdGVkKEdP YmplY3QqIG9iamVjdCkKIAogICAgIGlmIChpbXhWaWRlb0NvbnZlcnRHMkQpCiAgICAgICAgIGdz dF9lbGVtZW50X2xpbmsoaW14VmlkZW9Db252ZXJ0RzJELCB1cGxvYWQpOwotICAgIGdzdF9lbGVt ZW50X2xpbmtfbWFueSh1cGxvYWQsIGNvbG9yY29udmVydCwgdmlkZW9GbGlwLCBzaW5rLT5wcml2 LT5hcHBTaW5rLmdldCgpLCBudWxscHRyKTsKKyAgICBnc3RfZWxlbWVudF9saW5rKHVwbG9hZCwg Y29sb3Jjb252ZXJ0KTsKKworICAgIGlmICh2aWRlb0ZsaXApCisgICAgICAgIGdzdF9lbGVtZW50 X2xpbmtfbWFueShjb2xvcmNvbnZlcnQsIHZpZGVvRmxpcCwgc2luay0+cHJpdi0+YXBwU2luay5n ZXQoKSwgbnVsbHB0cik7CisgICAgZWxzZQorICAgICAgICBnc3RfZWxlbWVudF9saW5rKGNvbG9y Y29udmVydCwgc2luay0+cHJpdi0+YXBwU2luay5nZXQoKSk7CiAKICAgICBHc3RFbGVtZW50KiBz aW5rRWxlbWVudCA9CiAgICAgICAgIFsmXSB7CkBAIC0yMTAsNiArMjIyLDkgQEAgc3RhdGljIHZv aWQgd2ViS2l0R0xWaWRlb1NpbmtHZXRQcm9wZXJ0eShHT2JqZWN0KiBvYmplY3QsIGd1aW50IHBy b3BlcnR5SWQsIEdWYWwKICAgICAgICAgICAgIGdzdF92YWx1ZV9zZXRfc3RydWN0dXJlKHZhbHVl LCBzdGF0cy5nZXQoKSk7CiAgICAgICAgIH0KICAgICAgICAgYnJlYWs7CisgICAgY2FzZSBQUk9Q X0hBTkRMRVNfUk9UQVRJT05fVEFHUzoKKyAgICAgICAgZ192YWx1ZV9zZXRfYm9vbGVhbih2YWx1 ZSwgc2luay0+cHJpdi0+aGFuZGxlc1JvdGF0aW9uVGFncyk7CisgICAgICAgIGJyZWFrOwogICAg IGRlZmF1bHQ6CiAgICAgICAgIEdfT0JKRUNUX1dBUk5fSU5WQUxJRF9QUk9QRVJUWV9JRChvYmpl Y3QsIHByb3BlcnR5SWQsIHBhcmFtU3BlYyk7CiAgICAgICAgIFJFTEVBU0VfQVNTRVJUX05PVF9S RUFDSEVEKCk7CkBAIC0yMzIsNiArMjQ3LDkgQEAgc3RhdGljIHZvaWQgd2Via2l0X2dsX3ZpZGVv X3NpbmtfY2xhc3NfaW5pdChXZWJLaXRHTFZpZGVvU2lua0NsYXNzKiBrbGFzcykKICAgICBnX29i amVjdF9jbGFzc19pbnN0YWxsX3Byb3BlcnR5KG9iamVjdENsYXNzLCBQUk9QX1NUQVRTLCBnX3Bh cmFtX3NwZWNfYm94ZWQoInN0YXRzIiwgIlN0YXRpc3RpY3MiLAogICAgICAgICAiU2luayBTdGF0 aXN0aWNzIiwgR1NUX1RZUEVfU1RSVUNUVVJFLCBzdGF0aWNfY2FzdDxHUGFyYW1GbGFncz4oR19Q QVJBTV9SRUFEQUJMRSB8IEdfUEFSQU1fU1RBVElDX1NUUklOR1MpKSk7CiAKKyAgICBnX29iamVj dF9jbGFzc19pbnN0YWxsX3Byb3BlcnR5KG9iamVjdENsYXNzLCBQUk9QX0hBTkRMRVNfUk9UQVRJ T05fVEFHUywgZ19wYXJhbV9zcGVjX2Jvb2xlYW4oImhhbmRsZXMtcm90YXRpb24tdGFncyIsICJI YW5kbGVzIFJvdGF0aW9uIFRhZ3MiLAorICAgICAgICAiVHJ1ZSBpZiB0aGUgc2luayBpcyByZWx5 aW5nIG9uIGdsdmlkZW9mbGlwIHRvIGhhbmRsZSBmcmFtZSByb3RhdGlvbiIsIEZBTFNFLCBzdGF0 aWNfY2FzdDxHUGFyYW1GbGFncz4oR19QQVJBTV9SRUFEQUJMRSB8IEdfUEFSQU1fU1RBVElDX1NU UklOR1MpKSk7CisKICAgICBlbGVtZW50Q2xhc3MtPmNoYW5nZV9zdGF0ZSA9IEdTVF9ERUJVR19G VU5DUFRSKHdlYktpdEdMVmlkZW9TaW5rQ2hhbmdlU3RhdGUpOwogfQogCmRpZmYgLS1naXQgYS9T b3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9nc3RyZWFtZXIvTWVkaWFQbGF5ZXJQcml2 YXRlR1N0cmVhbWVyLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2dzdHJl YW1lci9NZWRpYVBsYXllclByaXZhdGVHU3RyZWFtZXIuY3BwCmluZGV4IDMwNmY3NTRlNmYyNTA0 ZTg4ZGQ2YzU2NDNlNzMxZTI4N2EyNmYyZTEuLjFkNTYwZDk2OWI2YTUxMTRiODM2YjgyNTRiMzM2 MjA5MTEwY2IzZTkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNz L2dzdHJlYW1lci9NZWRpYVBsYXllclByaXZhdGVHU3RyZWFtZXIuY3BwCisrKyBiL1NvdXJjZS9X ZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2dzdHJlYW1lci9NZWRpYVBsYXllclByaXZhdGVHU3Ry ZWFtZXIuY3BwCkBAIC0zMzY0LDYgKzMzNjQsMTEgQEAgR3N0RWxlbWVudCogTWVkaWFQbGF5ZXJQ cml2YXRlR1N0cmVhbWVyOjpjcmVhdGVWaWRlb1NpbmtHTCgpCiAgICAgR3N0RWxlbWVudCogc2lu ayA9IGdzdF9lbGVtZW50X2ZhY3RvcnlfbWFrZSgid2Via2l0Z2x2aWRlb3NpbmsiLCBudWxscHRy KTsKICAgICBBU1NFUlQoc2luayk7CiAgICAgd2ViS2l0R0xWaWRlb1NpbmtTZXRNZWRpYVBsYXll clByaXZhdGUoV0VCS0lUX0dMX1ZJREVPX1NJTksoc2luayksIHRoaXMpOworCisgICAgZ2Jvb2xl YW4gaGFuZGxlc1JvdGF0aW9uVGFnczsKKyAgICBnX29iamVjdF9nZXQoc2luaywgImhhbmRsZXMt cm90YXRpb24tdGFncyIsICZoYW5kbGVzUm90YXRpb25UYWdzLCBudWxscHRyKTsKKyAgICBtX3No b3VsZEhhbmRsZU9yaWVudGF0aW9uVGFncyA9ICFoYW5kbGVzUm90YXRpb25UYWdzOworCiAgICAg cmV0dXJuIHNpbms7CiB9CiAjZW5kaWYgLy8gVVNFKEdTVFJFQU1FUl9HTCkK