<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>225451</bug_id>
          
          <creation_ts>2021-05-06 04:58:45 -0700</creation_ts>
          <short_desc>video.currentSrc should not be reset when a new load errors</short_desc>
          <delta_ts>2022-06-27 18:38:59 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Media</component>
          <version>Safari Technology Preview</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          <see_also>https://bugs.webkit.org/show_bug.cgi?id=241982</see_also>
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Philip Jägenstedt">philip</reporter>
          <assigned_to name="Youssef Soliman">y_soliman</assigned_to>
          <cc>eric.carlson</cc>
    
    <cc>jer.noble</cc>
    
    <cc>webkit-bug-importer</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1757354</commentid>
    <comment_count>0</comment_count>
    <who name="Philip Jägenstedt">philip</who>
    <bug_when>2021-05-06 04:58:45 -0700</bug_when>
    <thetext>A test for this in web-platform-tests fails in Safari, but passes in Chrome and Firefox:
https://wpt.fyi/results/html/semantics/embedded-content/media-elements/loading-the-media-resource/resource-selection-currentSrc.html?run_id=5677336357765120&amp;run_id=5721877584543744&amp;run_id=5638047716605952&amp;run_id=5718410715463680

Safari is failing this bit:
https://github.com/web-platform-tests/wpt/blob/6a96f5c7fe3c2fd837f1814fef4fac93ade8344e/html/semantics/embedded-content/media-elements/loading-the-media-resource/resource-selection-currentSrc.html#L74-L81

The test is setting v.src = &quot;https://test:test/ which is an invalid URL.

The spec for this is https://html.spec.whatwg.org/multipage/media.html#concept-media-load-algorithm, where the &quot;If mode is attribute&quot; will reach &quot;If urlString was obtained successfully, set the currentSrc attribute to urlString.&quot; and *not* set currentSrc. There isn&apos;t anything else that updates currentSrc either.

See https://github.com/whatwg/html/issues/3988 for spec discussion around this.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1759646</commentid>
    <comment_count>1</comment_count>
    <who name="Radar WebKit Bug Importer">webkit-bug-importer</who>
    <bug_when>2021-05-13 04:59:12 -0700</bug_when>
    <thetext>&lt;rdar://problem/77961629&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1869454</commentid>
    <comment_count>2</comment_count>
    <who name="Youssef Soliman">y_soliman</who>
    <bug_when>2022-05-16 15:33:06 -0700</bug_when>
    <thetext>Pull request: https://github.com/WebKit/WebKit/pull/652</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1876565</commentid>
    <comment_count>3</comment_count>
    <who name="EWS">ews-feeder</who>
    <bug_when>2022-06-17 16:57:20 -0700</bug_when>
    <thetext>Committed r295649 (251654@main): &lt;https://commits.webkit.org/251654@main&gt;

Reviewed commits have been landed. Closing PR #652 and removing active labels.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1878303</commentid>
    <comment_count>4</comment_count>
    <who name="EWS">ews-feeder</who>
    <bug_when>2022-06-24 17:23:03 -0700</bug_when>
    <thetext>Committed 251841@main (dbb1064e05e5): &lt;https://commits.webkit.org/251841@main&gt;

Reviewed commits have been landed. Closing PR #1790 and removing active labels.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1878305</commentid>
    <comment_count>5</comment_count>
    <who name="Ryan Haddad">ryanhaddad</who>
    <bug_when>2022-06-24 17:24:32 -0700</bug_when>
    <thetext>This was reverted to resolve https://bugs.webkit.org/show_bug.cgi?id=241982</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1878601</commentid>
    <comment_count>6</comment_count>
    <who name="Youssef Soliman">y_soliman</who>
    <bug_when>2022-06-27 15:04:50 -0700</bug_when>
    <thetext>Pull request: https://github.com/WebKit/WebKit/pull/1835</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1878647</commentid>
    <comment_count>7</comment_count>
    <who name="EWS">ews-feeder</who>
    <bug_when>2022-06-27 18:38:56 -0700</bug_when>
    <thetext>Committed 251899@main (de4124158812): &lt;https://commits.webkit.org/251899@main&gt;

Reviewed commits have been landed. Closing PR #1835 and removing active labels.</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>