225415 2021-05-05 14:08:06 -0700 [build.webkit.org] Add a build step to set appropriate permissions on uploaded test results 2021-05-05 14:53:16 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 aakash_jain aakash_jain aakash_jain dewei_zhu jbedard ryanhaddad webkit-bug-importer oldest_to_newest 1757094 0 aakash_jain 2021-05-05 14:08:06 -0700 Add a build step to set appropriate permissions on uploaded test results on build.webkit.org See rdar://74200562 1757098 1 427804 aakash_jain 2021-05-05 14:10:12 -0700 Created attachment 427804 Patch 1757104 2 427804 dewei_zhu 2021-05-05 14:26:04 -0700 Comment on attachment 427804 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=427804&action=review > Tools/CISupport/build-webkit-org/steps.py:1137 > + kwargs['command'] = ['chmod', 'a+rx', resultDirectory] Do we really need 'x' bit for the result file? 1757110 3 aakash_jain 2021-05-05 14:43:42 -0700 (In reply to dewei_zhu from comment #2) > Do we really need 'x' bit for the result file? Yes, since this is for the directory, and we want to allow the directory browsing. Also, this step is already running on build.webkit.org for a while, e.g. https://build.webkit.org/#/builders/70/builds/200 1757111 4 427804 dewei_zhu 2021-05-05 14:47:32 -0700 Comment on attachment 427804 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=427804&action=review r=me >> Tools/CISupport/build-webkit-org/steps.py:1137 >> + kwargs['command'] = ['chmod', 'a+rx', resultDirectory] > > Do we really need 'x' bit for the result file? Discussed in person, it looks like we do need it for listing directory. 1757112 5 427811 aakash_jain 2021-05-05 14:49:34 -0700 Created attachment 427811 [fast-cq] Patch 1757113 6 ews-feeder 2021-05-05 14:52:45 -0700 Committed r277043 (237355@main): <https://commits.webkit.org/237355@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 427811. 1757115 7 webkit-bug-importer 2021-05-05 14:53:16 -0700 <rdar://problem/77576905> 427804 2021-05-05 14:10:12 -0700 2021-05-05 14:49:32 -0700 Patch bug-225415-20210505171011.patch text/plain 2664 aakash_jain SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDI3NzA0MSkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE2IEBACisyMDIxLTA1LTA1ICBBYWthc2ggSmFpbiAgPGFha2FzaF9qYWluQGFwcGxlLmNv bT4KKworICAgICAgICBbYnVpbGQud2Via2l0Lm9yZ10gQWRkIGEgYnVpbGQgc3RlcCB0byBzZXQg YXBwcm9wcmlhdGUgcGVybWlzc2lvbnMgb24gdXBsb2FkZWQgdGVzdCByZXN1bHRzCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMjU0MTUKKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIENJU3VwcG9ydC9idWls ZC13ZWJraXQtb3JnL2ZhY3Rvcmllcy5weToKKyAgICAgICAgKFRlc3RGYWN0b3J5Ll9faW5pdF9f KTogQWRkZWQgdGhlIGJ1aWxkLXN0ZXAuCisgICAgICAgICogQ0lTdXBwb3J0L2J1aWxkLXdlYmtp dC1vcmcvc3RlcHMucHk6CisgICAgICAgIChFeHRyYWN0VGVzdFJlc3VsdHMucmVzdWx0RGlyZWN0 b3J5VVJMKToKKyAgICAgICAgKFNldFBlcm1pc3Npb25zKTogQnVpbGQgc3RlcCB0byBzZXQgcGVy bWlzc2lvbnMgb24gdXBsb2FkZWQgdGVzdCByZXN1bHQgZGlyZWN0b3J5LgorCiAyMDIxLTA1LTA1 ICBBbGljaWEgQm95YSBHYXJjw61hICA8YWJveWFAaWdhbGlhLmNvbT4KIAogICAgICAgICBbTVNF XVtHU3RyZWFtZXJdIFdlYktpdE1lZGlhU3JjIHJld29yayB2MgpJbmRleDogVG9vbHMvQ0lTdXBw b3J0L2J1aWxkLXdlYmtpdC1vcmcvZmFjdG9yaWVzLnB5Cj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFRvb2xzL0NJ U3VwcG9ydC9idWlsZC13ZWJraXQtb3JnL2ZhY3Rvcmllcy5weQkocmV2aXNpb24gMjc3MDQxKQor KysgVG9vbHMvQ0lTdXBwb3J0L2J1aWxkLXdlYmtpdC1vcmcvZmFjdG9yaWVzLnB5CSh3b3JraW5n IGNvcHkpCkBAIC0xMTQsNiArMTE0LDcgQEAgY2xhc3MgVGVzdEZhY3RvcnkoRmFjdG9yeSk6CiAg ICAgICAgICAgICBzZWxmLmFkZFN0ZXAoQXJjaGl2ZVRlc3RSZXN1bHRzKCkpCiAgICAgICAgICAg ICBzZWxmLmFkZFN0ZXAoVXBsb2FkVGVzdFJlc3VsdHMoKSkKICAgICAgICAgICAgIHNlbGYuYWRk U3RlcChFeHRyYWN0VGVzdFJlc3VsdHMoKSkKKyAgICAgICAgICAgIHNlbGYuYWRkU3RlcChTZXRQ ZXJtaXNzaW9ucygpKQogICAgICAgICBpZiBwbGF0Zm9ybSA9PSAiZ3RrIjoKICAgICAgICAgICAg IHNlbGYuYWRkU3RlcChSdW5HdGtBUElUZXN0cygpKQogICAgICAgICAgICAgaWYgYWRkaXRpb25h bEFyZ3VtZW50cyBhbmQgIi0tZGlzcGxheS1zZXJ2ZXI9d2F5bGFuZCIgaW4gYWRkaXRpb25hbEFy Z3VtZW50czoKSW5kZXg6IFRvb2xzL0NJU3VwcG9ydC9idWlsZC13ZWJraXQtb3JnL3N0ZXBzLnB5 Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT0KLS0tIFRvb2xzL0NJU3VwcG9ydC9idWlsZC13ZWJraXQtb3JnL3N0ZXBzLnB5 CShyZXZpc2lvbiAyNzcwNDEpCisrKyBUb29scy9DSVN1cHBvcnQvYnVpbGQtd2Via2l0LW9yZy9z dGVwcy5weQkod29ya2luZyBjb3B5KQpAQCAtMTExNyw2ICsxMTE3LDcgQEAgY2xhc3MgRXh0cmFj dFRlc3RSZXN1bHRzKG1hc3Rlci5NYXN0ZXJTaAogICAgICAgICBtYXN0ZXIuTWFzdGVyU2hlbGxD b21tYW5kLl9faW5pdF9fKHNlbGYsICoqa3dhcmdzKQogCiAgICAgZGVmIHJlc3VsdERpcmVjdG9y eVVSTChzZWxmKToKKyAgICAgICAgc2VsZi5zZXRQcm9wZXJ0eSgncmVzdWx0X2RpcmVjdG9yeScs IHNlbGYucmVzdWx0RGlyZWN0b3J5KQogICAgICAgICByZXR1cm4gc2VsZi5yZXN1bHREaXJlY3Rv cnkucmVwbGFjZSgncHVibGljX2h0bWwvJywgJy8nKSArICcvJwogCiAgICAgZGVmIGFkZEN1c3Rv bVVSTHMoc2VsZik6CkBAIC0xMTI4LDYgKzExMjksMTYgQEAgY2xhc3MgRXh0cmFjdFRlc3RSZXN1 bHRzKG1hc3Rlci5NYXN0ZXJTaAogICAgICAgICByZXR1cm4gbWFzdGVyLk1hc3RlclNoZWxsQ29t bWFuZC5maW5pc2hlZChzZWxmLCByZXN1bHQpCiAKIAorY2xhc3MgU2V0UGVybWlzc2lvbnMobWFz dGVyLk1hc3RlclNoZWxsQ29tbWFuZCk6CisgICAgbmFtZSA9ICdzZXQtcGVybWlzc2lvbnMnCisK KyAgICBkZWYgX19pbml0X18oc2VsZiwgKiprd2FyZ3MpOgorICAgICAgICByZXN1bHREaXJlY3Rv cnkgPSBJbnRlcnBvbGF0ZSgnJShwcm9wOnJlc3VsdF9kaXJlY3RvcnkpcycpCisgICAgICAgIGt3 YXJnc1snY29tbWFuZCddID0gWydjaG1vZCcsICdhK3J4JywgcmVzdWx0RGlyZWN0b3J5XQorICAg ICAgICBrd2FyZ3NbJ2xvZ0Vudmlyb24nXSA9IEZhbHNlCisgICAgICAgIG1hc3Rlci5NYXN0ZXJT aGVsbENvbW1hbmQuX19pbml0X18oc2VsZiwgKiprd2FyZ3MpCisKKwogY2xhc3MgU2hvd0lkZW50 aWZpZXIoc2hlbGwuU2hlbGxDb21tYW5kKToKICAgICBuYW1lID0gJ3Nob3ctaWRlbnRpZmllcicK ICAgICBpZGVudGlmaWVyX3JlID0gJ15JZGVudGlmaWVyOiAoLiopJCcK 427811 2021-05-05 14:49:34 -0700 2021-05-05 14:52:45 -0700 [fast-cq] Patch bug-225415-20210505174933.patch text/plain 4210 aakash_jain SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDI3NzA0MikKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE2IEBACisyMDIxLTA1LTA1ICBBYWthc2ggSmFpbiAgPGFha2FzaF9qYWluQGFwcGxlLmNv bT4KKworICAgICAgICBbYnVpbGQud2Via2l0Lm9yZ10gQWRkIGEgYnVpbGQgc3RlcCB0byBzZXQg YXBwcm9wcmlhdGUgcGVybWlzc2lvbnMgb24gdXBsb2FkZWQgdGVzdCByZXN1bHRzCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMjU0MTUKKworICAgICAg ICBSZXZpZXdlZCBieSBEZXdlaSBaaHUuCisKKyAgICAgICAgKiBDSVN1cHBvcnQvYnVpbGQtd2Vi a2l0LW9yZy9mYWN0b3JpZXMucHk6CisgICAgICAgIChUZXN0RmFjdG9yeS5fX2luaXRfXyk6IEFk ZGVkIHRoZSBidWlsZC1zdGVwLgorICAgICAgICAqIENJU3VwcG9ydC9idWlsZC13ZWJraXQtb3Jn L3N0ZXBzLnB5OgorICAgICAgICAoRXh0cmFjdFRlc3RSZXN1bHRzLnJlc3VsdERpcmVjdG9yeVVS TCk6CisgICAgICAgIChTZXRQZXJtaXNzaW9ucyk6IEJ1aWxkIHN0ZXAgdG8gc2V0IHBlcm1pc3Np b25zIG9uIHVwbG9hZGVkIHRlc3QgcmVzdWx0IGRpcmVjdG9yeS4KKwogMjAyMS0wNS0wNSAgQWxp Y2lhIEJveWEgR2FyY8OtYSAgPGFib3lhQGlnYWxpYS5jb20+CiAKICAgICAgICAgW01TRV1bR1N0 cmVhbWVyXSBXZWJLaXRNZWRpYVNyYyByZXdvcmsgdjIKSW5kZXg6IFRvb2xzL0NJU3VwcG9ydC9i dWlsZC13ZWJraXQtb3JnL2ZhY3Rvcmllcy5weQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DSVN1cHBv cnQvYnVpbGQtd2Via2l0LW9yZy9mYWN0b3JpZXMucHkJKHJldmlzaW9uIDI3NzA0MikKKysrIFRv b2xzL0NJU3VwcG9ydC9idWlsZC13ZWJraXQtb3JnL2ZhY3Rvcmllcy5weQkod29ya2luZyBjb3B5 KQpAQCAtMTE0LDYgKzExNCw3IEBAIGNsYXNzIFRlc3RGYWN0b3J5KEZhY3RvcnkpOgogICAgICAg ICAgICAgc2VsZi5hZGRTdGVwKEFyY2hpdmVUZXN0UmVzdWx0cygpKQogICAgICAgICAgICAgc2Vs Zi5hZGRTdGVwKFVwbG9hZFRlc3RSZXN1bHRzKCkpCiAgICAgICAgICAgICBzZWxmLmFkZFN0ZXAo RXh0cmFjdFRlc3RSZXN1bHRzKCkpCisgICAgICAgICAgICBzZWxmLmFkZFN0ZXAoU2V0UGVybWlz c2lvbnMoKSkKICAgICAgICAgaWYgcGxhdGZvcm0gPT0gImd0ayI6CiAgICAgICAgICAgICBzZWxm LmFkZFN0ZXAoUnVuR3RrQVBJVGVzdHMoKSkKICAgICAgICAgICAgIGlmIGFkZGl0aW9uYWxBcmd1 bWVudHMgYW5kICItLWRpc3BsYXktc2VydmVyPXdheWxhbmQiIGluIGFkZGl0aW9uYWxBcmd1bWVu dHM6CkluZGV4OiBUb29scy9DSVN1cHBvcnQvYnVpbGQtd2Via2l0LW9yZy9zdGVwcy5weQo9PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09Ci0tLSBUb29scy9DSVN1cHBvcnQvYnVpbGQtd2Via2l0LW9yZy9zdGVwcy5weQkocmV2 aXNpb24gMjc3MDQyKQorKysgVG9vbHMvQ0lTdXBwb3J0L2J1aWxkLXdlYmtpdC1vcmcvc3RlcHMu cHkJKHdvcmtpbmcgY29weSkKQEAgLTExMTcsNiArMTExNyw3IEBAIGNsYXNzIEV4dHJhY3RUZXN0 UmVzdWx0cyhtYXN0ZXIuTWFzdGVyU2gKICAgICAgICAgbWFzdGVyLk1hc3RlclNoZWxsQ29tbWFu ZC5fX2luaXRfXyhzZWxmLCAqKmt3YXJncykKIAogICAgIGRlZiByZXN1bHREaXJlY3RvcnlVUkwo c2VsZik6CisgICAgICAgIHNlbGYuc2V0UHJvcGVydHkoJ3Jlc3VsdF9kaXJlY3RvcnknLCBzZWxm LnJlc3VsdERpcmVjdG9yeSkKICAgICAgICAgcmV0dXJuIHNlbGYucmVzdWx0RGlyZWN0b3J5LnJl cGxhY2UoJ3B1YmxpY19odG1sLycsICcvJykgKyAnLycKIAogICAgIGRlZiBhZGRDdXN0b21VUkxz KHNlbGYpOgpAQCAtMTEyOCw2ICsxMTI5LDE2IEBAIGNsYXNzIEV4dHJhY3RUZXN0UmVzdWx0cyht YXN0ZXIuTWFzdGVyU2gKICAgICAgICAgcmV0dXJuIG1hc3Rlci5NYXN0ZXJTaGVsbENvbW1hbmQu ZmluaXNoZWQoc2VsZiwgcmVzdWx0KQogCiAKK2NsYXNzIFNldFBlcm1pc3Npb25zKG1hc3Rlci5N YXN0ZXJTaGVsbENvbW1hbmQpOgorICAgIG5hbWUgPSAnc2V0LXBlcm1pc3Npb25zJworCisgICAg ZGVmIF9faW5pdF9fKHNlbGYsICoqa3dhcmdzKToKKyAgICAgICAgcmVzdWx0RGlyZWN0b3J5ID0g SW50ZXJwb2xhdGUoJyUocHJvcDpyZXN1bHRfZGlyZWN0b3J5KXMnKQorICAgICAgICBrd2FyZ3Nb J2NvbW1hbmQnXSA9IFsnY2htb2QnLCAnYStyeCcsIHJlc3VsdERpcmVjdG9yeV0KKyAgICAgICAg a3dhcmdzWydsb2dFbnZpcm9uJ10gPSBGYWxzZQorICAgICAgICBtYXN0ZXIuTWFzdGVyU2hlbGxD b21tYW5kLl9faW5pdF9fKHNlbGYsICoqa3dhcmdzKQorCisKIGNsYXNzIFNob3dJZGVudGlmaWVy KHNoZWxsLlNoZWxsQ29tbWFuZCk6CiAgICAgbmFtZSA9ICdzaG93LWlkZW50aWZpZXInCiAgICAg aWRlbnRpZmllcl9yZSA9ICdeSWRlbnRpZmllcjogKC4qKSQnCkluZGV4OiBUb29scy9DSVN1cHBv cnQvYnVpbGQtd2Via2l0LW9yZy9zdGVwc191bml0dGVzdC5weQo9PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29s cy9DSVN1cHBvcnQvYnVpbGQtd2Via2l0LW9yZy9zdGVwc191bml0dGVzdC5weQkocmV2aXNpb24g Mjc3MDQyKQorKysgVG9vbHMvQ0lTdXBwb3J0L2J1aWxkLXdlYmtpdC1vcmcvc3RlcHNfdW5pdHRl c3QucHkJKHdvcmtpbmcgY29weSkKQEAgLTk2MiwzICs5NjIsMzIgQEAgY2xhc3MgVGVzdFJ1bkph dmFTY3JpcHRDb3JlVGVzdHMoQnVpbGRTdAogICAgICAgICApCiAgICAgICAgIHNlbGYuZXhwZWN0 T3V0Y29tZShyZXN1bHQ9RkFJTFVSRSwgc3RhdGVfc3RyaW5nPSc5IEpTQyB0ZXN0cyBmYWlsZWQn KQogICAgICAgICByZXR1cm4gc2VsZi5ydW5TdGVwKCkKKworCitjbGFzcyBUZXN0U2V0UGVybWlz c2lvbnMoQnVpbGRTdGVwTWl4aW5BZGRpdGlvbnMsIHVuaXR0ZXN0LlRlc3RDYXNlKToKKyAgICBk ZWYgc2V0VXAoc2VsZik6CisgICAgICAgIHNlbGYubG9uZ01lc3NhZ2UgPSBUcnVlCisgICAgICAg IHJldHVybiBzZWxmLnNldFVwQnVpbGRTdGVwKCkKKworICAgIGRlZiB0ZWFyRG93bihzZWxmKToK KyAgICAgICAgcmV0dXJuIHNlbGYudGVhckRvd25CdWlsZFN0ZXAoKQorCisgICAgZGVmIHRlc3Rf c3VjY2VzcyhzZWxmKToKKyAgICAgICAgc2VsZi5zZXR1cFN0ZXAoU2V0UGVybWlzc2lvbnMoKSkK KyAgICAgICAgc2VsZi5zZXRQcm9wZXJ0eSgncmVzdWx0X2RpcmVjdG9yeScsICdwdWJsaWNfaHRt bC9yZXN1bHRzL0FwcGxlLUJpZ1N1ci1SZWxlYXNlLVdLMi1UZXN0cy9yMjc3MDM0ICgyMzQ2KScp CisgICAgICAgIHNlbGYuZXhwZWN0TG9jYWxDb21tYW5kcygKKyAgICAgICAgICAgIEV4cGVjdE1h c3RlclNoZWxsQ29tbWFuZChjb21tYW5kPVsnY2htb2QnLCAnYStyeCcsICdwdWJsaWNfaHRtbC9y ZXN1bHRzL0FwcGxlLUJpZ1N1ci1SZWxlYXNlLVdLMi1UZXN0cy9yMjc3MDM0ICgyMzQ2KSddKQor ICAgICAgICAgICAgKyAwLAorICAgICAgICApCisgICAgICAgIHNlbGYuZXhwZWN0T3V0Y29tZShy ZXN1bHQ9U1VDQ0VTUywgc3RhdGVfc3RyaW5nPSdSYW4nKQorICAgICAgICByZXR1cm4gc2VsZi5y dW5TdGVwKCkKKworICAgIGRlZiB0ZXN0X2ZhaWx1cmUoc2VsZik6CisgICAgICAgIHNlbGYuc2V0 dXBTdGVwKFNldFBlcm1pc3Npb25zKCkpCisgICAgICAgIHNlbGYuc2V0UHJvcGVydHkoJ3Jlc3Vs dF9kaXJlY3RvcnknLCAndGVzdGRpcicpCisgICAgICAgIHNlbGYuZXhwZWN0TG9jYWxDb21tYW5k cygKKyAgICAgICAgICAgIEV4cGVjdE1hc3RlclNoZWxsQ29tbWFuZChjb21tYW5kPVsnY2htb2Qn LCAnYStyeCcsICd0ZXN0ZGlyJ10pCisgICAgICAgICAgICArIDEsCisgICAgICAgICkKKyAgICAg ICAgc2VsZi5leHBlY3RPdXRjb21lKHJlc3VsdD1GQUlMVVJFLCBzdGF0ZV9zdHJpbmc9J2ZhaWxl ZCAoMSkgKGZhaWx1cmUpJykKKyAgICAgICAgcmV0dXJuIHNlbGYucnVuU3RlcCgpCg==