225411 2021-05-05 13:23:28 -0700 EWS bubbles should show current status after pressing 'Retry failed builds' button 2021-05-06 11:43:21 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 hi aakash_jain aakash_jain ap hi jbedard ryanhaddad webkit-bug-importer oldest_to_newest 1757073 0 hi 2021-05-05 13:23:28 -0700 IMO accessing "what is it doing now" is more important/useful than "what did it do before". Right now I don't know whether a "retry failures" patch is successfully/correctly in the bot's queue or if the bot is stuck or some other thing. 1757167 1 427817 aakash_jain 2021-05-05 16:40:41 -0700 Created attachment 427817 Patch 1757192 2 aakash_jain 2021-05-05 17:24:10 -0700 To clarify the request here, even after clicking 'Retry failed builds' button, for the queue which were retried, the status-bubble keep linking to old builds (and keep showing old build info in hover-over message). This becomes confusing to some users, especially when the new build isn't started soon. A better way would be to not show old build info anymore, and link to the queue (in which the retry request is queued) instead of linking to old build. 1757193 3 427830 aakash_jain 2021-05-05 17:25:08 -0700 Created attachment 427830 [fast-cq] Patch 1757533 4 ews-feeder 2021-05-06 11:34:21 -0700 Committed r277103 (237405@main): <https://commits.webkit.org/237405@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 427830. 1757534 5 webkit-bug-importer 2021-05-06 11:35:16 -0700 <rdar://problem/77617611> 1757546 6 aakash_jain 2021-05-06 11:43:21 -0700 Deployed this change on the server. 427817 2021-05-05 16:40:41 -0700 2021-05-05 17:25:05 -0700 Patch bug-225411-20210505194040.patch text/plain 1641 aakash_jain SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDI3NzA1MykKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDEzIEBACisyMDIxLTA1LTA1ICBBYWthc2ggSmFpbiAgPGFha2FzaF9qYWluQGFwcGxlLmNv bT4KKworICAgICAgICBFV1MgYnViYmxlcyBzaG91bGQgc2hvdyBjdXJyZW50IHN0YXR1cyBhZnRl ciAicmV0cnkgZmFpbHVyZXMiCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD0yMjU0MTEKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KworICAgICAgICAqIENJU3VwcG9ydC9ld3MtYXBwL2V3cy92aWV3cy9zdGF0dXNidWJibGUucHk6 CisgICAgICAgIChTdGF0dXNCdWJibGUuX2J1aWxkX2J1YmJsZSk6CisKIDIwMjEtMDUtMDUgIERl dmluIFJvdXNzbyAgPGRyb3Vzc29AYXBwbGUuY29tPgogCiAgICAgICAgIFNhbXBsZWQgUGFnZSBU b3AgQ29sb3I6IGRvbid0IHNuYXBzaG90IGlmIHRoZSBoaXQgdGVzdCBsb2NhdGlvbiBpcyBhbiBp bWFnZSBvciBoYXMgYW4gYW5pbWF0aW9uCkluZGV4OiBUb29scy9DSVN1cHBvcnQvZXdzLWFwcC9l d3Mvdmlld3Mvc3RhdHVzYnViYmxlLnB5Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFRvb2xzL0NJU3VwcG9ydC9l d3MtYXBwL2V3cy92aWV3cy9zdGF0dXNidWJibGUucHkJKHJldmlzaW9uIDI3NzA1MikKKysrIFRv b2xzL0NJU3VwcG9ydC9ld3MtYXBwL2V3cy92aWV3cy9zdGF0dXNidWJibGUucHkJKHdvcmtpbmcg Y29weSkKQEAgLTEyMiw3ICsxMjIsOCBAQCBjbGFzcyBTdGF0dXNCdWJibGUoVmlldyk6CiAgICAg ICAgICAgICBidWJibGVbJ2RldGFpbHNfbWVzc2FnZSddID0gJ0J1aWxkIGlzIGluLXByb2dyZXNz LiBSZWNlbnQgbWVzc2FnZXM6JyArIHNlbGYuX3N0ZXBzX21lc3NhZ2VzX2Zyb21fbXVsdGlwbGVf YnVpbGRzKGJ1aWxkcykKICAgICAgICAgZWxpZiBidWlsZC5yZXRyaWVkOgogICAgICAgICAgICAg YnViYmxlWydzdGF0ZSddID0gJ3N0YXJ0ZWQnCi0gICAgICAgICAgICBidWJibGVbJ2RldGFpbHNf bWVzc2FnZSddID0gJ1dhaXRpbmcgZm9yIGF2YWlsYWJsZSBib3QgdG8gcmV0cnkgdGhlIGJ1aWxk LlxuXG5SZWNlbnQgbWVzc2FnZXM6JyArIHNlbGYuX3N0ZXBzX21lc3NhZ2VzX2Zyb21fbXVsdGlw bGVfYnVpbGRzKGJ1aWxkcykKKyAgICAgICAgICAgIGJ1YmJsZVsnZGV0YWlsc19tZXNzYWdlJ10g PSAnV2FpdGluZyBmb3IgYXZhaWxhYmxlIGJvdCB0byByZXRyeSB0aGUgYnVpbGQuJworICAgICAg ICAgICAgYnViYmxlWyd1cmwnXSA9IE5vbmUKICAgICAgICAgZWxpZiBidWlsZC5yZXN1bHQgPT0g QnVpbGRib3QuU1VDQ0VTUzoKICAgICAgICAgICAgIGlmIGlzX3BhcmVudF9idWlsZDoKICAgICAg ICAgICAgICAgICBpZiBwYXRjaC5jcmVhdGVkIDwgKHRpbWV6b25lLm5vdygpIC0gZGF0ZXRpbWUu dGltZWRlbHRhKGRheXM9U3RhdHVzQnViYmxlLkRBWVNfVE9fQ0hFQ0spKToK 427830 2021-05-05 17:25:08 -0700 2021-05-06 11:34:22 -0700 [fast-cq] Patch bug-225411-20210505202507.patch text/plain 1892 aakash_jain SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDI3NzA1MykKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDEzIEBACisyMDIxLTA1LTA1ICBBYWthc2ggSmFpbiAgPGFha2FzaF9qYWluQGFwcGxlLmNv bT4KKworICAgICAgICBFV1MgYnViYmxlcyBzaG91bGQgc2hvdyBjdXJyZW50IHN0YXR1cyBhZnRl ciBwcmVzc2luZyAnUmV0cnkgZmFpbGVkIGJ1aWxkcycgYnV0dG9uCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMjU0MTEKKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIENJU3VwcG9ydC9ld3MtYXBwL2V3cy92 aWV3cy9zdGF0dXNidWJibGUucHk6CisgICAgICAgIChTdGF0dXNCdWJibGUuX2J1aWxkX2J1YmJs ZSk6CisKIDIwMjEtMDUtMDUgIERldmluIFJvdXNzbyAgPGRyb3Vzc29AYXBwbGUuY29tPgogCiAg ICAgICAgIFNhbXBsZWQgUGFnZSBUb3AgQ29sb3I6IGRvbid0IHNuYXBzaG90IGlmIHRoZSBoaXQg dGVzdCBsb2NhdGlvbiBpcyBhbiBpbWFnZSBvciBoYXMgYW4gYW5pbWF0aW9uCkluZGV4OiBUb29s cy9DSVN1cHBvcnQvZXdzLWFwcC9ld3Mvdmlld3Mvc3RhdHVzYnViYmxlLnB5Cj09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0K LS0tIFRvb2xzL0NJU3VwcG9ydC9ld3MtYXBwL2V3cy92aWV3cy9zdGF0dXNidWJibGUucHkJKHJl dmlzaW9uIDI3NzA1MikKKysrIFRvb2xzL0NJU3VwcG9ydC9ld3MtYXBwL2V3cy92aWV3cy9zdGF0 dXNidWJibGUucHkJKHdvcmtpbmcgY29weSkKQEAgLTEyMiw3ICsxMjIsMTEgQEAgY2xhc3MgU3Rh dHVzQnViYmxlKFZpZXcpOgogICAgICAgICAgICAgYnViYmxlWydkZXRhaWxzX21lc3NhZ2UnXSA9 ICdCdWlsZCBpcyBpbi1wcm9ncmVzcy4gUmVjZW50IG1lc3NhZ2VzOicgKyBzZWxmLl9zdGVwc19t ZXNzYWdlc19mcm9tX211bHRpcGxlX2J1aWxkcyhidWlsZHMpCiAgICAgICAgIGVsaWYgYnVpbGQu cmV0cmllZDoKICAgICAgICAgICAgIGJ1YmJsZVsnc3RhdGUnXSA9ICdzdGFydGVkJwotICAgICAg ICAgICAgYnViYmxlWydkZXRhaWxzX21lc3NhZ2UnXSA9ICdXYWl0aW5nIGZvciBhdmFpbGFibGUg Ym90IHRvIHJldHJ5IHRoZSBidWlsZC5cblxuUmVjZW50IG1lc3NhZ2VzOicgKyBzZWxmLl9zdGVw c19tZXNzYWdlc19mcm9tX211bHRpcGxlX2J1aWxkcyhidWlsZHMpCisgICAgICAgICAgICBidWJi bGVbJ2RldGFpbHNfbWVzc2FnZSddID0gJ1dhaXRpbmcgZm9yIGF2YWlsYWJsZSBib3QgdG8gcmV0 cnkgdGhlIGJ1aWxkLicKKyAgICAgICAgICAgIGJ1YmJsZVsndXJsJ10gPSBOb25lCisgICAgICAg ICAgICBxdWV1ZV9mdWxsX25hbWUgPSBCdWlsZGJvdC5xdWV1ZV9uYW1lX2J5X3Nob3J0bmFtZV9t YXBwaW5nLmdldChxdWV1ZSkKKyAgICAgICAgICAgIGlmIHF1ZXVlX2Z1bGxfbmFtZToKKyAgICAg ICAgICAgICAgICBidWJibGVbJ3VybCddID0gJ2h0dHBzOi8ve30vIy9idWlsZGVycy97fScuZm9y bWF0KGNvbmZpZy5CVUlMREJPVF9TRVJWRVJfSE9TVCwgcXVldWVfZnVsbF9uYW1lKQogICAgICAg ICBlbGlmIGJ1aWxkLnJlc3VsdCA9PSBCdWlsZGJvdC5TVUNDRVNTOgogICAgICAgICAgICAgaWYg aXNfcGFyZW50X2J1aWxkOgogICAgICAgICAgICAgICAgIGlmIHBhdGNoLmNyZWF0ZWQgPCAodGlt ZXpvbmUubm93KCkgLSBkYXRldGltZS50aW1lZGVsdGEoZGF5cz1TdGF0dXNCdWJibGUuREFZU19U T19DSEVDSykpOgo=