225401 2021-05-05 12:12:30 -0700 [LibWebRTC][WPE][GTK] do not use system installed vpx headers when building webrtc 2021-06-21 09:08:47 -0700 1 1 1 Unclassified WebKit Platform WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 yurys yurys annulen calvaris eric.carlson ews-watchlist gyuyoung.kim pnormand ryuan.choi sergio webkit-bug-importer oldest_to_newest 1757027 0 yurys 2021-05-05 12:12:30 -0700 After https://commits.webkit.org/r276491 WPE build fails on Ubuntu 18.04 with the following error: In file included from ../../../Source/ThirdParty/libwebrtc/Source/webrtc/modules/video_coding/codecs/vp9/vp9.cc:16:0: ../../../Source/ThirdParty/libwebrtc/Source/webrtc/modules/video_coding/codecs/vp9/vp9_impl.h:134:3: error: ‘vpx_svc_frame_drop_t’ does not name a type; did you mean ‘vpx_enc_frame_flags_t’? vpx_svc_frame_drop_t svc_drop_frame_; ^~~~~~~~~~~~~~~~~~~~ vpx_enc_frame_flags_t This is because #include "vpx/vp8cx.h" in vp9_impl.h gets the header from /usr/include/vpx/vp8cx.h (provided by libvpx-dev) instead of WebKit/Source/ThirdParty/libwebrtc/Source/third_party/libvpx/source/libvpx/vpx/vp8cx.h. vp8cx.h on Ubuntu 18.04 [1] is rather old and doesn't define vpx_svc_frame_drop_t structure so the build fails. [1] https://packages.ubuntu.com/source/bionic/libvpx 1757030 1 427787 yurys 2021-05-05 12:22:33 -0700 Created attachment 427787 Patch 1757031 2 427788 yurys 2021-05-05 12:25:21 -0700 Created attachment 427788 Patch 1757055 3 427788 pnormand 2021-05-05 12:52:39 -0700 Comment on attachment 427788 Patch Thanks Yury! Sorry for the trouble :) 1757069 4 ews-feeder 2021-05-05 13:19:31 -0700 Committed r277036 (237349@main): <https://commits.webkit.org/237349@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 427788. 1757070 5 webkit-bug-importer 2021-05-05 13:20:14 -0700 <rdar://problem/77572149> 1771090 6 pnormand 2021-06-19 04:44:36 -0700 For the record, this patch is actually wrong :( It might have fixed your build, but if you were running webrtc tests you would realise they're broken. The WPE/GTK ports rely on external libvpx, so we cannot pull in the bundled libvpx headers without making sure the external libvpx is ABI compatible with the version bundled in libwebrtc. See also https://bugs.webkit.org/show_bug.cgi?id=227172 I'm updating the Flatpak SDK to libvpx 1.10 and will from now on keep the version check of libvpx in cmake synchronized with the bundled version, that means WebKit builds enabling libwebrtc while the host has libvpx < 1.10, will fail during CMake configure step. 1771301 7 yurys 2021-06-21 08:54:31 -0700 (In reply to Philippe Normand from comment #6) > The WPE/GTK ports rely on external libvpx, so we cannot pull in the bundled > libvpx headers without making sure the external libvpx is ABI compatible > with the version bundled in libwebrtc. I see, this makes sense. I believe proper fix for jhbuild would be to pull corresponding version of libvpx sources. > I'm updating the Flatpak SDK to libvpx 1.10 and will from now on keep the > version check of libvpx in cmake synchronized with the bundled version, that > means WebKit builds enabling libwebrtc while the host has libvpx < 1.10, > will fail during CMake configure step. Isn't this version distribution-specific? On Ubuntu 20.04 it is shipped as libvpx6 with current version being 1.8.2, will >=1.10 requirement break it? In any case, thanks for heads-up! 1771310 8 pnormand 2021-06-21 09:08:47 -0700 (In reply to Yury Semikhatsky from comment #7) > (In reply to Philippe Normand from comment #6) > > The WPE/GTK ports rely on external libvpx, so we cannot pull in the bundled > > libvpx headers without making sure the external libvpx is ABI compatible > > with the version bundled in libwebrtc. > > I see, this makes sense. I believe proper fix for jhbuild would be to pull > corresponding version of libvpx sources. > Yes. > > > I'm updating the Flatpak SDK to libvpx 1.10 and will from now on keep the > > version check of libvpx in cmake synchronized with the bundled version, that > > means WebKit builds enabling libwebrtc while the host has libvpx < 1.10, > > will fail during CMake configure step. > > Isn't this version distribution-specific? On Ubuntu 20.04 it is shipped as > libvpx6 with current version being 1.8.2, will >=1.10 requirement break it? > In any case, thanks for heads-up! Maybe 1.8.2 is ABI compatible with some previous versions. 427787 2021-05-05 12:22:33 -0700 2021-05-05 12:25:19 -0700 Patch bug-225401-20210505122232.patch text/plain 1459 yurys U3VidmVyc2lvbiBSZXZpc2lvbjogMjc3MDM0CmRpZmYgLS1naXQgYS9Tb3VyY2UvVGhpcmRQYXJ0 eS9saWJ3ZWJydGMvQ2hhbmdlTG9nIGIvU291cmNlL1RoaXJkUGFydHkvbGlid2VicnRjL0NoYW5n ZUxvZwppbmRleCA3OWQzNmQ5OTllNDk4NTg1NDU5ODA3Y2RmZmYwZWEzZTQyNzk2MWNjLi4zYTlk ZmI0YWQ0ODFiOGFkYTFmMjJlOGUzNTk3NGY1NGJmNDAxNDQ1IDEwMDY0NAotLS0gYS9Tb3VyY2Uv VGhpcmRQYXJ0eS9saWJ3ZWJydGMvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9UaGlyZFBhcnR5L2xp YndlYnJ0Yy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNCBAQAorMjAyMS0wNS0wNSAgWXVyeSBTZW1p a2hhdHNreSAgPHl1cnlzQGNocm9taXVtLm9yZz4KKworICAgICAgICBbTGliV2ViUlRDXVtXUEVd W0dUS10gZG8gbm90IHVzZSBzeXN0ZW0gaW5zdGFsbGVkIHZweCBoZWFkZXJzIHdoZW4gYnVpbGRp bmcgd2VicnRjCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0yMjU0MDEKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBVc2UgdnB4IGhlYWRlcnMgZnJvbSBTb3VyY2UvVGhpcmRQYXJ0eS9saWJ3ZWJydGMgaW5zdGVh ZCBvZiB0aG9zZSBmcm9tIHRoZSBob3N0IHN5c3RlbS4KKworICAgICAgICAqIENNYWtlTGlzdHMu dHh0OiBleHBvc2UgbGlidnB4IGhlYWRlcnMgdG8gd2VicnRjCisKIDIwMjEtMDQtMjcgIFlvdWVu biBGYWJsZXQgIDx5b3Vlbm5AYXBwbGUuY29tPgogCiAgICAgICAgIERpc2FibGUgV2ViUlRDIHRy YWNlIGV2ZW50IG1hY3JvcwpkaWZmIC0tZ2l0IGEvU291cmNlL1RoaXJkUGFydHkvbGlid2VicnRj L0NNYWtlTGlzdHMudHh0IGIvU291cmNlL1RoaXJkUGFydHkvbGlid2VicnRjL0NNYWtlTGlzdHMu dHh0CmluZGV4IGNkMTgyNDU0NDMzZTY2ZmFiNzc2YjQ1ODEzZGNiZTc0ZjVjMWVmZGUuLmJmNDgz NjY3OTFjYjQxZDVjY2YzNTZhNzJmZGE2OTVmOTVhYzc4YmMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9U aGlyZFBhcnR5L2xpYndlYnJ0Yy9DTWFrZUxpc3RzLnR4dAorKysgYi9Tb3VyY2UvVGhpcmRQYXJ0 eS9saWJ3ZWJydGMvQ01ha2VMaXN0cy50eHQKQEAgLTE2OTgsNiArMTY5OCw3IEBAIHNldCh3ZWJy dGNfSU5DTFVERV9ESVJFQ1RPUklFUyBQUklWQVRFCiAgICAgU291cmNlL3RoaXJkX3BhcnR5L2xp YnNydHAvY3J5cHRvL2luY2x1ZGUKICAgICBTb3VyY2UvdGhpcmRfcGFydHkvbGlic3J0cC9pbmNs dWRlCiAgICAgU291cmNlL3RoaXJkX3BhcnR5L2xpYnl1di9pbmNsdWRlCisgICAgU291cmNlL3Ro aXJkX3BhcnR5L2xpYnZweC9zb3VyY2UvbGlidnB4CiAgICAgU291cmNlL3RoaXJkX3BhcnR5L29w dXMvc3JjL2NlbHQKICAgICBTb3VyY2UvdGhpcmRfcGFydHkvb3B1cy9zcmMvaW5jbHVkZQogICAg IFNvdXJjZS90aGlyZF9wYXJ0eS9vcHVzL3NyYy9zaWxrCg== 427788 2021-05-05 12:25:21 -0700 2021-05-05 13:19:32 -0700 Patch bug-225401-20210505122521.patch text/plain 1754 yurys U3VidmVyc2lvbiBSZXZpc2lvbjogMjc3MDM0CmRpZmYgLS1naXQgYS9Tb3VyY2UvVGhpcmRQYXJ0 eS9saWJ3ZWJydGMvQ2hhbmdlTG9nIGIvU291cmNlL1RoaXJkUGFydHkvbGlid2VicnRjL0NoYW5n ZUxvZwppbmRleCA3OWQzNmQ5OTllNDk4NTg1NDU5ODA3Y2RmZmYwZWEzZTQyNzk2MWNjLi4zYTlk ZmI0YWQ0ODFiOGFkYTFmMjJlOGUzNTk3NGY1NGJmNDAxNDQ1IDEwMDY0NAotLS0gYS9Tb3VyY2Uv VGhpcmRQYXJ0eS9saWJ3ZWJydGMvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9UaGlyZFBhcnR5L2xp YndlYnJ0Yy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNCBAQAorMjAyMS0wNS0wNSAgWXVyeSBTZW1p a2hhdHNreSAgPHl1cnlzQGNocm9taXVtLm9yZz4KKworICAgICAgICBbTGliV2ViUlRDXVtXUEVd W0dUS10gZG8gbm90IHVzZSBzeXN0ZW0gaW5zdGFsbGVkIHZweCBoZWFkZXJzIHdoZW4gYnVpbGRp bmcgd2VicnRjCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0yMjU0MDEKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBVc2UgdnB4IGhlYWRlcnMgZnJvbSBTb3VyY2UvVGhpcmRQYXJ0eS9saWJ3ZWJydGMgaW5zdGVh ZCBvZiB0aG9zZSBmcm9tIHRoZSBob3N0IHN5c3RlbS4KKworICAgICAgICAqIENNYWtlTGlzdHMu dHh0OiBleHBvc2UgbGlidnB4IGhlYWRlcnMgdG8gd2VicnRjCisKIDIwMjEtMDQtMjcgIFlvdWVu biBGYWJsZXQgIDx5b3Vlbm5AYXBwbGUuY29tPgogCiAgICAgICAgIERpc2FibGUgV2ViUlRDIHRy YWNlIGV2ZW50IG1hY3JvcwpkaWZmIC0tZ2l0IGEvU291cmNlL1RoaXJkUGFydHkvbGlid2VicnRj L0NNYWtlTGlzdHMudHh0IGIvU291cmNlL1RoaXJkUGFydHkvbGlid2VicnRjL0NNYWtlTGlzdHMu dHh0CmluZGV4IGNkMTgyNDU0NDMzZTY2ZmFiNzc2YjQ1ODEzZGNiZTc0ZjVjMWVmZGUuLmE1NTkw ZGIxOTQ3MDE3NmQ0MWQwYmEyYmE5M2U3N2Q0N2E1ZjFkN2YgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9U aGlyZFBhcnR5L2xpYndlYnJ0Yy9DTWFrZUxpc3RzLnR4dAorKysgYi9Tb3VyY2UvVGhpcmRQYXJ0 eS9saWJ3ZWJydGMvQ01ha2VMaXN0cy50eHQKQEAgLTE2OTgsNiArMTY5OCw3IEBAIHNldCh3ZWJy dGNfSU5DTFVERV9ESVJFQ1RPUklFUyBQUklWQVRFCiAgICAgU291cmNlL3RoaXJkX3BhcnR5L2xp YnNydHAvY3J5cHRvL2luY2x1ZGUKICAgICBTb3VyY2UvdGhpcmRfcGFydHkvbGlic3J0cC9pbmNs dWRlCiAgICAgU291cmNlL3RoaXJkX3BhcnR5L2xpYnl1di9pbmNsdWRlCisgICAgU291cmNlL3Ro aXJkX3BhcnR5L2xpYnZweC9zb3VyY2UvbGlidnB4CiAgICAgU291cmNlL3RoaXJkX3BhcnR5L29w dXMvc3JjL2NlbHQKICAgICBTb3VyY2UvdGhpcmRfcGFydHkvb3B1cy9zcmMvaW5jbHVkZQogICAg IFNvdXJjZS90aGlyZF9wYXJ0eS9vcHVzL3NyYy9zaWxrCkBAIC0xNzE1LDcgKzE3MTYsNiBAQCBz ZXQod2VicnRjX0lOQ0xVREVfRElSRUNUT1JJRVMgUFJJVkFURQogCiBpZiAoQVBQTEUpCiAgICAg bGlzdChBUFBFTkQgd2VicnRjX0lOQ0xVREVfRElSRUNUT1JJRVMgUFJJVkFURQotICAgICAgICBT b3VyY2UvdGhpcmRfcGFydHkvbGlidnB4L3NvdXJjZS9saWJ2cHgKICAgICAgICAgU291cmNlL3dl YnJ0Yy9zZGsvb2JqYwogICAgICAgICBTb3VyY2Uvd2VicnRjL3Nkay9vYmpjL2Jhc2UKICAgICAg ICAgU291cmNlL3dlYnJ0Yy9zZGsvb2JqYy9GcmFtZXdvcmsvQ2xhc3Nlcwo=