225389 2021-05-05 02:50:24 -0700 [SOUP] Wrong cookie timestamp in case of long expire time 2021-05-05 06:25:02 -0700 1 1 1 Unclassified WebKit WebKitGTK Other Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 enometh webkit-unassigned aperez berto bugs-noreply cgarcia ews-watchlist gustavo oldest_to_newest 1756877 0 enometh 2021-05-05 02:50:24 -0700 Assume I have a cookie file cookie.txt #HttpOnly_localhost FALSE / FALSE 2682374400 prov 123 None Which is specifies date 2055-01-01:00:00:00 When I try to access this cookie through: GFile *cookie_path = g_file_new_build_filename (dirpath, "cookies.txt", NULL); webkit_cookie_manager_set_persistent_storage (cm, g_file_peek_path (cookie_path), WEBKIT_COOKIE_PERSISTENT_STORAGE_TEXT); ... gboolean inspect_cookies(WebKitCookieManager *cm) { webkit_cookie_manager_get_cookies (cm, "http://localhost/", NULL, inspect_localhost_cookies_cb, NULL); return FALSE; } void inspect_localhost_cookies_cb(GObject *source_object, GAsyncResult *res, gpointer user_data) { GError *error; WebKitCookieManager *cookie_manager = WEBKIT_COOKIE_MANAGER(source_object); error = NULL; GList *gl = webkit_cookie_manager_get_cookies_finish (cookie_manager, res, &error); if (error) { g_warning("inspect cookies cb: failed: %s", error->message ?: ""); return; } while (gl) { g_assert(gl->data); SoupCookie *soup_cookie = gl->data; g_message("COOKIE ==> %s", soup_cookie_to_set_cookie_header(soup_cookie)); gl = gl->next; } } I get a message which shows ** Message: 15:11:42.077: COOKIE ==> prov=123; expires=Fri, 01-Jan-2055 00:00:-8 GMT; path=/; domain=localhost; HttpOnly This indicates that the seconds field now stores a negative integer. In practice this triggers a critical in glib #0 g_logv (log_domain=0x7fffed49614e "GLib", log_level=G_LOG_LEVEL_CRITICAL, format=<optimized out>, args=<optimized out>) at ../glib-2.68.0/glib/gmessages.c:1413 #1 0x00007fffed44c782 in g_log (log_domain=log_domain@entry=0x7fffed49614e "GLib", log_level=log_level@entry=G_LOG_LEVEL_CRITICAL, format=format@entry=0x7fffed498336 "%s: assertion '%s' failed") at ../glib-2.68.0/glib/gmessages.c:1451 #2 0x00007fffed44cf39 in g_return_if_fail_warning (log_domain=log_domain@entry=0x7fffed49614e "GLib", pretty_function=pretty_function@entry=0x7fffed4a6450 <__func__.14> "g_date_time_to_unix", expression=expression@entry=0x7fffed49702a "datetime != NULL") at ../glib-2.68.0/glib/gmessages.c:2883 #3 0x00007fffed42c81a in g_date_time_to_unix (datetime=0x0) at ../glib-2.68.0/glib/gdatetime.c:2566 #4 g_date_time_to_unix (datetime=datetime@entry=0x0) at ../glib-2.68.0/glib/gdatetime.c:2564 #5 0x00007ffff0d3be89 in soup_date_to_time_t (date=<optimized out>) at ../libsoup-2.70.0/libsoup/soup-date.c:718 #6 0x00007ffff5119e24 in WebCore::Cookie::Cookie(_SoupCookie*) () at /7/gtk/webkitgtk/build.amd64/lib/libwebkit2gtk-4.0.so.37 I'm noticing this since 2.32.0. Do others see this or should i suspect another gcc bug 1756896 1 cgarcia 2021-05-05 04:54:59 -0700 I can reproduce with libsoup2, but it's also failing in libsoup3 in a different way. It's a WebKit bug in any case. I'll submit a patch. 1756913 2 427761 cgarcia 2021-05-05 05:44:36 -0700 Created attachment 427761 Patch 1756922 3 cgarcia 2021-05-05 06:25:02 -0700 Committed r277014 (237330@main): <https://commits.webkit.org/237330@main> 427761 2021-05-05 05:44:36 -0700 2021-05-05 06:20:23 -0700 Patch wcore-soup-cookie-expires.diff text/plain 5571 cgarcia ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCAyZDIyYjhmYjRjZmEuLmY0ZjQ1ZmJjODNlMSAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAt MSwzICsxLDE5IEBACisyMDIxLTA1LTA1ICBDYXJsb3MgR2FyY2lhIENhbXBvcyAgPGNnYXJjaWFA aWdhbGlhLmNvbT4KKworICAgICAgICBbU09VUF0gV3JvbmcgY29va2llIHRpbWVzdGFtcCBpbiBj YXNlIG9mIGxvbmcgZXhwaXJlIHRpbWUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTIyNTM4OQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgIFRoZXJlJ3MgYW4gb3ZlcmZsb3cgd2hlbiBjb252ZXJ0aW5nIHRoZSBk YXRlcyBpbiBib3RoIGxpYnNvdXAyIGFuZCBsaWJzb3VwMywgYnV0IGZvciB0d28gZGlmZmVyZW50 IHJlYXNvbnMuIEluCisgICAgICAgIHRoZSBjYXNlIG9mIGxpYnNvdXAyIHdlIGFyZSB1c2luZyBh biBpbnQgZm9yIHRoZSBjb252ZXJzaW9uIG9mIG1pbGxpc2Vjb25kcyB0byBzZWNvbmRzIHdoaWNo IGlzIG5vdCBlbm91Z2guIEluCisgICAgICAgIHRoZSBjYXNlIG9mIGxpYnNvdXAzIHdlIGFyZSBw YXNzaW5nIHRoZSB2YWx1ZSBpbiBtaWxsaXNlY29uZHMgdG8gZ19kYXRlX3RpbWVfbmV3X2Zyb21f dW5peF91dGMoKSB0aGF0IGV4cGVjdHMKKyAgICAgICAgc2Vjb25kcy4KKworICAgICAgICAqIHBs YXRmb3JtL25ldHdvcmsvc291cC9Db29raWVTb3VwLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6Om1z VG9Tb3VwRGF0ZSk6IFVzZSBpbnQ2NF90IGluc3RlYWQgb2YgaW50IGZvciB0aGUgY2FzdC4KKyAg ICAgICAgKFdlYkNvcmU6OkNvb2tpZTo6dG9Tb3VwQ29va2llIGNvbnN0KTogQ29udmVydCB0aGUg dmFsdWUgdG8gc2Vjb25kcy4KKwogMjAyMS0wNS0wNSAgQ2FybG9zIEdhcmNpYSBDYW1wb3MgIDxj Z2FyY2lhQGlnYWxpYS5jb20+CiAKICAgICAgICAgQ3JlYXRlIGEgUmVuZGVyTGluZUJyZWFrIHdo ZW4gQlIgZWxlbWVudCBoYXMgdW5zdXBwb3J0ZWQgY29udGVudCBkYXRhIHN0eWxlCmRpZmYgLS1n aXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL3NvdXAvQ29va2llU291cC5jcHAg Yi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL3NvdXAvQ29va2llU291cC5jcHAKaW5k ZXggNzk3ZjRjYjBjYWE5Li4xZjNjZDI2NzMxNzkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3Jl L3BsYXRmb3JtL25ldHdvcmsvc291cC9Db29raWVTb3VwLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29y ZS9wbGF0Zm9ybS9uZXR3b3JrL3NvdXAvQ29va2llU291cC5jcHAKQEAgLTkzLDcgKzkzLDcgQEAg c3RhdGljIFNvdXBEYXRlKiBtc1RvU291cERhdGUoZG91YmxlIG1zKQogCiAgICAgLy8gbW9udGhG cm9tRGF5SW5ZZWFyKCkgcmV0dXJucyBhIHZhbHVlIGluIHRoZSBbMCwxMV0gcmFuZ2UsIHdoaWxl IHNvdXBfZGF0ZV9uZXcoKSBleHBlY3RzCiAgICAgLy8gYSB2YWx1ZSBpbiB0aGUgWzEsMTJdIHJh bmdlLCBtZWFuaW5nIHdlIGhhdmUgdG8gbWFudWFsbHkgYWRqdXN0IHRoZSBtb250aCB2YWx1ZS4K LSAgICByZXR1cm4gc291cF9kYXRlX25ldyh5ZWFyLCBtb250aEZyb21EYXlJblllYXIoZGF5T2ZZ ZWFyLCBsZWFwWWVhcikgKyAxLCBkYXlJbk1vbnRoRnJvbURheUluWWVhcihkYXlPZlllYXIsIGxl YXBZZWFyKSwgbXNUb0hvdXJzKG1zKSwgbXNUb01pbnV0ZXMobXMpLCBzdGF0aWNfY2FzdDxpbnQ+ KG1zIC8gMTAwMCkgJSA2MCk7CisgICAgcmV0dXJuIHNvdXBfZGF0ZV9uZXcoeWVhciwgbW9udGhG cm9tRGF5SW5ZZWFyKGRheU9mWWVhciwgbGVhcFllYXIpICsgMSwgZGF5SW5Nb250aEZyb21EYXlJ blllYXIoZGF5T2ZZZWFyLCBsZWFwWWVhciksIG1zVG9Ib3VycyhtcyksIG1zVG9NaW51dGVzKG1z KSwgc3RhdGljX2Nhc3Q8aW50NjRfdD4obXMgLyAxMDAwKSAlIDYwKTsKIH0KICNlbmRpZgogCkBA IC0xMTcsNyArMTE3LDcgQEAgU291cENvb2tpZSogQ29va2llOjp0b1NvdXBDb29raWUoKSBjb25z dAogICAgICAgICBzb3VwX2Nvb2tpZV9zZXRfZXhwaXJlcyhzb3VwQ29va2llLCBkYXRlKTsKICAg ICAgICAgc291cF9kYXRlX2ZyZWUoZGF0ZSk7CiAjZWxzZQotICAgICAgICBHUmVmUHRyPEdEYXRl VGltZT4gZGF0ZSA9IGFkb3B0R1JlZihnX2RhdGVfdGltZV9uZXdfZnJvbV91bml4X3V0YygqZXhw aXJlcykpOworICAgICAgICBHUmVmUHRyPEdEYXRlVGltZT4gZGF0ZSA9IGFkb3B0R1JlZihnX2Rh dGVfdGltZV9uZXdfZnJvbV91bml4X3V0YygqZXhwaXJlcyAvIDEwMDAuKSk7CiAgICAgICAgIHNv dXBfY29va2llX3NldF9leHBpcmVzKHNvdXBDb29raWUsIGRhdGUuZ2V0KCkpOwogI2VuZGlmCiAg ICAgfQpkaWZmIC0tZ2l0IGEvVG9vbHMvQ2hhbmdlTG9nIGIvVG9vbHMvQ2hhbmdlTG9nCmluZGV4 IDY5OWVlMDY5MmI0ZS4uYjA2Y2Q1M2QzNzk4IDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cK KysrIGIvVG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMjEtMDUtMDUgIENhcmxv cyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29tPgorCisgICAgICAgIFtTT1VQXSBX cm9uZyBjb29raWUgdGltZXN0YW1wIGluIGNhc2Ugb2YgbG9uZyBleHBpcmUgdGltZQorICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjI1Mzg5CisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQWRkIGEgdGVzdCBjYXNl LgorCisgICAgICAgICogVGVzdFdlYktpdEFQSS9UZXN0cy9XZWJLaXRHTGliL1Rlc3RDb29raWVN YW5hZ2VyLmNwcDoKKyAgICAgICAgKHRlc3RDb29raWVNYW5hZ2VyTG9uZ0V4cGlyZXMpOgorICAg ICAgICAoYmVmb3JlQWxsKToKKwogMjAyMS0wNS0wNCAgSmlld2VuIFRhbiAgPGppZXdlbl90YW5A YXBwbGUuY29tPgogCiAgICAgICAgIFBDTTogRmluZCBhIHdheSB0byB2YWxpZGF0ZSBzb3VyY2Vf c2VjcmV0X3Rva2VuIGFuZCBzb3VyY2Vfc2VjcmV0X3Rva2VuX3NpZ25hdHVyZQpkaWZmIC0tZ2l0 IGEvVG9vbHMvVGVzdFdlYktpdEFQSS9UZXN0cy9XZWJLaXRHTGliL1Rlc3RDb29raWVNYW5hZ2Vy LmNwcCBiL1Rvb2xzL1Rlc3RXZWJLaXRBUEkvVGVzdHMvV2ViS2l0R0xpYi9UZXN0Q29va2llTWFu YWdlci5jcHAKaW5kZXggZDg4ZTg3NDFmN2Y3Li41OGYyMzcwYjlhMjAgMTAwNjQ0Ci0tLSBhL1Rv b2xzL1Rlc3RXZWJLaXRBUEkvVGVzdHMvV2ViS2l0R0xpYi9UZXN0Q29va2llTWFuYWdlci5jcHAK KysrIGIvVG9vbHMvVGVzdFdlYktpdEFQSS9UZXN0cy9XZWJLaXRHTGliL1Rlc3RDb29raWVNYW5h Z2VyLmNwcApAQCAtNzA2LDYgKzcwNiwzMyBAQCBzdGF0aWMgdm9pZCB0ZXN0Q29va2llTWFuYWdl ckVwaGVtZXJhbChDb29raWVNYW5hZ2VyVGVzdCogdGVzdCwgZ2NvbnN0cG9pbnRlcikKICAgICBn X21haW5fbG9vcF9ydW4odGVzdC0+bV9tYWluTG9vcCk7CiB9CiAKK3N0YXRpYyB2b2lkIHRlc3RD b29raWVNYW5hZ2VyTG9uZ0V4cGlyZXMoQ29va2llTWFuYWdlclRlc3QqIHRlc3QsIGdjb25zdHBv aW50ZXIpCit7CisgICAgZ191bmxpbmsodGVzdC0+bV9jb29raWVzVGV4dEZpbGUuZ2V0KCkpOwor ICAgIGdfdW5saW5rKHRlc3QtPm1fY29va2llc1NRTGl0ZUZpbGUuZ2V0KCkpOworCisgICAgR1Jl ZlB0cjxHRGF0ZVRpbWU+IG5vdyA9IGFkb3B0R1JlZihnX2RhdGVfdGltZV9uZXdfbm93X3V0Yygp KTsKKyAgICBHUmVmUHRyPEdEYXRlVGltZT4gZXhwaXJlcyA9IGFkb3B0R1JlZihnX2RhdGVfdGlt ZV9hZGRfeWVhcnMobm93LmdldCgpLCAzNSkpOworICAgIEdVbmlxdWVQdHI8Y2hhcj4gbGluZShn X3N0cmR1cF9wcmludGYoIiNIdHRwT25seV9sb2NhbGhvc3RcdEZBTFNFXHQvXHRGQUxTRVx0JWxk XHRwcm92XHQxMjNcdE5vbmUiLCBnX2RhdGVfdGltZV90b191bml4KGV4cGlyZXMuZ2V0KCkpKSk7 CisgICAgdGVzdC0+bV9jb29raWVzVGV4dEZpbGUucmVzZXQoZ19idWlsZF9maWxlbmFtZShUZXN0 OjpkYXRhRGlyZWN0b3J5KCksICJjb29raWVzLnR4dCIsIG51bGxwdHIpKTsKKyAgICBnX2ZpbGVf c2V0X2NvbnRlbnRzKHRlc3QtPm1fY29va2llc1RleHRGaWxlLmdldCgpLCBsaW5lLmdldCgpLCAt MSwgbnVsbHB0cik7CisgICAgdGVzdC0+c2V0UGVyc2lzdGVudFN0b3JhZ2UoV0VCS0lUX0NPT0tJ RV9QRVJTSVNURU5UX1NUT1JBR0VfVEVYVCk7CisKKyAgICBHTGlzdCogY29va2llcyA9IHRlc3Qt PmdldENvb2tpZXMoImh0dHA6Ly9sb2NhbGhvc3QvIik7CisgICAgZ19hc3NlcnRfY21waW50KGdf bGlzdF9sZW5ndGgoY29va2llcyksID09LCAxKTsKKyAgICBTb3VwQ29va2llKiBjb29raWUgPSBz dGF0aWNfY2FzdDxTb3VwQ29va2llKj4oY29va2llcy0+ZGF0YSk7CisgICAgYXV0byogY29va2ll c0V4cGlyZXMgPSBzb3VwX2Nvb2tpZV9nZXRfZXhwaXJlcyhjb29raWUpOworICAgIGdfYXNzZXJ0 X25vbm51bGwoY29va2llc0V4cGlyZXMpOworI2lmIFVTRShTT1VQMikKKyAgICBnX2Fzc2VydF9j bXBpbnQoZ19kYXRlX3RpbWVfdG9fdW5peChleHBpcmVzLmdldCgpKSwgPT0sIHNvdXBfZGF0ZV90 b190aW1lX3QoY29va2llc0V4cGlyZXMpKTsKKyNlbHNlCisgICAgZ19hc3NlcnRfY21waW50KGdf ZGF0ZV90aW1lX3RvX3VuaXgoZXhwaXJlcy5nZXQoKSksID09LCBnX2RhdGVfdGltZV90b191bml4 KGNvb2tpZXNFeHBpcmVzKSk7CisjZW5kaWYKKworICAgIHRlc3QtPmRlbGV0ZUFsbENvb2tpZXMo KTsKKyAgICBnX2Fzc2VydF9jbXBpbnQoZ19zdHJ2X2xlbmd0aCh0ZXN0LT5nZXREb21haW5zKCkp LCA9PSwgMCk7Cit9CisKICNpZiBVU0UoU09VUDIpCiBzdGF0aWMgdm9pZCBzZXJ2ZXJDYWxsYmFj ayhTb3VwU2VydmVyKiBzZXJ2ZXIsIFNvdXBNZXNzYWdlKiBtZXNzYWdlLCBjb25zdCBjaGFyKiBw YXRoLCBHSGFzaFRhYmxlKiwgU291cENsaWVudENvbnRleHQqLCBncG9pbnRlcikKICNlbHNlCkBA IC03NDgsNiArNzc1LDcgQEAgdm9pZCBiZWZvcmVBbGwoKQogICAgIENvb2tpZVBlcnNpc3RlbnRT dG9yYWdlVGVzdDo6YWRkKCJXZWJLaXRDb29raWVNYW5hZ2VyIiwgInBlcnNpc3RlbnQtc3RvcmFn ZSIsIHRlc3RDb29raWVNYW5hZ2VyUGVyc2lzdGVudFN0b3JhZ2UpOwogICAgIENvb2tpZU1hbmFn ZXJUZXN0OjphZGQoIldlYktpdENvb2tpZU1hbmFnZXIiLCAicGVyc2lzdGVudC1zdG9yYWdlLWRl bGV0ZS1hbGwiLCB0ZXN0Q29va2llTWFuYWdlclBlcnNpc3RlbnRTdG9yYWdlRGVsZXRlQWxsKTsK ICAgICBDb29raWVNYW5hZ2VyVGVzdDo6YWRkKCJXZWJLaXRDb29raWVNYW5hZ2VyIiwgImVwaGVt ZXJhbCIsIHRlc3RDb29raWVNYW5hZ2VyRXBoZW1lcmFsKTsKKyAgICBDb29raWVNYW5hZ2VyVGVz dDo6YWRkKCJXZWJLaXRDb29raWVNYW5hZ2VyIiwgImxvbmctZXhwaXJlcyIsIHRlc3RDb29raWVN YW5hZ2VyTG9uZ0V4cGlyZXMpOwogfQogCiB2b2lkIGFmdGVyQWxsKCkK